gds-api-adapters 7.3.0 → 7.4.0

data/lib/gds_api/json_client.rb

@@ -64,8 +64,8 @@ module GdsApi
     # Define "safe" methods for each supported HTTP method
     #
     # Each "bang method" tries to make a request, but raises an exception if
-    # the response is not successful. These methods discard those exceptions
-    # and return nil.
+    # the response is not successful. These methods discard the HTTPNotFound
+    # exceptions (and return nil), and pass through all other exceptions.
     [:get, :post, :put, :delete].each do |http_method|
       method_name = "#{http_method}_json"
       define_method method_name do |url, *args, &block|

data/lib/gds_api/support.rb

@@ -2,7 +2,11 @@ require_relative 'base'
 
 class GdsApi::Support < GdsApi::Base
   def create_foi_request(request_details)
-    post_json("#{base_url}/foi_requests", { :foi_request => request_details })
+    post_json!("#{base_url}/foi_requests", { :foi_request => request_details })
+  end
+
+  def create_problem_report(request_details)
+    post_json!("#{base_url}/problem_reports", { :problem_report => request_details })
   end
 
   private

data/lib/gds_api/test_helpers/support.rb

@@ -4,10 +4,14 @@ module GdsApi
       SUPPORT_ENDPOINT = Plek.current.find('support')
 
       def stub_support_foi_request_creation(request_details = nil)
-        body_expectation = {"foi_request" => request_details}.to_json
+        post_stub = stub_http_request(:post, "#{SUPPORT_ENDPOINT}/foi_requests")
+        post_stub.with(:body => {"foi_request" => request_details}) unless request_details.nil?
+        post_stub.to_return(:status => 201)
+      end
 
-        post_stub = stub_request(:post, "#{SUPPORT_ENDPOINT}/foi_requests")
-        post_stub.with(:body => {"foi_request" => request_details}.to_json) unless request_details.nil?
+      def stub_support_problem_report_creation(request_details = nil)
+        post_stub = stub_http_request(:post, "#{SUPPORT_ENDPOINT}/problem_reports")
+        post_stub.with(:body => { problem_report: request_details }) unless request_details.nil?
         post_stub.to_return(:status => 201)
       end
 

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '7.3.0'
+  VERSION = '7.4.0'
 end

data/test/support_api_test.rb

@@ -1,13 +1,16 @@
 require 'test_helper'
 require 'gds_api/support'
+require 'gds_api/test_helpers/support'
 
 describe GdsApi::Support do
+  include GdsApi::TestHelpers::Support
+
   before do
     @base_api_url = Plek.current.find("support")
     @api = GdsApi::Support.new(@base_api_url)
   end
 
-  it "can create an asset with a file" do
+  it "can create an FOI request" do
     request_details = {"foi_request"=>{"requester"=>{"name"=>"A", "email"=>"a@b.com"}, "details"=>"abc"}}
 
     stub_post = stub_request(:post, "#{@base_api_url}/foi_requests").
@@ -18,4 +21,28 @@ describe GdsApi::Support do
 
     assert_requested(stub_post)
   end
+
+  it "throws an exception when the support app  isn't available" do
+    support_isnt_available
+
+    assert_raises(GdsApi::HTTPErrorResponse) { @api.create_foi_request({}) }
+  end
+
+  it "can report a problem" do
+    request_details = {certain: "details"}
+
+    stub_post = stub_request(:post, "#{@base_api_url}/problem_reports").
+      with(:body => {"problem_report" => request_details}.to_json).
+      to_return(:status => 201)
+
+    @api.create_problem_report(request_details)
+
+    assert_requested(stub_post)
+  end
+
+  it "throws an exception when the support app  isn't available" do
+    support_isnt_available
+
+    assert_raises(GdsApi::HTTPErrorResponse) { @api.create_problem_report({}) }
+  end
 end

metadata

@@ -2,7 +2,7 @@
 name: gds-api-adapters
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 7.3.0
+  version: 7.4.0
 platform: ruby
 authors: 
 - James Stewart
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-08-12 00:00:00 Z
+date: 2013-08-21 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: plek
@@ -260,7 +260,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -933955563815808271
+      hash: 167124885650140799
       segments: 
       - 0
       version: "0"
@@ -269,7 +269,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: -933955563815808271
+      hash: 167124885650140799
       segments: 
       - 0
       version: "0"