gds-api-adapters 11.4.0 → 11.5.0

data/lib/gds_api/support_api.rb

@@ -0,0 +1,7 @@
+require_relative 'base'
+
+class GdsApi::SupportApi < GdsApi::Base
+  def create_service_feedback(request_details)
+    post_json!("#{endpoint}/anonymous-feedback/service-feedback", { :service_feedback => request_details })
+  end
+end

data/lib/gds_api/test_helpers/support_api.rb

@@ -0,0 +1,17 @@
+module GdsApi
+  module TestHelpers
+    module SupportApi
+      SUPPORT_API_ENDPOINT = Plek.current.find('support-api')
+
+      def stub_support_api_service_feedback_creation(feedback_details = nil)
+        post_stub = stub_http_request(:post, "#{SUPPORT_API_ENDPOINT}/anonymous-feedback/service-feedback")
+        post_stub.with(:body => { service_feedback: feedback_details }) unless feedback_details.nil?
+        post_stub.to_return(:status => 201)
+      end
+
+      def support_api_isnt_available
+        stub_request(:post, /#{SUPPORT_API_ENDPOINT}\/.*/).to_return(:status => 503)
+      end
+    end
+  end
+end

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '11.4.0'
+  VERSION = '11.5.0'
 end

data/test/support_api_test.rb

@@ -1,79 +1,19 @@
 require 'test_helper'
-require 'gds_api/support'
-require 'gds_api/test_helpers/support'
+require 'gds_api/support_api'
+require 'gds_api/test_helpers/support_api'
 
-describe GdsApi::Support do
-  include GdsApi::TestHelpers::Support
+describe GdsApi::SupportApi do
+  include GdsApi::TestHelpers::SupportApi
 
   before do
-    @base_api_url = Plek.current.find("support")
-    @api = GdsApi::Support.new(@base_api_url)
-  end
-
-  it "can create an FOI request" do
-    request_details = {"foi_request"=>{"requester"=>{"name"=>"A", "email"=>"a@b.com"}, "details"=>"abc"}}
-
-    stub_post = stub_request(:post, "#{@base_api_url}/foi_requests").
-      with(:body => {"foi_request" => request_details}.to_json).
-      to_return(:status => 201)
-
-    @api.create_foi_request(request_details)
-
-    assert_requested(stub_post)
-  end
-
-  it "throws an exception when the support app isn't available" do
-    support_isnt_available
-
-    assert_raises(GdsApi::HTTPErrorResponse) { @api.create_foi_request({}) }
-  end
-
-  it "can report a problem" do
-    request_details = {certain: "details"}
-
-    stub_post = stub_request(:post, "#{@base_api_url}/anonymous_feedback/problem_reports").
-      with(:body => {"problem_report" => request_details}.to_json).
-      to_return(:status => 201)
-
-    @api.create_problem_report(request_details)
-
-    assert_requested(stub_post)
-  end
-
-  it "can submit long-form anonymous feedback" do
-    request_details = {certain: "details"}
-
-    stub_post = stub_request(:post, "#{@base_api_url}/anonymous_feedback/long_form_contacts").
-      with(:body => {"long_form_contact" => request_details}.to_json).
-      to_return(:status => 201)
-
-    @api.create_anonymous_long_form_contact(request_details)
-
-    assert_requested(stub_post)
-  end
-
-  it "can create a named contact" do
-    request_details = {certain: "details"}
-
-    stub_post = stub_request(:post, "#{@base_api_url}/named_contacts").
-      with(:body => {"named_contact" => request_details}.to_json).
-      to_return(:status => 201)
-
-    @api.create_named_contact(request_details)
-
-    assert_requested(stub_post)
-  end
-
-  it "throws an exception when the support app isn't available" do
-    support_isnt_available
-
-    assert_raises(GdsApi::HTTPErrorResponse) { @api.create_problem_report({}) }
+    @base_api_url = Plek.current.find("support-api")
+    @api = GdsApi::SupportApi.new(@base_api_url)
   end
 
   it "can pass service feedback" do
     request_details = {"transaction-completed-values"=>"1", "details"=>"abc"}
 
-    stub_post = stub_request(:post, "#{@base_api_url}/anonymous_feedback/service_feedback").
+    stub_post = stub_request(:post, "#{@base_api_url}/anonymous-feedback/service-feedback").
       with(:body => {"service_feedback" => request_details}.to_json).
       to_return(:status => 201)
 
@@ -83,14 +23,8 @@ describe GdsApi::Support do
   end
 
   it "throws an exception when the support app isn't available" do
-    support_isnt_available
+    support_api_isnt_available
 
     assert_raises(GdsApi::HTTPErrorResponse) { @api.create_service_feedback({}) }
   end
-
-  it "gets the correct feedback URL" do
-    assert_equal("#{@base_api_url}/anonymous_feedback?path=foo",
-                 @api.feedback_url('foo'))
-
-  end
 end

data/test/support_test.rb

@@ -0,0 +1,96 @@
+require 'test_helper'
+require 'gds_api/support'
+require 'gds_api/test_helpers/support'
+
+describe GdsApi::Support do
+  include GdsApi::TestHelpers::Support
+
+  before do
+    @base_api_url = Plek.current.find("support")
+    @api = GdsApi::Support.new(@base_api_url)
+  end
+
+  it "can create an FOI request" do
+    request_details = {"foi_request"=>{"requester"=>{"name"=>"A", "email"=>"a@b.com"}, "details"=>"abc"}}
+
+    stub_post = stub_request(:post, "#{@base_api_url}/foi_requests").
+      with(:body => {"foi_request" => request_details}.to_json).
+      to_return(:status => 201)
+
+    @api.create_foi_request(request_details)
+
+    assert_requested(stub_post)
+  end
+
+  it "throws an exception when the support app isn't available" do
+    support_isnt_available
+
+    assert_raises(GdsApi::HTTPErrorResponse) { @api.create_foi_request({}) }
+  end
+
+  it "can report a problem" do
+    request_details = {certain: "details"}
+
+    stub_post = stub_request(:post, "#{@base_api_url}/anonymous_feedback/problem_reports").
+      with(:body => {"problem_report" => request_details}.to_json).
+      to_return(:status => 201)
+
+    @api.create_problem_report(request_details)
+
+    assert_requested(stub_post)
+  end
+
+  it "can submit long-form anonymous feedback" do
+    request_details = {certain: "details"}
+
+    stub_post = stub_request(:post, "#{@base_api_url}/anonymous_feedback/long_form_contacts").
+      with(:body => {"long_form_contact" => request_details}.to_json).
+      to_return(:status => 201)
+
+    @api.create_anonymous_long_form_contact(request_details)
+
+    assert_requested(stub_post)
+  end
+
+  it "can create a named contact" do
+    request_details = {certain: "details"}
+
+    stub_post = stub_request(:post, "#{@base_api_url}/named_contacts").
+      with(:body => {"named_contact" => request_details}.to_json).
+      to_return(:status => 201)
+
+    @api.create_named_contact(request_details)
+
+    assert_requested(stub_post)
+  end
+
+  it "throws an exception when the support app isn't available" do
+    support_isnt_available
+
+    assert_raises(GdsApi::HTTPErrorResponse) { @api.create_problem_report({}) }
+  end
+
+  it "can pass service feedback" do
+    request_details = {"transaction-completed-values"=>"1", "details"=>"abc"}
+
+    stub_post = stub_request(:post, "#{@base_api_url}/anonymous_feedback/service_feedback").
+      with(:body => {"service_feedback" => request_details}.to_json).
+      to_return(:status => 201)
+
+    @api.create_service_feedback(request_details)
+
+    assert_requested(stub_post)
+  end
+
+  it "throws an exception when the support app isn't available" do
+    support_isnt_available
+
+    assert_raises(GdsApi::HTTPErrorResponse) { @api.create_service_feedback({}) }
+  end
+
+  it "gets the correct feedback URL" do
+    assert_equal("#{@base_api_url}/anonymous_feedback?path=foo",
+                 @api.feedback_url('foo'))
+
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gds-api-adapters
 version: !ruby/object:Gem::Version
-  version: 11.4.0
+  version: 11.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-02 00:00:00.000000000 Z
+date: 2014-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plek
@@ -303,6 +303,7 @@ files:
 - lib/gds_api/test_helpers/mapit.rb
 - lib/gds_api/test_helpers/panopticon.rb
 - lib/gds_api/test_helpers/json_client_helper.rb
+- lib/gds_api/test_helpers/support_api.rb
 - lib/gds_api/test_helpers/content_store.rb
 - lib/gds_api/test_helpers/asset_manager.rb
 - lib/gds_api/test_helpers/gov_uk_delivery.rb
@@ -323,6 +324,7 @@ files:
 - lib/gds_api/helpers.rb
 - lib/gds_api/middleware/govuk_request_id_sniffer.rb
 - lib/gds_api/panopticon.rb
+- lib/gds_api/support_api.rb
 - lib/gds_api/content_store.rb
 - lib/gds_api/asset_manager.rb
 - lib/gds_api/gov_uk_delivery.rb
@@ -342,6 +344,7 @@ files:
 - test/finder_schema_test.rb
 - test/need_api_test.rb
 - test/publisher_api_test.rb
+- test/support_test.rb
 - test/fact_cave_test.rb
 - test/finder_api_test.rb
 - test/licence_application_api_test.rb
@@ -382,7 +385,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3744965370006170691
+      hash: -724725384917283612
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -391,7 +394,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3744965370006170691
+      hash: -724725384917283612
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
@@ -405,6 +408,7 @@ test_files:
 - test/finder_schema_test.rb
 - test/need_api_test.rb
 - test/publisher_api_test.rb
+- test/support_test.rb
 - test/fact_cave_test.rb
 - test/finder_api_test.rb
 - test/licence_application_api_test.rb