gds-api-adapters 10.6.2 → 10.6.3

data/lib/gds_api/need_api.rb

@@ -8,6 +8,13 @@ class GdsApi::NeedApi < GdsApi::Base
     get_list!("#{endpoint}/needs#{query}")
   end
 
+  def needs_by_id(*ids)
+    ids_string = ids.flatten.map(&:to_i).sort.join(',')
+    query = query_string(ids: ids_string)
+
+    get_list!("#{endpoint}/needs#{query}")
+  end
+
   def need(need_id)
     get_json("#{endpoint}/needs/#{CGI.escape(need_id.to_s)}")
   end

data/lib/gds_api/test_helpers/need_api.rb

@@ -50,6 +50,16 @@ module GdsApi
         stub_request(:get, url).to_return(status: 200, body: body.to_json, headers: {})
       end
 
+      def need_api_has_need_ids(needs)
+        ids = needs.map {|need| (need["id"] || need[:id]).to_i }.sort.join(',')
+        url = NEED_API_ENDPOINT + "/needs?ids=#{ids}"
+
+        body = response_base.merge(
+          "results" => needs
+        )
+        stub_request(:get, url).to_return(status: 200, body: body.to_json, headers: {})
+      end
+
       def need_api_has_need(need)
         need_id = need["id"] || need[:id]
         raise ArgumentError, "Test need is missing an ID" unless need_id

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '10.6.2'
+  VERSION = '10.6.3'
 end

data/test/need_api_test.rb

@@ -10,6 +10,55 @@ describe GdsApi::NeedApi do
     @api = GdsApi::NeedApi.new(@base_api_url)
   end
 
+  describe "requesting needs by ID" do
+    before do
+      need_api_has_need_ids([
+        {
+          "id"   => "1",
+          "role" => "parent",
+          "goal" => "apply for a primary school place",
+          "benefit" => "my child can start school",
+        },
+        {
+          "id"   => "2",
+          "role" => "user",
+          "goal" => "find out about becoming a British citizen",
+          "benefit" => "i can take the correct steps to apply for citizenship",
+        },
+        {
+          "id"   => "3",
+          "role" => "user",
+          "goal" => "find out about unemployment benefits",
+          "benefit" => "i have financial support whilst unemployed",
+        }
+      ])
+    end
+
+    it "returns a list of needs matching the IDs" do
+      needs = @api.needs_by_id(1,2,3)
+
+      assert_equal 3, needs.count
+      assert_equal %w(1 2 3), needs.map(&:id)
+      assert_equal "apply for a primary school place", needs.results[0].goal
+      assert_equal "find out about becoming a British citizen", needs.results[1].goal
+      assert_equal "find out about unemployment benefits", needs.results[2].goal
+    end
+
+    it "makes the same request regardless of the order of the IDs" do
+      needs = @api.needs_by_id(2,1,3)
+
+      assert_equal 3, needs.count
+      assert_equal %w(1 2 3), needs.map(&:id)
+    end
+
+    it "correctly sorts IDs requested as strings" do
+      needs = @api.needs_by_id(%w(02 3 1))
+
+      assert_equal 3, needs.count
+      assert_equal %w(1 2 3), needs.map(&:id)
+    end
+  end
+
   describe "requesting needs" do
     it "should return a list of all needs" do
       req = need_api_has_needs([

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gds-api-adapters
 version: !ruby/object:Gem::Version
-  version: 10.6.2
+  version: 10.6.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-08 00:00:00.000000000 Z
+date: 2014-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plek
@@ -376,7 +376,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2318323185419183875
+      hash: -3682421441784526579
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -385,7 +385,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2318323185419183875
+      hash: -3682421441784526579
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23