gds-api-adapters 0.0.37 → 0.0.38

data/lib/gds_api/json_client.rb

@@ -1,13 +1,19 @@
 require_relative 'response'
 require_relative 'exceptions'
 require_relative 'version'
+require 'lrucache'
 
 module GdsApi
   class JsonClient
+    def self.cache
+      @cache ||= LRUCache.new(max_size: 10)
+    end
+
     attr_accessor :logger, :options
 
     def initialize(options = {})
       @logger = options[:logger] || GdsApi::Base.logger
+      @cache = options[:cache] || JsonClient.cache
       @options = options
     end
 
@@ -19,7 +25,7 @@ module GdsApi
     DEFAULT_TIMEOUT_IN_SECONDS = 2
 
     def get_json(url)
-      do_request(Net::HTTP::Get, url)
+      @cache[url] ||= do_request(Net::HTTP::Get, url)
     end
 
     def post_json(url, params)

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '0.0.37'
+  VERSION = '0.0.38'
 end

data/test/json_client_test.rb

@@ -5,7 +5,7 @@ require 'base64'
 
 class JsonClientTest < MiniTest::Spec
   def setup
-    @client = GdsApi::JsonClient.new
+    @client = GdsApi::JsonClient.new(cache: {})
   end
 
   def options;
@@ -50,6 +50,15 @@ class JsonClientTest < MiniTest::Spec
     assert_equal GdsApi::Response, @client.get_json(url).class
   end
 
+  def test_should_cache_multiple_requests_to_same_url_across_instances
+    url = "http://some.endpoint/some.json"
+    result = {"foo" => "bar"}
+    stub_request(:get, url).to_return(:body => JSON.dump(result), :status => 200).times(1)
+    response_a = GdsApi::JsonClient.new.get_json(url)
+    response_b = GdsApi::JsonClient.new.get_json(url)
+    assert_equal response_a.object_id, response_b.object_id
+  end
+
   def test_should_return_nil_if_404_returned_from_endpoint
     url = "http://some.endpoint/some.json"
     stub_request(:get, url).to_return(:body => "{}", :status => 404)

metadata

@@ -1,190 +1,188 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: gds-api-adapters
-version: !ruby/object:Gem::Version 
+version: !ruby/object:Gem::Version
+  version: 0.0.38
   prerelease: 
-  version: 0.0.37
 platform: ruby
-authors: 
+authors:
 - James Stewart
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-01-13 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-01-24 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: plek
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &22925880 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
+  version_requirements: *22925880
+- !ruby/object:Gem::Dependency
   name: null_logger
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  requirement: &22925100 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
+  version_requirements: *22925100
+- !ruby/object:Gem::Dependency
+  name: lrucache
+  requirement: &22970740 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.1.1
+  type: :runtime
+  prerelease: false
+  version_requirements: *22970740
+- !ruby/object:Gem::Dependency
   name: rake
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  requirement: &22969200 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 0.9.2.2
   type: :development
   prerelease: false
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
+  version_requirements: *22969200
+- !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  requirement: &22968160 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        version: "1.7"
+      - !ruby/object:Gem::Version
+        version: '1.7'
   type: :development
   prerelease: false
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
+  version_requirements: *22968160
+- !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  requirement: &22967360 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 0.10.0
   type: :development
   prerelease: false
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
+  version_requirements: *22967360
+- !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  requirement: &22966020 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 2.10.0
   type: :development
   prerelease: false
-  version_requirements: *id006
-- !ruby/object:Gem::Dependency 
+  version_requirements: *22966020
+- !ruby/object:Gem::Dependency
   name: rack
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  requirement: &22964680 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id007
-- !ruby/object:Gem::Dependency 
+  version_requirements: *22964680
+- !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &id008 !ruby/object:Gem::Requirement 
+  requirement: &22962820 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
+      - !ruby/object:Gem::Version
         version: 0.5.4
   type: :development
   prerelease: false
-  version_requirements: *id008
-- !ruby/object:Gem::Dependency 
+  version_requirements: *22962820
+- !ruby/object:Gem::Dependency
   name: simplecov-rcov
-  requirement: &id009 !ruby/object:Gem::Requirement 
+  requirement: &23061160 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *id009
+  version_requirements: *23061160
 description: A set of adapters providing easy access to the GDS gov.uk APIs
-email: 
+email:
 - jystewart@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
-- lib/gds_api/base.rb
-- lib/gds_api/contactotron.rb
-- lib/gds_api/core-ext/openstruct.rb
-- lib/gds_api/exceptions.rb
-- lib/gds_api/helpers.rb
-- lib/gds_api/imminence.rb
-- lib/gds_api/json_client.rb
-- lib/gds_api/needotron.rb
-- lib/gds_api/oauth2_client.rb
+files:
+- lib/gds_api/response.rb
 - lib/gds_api/panopticon/registerer.rb
-- lib/gds_api/panopticon.rb
+- lib/gds_api/core-ext/openstruct.rb
 - lib/gds_api/part_methods.rb
-- lib/gds_api/publisher.rb
-- lib/gds_api/response.rb
-- lib/gds_api/test_helpers/contactotron.rb
+- lib/gds_api/oauth2_client.rb
 - lib/gds_api/test_helpers/imminence.rb
+- lib/gds_api/test_helpers/contactotron.rb
 - lib/gds_api/test_helpers/panopticon.rb
 - lib/gds_api/test_helpers/publisher.rb
+- lib/gds_api/imminence.rb
+- lib/gds_api/needotron.rb
+- lib/gds_api/contactotron.rb
+- lib/gds_api/panopticon.rb
+- lib/gds_api/helpers.rb
+- lib/gds_api/json_client.rb
+- lib/gds_api/publisher.rb
+- lib/gds_api/exceptions.rb
 - lib/gds_api/version.rb
+- lib/gds_api/base.rb
 - README.md
 - Rakefile
-- test/contactotron_api_test.rb
 - test/gds_api_base_test.rb
-- test/json_client_test.rb
-- test/panopticon_api_test.rb
 - test/publisher_api_test.rb
 - test/test_helper.rb
+- test/panopticon_api_test.rb
+- test/json_client_test.rb
+- test/contactotron_api_test.rb
 homepage: http://github.com/alphagov/gds-api-adapters
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3917338129765576762
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3917338129765576762
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.13
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: Adapters to work with GDS APIs
-test_files: 
-- test/contactotron_api_test.rb
+test_files:
 - test/gds_api_base_test.rb
-- test/json_client_test.rb
-- test/panopticon_api_test.rb
 - test/publisher_api_test.rb
 - test/test_helper.rb
+- test/panopticon_api_test.rb
+- test/json_client_test.rb
+- test/contactotron_api_test.rb