gci-class-extensions 1.1.2 → 1.2.0

data/lib/gci-class-extensions.rb

@@ -46,7 +46,7 @@ end
 class String
   def is_valid_dollar_amount?
     # Optional parentheses or negative sign before or after the optional dollar sign, any number of digits and commas, followed by optional . and 1 or 2 digits, and optional close parentheses, with nothing on either side
-    strip =~ /^[\(-]?\$?[\(-]?([\d,]+(\.\d{1,2})?|\.\d{1,2})\)?$/ ? true : false
+    strip =~ /^[\(-]?\$?[\(-]?[\d,]+(\.\d{1,2})?\)?$/ ? true : false
   end
   
   def scrubbed_dollar_amount
@@ -62,10 +62,6 @@ class String
   def escape_sql
     self.gsub(/\\/, '\&\&').gsub(/'/, "''")
   end
-  
-  def to_dollar_amount
-    is_valid_dollar_amount? ? scrubbed_dollar_amount.to_f.round(2) : 0.0
-  end
 end
 
 # TODO write a spec
@@ -74,10 +70,3 @@ class Float
     (self * 100).round(precision)
   end
 end
-
-class Fixnum
-  # we ignore the precision and just return itself as a float, since Float#to_f accepts this parameter
-  def round(precision=2)
-    to_f
-  end
-end

data/spec/gci-class-extensions_spec.rb

@@ -88,8 +88,6 @@ end
 
 describe String, "knowing whether it contains a valid dollar amount" do
   valid_amounts = [
-    # less than a dollar
-    ".50", "0.50", ".25",
     # simple numbers with dollar signs
     "$123", "$123.45", "$123,456", "$123,456.78",
     # simple numbers without dollar signs
@@ -141,33 +139,6 @@ describe String, "when scrubbing the dollar amounts to only the digits" do
   it "should leave the string alone if has no dollar sign or commas" do
     "123".scrubbed_dollar_amount.should == "123"
   end
-  
-  it "should convert the string to a dollar with two decimals" do
-    '123.12'.to_dollar_amount.should == 123.12
-  end
-  
-  it "should return 0.0 if the string has > 2 decimal places" do
-    '123.1234'.to_dollar_amount.should == 0.0
-  end
-  
-  it "should return 0.0 if the string is not a valid $ amount" do
-    "xcv".to_dollar_amount.should == 0.0
-  end
-  
-end
-
-describe Fixnum, "accepting a parameter to round as float does" do
-  it "should ignore the parameter and just return itself" do
-    1.round(2).should == 1.0
-    7.round(9).should == 7.0
-    0.round(123456789).should == 0.0
-  end
-
-  it "should accept no parameter" do
-    1.round.should == 1.0
-    7.round.should == 7.0
-    0.round.should == 0.0
-  end
 end
 
 describe Float, "knowing its value as a percentage" do
@@ -185,3 +156,9 @@ describe Float, "knowing its value as a percentage" do
     (6.543212).to_percentage(3).should == 654.321
   end
 end
+
+# class Float
+#   def to_percentage(precision=2)
+#     (self * 100).round(precision)
+#   end
+# end

metadata

@@ -1,13 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: gci-class-extensions
 version: !ruby/object:Gem::Version 
-  hash: 23
-  prerelease: 
-  segments: 
-  - 1
-  - 1
-  - 2
-  version: 1.1.2
+  version: 1.2.0
 platform: ruby
 authors: 
 - Patrick Byrne
@@ -15,36 +9,29 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-03-31 00:00:00 Z
+date: 2010-07-19 00:00:00 -05:00
+default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: active_support
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
         version: "0"
-  type: :runtime
-  version_requirements: *id001
+    version: 
 - !ruby/object:Gem::Dependency 
   name: valid-date
-  prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
+  type: :runtime
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
         version: "0"
-  type: :runtime
-  version_requirements: *id002
+    version: 
 description: 
 email: code@patrickbyrne.net
 executables: []
@@ -56,7 +43,7 @@ extra_rdoc_files:
 files: 
 - lib/gci-class-extensions.rb
 - README
-- spec/gci-class-extensions_spec.rb
+has_rdoc: true
 homepage: http://bitbucket.org/pbyrne/common-ruby-class-extensions/
 licenses: []
 
@@ -66,27 +53,21 @@ rdoc_options: []
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
+  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
+  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.6
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: A gem used by our internal team for common class extensions, like not_blank? and not_nil? counterparts to blank? and nil?.