gbip 0.8.0 → 0.8.1

data/CHANGELOG

@@ -1,8 +1,12 @@
-v0.8.0 (7th November)
+v0.8.1 (11th June 2009)
+- Fix parsing of API responses that contain multiple results
+- small update to specs
+
+v0.8.0 (7th November 2008)
 - Add checks for additional error codes, and raise an appropriate error
 - overhauled specs
 
-v0.7.1 (14th October)
+v0.7.1 (14th October 2008)
 - Correctly parse API responses that contain a # in their data
 - Use ISBN13s in queries. No change to user API (we accept ISBN10s or ISBN13s)
 

data/Rakefile

@@ -5,7 +5,7 @@ require 'rake/testtask'
 require "rake/gempackagetask"
 require 'spec/rake/spectask'
 
-PKG_VERSION = "0.8.0"
+PKG_VERSION = "0.8.1"
 PKG_NAME = "gbip"
 PKG_FILE_NAME = "#{PKG_NAME}-#{PKG_VERSION}"
 RUBYFORGE_PROJECT = 'rbook'

data/lib/gbip/pos.rb

@@ -26,6 +26,7 @@ module GBIP
     # Supported options:
     # :markets => only search the specified markets. comma sperated list
     # :timeout => amount of time in seconds to wait for a reponse from the server before timing out. Defaults to 10.
+    #
     def find(type, isbn, options = {})
       case type
       when :first then default_return = nil
@@ -88,15 +89,11 @@ module GBIP
         body.shift
       end
 
-      titles_arr = [[]]
-      body.each do |element|
-        if element == "#" && titles_arr.last.size > 15
-          titles_arr << []
-        else
-          titles_arr.last << element
-        end
-        #titles_arr << arr.split("\t")
-        #titles_arr[-1] = titles_arr.last[1,titles_arr.last.size-1]
+      titles_arr = []
+      while body.size > 0
+        warehouse_count = body[21].to_i
+        extract_count = 22 + (5 * warehouse_count)
+        titles_arr << body.slice!(0, extract_count)
       end
 
       if titles_arr.size == 0

data/specs/pos_class_spec.rb

@@ -2,11 +2,10 @@ $LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
 
 require 'gbip'
 require File.dirname(__FILE__) + "/spec_helper"
-require File.dirname(__FILE__) + "/timeout_tcpsocket"
 
 context "A new POS object" do
 
-  setup do
+  before(:all) do
     @username = "user"
     @password = "pass"
     @isbn10   = "1741146712"
@@ -230,6 +229,18 @@ context "A new POS object" do
     result.should be_empty
   end
 
+  specify "should return an Array with multiple items when a query returns multiple matches" do
+    # Mock TCPSocket to return a valid response with no matches
+    data = File.read(File.dirname(__FILE__) + "/responses/multiple_response.txt").strip
+    socket = TCPSocket.stub_instance(:print => true, :close => true, :gets => data)
+    TCPSocket.stub_method(:new => socket)
+
+    pos = GBIP::POS.new(@username, @password)
+    result = pos.find(:all, @isbn13)
+    result.should be_a_kind_of(Array)
+    result.size.should eql(3)
+  end
+
   specify "should return an empty array when any object is supplied as an ISBN when searching for :all" do
     pos = GBIP::POS.new(@username, @password)
     result = pos.find(:all, nil)

data/specs/responses/multiple_response.txt

@@ -0,0 +1 @@
+3	rainbowbook	3	#	57073276	1	AUS	Hallucinogens and Your Neurons:The Incredibly Disgusting Story	978-0-8239-3391-4	Library Binding	Active Record		Cefrey, Holly	Rosen Publishing Group, Incorporated, The	032000	29.95	UNITED STATES	22896	$	DRUG ABUSE_JUVENILE LITERATURE	JUVENILE NONFICTION / Health & Daily Living / Substance Abuse		PERSONAL & SOCIAL ISSUES: DRUGS & ADDICTION (CHILDREN'S/YA)		ING	1	Ingram Book Company, La Vergne, TN	Available for order		0	06/10/2009#	51552044	1	USA	Hallucinogens and Your Neurons:The Incredibly Disgusting Story	978-0-8239-3391-4	Library Binding	Active Record		Cefrey, Holly	Rosen Publishing Group, Incorporated, The	012005	25.25	UNITED STATES	22896	$	DRUG ABUSE_JUVENILE LITERATURE	JUVENILE NONFICTION / Health & Daily Living / Substance Abuse	DRUG ABUSE	PERSONAL & SOCIAL ISSUES: DRUGS & ADDICTION (CHILDREN'S/YA)		ING	1	Ingram Book Company, La Vergne, TN	Available for order		0	06/10/2009#	53231792	1	CAN	Hallucinogens and Your Neurons:The Incredibly Disgusting Story	978-0-8239-3391-4	Library Binding	Active Record		Cefrey, Holly	Rosen Publishing Group, Incorporated, The	2000	28.45	UNITED STATES	22896	$	DRUG ABUSE_JUVENILE LITERATURE	JUVENILE NONFICTION / Health & Daily Living / Substance Abuse		PERSONAL & SOCIAL ISSUES: DRUGS & ADDICTION (CHILDREN'S/YA)		ING	1	Ingram Book Company, La Vergne, TN	Available for order		0	06/10/2009	

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: gbip
 version: !ruby/object:Gem::Version 
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors: 
 - James Healy
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-11-07 00:00:00 +11:00
+date: 2009-06-11 00:00:00 +10:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -22,7 +22,7 @@ dependencies:
       - !ruby/object:Gem::Version 
         version: "1.0"
     version: 
-description: gbip is a small library to interact with the globalbooksinprint.com API. The API is based on raw TCP sockets.
+description: "  gbip is a small library to interact with the\n  globalbooksinprint.com API. The API is based\n  on raw TCP sockets.\n"
 email: jimmy@deefa.com
 executables: []
 
@@ -36,12 +36,10 @@ extra_rdoc_files:
 files: 
 - examples/gbip.rb
 - lib/gbip.rb
-- lib/gbip
 - lib/gbip/pos.rb
 - lib/gbip/title.rb
 - lib/gbip/warehouse.rb
 - specs/pos_class_spec.rb
-- specs/responses
 - specs/responses/invalid_login.txt
 - specs/responses/no_result.txt
 - specs/responses/no_warehouses.txt
@@ -51,6 +49,7 @@ files:
 - specs/responses/invalid_bad_data.txt
 - specs/responses/invalid_request.txt
 - specs/responses/invalid_system_unavailable.txt
+- specs/responses/multiple_response.txt
 - specs/spec_helper.rb
 - Rakefile
 - CHANGELOG
@@ -59,6 +58,8 @@ files:
 - LICENSE
 has_rdoc: true
 homepage: http://rbook.rubyforge.org/
+licenses: []
+
 post_install_message: 
 rdoc_options: 
 - --title
@@ -83,9 +84,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: rbook
-rubygems_version: 1.2.0
+rubygems_version: 1.3.3
 signing_key: 
-specification_version: 2
+specification_version: 3
 summary: A library for access the globalbooksinprint.com API
 test_files: 
 - specs/pos_class_spec.rb