gastly 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 327d0941c591a2f1b07c19b013307d917f9c744e
-  data.tar.gz: 0f87c8fc8905ffc76e0dccb6395302214f13ca71
+  metadata.gz: a44ef15ac998bc80a529ceb87f868e53c8ce61bf
+  data.tar.gz: 75a64b654c9031160a85aff58f5ef47b2f1add23
 SHA512:
-  metadata.gz: bd7e4f76405c0c344427fc052950ff8b36abf56269becf515cd278527a2af2e09dd48f31891fa1646653117e26c52d1146edbe273f4316f4384c5b449d79c8cc
-  data.tar.gz: c49f95e949893ef171c9d6d9366aa327d10300db95cc8e91b03db5a82717c6981855f097973be6b1a640d7096727a066ad30c15919ed369f1103743dc0bd7ec5
+  metadata.gz: 8d110af0420f000a7851a1c21855ec111d4924ce34df3b5677fb8db1c57835fc541a96596e5f2c5fc1366955ba16b69a4df1c66db9ec5a40d25430cadc18ad78
+  data.tar.gz: 83e1dd27eb9f8122bc86764c03a2c837f512742300d86e905b188fe3f934e2e60139e091b0d0ae43d4122f2b76c0c1966448efdf46c2eb435d33522dae397da0

data/.rubocop.yml

@@ -0,0 +1,27 @@
+AllCops:
+  # Cop names are not displayed in offense messages by default. Change behavior
+  # by overriding DisplayCopNames, or by giving the -D/--display-cop-names
+  # option.
+  DisplayCopNames: true
+  # Style guide URLs are not displayed in offense messages by default. Change
+  # behavior by overriding DisplayStyleGuide, or by giving the
+  # -S/--display-style-guide option.
+  DisplayStyleGuide: true
+  Exclude:
+    - 'bin/**/*'
+    - 'spec/**/*'
+    - 'vendor/**/*'
+
+# Missing top-level class documentation comment
+Style/Documentation:
+  Enabled: false
+
+# Line is too long
+# https://github.com/bbatsov/ruby-style-guide#80-character-limits
+Metrics/LineLength:
+  Max: 180 # 80
+
+# Assignment Branch Condition size for perform is too high
+# http://c2.com/cgi/wiki?AbcMetric
+Metrics/AbcSize:
+  Enabled: false

data/.travis.yml

@@ -1,3 +1,6 @@
 language: ruby
 rvm:
-  - 2.1.3
+  - 1.9.3
+  - 2.0.0
+  - 2.1.7
+  - 2.2.3

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 0.2.3 (23/11/2015)
+
+### Enhancements
+
+* Suppress client errors
+
 ## 0.2.2 (19/08/2015)
 
 ### Enhancements
@@ -29,4 +35,4 @@
 
 ## 0.1.0 (13/07/2015)
 
-* Initial release
+* Initial release

data/README.md

@@ -1,6 +1,10 @@
 # Gastly
 
-Create screenshots or previews of web pages using Gastly. Under the hood Phantom.js and MiniMagick. Gastly, I choose you!
+[![Gem Version](https://badge.fury.io/rb/gastly.svg)](http://badge.fury.io/rb/gastly)
+[![Dependency Status](https://gemnasium.com/mgrachev/gastly.svg)](https://gemnasium.com/mgrachev/gastly)
+[![Code Climate](https://codeclimate.com/github/mgrachev/gastly/badges/gpa.svg)](https://codeclimate.com/github/mgrachev/gastly)
+
+Create screenshots or previews of web pages using Gastly. Under the hood [Phantom.js](https://github.com/ariya/phantomjs/) and [MiniMagick](https://github.com/minimagick/minimagick). Gastly, I choose you!
 
 ![Gastly](https://github.com/mgrachev/gastly/raw/master/gastly.png)
 
@@ -35,7 +39,7 @@ screenshot.browser_width = 1280 # Default: 1440px
 screenshot.browser_height = 780 # Default: 900px
 screenshot.timeout = 1000 # Default: 0 seconds
 screenshot.cookies = { user_id: 1, auth_token: 'abcd' } # If you need
-screenshot.proxy_host = '10.10.10.1' # If you want to use a proxy
+screenshot.proxy_host = '10.10.10.1' # If you want to use a http proxy
 screenshot.proxy_port = '8080'
 image = screenshot.capture
 ```

data/Rakefile

@@ -1 +1 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'

data/gastly.gemspec

@@ -9,8 +9,8 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Mikhail Grachev']
   spec.email         = ['work@mgrachev.com']
 
-  spec.summary       = %q{Create screenshots or previews of web pages using Gastly. Gastly, I choose you!}
-  spec.description   = %q{Create screenshots or previews of web pages using Gastly. Under the hood Phantom.js and MiniMagick.}
+  spec.summary       = 'Create screenshots or previews of web pages using Gastly. Gastly, I choose you!'
+  spec.description   = 'Create screenshots or previews of web pages using Gastly. Under the hood Phantom.js and MiniMagick.'
   spec.homepage      = 'https://github.com/mgrachev/gastly'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
@@ -20,6 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 1.9'
   spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rubocop'
 
   spec.add_dependency 'phantomjs2', '~> 2.0'
   spec.add_dependency 'mini_magick', '~> 4.2'

data/lib/gastly.rb

@@ -4,7 +4,6 @@ require_relative 'gastly/exceptions'
 require_relative 'gastly/version'
 
 module Gastly
-
   def screenshot(url, **kwargs)
     Screenshot.new(url, **kwargs)
   end
@@ -14,4 +13,4 @@ module Gastly
   end
 
   module_function :screenshot, :capture
-end
+end

data/lib/gastly/exceptions.rb

@@ -7,5 +7,5 @@ module Gastly
     end
   end
 
-  PhantomJSError = Class.new(StandardError)
-end
+  PhantomJSError = Class.new(RuntimeError)
+end

data/lib/gastly/image.rb

@@ -2,7 +2,6 @@ require 'mini_magick'
 
 module Gastly
   class Image
-
     attr_reader :file
 
     def initialize(tempfile)
@@ -23,6 +22,5 @@ module Gastly
       @file.write(output)
       output
     end
-
   end
-end
+end

data/lib/gastly/screenshot.rb

@@ -4,7 +4,6 @@ require 'active_support/core_ext/object/blank'
 
 module Gastly
   class Screenshot
-
     SCRIPT_PATH = File.expand_path('../script.js', __FILE__)
     DEFAULT_TIMEOUT = 0
     DEFAULT_BROWSER_WIDTH = 1440
@@ -81,8 +80,7 @@ module Gastly
               when /^RuntimeError:(.+)/m  then Gastly::PhantomJSError
               end
 
-      raise error, $1
+      fail error, Regexp.last_match(1)
     end
-
   end
-end
+end

data/lib/gastly/script.js

@@ -1,15 +1,15 @@
 function extractDomain(url){
-    var domain;
-    // Remove protocol
-    if (url.indexOf("://") > -1) {
-        domain = url.split('/')[2];
-    } else {
-        domain = url.split('/')[0];
-    }
-    // Remove port number
-    domain = domain.split(':')[0];
-
-    return domain;
+  var domain;
+  // Remove protocol
+  if (url.indexOf("://") > -1) {
+      domain = url.split('/')[2];
+  } else {
+      domain = url.split('/')[0];
+  }
+  // Remove port number
+  domain = domain.split(':')[0];
+
+  return domain;
 }
 
 var i, pair,
@@ -18,72 +18,76 @@ var i, pair,
     page    = require('webpage').create();
 
 system.args.forEach(function(arg) {
-    pair = arg.split(/=(.*)/);
-    args[pair[0]] = pair[1];
+  pair = arg.split(/=(.*)/);
+  args[pair[0]] = pair[1];
 });
 
 if (args.cookies !== undefined) {
-    var cookiesPair = args.cookies.split(',');
+  var cookiesPair = args.cookies.split(',');
 
-    cookiesPair.forEach(function(cookie) {
-        pair = cookie.split(/=(.*)/);
+  cookiesPair.forEach(function(cookie) {
+    pair = cookie.split(/=(.*)/);
 
-        page.addCookie({
-            'name': pair[0],
-            'value': pair[1],
-            'path': '/',
-            'domain': extractDomain(args.url)
-        });
+    page.addCookie({
+      'name': pair[0],
+      'value': pair[1],
+      'path': '/',
+      'domain': extractDomain(args.url)
     });
+  });
 }
 
 phantom.onError = function(message, trace){
-    var messageStack = ['RuntimeError:' + message];
+  var messageStack = ['RuntimeError:' + message];
 
-    if (trace && trace.length) {
-        messageStack.push('Trace:');
+  if (trace && trace.length) {
+    messageStack.push('Trace:');
 
-        trace.forEach(function(t) {
-            messageStack.push(' -> ' + t.file + ': ' + t.line + (t.function ? ' (in function "' + t.function +'")' : ''));
-        });
-    }
+    trace.forEach(function(t) {
+        messageStack.push(' -> ' + t.file + ': ' + t.line + (t.function ? ' (in function "' + t.function +'")' : ''));
+    });
+  }
 
-    console.log(messageStack.join('\n'));
-    phantom.exit(1);
+  console.log(messageStack.join('\n'));
+  phantom.exit(1);
 }
 
+// Suppress client errors
+page.onError = function(message, trace){
+};
+
 page.open(args.url, function(status){
-    if(status !== 'success') {
-        console.log('FetchError:' + args.url);
-        phantom.exit();
-    } else {
-        window.setTimeout(function(){
-            page.viewportSize = { width: args.width, height: args.height };
-
-            if (args.selector !== undefined){
-                // Returns ClientRect object or null if selector not found
-                var clipRect = page.evaluate(function(s){
-                    var result, selector = document.querySelector(s);
-
-                    if (selector !== null) {
-                        result = selector.getBoundingClientRect();
-                    }
-
-                    return result;
-                }, args.selector);
-
-                if (clipRect !== null) {
-                    page.clipRect = {
-                        top:    clipRect.top,
-                        left:   clipRect.left,
-                        width:  clipRect.width,
-                        height: clipRect.height
-                    };
-                }
-            }
-
-            page.render(args.output);
-            phantom.exit();
-        }, args.timeout);
-    }
-});
+  if(status !== 'success') {
+    console.log('FetchError:' + args.url);
+    phantom.exit();
+  } else {
+    window.setTimeout(function(){
+      page.viewportSize = { width: args.width, height: args.height };
+
+      if (args.selector !== undefined){
+        // Returns ClientRect object or null if selector not found
+        var clipRect = page.evaluate(function(s){
+          var result, selector = document.querySelector(s);
+
+          if (selector !== null) {
+            result = selector.getBoundingClientRect();
+          }
+
+          return result;
+        }, args.selector);
+
+        if (clipRect !== null) {
+          page.clipRect = {
+            top:    clipRect.top,
+            left:   clipRect.left,
+            width:  clipRect.width,
+            height: clipRect.height
+          };
+        }
+      }
+
+      page.render(args.output);
+      phantom.exit();
+    }, args.timeout);
+  }
+});

data/lib/gastly/version.rb

@@ -1,3 +1,3 @@
 module Gastly
-  VERSION = '0.2.2'
-end
+  VERSION = '0.2.3'
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gastly
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Mikhail Grachev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-08-19 00:00:00.000000000 Z
+date: 2015-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,6 +38,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: phantomjs2
   requirement: !ruby/object:Gem::Requirement
@@ -89,6 +103,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -123,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.7
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Create screenshots or previews of web pages using Gastly. Gastly, I choose