garnierjm-dry-report 0.1 → 0.2

data/Rakefile

@@ -5,8 +5,8 @@ require 'rake/gempackagetask'
 require 'spec/rake/spectask'
 
 spec = Gem::Specification.new do |s|
-  s.name = 'dont_repeat_yourself'
-  s.version = '0.0.1'
+  s.name = 'garnierjm-dry-report'
+  s.version = '0.1'
   s.has_rdoc = false
   s.summary = 'Generate duplicate lines report'
   s.description = s.summary

data/TODO

@@ -1,26 +1,28 @@
 Must Have:
 
-    Dev Tasks:                   
-        - add gemspec syntax with dependencies
-        - publish verion 0.1 on github with http://gems.github.com/ ,
-        - add specs for Rails plugin
-        - delete project on rubyforge and communicate about it. 
-        - update http://github.com/garnierjm/dry-report/wikis/home        
+    Dev Tasks:        
+        - set up CI server http://runcoderun.com/github
+        - DRY plugin source code
+        - fix specs on plugin repo
+        - clean gem code, do not delete crontab plugin!        
+        - update http://github.com/garnierjm/dry-report/wikis/home & README (rename it to Textile?)
+        - delete project on rubyforge
+        - communicate: email mailing lists ruby & rails
         - Add an option for separating HTML/CSS related reports, from JS ones and from Ruby ones.                        
-        - add geminstaller dependency check (phillipe style) in the rake file:
-        hoe, syntax, rspec, rake, java        
+        - add geminstaller dependency check (phillipe style) in the rake file to run the specs:
+        hoe, syntax, rspec, rake
 
-    Communication Tasks:  
-        - new screencast with Netbeans + Autotest + DRY        
+    Communication Tasks:          
         - publicize in blogs and plugin sites:
             . Rails wiki
             . Rails mailing list, ruby mailing list, citcon mailing list
             . 2 other Rails plugins sites
             . wikipedia DRY (also add Simian)
-            . blogs : http://www.google.com/search?q=DRY+Rails&esrch=BetaShortcu        
+            . blogs : http://www.google.com/search?q=DRY+Rails&esrch=BetaShortcu
+            . Rails
 
 Nice to have:
-        
+        - new screencast with Netbeans + Autotest + DRY        
         - UML Class & Sequence Diagrams (generated?)
         - Aptana RadRails report, vim report, other report
         - Use RR for mocks Reg exp to convert RSpec mocks to RR mocks: dont_allow(@user) do |m| m.$1 end

data/lib/dont_repeat_yourself.rb

@@ -1,7 +1,7 @@
 $:.unshift(File.dirname(__FILE__)) unless $:.include?(File.dirname(__FILE__)) || $:.include?(File.expand_path(File.dirname(__FILE__)))
 
 require 'dont_repeat_yourself/cli'
+require 'dont_repeat_yourself/unit_testing_helpers'
 
-module DontRepeatYourself
-  
+module DontRepeatYourself  
 end

data/lib/dont_repeat_yourself/cli.rb

@@ -3,13 +3,7 @@ require 'optparse'
 
 module DontRepeatYourself
   class CLI
-    
-    ### Define methods for generating a DRY *_rails_report for Rails project where plugin is installed
-    DEFAULT_REPORT_DESC   = "display the default plain report"    
-    NETBEANS_REPORT_DESC  = "display the report in the Output window of the Netbeans IDE (Ctrl+4)"    
-    HTML_REPORT_DESC      = "generate an DRY_report.html file in the project root folder"    
-    TEXTMATE_REPORT_DESC  = "to generate an html report with links which open files in the Textmate editor"
-       
+           
     class << self
     
       def execute

data/lib/dont_repeat_yourself/formatter.rb

@@ -70,7 +70,7 @@ module DontRepeatYourself
       report << report_body.gsub(/TWO_SPACE_CHARS/, "&nbsp;&nbsp;").gsub(/\n/, "</br>\n")           
       report << report_footer
     end
-           
+    
     def format_duplicate_lines_snippet(block)
       starts = block.line_number_of_first_duplicate_line
       ends = block.line_number_of_last_duplicate_line

data/lib/dont_repeat_yourself/reporter.rb

@@ -44,12 +44,16 @@ module DontRepeatYourself
       self
     end
     
+    def basedir
+      @simian_runner.basedir
+    end
+    
     def report
       DontRepeatYourself::FormatterFactory.create_report(@report_type, run_simian)
     end        
     
     # TODO Not very readable: you have to read the code of run_simian to understand
-    def dry?      
+    def is_dry?
       run_simian.duplicate_line_count <= @maximum_number_of_duplicate_lines_i_want_in_my_project        
     end
     

data/lib/dont_repeat_yourself/unit_testing_helpers.rb

@@ -5,18 +5,9 @@ require 'test/unit/assertions'
 module DontRepeatYourself
   
   module UnitTestingHelpers
-    
-    #    module RubyAndRailsProjectHelpers
+        
     module RubyProjectHelpers
-      # Helpers
-      #      def ruby_code_in_rails_plugin(plugin_name)
-      #        DontRepeatYourself::RailsPluginProjectReporter.new(plugin_name)
-      #      end
-      #    
-      #      def rails_application
-      #        DontRepeatYourself::RailsProjectReporter.new
-      #      end
-      
+           
       def ruby_project(project_path)
         DontRepeatYourself::RubyProjectReporter.new(project_path)
       end            
@@ -28,7 +19,7 @@ module DontRepeatYourself
       include DontRepeatYourself::UnitTestingHelpers::RubyProjectHelpers
                   
       def assert_dry(project)
-        assert(project.dry?, project.failure_message)
+        assert(project.is_dry?, project.failure_message)
       end
     
     end   
@@ -39,11 +30,11 @@ module DontRepeatYourself
       
       include DontRepeatYourself::UnitTestingHelpers::RubyProjectHelpers
       
-      class BeDRY
+      class BeDRYMatcher
                               
         def matches?(project)
           @project = project
-          @project.dry?
+          @project.is_dry?
         end
               
         # TODO Do we really need this? It does not make a lot of sense
@@ -52,7 +43,7 @@ module DontRepeatYourself
         end
       
         def description
-          "be " << @project.description
+          "follow the 'Don't Repeat Yourself' principle " << @project.description
         end
         
         def failure_message
@@ -62,8 +53,8 @@ module DontRepeatYourself
       end        
     
       # Custom expectation matcher
-      def be_dry
-        DontRepeatYourself::UnitTestingHelpers::RSpecMatchers::BeDRY.new
+      def follow_the_dry_principle
+        DontRepeatYourself::UnitTestingHelpers::RSpecMatchers::BeDRYMatcher.new
       end                          
     
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: garnierjm-dry-report
 version: !ruby/object:Gem::Version 
-  version: "0.1"
+  version: "0.2"
 platform: ruby
 authors: 
 - Jean-Michel Garnier
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-10-14 00:00:00 -07:00
+date: 2008-11-13 00:00:00 -08:00
 default_executable: dry-report
 dependencies: 
 - !ruby/object:Gem::Dependency