gared 0.0.28 → 0.0.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f22677bcf110b745ab91eff743bec77b61da5c8a8bc621d5ca9d01cedb3f3884
-  data.tar.gz: 8c2c1ee16db5008fc2952376767d892700db64283597af81c3f5469a9a1505dd
+  metadata.gz: 5a4f6f4cbc307c097bf84e4308d7cc76257583ba58f97d0c861ebd79e1e362e6
+  data.tar.gz: 83aca016e843de3bbdbdfbeecdf1b4b544a376d3205970a810c5076ce3d3466e
 SHA512:
-  metadata.gz: e499ca87b0ee1c1fef99c225bbdee3f73e38b8bfa6535eb6fcb955b4eec1abdec6b28104f4ac38db05ed32e7e67152baa518992bba89ad8c7bfa1326854ff097
-  data.tar.gz: 16a97a64cf82de5998d5a816755e94ced98d5d4e084eeacbea2cb2fc4f6b651add34b6801f26847d5577a52e29014d93d5c6166899ecad7e5325a304139c57bb
+  metadata.gz: 686d91870739b68c421f68c3a55fd8443dec0f4747118137d0cd256758e67e223c9db5617c7cbd408a4295c32936741172f8865dd96c1303a318841ff4157a41
+  data.tar.gz: 85336cda8af09b48fa3515d90efb5898dbe28592282c17ce3f352cde96ba459aa50a9cab7c2b32c6d32df4afe52a547d7a999a02a19eb4c4edf28e5beff729fd

data/lib/gared/primo.rb

@@ -53,14 +53,24 @@ module Gared
             # collect additional URLS from record, for clients to be able to determine whether a scanned object exists
             additional_urls = []
             deets.keys.each do |key|
-              additional_urls << deets[key] if deets[key] =~ /https?:[^\s]/
+              if deets[key].class == Array
+                deets[key].each do |kkey|
+                  additional_urls << kkey if kkey.class == String && kkey =~ /https?:[^\s]/
+                end
+              elsif deets[key].class == String
+                additional_urls << deets[key] if deets[key] =~ /https?:[^\s]/
+              end
             end
             p.additional_urls = additional_urls if additional_urls.length > 0
             h = Holding.new
             h.source_id = p.source_id
             h.source_name = 'Primo:'+@options[:institution]
             
-            h.location = r['LIBRARIES']['LIBRARY'][0].nil? ? r['LIBRARIES']['LIBRARY']['callNumber'] : r['LIBRARIES']['LIBRARY'][0]['callNumber'] # there seem to be two cases, different between NLI and TAU, for example
+            begin
+              h.location = r['LIBRARIES']['LIBRARY'][0].nil? ? r['LIBRARIES']['LIBRARY']['callNumber'] : r['LIBRARIES']['LIBRARY'][0]['callNumber'] # there seem to be two cases, different between NLI and TAU, for example; there also seems to not even be a LIBRARIES key for some electronic resources. We're skipping those.
+            rescue Exception
+              puts $!
+            end
             p.add_holding(h)
             ret << p
           rescue Exception

data/test/test_gared.rb

@@ -10,7 +10,7 @@ class GaredTest < Minitest::Test
       return
     end
     puts "Testing NLI API"
-    byebug
+    #byebug
     nli = Gared::Nli_Api.new('https://api.nli.org.il/openlibrary/search', ENV['NLI_API_KEY'])
     refute_nil nli
     #recs = nli.query_publications_by_person('ביאליק')
@@ -20,16 +20,16 @@ class GaredTest < Minitest::Test
     refute_empty(recs[0].title)
   end
 
-# temporarily disabled until we find another Primo server to test against
-#  def test_primo_query_publications_by_person
-#    puts "Testing Primo"
-#    primo = Gared::Primo.new('http://primo.nli.org.il/PrimoWebServices/xservice/search/brief', 'NNL')
-#    refute_nil primo
-#    recs = primo.query_publications_by_person('אילנאה')
-#    refute_nil recs
-#    refute_empty(recs)
-#    refute_empty(recs[0].title)
-#  end
+  # temporarily disabled until we find another Primo server to test against
+  def test_primo_query_publications_by_person
+    puts "Testing Primo"
+    primo = Gared::Primo.new('http://tau-primo.hosted.exlibrisgroup.com/PrimoWebServices/xservice/search/brief', 'TAU')
+    refute_nil primo
+    recs = primo.query_publications_by_person('אילנאה')
+    refute_nil recs
+    refute_empty(recs)
+    refute_empty(recs[0].title)
+  end
 
   def test_googlebooks_query_publications_by_person
     if ENV['GOOGLE_API_KEY'].nil?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gared
 version: !ruby/object:Gem::Version
-  version: 0.0.28
+  version: 0.0.29
 platform: ruby
 authors:
 - Asaf Bartov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-01-28 00:00:00.000000000 Z
+date: 2023-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: watir
@@ -102,7 +102,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Scrape Hebrew bibliography sources