garb 0.8.2 → 0.8.3

data/lib/garb.rb

@@ -7,6 +7,7 @@ require 'crack'
 
 begin
   require 'active_support/inflector'
+  require 'active_support/deprecation'
 rescue LoadError
   require 'active_support'
 end

data/lib/garb/model.rb

@@ -3,6 +3,10 @@ module Garb
     MONTH = 2592000
     URL = "https://www.google.com/analytics/feeds/data"
 
+    def self.extended(base)
+      ProfileReports.add_report_method(base)
+    end
+
     def metrics(*fields)
       @metrics ||= ReportParameter.new(:metrics)
       @metrics << fields
@@ -26,6 +30,8 @@ module Garb
 
       param_set = [
         default_params,
+        metrics.to_params,
+        dimensions.to_params,
         parse_filters(options).to_params,
         parse_segment(options),
         parse_sort(options).to_params,

data/lib/garb/profile.rb

@@ -21,11 +21,12 @@ module Garb
     end
 
     def self.all(session = Session)
+      ActiveSupport::Deprecation.warn("Garb::Profile.all is deprecated in favor of Garb::Management::Profile.all")
       AccountFeedRequest.new(session).entries.map {|entry| new(entry, session)}
     end
 
-    # ActiveSupport::Deprecation.warn
     def self.first(id, session = Session)
+      ActiveSupport::Deprecation.warn("Garb::Profile.first is deprecated in favor of Garb::Management::WebProperty")
       all(session).detect {|profile| profile.id == id || profile.web_property_id == id }
     end
   end

data/lib/garb/profile_reports.rb

@@ -3,7 +3,8 @@ module Garb
     def self.add_report_method(klass)
       # demodulize leaves potential to redefine
       # these methods given different namespaces
-      method_name = klass.to_s.demodulize.underscore
+      method_name = klass.name.demodulize.underscore
+      return unless method_name.length > 0
 
       class_eval <<-CODE
         def #{method_name}(opts = {}, &block)

data/lib/garb/report.rb

@@ -6,7 +6,7 @@ module Garb
     URL = "https://www.google.com/analytics/feeds/data"
 
     def initialize(profile, opts={})
-      # ActiveSupport::Deprecation.warn("The use of report will be removed in favor of extend Garb::Scheme")
+      ActiveSupport::Deprecation.warn("The use of Report will be removed in favor of 'extend Garb::Model'")
 
       @profile = profile
 

data/lib/garb/resource.rb

@@ -9,6 +9,8 @@ module Garb
       # to enable profile.exits(options_hash, &block)
       # returns Exits.results(self, options_hash, &block)
       # every class defined which extends Resource will add to the module
+
+      # ActiveSupport::Deprecation.warn
       ProfileReports.add_report_method(base)
     end
 

data/lib/garb/version.rb

@@ -3,7 +3,7 @@ module Garb
 
     MAJOR = 0
     MINOR = 8
-    TINY  = 2
+    TINY  = 3
 
     def self.to_s # :nodoc:
       [MAJOR, MINOR, TINY].join('.')

data/test/unit/garb/model_test.rb

@@ -60,12 +60,17 @@ module Garb
             DataRequest.stubs(:new).returns(stub(:send_request => @response))
             ReportResponse.stubs(:new).returns(stub(:results => ['result']))
 
+            @test_model.stubs(:metrics).returns(stub(:to_params => {'metrics' => 'ga:visits'}))
+            @test_model.stubs(:dimensions).returns(stub(:to_params => {'dimensions' => 'ga:pagePath'}))
+
             now = Time.now
             Time.stubs(:new).returns(now)
 
             @params = {'ids' => Garb.to_ga(@profile.id),
               'start-date' => (now - Model::MONTH).strftime('%Y-%m-%d'),
-              'end-date' => now.strftime('%Y-%m-%d')}
+              'end-date' => now.strftime('%Y-%m-%d'),
+              'metrics' => 'ga:visits',
+              'dimensions' => 'ga:pagePath'}
           end
 
           should "get all results" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: garb
 version: !ruby/object:Gem::Version 
-  hash: 59
+  hash: 57
   prerelease: false
   segments: 
   - 0
   - 8
-  - 2
-  version: 0.8.2
+  - 3
+  version: 0.8.3
 platform: ruby
 authors: 
 - Tony Pitale