gaq 0.2.1 → 0.2.2

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    YTc3MTUwZGM5NmUxNjQ0ODc3NjcwODQ3NWFlNjRlMjk3ZjcxYjdlMA==
+  data.tar.gz: !binary |-
+    NzEwZGZiNTY2NzRlYzlmZTRlNjAxNTdkMjE0NGNhYTQyMmI3OTcwNQ==
+!binary "U0hBNTEy":
+  metadata.gz: !binary |-
+    NzhjNzAzYTVjODI4MGE1YjAxYWMzZmVkNTA5ZTJjMDYxMjMzNjY2NTUxOTQ5
+    ZDE1YmIwN2Q3YTVmMDIzZjdmMGY0ZTliMjE2MzdlYzMzOTA5MzNlY2E0NzE1
+    NjU0OWIxYmJiYmFlMGE5MTIxMWMwNDA5ODYwOGZiNDUwMzFmNGQ=
+  data.tar.gz: !binary |-
+    ZTg2Mjc0ZjkyYjFjMmZhNTc4ODIyYjg2NWI3NDIzNGExZTE1MDFiOTBjZmRj
+    M2ZiNTVjZWU2Mjg4MTBjYWQ2NmU1ODZmNWEwYTMxZmRkODkwMTE1MTdlMTY3
+    N2Q2YjhhZDUxYzQ3MzllMjg3ODA2Y2RjZDU2OWE4ZTU5M2RjYjU=

data/.travis.yml

@@ -0,0 +1,5 @@
+language: ruby
+
+rvm:
+  - 1.9.3
+  - 2.0.0

data/Gemfile

@@ -17,3 +17,5 @@ gem 'debugger'
 gem 'nokogiri'
 
 gem 'coveralls', require: false
+
+gem 'rake'

data/lib/gaq/controller_handle.rb

@@ -27,8 +27,7 @@ module Gaq
       commands = immediate_commands.dup
       commands << @language.new_command(:anonymize_ip) if interpret_config(@config.anonymize_ip)
 
-      setup_tracker_names = [nil, *track_pageview_tracker_names, *seen_tracker_names].uniq
-      setup_tracker_names.each do |tracker_name|
+      @config.tracker_names.each do |tracker_name|
         tracker_config = @config.tracker_config(tracker_name)
         commands += tracker_setup_commands(tracker_config) if tracker_config
       end
@@ -43,16 +42,6 @@ module Gaq
       super(value, @controller_facade)
     end
 
-    def seen_tracker_names
-      immediate_commands.map(&:tracker_name).uniq
-    end
-
-    def track_pageview_tracker_names
-      @config.tracker_names.select do |tracker_name|
-        @config.tracker_config(tracker_name).track_pageview?
-      end
-    end
-
     def tracker_setup_commands(tracker_config)
       [set_account_command(tracker_config), track_pageview_command(tracker_config)].compact
     end

data/lib/gaq/version.rb

@@ -1,3 +1,3 @@
 module Gaq
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/spec/lib/gaq/controller_handle_spec.rb

@@ -281,24 +281,8 @@ module Gaq
             rails_config.track_pageview = false
           end
 
-          it "does not render anything for default tracker", pending: true do
-            # Currently, the default tracker _setAccount is always rendered.
-            # I'm undecided about that.
-            # If the implementation stays this way, I should assert
-            # _setAccount presence here instead.
-            result.should_not include command_segments.for_default_tracker
-          end
-
-          context "with a tracker command" do
-            before do
-              # this is really an arbitrary tracker command.
-              root_target.track_event 'category', 'action', 'label'
-            end
-
-            it "renders the _setAccount, but not a _trackPageview" do
-              result.should include(["_setAccount", 'UA-TEST23-5'])
-              result.should_not include(command_segments.starting_with('_trackPageview'))
-            end
+          it "does not render a _trackPageview for the tracker" do
+            result.should_not include(["_trackPageview"])
           end
         end
       end
@@ -435,34 +419,6 @@ module Gaq
           rails_config.additional_trackers = ["foo"]
         end
 
-        context "configured not to track pageviews" do
-          before do
-            rails_config.tracker(:foo).track_pageview = false
-          end
-
-          it "does not render any command for the additional tracker" do
-            result.should_not include(command_segments.for_tracker('foo'))
-          end
-
-          context "after gaq[:foo].track_event 'category', 'action', 'label'" do
-            before do
-              root_target["foo"].track_event 'category', 'action', 'label'
-            end
-
-            it "renders the proper _setAccount" do
-              result.should include(["foo._setAccount", "UA-XUNSET-S"])
-            end
-
-            it "does not render a _trackPageview for the tracker" do
-              result.should_not include(["foo._trackPageview"])
-            end
-
-            it "renders the _trackEvent" do
-              result.should include(["foo._trackEvent", "category", "action", "label"])
-            end
-          end
-        end
-
         it "renders a _setAccount for the additional tracker" do
           result.should include(['foo._setAccount', "UA-XUNSET-S"])
         end
@@ -471,17 +427,19 @@ module Gaq
           result.should include(["foo._trackPageview"])
         end
 
-        context "after gaq[:foo].track_event 'category', 'action', 'label'" do
+        context "configured not to track pageviews" do
           before do
-            root_target["foo"].track_event 'category', 'action', 'label'
+            rails_config.tracker(:foo).track_pageview = false
           end
 
-          it "renders a _setAccount for the additional tracker" do
-            result.should include(['foo._setAccount', "UA-XUNSET-S"])
+          it "does not render a _trackPageview for the tracker" do
+            result.should_not include(["foo._trackPageview"])
           end
+        end
 
-          it "renders a _trackPageview for the tracker" do
-            result.should include(["foo._trackPageview"])
+        context "after gaq[:foo].track_event 'category', 'action', 'label'" do
+          before do
+            root_target["foo"].track_event 'category', 'action', 'label'
           end
 
           it "renders the _trackEvent" do

metadata

@@ -1,44 +1,39 @@
 --- !ruby/object:Gem::Specification
 name: gaq
 version: !ruby/object:Gem::Version
-  version: 0.2.1
-  prerelease: 
+  version: 0.2.2
 platform: ruby
 authors:
 - Thomas Stratmann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-04 00:00:00.000000000 Z
+date: 2013-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
+  type: :runtime
+  prerelease: false
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
+  type: :runtime
+  prerelease: false
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
-  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -53,6 +48,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .simplecov
+- .travis.yml
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -126,27 +122,26 @@ files:
 - spec/lib/gaq/snippet_renderer_spec.rb
 homepage: ''
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Renders _gaq initialization and the ga.js snippet. Supports pushing from
   the back end
 test_files: