gamekey 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f9021ba8301abd0b2212bac379f30853727da957
-  data.tar.gz: 65f3202b5b2a8b46da58317ce73634670f3a2931
+  metadata.gz: 5e1811ae91ca0c3a3e8bf367102245dc6966f0e3
+  data.tar.gz: b10f545ec4a409351660c5d594ca0178e9ac298d
 SHA512:
-  metadata.gz: e9d54d1d3e9c58bfbf10356956cce144916709fbb55c7ec11db49905304d8443281a1f1866ff11aa195a74f2649dfaf7f0dd653399e82d6316c04a1e9cf816ce
-  data.tar.gz: 50f9540a370b0e27dc43de89e81c9c9e9b6c059e5aa3b58bf966e6f433c2f46b4c185e5a379568c34d1029aba6843e810f017e1db7fc6e1bb5e0492a54663f5a
+  metadata.gz: 2c2bb15f1b1ba226d5dd5aa4360b0fbcd3a089f7a82a4f531553e867454c68dcb45996edb5d6fa04d3f63a35114c2d66d9944b09fd056b35b413ee58512820f6
+  data.tar.gz: 1a9bfe61b13773a46070d54e13de7f880389f31b8ed534dbfb1bd1cbce7f3000348c892053fdcc4c63ceff3e15c46adbb3316528341c54b38fcecf4e02437770

data/README.md

@@ -134,6 +134,10 @@ So you can get all the sources via the following git command.
     
 ## Changelog
 
+### Version 0.0.3
+POST /user checks now that a password and a user name is provided. 
+Thanks again to Jan Lukas Deichmann figuring out this bug (WebTech SoSe 2016).
+
 ### Version 0.0.2
 POST /game checks now that a secret is provided. 
 Thanks to Jan Lukas Deichmann figuring out this bug (WebTech SoSe 2016).

data/bin/gamekey

@@ -9,7 +9,7 @@ require 'gamekey'
 require 'defaults'
 require 'reference'
 
-program :version, '0.0.2'
+program :version, Gamekey::VERSION
 program :description, 'Command to launch, manage and test the gamekey service.'
 default_command :help
 

data/lib/gamekey.rb

@@ -128,6 +128,16 @@ class GamekeyService
         mail = params['mail']
         id   = SecureRandom.uuid
 
+        if (name == nil || name.empty?)
+          status 400
+          return "Bad Request: '#{name}' is not a valid name"
+        end
+
+        if (pwd == nil || pwd.empty?)
+          status 400
+          return "Bad Request: password must be provided and not be empty"
+        end
+
         unless mail =~ Defaults::VALID_EMAIL_REGEX || mail == nil
           status 400
           return "Bad Request: '#{mail}' is not a valid email."

data/lib/gamekey/version.rb

@@ -1,3 +1,3 @@
 module Gamekey
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/reference.rb

@@ -42,6 +42,13 @@ class GamekeyReferenceTests
 
     uri = URI("#{@host}/user")
     send = DateTime.now
+
+    res = Net::HTTP.post_form(uri, 'name' => @user)
+    return "#{error('POST', '/user', "PU-0")} Could create user '#{@user}' without password (should return HTTP code 400, was #{res.code})".red unless (res.code == "400")
+
+    res = Net::HTTP.post_form(uri, 'pwd' => 'secret')
+    return "#{error('POST', '/user', "PU-0a")} Could create user without name (should return HTTP code 400, was #{res.code})".red unless (res.code == "400")
+
     res = Net::HTTP.post_form(uri, 'name' => @user, 'pwd' => @pwd)
 
     return "#{error('POST', '/user', "PU-1")} Could not create user '#{@user}' (should return HTTP code 200, was #{res.code})".red unless (res.code == "200")
@@ -271,7 +278,7 @@ class GamekeyReferenceTests
       name = "John Doe #{i}"
       request.set_form_data({
           "name" => name,
-          "pwd" => ""
+          "pwd" => "secret"
       })
       res = http.request(request)
       return "#{error('POST', '/user', "SU-1")} Creating user with name '#{name}' failed while stress testing.\n#{res.body}".red unless res.code == "200"
@@ -286,7 +293,7 @@ class GamekeyReferenceTests
     users.each do |user|
       delete_user = Net::HTTP::Delete.new("/user/#{user['id']}")
       delete_user.set_form_data({
-          "pwd" => ""
+          "pwd" => "secret"
       })
       res = http.request(delete_user)
       return "#{error('DELETE', '/user/id', "SU-3")} Deleting user with id '#{user['name']} (#{user['id']})' failed while stress testing.\n#{res.body}".red unless res.code == "200"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gamekey
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Nane Kratzke