galetahub-enum_field 0.5.3 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2be661f299492be0519d65da4c1058d38799ff3e
-  data.tar.gz: a06ff5abf876efbfb0d9318aac939566e7daad83
+SHA256:
+  metadata.gz: ecf564d565c3fb097c126fee3d88effe88d0240c5359fe2ea0ca466f163f9127
+  data.tar.gz: 53d0500a0585fe7ebd765b0771f1ca0235a797c7e420d8b4c95edbd177bf1f0c
 SHA512:
-  metadata.gz: 243473028ff13052255159cdb793122763ab4e568a7289fa6db1a825dace9edcf7345a6767f8b66f357ee780173e70f50617adcbef293211a35e354225724c45
-  data.tar.gz: e1f248f5232d6aa901081579fba8faddbe86a0a71853b984c76c4fe464f1cc73699ee0f400de0df4866dfde17c13fecd4ecf2b6f7bbd3b078e0dedcd50307f8c
+  metadata.gz: f5fee53ce52bc2ff4d69a0c6e99976837164b74ca713f7630c1562158750fdcace36ea1e8e5bf4b0137c4649063842584ba76ee2c4776c8fd92c08981d2e4143
+  data.tar.gz: 1d70dff1a5d345f44152b85f1eec2a583cb9f9cbb238262525a1bc3fb0afc2384206d26b4cce709215d8ea54d49947059b842b5a1ecc7f908391b3c1f2cc6ca5

data/README.md

@@ -107,7 +107,9 @@ PhoneType.first == PhoneType.home
 PhoneType.last == PhoneType.mobile
 
 PhoneType.find_by_id(PhoneType.home.id) == PhoneType.home
-PhoneType.find_by_id(123456) == nil
+PhoneType.find_by_id(123456) == nil # will not raise if id does not exists
+PhoneType.safe_find(123456) == nil # just alias for find_by_id
+
 PhoneType.find(2) == PhoneType.commercial
 PhoneType.find(123456)  # will raise
 

data/Rakefile

@@ -1,25 +1,26 @@
-# encoding: utf-8
-require 'rake'
-require 'rake/testtask'
-require 'rake/rdoctask'
-require File.join(File.dirname(__FILE__), 'lib', 'enum_field', 'version')
-
-desc 'Default: run unit tests.'
-task :default => :test
-
-desc 'Test the enum_field plugin.'
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.libs << 'test'
-  t.pattern = 'test/**/*_test.rb'
-  t.verbose = true
-end
-
-desc 'Generate documentation for the enum_field plugin.'
-Rake::RDocTask.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'EnumField'
-  rdoc.options << '--line-numbers' << '--inline-source'
-  rdoc.rdoc_files.include('README.rdoc')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
+# frozen_string_literal: true
+
+require 'rake'
+require 'rake/testtask'
+require 'rake/rdoctask'
+require File.join(File.dirname(__FILE__), 'lib', 'enum_field', 'version')
+
+desc 'Default: run unit tests.'
+task default: :test
+
+desc 'Test the enum_field plugin.'
+Rake::TestTask.new(:test) do |t|
+  t.libs << 'lib'
+  t.libs << 'test'
+  t.pattern = 'test/**/*_test.rb'
+  t.verbose = true
+end
+
+desc 'Generate documentation for the enum_field plugin.'
+Rake::RDocTask.new(:rdoc) do |rdoc|
+  rdoc.rdoc_dir = 'rdoc'
+  rdoc.title    = 'EnumField'
+  rdoc.options << '--line-numbers' << '--inline-source'
+  rdoc.rdoc_files.include('README.rdoc')
+  rdoc.rdoc_files.include('lib/**/*.rb')
+end

data/lib/enum_field.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 # Basic usage:
 #

data/lib/enum_field/attribute_value_resolver.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module EnumField
   class AttributeValueResolver
     attr_reader :value, :klass
@@ -18,7 +20,7 @@ module EnumField
     private
 
     def value_is_member?
-      value && value.respond_to?(:id)
+      value&.respond_to?(:id)
     end
 
     def value_is_member_name?

data/lib/enum_field/builder.rb

@@ -1,8 +1,8 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 module EnumField
   class Builder
-    METHODS = %w[all names find_by_id find first last ids valid_id? valid_name?].freeze
+    METHODS = %w[all names find_by_id find first last ids valid_id? valid_name? safe_find].freeze
 
     attr_reader :members
 
@@ -58,12 +58,13 @@ module EnumField
 
     def find_by_id(id)
       case id
-      when Array then
+      when Array
         all.select { |object| id.include?(object.id) }
       else
         all.detect { |object| object.id == id }
       end
     end
+    alias safe_find find_by_id
 
     def method_missing(method_name, *args, &block)
       if @target.respond_to?(method_name)

data/lib/enum_field/define_enum.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 module EnumField
   # Add enum methods to class

data/lib/enum_field/enumerated_attribute.rb

@@ -1,4 +1,4 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
 require 'active_support/inflector'
 

data/lib/enum_field/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module EnumField
-  VERSION = '0.5.3'.freeze
+  VERSION = '0.5.4'
 end

data/spec/enum_field/attribute_value_resolver_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe EnumField::AttributeValueResolver do

data/spec/enum_field/define_enum_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe EnumField::DefineEnum do
@@ -38,6 +40,12 @@ describe EnumField::DefineEnum do
       expect(Role.find_by_id(3)).to eq Role.employee
     end
 
+    it 'must safe_find one instance' do
+      expect(Role.safe_find(1)).to eq Role.admin
+      expect(Role.safe_find(2)).to eq Role.manager
+      expect(Role.safe_find(3)).to eq Role.employee
+    end
+
     it 'must find_by_id array of instances' do
       expect(Role.find_by_id([2, 3])).to eq [Role.manager, Role.employee]
       expect(Role.find_by_id([nil, 1])).to eq [Role.admin]

data/spec/enum_field/enumerated_attribute_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe EnumField::EnumeratedAttribute do
@@ -35,8 +37,8 @@ describe EnumField::EnumeratedAttribute do
   end
 
   it 'must set role_type_id' do
-    expect {
+    expect do
       admin_user.role_type = new_role
-    }.to change { admin_user.role_type_id }.from(RoleType.admin.id).to(new_role.id)
+    end.to change { admin_user.role_type_id }.from(RoleType.admin.id).to(new_role.id)
   end
 end

data/spec/enum_field_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe EnumField do

data/spec/spec_helper.rb

@@ -1,2 +1,4 @@
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+# frozen_string_literal: true
+
+$LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 require 'enum_field'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: galetahub-enum_field
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
 platform: ruby
 authors:
 - Igor Galeta
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-12 00:00:00.000000000 Z
+date: 2020-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -108,13 +108,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Enumerated attributes for any ruby class aka Active Record
 test_files:
-- spec/enum_field/attribute_value_resolver_spec.rb
-- spec/enum_field/define_enum_spec.rb
-- spec/enum_field/enumerated_attribute_spec.rb
 - spec/enum_field_spec.rb
 - spec/spec_helper.rb
+- spec/enum_field/enumerated_attribute_spec.rb
+- spec/enum_field/attribute_value_resolver_spec.rb
+- spec/enum_field/define_enum_spec.rb