galaxy_converter 3.1.2 → 3.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d7f0865539e739036e79313e9d9b65227d3b0cc1d22e5156332a39f642098500
-  data.tar.gz: 5d9f6de7ef78706cf1380b5c199e97b3703c17d4ffea755e8669d2420911213a
+  metadata.gz: c48f08e77a74b98ab61cfb545116a8ab1fe1e02855f1861f842d44182f96e76e
+  data.tar.gz: '059236058f8486ed9a3442ce525ff8d700fa51e80014b85ad3f30014fcd8eb51'
 SHA512:
-  metadata.gz: 6cb4fb0d5580bdc0642dda78eb2b2ba58300272474eb4e94ab2a9a4e1b0d88aeb95ee1362d33fce1d1400781b1da3bd52913985eac93b9ff8aa70d9c2ec068c1
-  data.tar.gz: d1be7f1f07456e668694cc4dd8e29e73c1f1f0fa9223340766eb53650c412a22e6ab21543ffa771745d0f0fd686355f5a7f25663808807e3a81881e3451e9ae9
+  metadata.gz: 5a324e325d47d5ede327c036a59f8f3487084b2c080ff22fc6599731f0e089cf7e6ad856f02bd8aa3307562d19e1d07833ae88d5c10f59f40128c2301e64c324
+  data.tar.gz: 6037b4ca02e5b73ffef27601bf464d9c2e0c8824b35f34b72655f6e2e7f886fcaddcfcd462a996daa0d0b6c0a3d08be0aa9bad95d8287baf62f99d8c3fe93fe4

data/README.md

@@ -5,7 +5,8 @@
   * [Roman numerals](#roman-numerals)
 * [Installation](#installation)
 * [Usage](#usage)
-  * [CLI](#cli)
+  * [Input](#input)
+  * [Output](#output)
 
 ## Scope
 This gem is the Ruby implementation of the `Merchant's Guide to the Galaxy` code-kata.
@@ -27,9 +28,8 @@ gem install galaxy_converter
 
 ## Usage
 
-### CLI
-The gem provides a CLI interface. 
-The program accepts as input a file containing several conversion notes:
+### Input
+The gem provides a CLI interface accepting as input a file containing several conversion notes:
 ```txt
 # ~/notes.txt
 glob is I
@@ -46,6 +46,7 @@ how many Credits is glob prok Iron ?
 how much wood could a woodchuck chuck if a woodchuck could chuck wood ?
 ```
 
+### Output
 Just pass the file path to the program:
 ```shell
 galaxy_converter ~/notes.txt

data/lib/galaxy_converter/constraint.rb

@@ -3,16 +3,11 @@ module GalaxyConverter
     extend self
 
     def call(value)
-      return if value.empty?
       violations.any? { |violation| value.index(violation) }
     end
 
     private def violations
-      @violations ||= repetitions + subtractions
-    end
-
-    private def repetitions
-      too_many_repetitions + unrepeatable
+      @violations ||= too_many_repetitions + unrepeatable + repeated_sub + wrong_sub
     end
 
     private def too_many_repetitions
@@ -23,10 +18,6 @@ module GalaxyConverter
       %w[D L V].map { |c| c * 2 }
     end
 
-    private def subtractions
-      repeated_sub + wrong_sub
-    end
-
     private def repeated_sub
       %w[V X].map { |c| "II#{c}"} +
         %w[L C].map { |c| "XX#{c}"} +

data/lib/galaxy_converter/detector.rb

@@ -9,8 +9,7 @@ module GalaxyConverter
     attr_reader :converter
 
     def initialize(notes, converter = Converter)
-      notes = notes.reject(&:question?)
-      @credits, @assertions = notes.partition { |note| note.instance_of? Credit }
+      @credits, @assertions = notes.reject(&:question?).partition { |note| note.instance_of? Credit }
       @converter = converter.new(mapping)
     end
 
@@ -27,7 +26,7 @@ module GalaxyConverter
     end
 
     private def mapping
-      @mapping ||= @assertions.reduce({}) do |acc, note|
+      @assertions.reduce({}) do |acc, note|
         matching = note.body.match(MAPPING_RULE)
         next acc unless matching
         unit, roman = matching.captures

data/lib/galaxy_converter/roman_numeral.rb

@@ -26,23 +26,15 @@ module GalaxyConverter
       @constraint = constraint
     end
 
-    def to_s
-      @value
-    end
-
     def to_i
-      return 0 unless valid?
-      stretched.chars.sum { |symbol| SYMBOLS.fetch(symbol, 0) }
+      return 0 if @constraint.call(@value)
+      to_l.chars.sum { |symbol| SYMBOLS.fetch(symbol, 0) }
     end
 
-    private def stretched
-      @stretched ||= STRETCH_MAP.reduce(@value) do |value, (long, short)|
+    private def to_l
+      STRETCH_MAP.reduce(@value) do |value, (long, short)|
         value.gsub(short, long)
       end
     end
-
-    private def valid?
-      !@constraint.call(@value)
-    end
   end
 end

data/lib/galaxy_converter/version.rb

@@ -1,3 +1,3 @@
 module GalaxyConverter
-  VERSION = "3.1.2"
+  VERSION = "3.1.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: galaxy_converter
 version: !ruby/object:Gem::Version
-  version: 3.1.2
+  version: 3.1.3
 platform: ruby
 authors:
 - costajob
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-02 00:00:00.000000000 Z
+date: 2019-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler