gabbara 0.0.2 → 0.0.3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gabbara (0.0.2)
+    gabbara (0.0.3)
       activesupport
 
 GEM

data/lib/gabbara/gabba.rb

@@ -83,8 +83,11 @@ module Gabbara
     end
 
     def event_data(category, action, label = nil, value = nil)
-      data = "5(#{category}*action" + (label ? "*#{label})" : ")")
-      data += "(#{value})" if value
+      "5(#{category}*action".tap do |data|
+        data << "*#{label}" if label
+        data << ")"
+        data << "(#{value})" if value
+      end
     end
 
     # create magical cookie params used by GA for its own nefarious purposes

data/lib/gabbara/version.rb

@@ -1,3 +1,3 @@
 module Gabbara
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/gabba_spec.rb

@@ -50,7 +50,40 @@ describe Gabbara::Gabba do
     end
   end
 
-  describe "when tracking custom events" do
+  describe "when tracking custom events with two params" do
+    before do
+      stub_analytics "utme"=>"5(cat1*action)", "utmt"=>"event"
+      @gabba = Gabbara::Gabba.new("UC-123", "domain", :utmn => "1009731272", :utmcc => '')
+    end
+
+    it "must do a request to google" do
+      @gabba.event("cat1", "act1", :utmhid => "6783939397")
+    end
+  end
+
+  describe "when tracking custom events with label without value" do
+    before do
+      stub_analytics "utme"=>"5(cat1*action*lab1)", "utmt"=>"event"
+      @gabba = Gabbara::Gabba.new("UC-123", "domain", :utmn => "1009731272", :utmcc => '')
+    end
+
+    it "must do a request to google" do
+      @gabba.event("cat1", "act1", "lab1", :utmhid => "6783939397")
+    end
+  end
+
+  describe "when tracking custom events with value without label" do
+    before do
+      stub_analytics "utme"=>"5(cat1*action)(val1)", "utmt"=>"event"
+      @gabba = Gabbara::Gabba.new("UC-123", "domain", :utmn => "1009731272", :utmcc => '')
+    end
+
+    it "must do a request to google" do
+      @gabba.event("cat1", "act1", nil, "val1", :utmhid => "6783939397")
+    end
+  end
+
+  describe "when tracking custom events with all params" do
     before do
       stub_analytics "utme"=>"5(cat1*action*lab1)(val1)", "utmt"=>"event"
       @gabba = Gabbara::Gabba.new("UC-123", "domain", :utmn => "1009731272", :utmcc => '')

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: gabbara
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: false
   segments: 
   - 0
   - 0
-  - 2
-  version: 0.0.2
+  - 3
+  version: 0.0.3
 platform: ruby
 authors: 
 - Michael Reinsch
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-12-20 00:00:00 +09:00
+date: 2010-12-27 00:00:00 +09:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency