gabba-gmp 0.0.6 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa1fbbacd4ca5a11831eaa722996264acfa10816
-  data.tar.gz: 216b0557d338dae6f714eac54dfc3df6570a263a
+  metadata.gz: c717601102a85e2882336840bf5b98d1bcbdca3d
+  data.tar.gz: bebccac8403b912d503aa4e437c1139256f7e917
 SHA512:
-  metadata.gz: 64eace221e2ed9b8d30ef049b6322461c6e01d0e30bb90f7903387c613a50c58d13bdbfa19ee0190935e84093fe1b527ee396a210552ed1064a05699ea787e16
-  data.tar.gz: 61ec5d5326491020e9408bc807b4054d547b41286657d1ae477938ffbcdd897d89d59f41ccf5e89325f9cb6114be2f6cd1cf6a504a32ba0bbdc96be9b30885f4
+  metadata.gz: 5cbf3ea181ff40f6974cb6f4b046e72dbd1adc689ea9ef318c40734d6ea1029d43918412ec6d2f483f346f90fa0c5d8cdc8a6aaf7a1a6831f877bdad6052914e
+  data.tar.gz: 5213d1478a2be1488d5027cb8fd3de6840a785b159be639fb80ba01feb341b76e5a17698fcd7823e9ca6183c955f8d1c65a41d66fac161bf14f365282f82c021

data/Readme.md

@@ -25,7 +25,7 @@ gabba.page_view(request, "Page Title")
 
 ```
 
-Or if you want to get really fancy you can update the parameters for the page view only..
+Or if you want to get really fancy you can update the parameters for this page view only...
 ```ruby
 gabba.page_view(request, "Page Title", document_path: "/manually/fiddled/url")
 
@@ -92,6 +92,61 @@ gabba.event("Videos", "Play", "ID", "123")
 
 ```
 
+### Parameters that may be set
+
+protocol_version:
+
+tracking_id:
+
+client_id:
+
+user_id:
+ 
+user_ip_address:
+ 
+user_agent:
+ 
+user_language: 
+
+hit_type: 
+
+document_title:
+
+document_path:
+
+document_referrer:
+
+document_host:
+
+event_category:
+
+event_action:
+
+event_label:
+
+event_value:
+
+campaign_name:
+
+campaign_source:
+
+campaign_medium:
+
+campaign_keyword:
+
+campaign_content: 
+
+dimension_[1-200]: 
+
+**Untested**
+
+user_screen_resolution:
+
+user_viewport_size:
+
+user_screen_colors: 
+
+
 ### License
 
 Gabba is released under the [MIT License](http://opensource.org/licenses/MIT).

data/lib/gabba-gmp/campaign.rb

@@ -4,7 +4,7 @@ module GabbaGMP
       attr_accessor :name, :source, :medium, :keyword, :content
       
       def present?
-        name.present? or source.present? or medium.present? or keyword.present? or content.present?
+        !name.to_s.empty? or !source.to_s.empty? or !medium.to_s.empty? or !keyword.to_s.empty? or !content.to_s.empty?
       end
     end
   end

data/lib/gabba-gmp/custom_vars.rb

@@ -14,7 +14,7 @@ module GabbaGMP
       #
       # Returns array with the custom variable data
       def set_custom_var(index, name, value)
-        raise "Index must be between 1 and #{GabbaGMP::DIMENSION_MAX}" unless (1..GabbaGMP::DIMENSION_MAX).include?(index)
+        raise GoogleAnalyticsInvalidParameterError, "Index must be between 1 and #{GabbaGMP::DIMENSION_MAX}" unless (1..GabbaGMP::DIMENSION_MAX).include?(index)
         
         @sessionopts["dimension_#{index}".to_sym] = value
       end

data/lib/gabba-gmp/event.rb

@@ -18,7 +18,8 @@ module GabbaGMP
         hey(event_params(category, action, label, value, options))
       end
 
-      # Public: Renders event params data in the format needed for GA
+      private
+      # Private: Renders event params data in the format needed for GA
       # Called before actually sending the data along to GA in GabbaGMP#event
       def event_params(category, action, label, value, event_options)
         options = {
@@ -26,8 +27,8 @@ module GabbaGMP
           event_category: category,
           event_action: action
         }
-        options[:event_label] = label if label.present?
-        options[:event_value] = value if value.present?
+        options[:event_label] = label if label
+        options[:event_value] = value if value
         @sessionopts.merge(options).merge!(event_options)
       end
     end

data/lib/gabba-gmp/gabba_gmp.rb

@@ -33,7 +33,7 @@ module GabbaGMP
 
     ESCAPES = %w{ ' ! * ) }
 
-    attr_accessor :debug
+    attr_accessor :logger
 
     # Public: Initialize Gabba Google Analytics Tracking Object.
     #
@@ -49,10 +49,10 @@ module GabbaGMP
     #
     def initialize(ga_tracking_id, request, cookies, options = {})
       client_id_cookie = options[:client_id_cookie_sym]
-      client_id_cookie = :utm_visitor_uuid if !client_id_cookie.present? or !client_id_cookie.kind_of? Symbol
+      client_id_cookie = :utm_visitor_uuid if client_id_cookie.nil? or !client_id_cookie.kind_of? Symbol
       
-      if !cookies[client_id_cookie].present?
-        cookie_expiry = options[:client_id_cookie_expiry] ? options[:client_id_cookie_expiry] : 1.year.from_now
+      if cookies[client_id_cookie].nil?
+        cookie_expiry = options[:client_id_cookie_expiry] ? options[:client_id_cookie_expiry] : Time.now + (60*60*24*365)
         cookies[client_id_cookie] = { value: "#{SecureRandom.uuid}", expires: cookie_expiry}
       end
       
@@ -64,16 +64,15 @@ module GabbaGMP
                       user_agent: request.user_agent,
                       user_language: preferred_language(request.accept_language)}
         
-      @sessionopts[:document_referrer] = request.referrer if request.referrer.present? and !request.referrer.starts_with?("#{request.protocol}#{request.host_with_port}")
+      @sessionopts[:document_referrer] = request.referrer if request.referrer and !request.referrer.start_with?("#{request.protocol}#{request.host_with_port}")
         
-      debug = false
     end
 
     def preferred_language(language)
-      return "" unless language.present?
+      return "" unless language
       
       language_arr = language.split(",").map {|lang_pref| lang_pref.split(";")}
-      language_arr[0][0].downcase #just get the first language. Will probably be correct.
+      language_arr[0][0].downcase.strip #just get the first language. Will probably be correct.
     end
 
     # Public: Set the session's parameters. This will be added to all actions that are sent to analytics.
@@ -81,7 +80,7 @@ module GabbaGMP
     #  See::  ParameterMap:GA_PARAMS
     def add_options(options)
       options.keys.each do |key| 
-        raise GoogleAnalyticsParameterNotFoundError, "Parameter '#{key}'" unless GA_PARAMS[key].present?
+        raise GoogleAnalyticsParameterNotFoundError, "Parameter '#{key}'" unless GA_PARAMS[key]
       end
       
       @sessionopts.merge!(options)
@@ -102,23 +101,27 @@ module GabbaGMP
             
           @sessionopts[:campaign_medium] = campaign.medium
           @sessionopts[:campaign_medium] ||= "(none)"
+          
+          @sessionopts.delete(:campaign_keyword)
+          @sessionopts[:campaign_keyword] = campaign.keyword if campaign.keyword
             
-          @sessionopts[:campaign_keyword] = campaign.keyword if campaign.keyword.present?
-            
-          @sessionopts[:campaign_content] = campaign.content if campaign.content.present?
+          @sessionopts.delete(:campaign_content)
+          @sessionopts[:campaign_content] = campaign.content if campaign.content
         end
       end
     end
     
+    
+    private
     # Sanity check that we have needed params to even call GA
     def validate_session_parameters(params)
-      raise GoogleAnalyticsRequiredParameterMissingError, "Protocol version is required" unless params[:protocol_version].present?
-      raise GoogleAnalyticsRequiredParameterMissingError, "Tracking id is required" unless params[:tracking_id].present?
-      raise GoogleAnalyticsRequiredParameterMissingError, "Client id is required" unless params[:client_id].present?
-      raise GoogleAnalyticsRequiredParameterMissingError, "Hit type is required" unless params[:hit_type].present?
+      raise GoogleAnalyticsRequiredParameterMissingError, "Protocol version is required" unless params[:protocol_version]
+      raise GoogleAnalyticsRequiredParameterMissingError, "Tracking id is required" unless params[:tracking_id]
+      raise GoogleAnalyticsRequiredParameterMissingError, "Client id is required" unless params[:client_id]
+      raise GoogleAnalyticsRequiredParameterMissingError, "Hit type is required" unless params[:hit_type]
       
       params.keys.each do |param|
-        raise GoogleAnalyticsInvalidParameterError, "The parameter '#{param}' is not currently recognised." unless GA_PARAMS[param].present?
+        raise GoogleAnalyticsInvalidParameterError, "The parameter '#{param}' is not currently recognised." unless GA_PARAMS[param]
       end
     end
 
@@ -129,10 +132,10 @@ module GabbaGMP
 
       @http ||= Net::HTTP::Persistent.new 'GabbaGMP'
 
-      Rails.logger.info "GABBA_GMP: request params: #{query}" if debug
+      @logger.info "GABBA_GMP: request params: #{query}" if @logger
       
       request = Net::HTTP::Get.new("#{BEACON_PATH}?#{query}")
-      request["User-Agent"] = URI.escape(params[:user_agent])
+      request["User-Agent"] = URI.escape(params[:user_agent]) if params[:user_agent] 
       request["Accept"] = "*/*"
       uri = URI "http://#{GOOGLE_HOST}/#{BEACON_PATH}"
       response = @http.request(uri, request)

data/lib/gabba-gmp/page_view.rb

@@ -16,7 +16,8 @@ module GabbaGMP
         hey(page_view_params(title, request.fullpath, options))
       end
 
-      # Public: Renders the page view params data in the format needed for GA
+      private
+      # Private: Renders the page view params data in the format needed for GA
       # Called before actually sending the data along to GA.
       def page_view_params(title, doc_path, options)
         @sessionopts.merge({

data/lib/gabba-gmp/version.rb

@@ -1,5 +1,5 @@
 module GabbaGMP
   unless const_defined?('VERSION')
-    VERSION = "0.0.6"
+    VERSION = "1.0.0"
   end
 end

data/spec/lib/campaign_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe GabbaGMP::GabbaGMP::Campaign do
+  describe "#present?" do
+    let(:campaign) { GabbaGMP::GabbaGMP::Campaign.new}
+    before do
+      campaign.name = "Campaign"
+      campaign.source = "Source"
+      campaign.medium = "Medium"
+      campaign.keyword = "Keyword"
+      campaign.content = "Content"
+    end
+    
+    it "has variables set" do
+      expect(campaign.name).to eq("Campaign")
+      expect(campaign.source).to eq("Source")
+      expect(campaign.medium).to eq("Medium")
+      expect(campaign.keyword).to eq("Keyword")
+      expect(campaign.content).to eq("Content")
+    end
+    
+    it "is present?" do
+      expect(campaign.present?).to be(true)
+    end
+    
+    it "is present? because of name" do
+      campaign = GabbaGMP::GabbaGMP::Campaign.new
+      campaign.name = 'X'
+      expect(campaign.present?).to be(true)
+    end
+    
+    it "is present? because of source" do
+      campaign = GabbaGMP::GabbaGMP::Campaign.new
+      campaign.source = 'X'
+      expect(campaign.present?).to be(true)
+    end
+    
+    it "is present? because of medium" do
+      campaign = GabbaGMP::GabbaGMP::Campaign.new
+      campaign.medium = 'X'
+      expect(campaign.present?).to be(true)
+    end
+    
+    it "is present? because of keyword" do
+      campaign = GabbaGMP::GabbaGMP::Campaign.new
+      campaign.keyword = 'X'
+      expect(campaign.present?).to be(true)
+    end
+    
+    it "is present? because of content" do
+      campaign = GabbaGMP::GabbaGMP::Campaign.new
+      campaign.content = 'X'
+      expect(campaign.present?).to be(true)
+    end
+
+    it "is not present?" do
+      campaign = GabbaGMP::GabbaGMP::Campaign.new
+      expect(campaign.present?).to be(false)
+    end
+  end
+end

data/spec/lib/custom_vars_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+require 'pry'
+
+describe GabbaGMP::GabbaGMP::CustomVars do
+  describe "#set_custom_var" do
+    let(:request) {MockRequest.new}
+    let(:cookies) {MockCookies.new(utm_visitor_uuid: 1234)}
+    let(:gabbaGmp) { GabbaGMP::GabbaGMP.new("tracker", request, cookies)}
+    before do
+      stub_analytics("")
+    end
+    
+    #index, name, value
+    
+    it "#set_custom_var(index, name, value) using pageview" do
+      gabbaGmp.set_custom_var(1, "Dogs", "Black")
+      gabbaGmp.page_view(request)
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", dt: "", tid: "tracker", cid: "1234", t: "pageview", dp: "", cd1: "Black"}))
+        
+      gabbaGmp.set_custom_var(1, "Dog", "Spotty")
+      gabbaGmp.set_custom_var(2, "Lemming", "Fall")
+      gabbaGmp.set_custom_var(3, "Kite", "Surf")
+      gabbaGmp.set_custom_var(200, "Cabbage", "Patch")
+      gabbaGmp.page_view(request)
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", dt: "", tid: "tracker", cid: "1234", t: "pageview", dp: "", 
+        cd1: "Spotty", cd2: "Fall", cd3: "Surf", cd200: "Patch"}))
+        
+      expect {gabbaGmp.set_custom_var(201, "Cabbage", "Patch")}.to raise_error(GabbaGMP::GoogleAnalyticsInvalidParameterError)
+      
+      gabbaGmp.page_view(request, nil, dimension_4: "Ni!!")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", dt: "", tid: "tracker", cid: "1234", t: "pageview", dp: "", 
+        cd1: "Spotty", cd2: "Fall", cd3: "Surf", cd200: "Patch", cd4: "Ni!!"}))
+    end
+
+    it "#set_custom_var(index, name, value) using event" do
+      gabbaGmp.set_custom_var(1, "Dogs", "Black")
+      gabbaGmp.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", cd1: "Black"}))
+        
+      gabbaGmp.set_custom_var(1, "Letting type", "Let's Go")
+      gabbaGmp.set_custom_var(2, "UFO", "Kite")
+      gabbaGmp.set_custom_var(200, "Kite", "Surf")
+      gabbaGmp.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", cd1: "Let's Go", cd2: "Kite", cd200: "Surf"}))
+
+      expect {gabbaGmp.set_custom_var(201, "Cabbage", "Patch")}.to raise_error(GabbaGMP::GoogleAnalyticsInvalidParameterError)
+
+      gabbaGmp.event("Cats", "Action", nil, nil, dimension_3: "NOW!")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", cd1: "Let's Go", cd2: "Kite", cd200: "Surf", cd3: "NOW!"}))
+      
+    end
+  end
+end

data/spec/lib/event_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+require 'pry'
+
+describe GabbaGMP::GabbaGMP::Event do
+  describe "#event" do
+    let(:request) {MockRequest.new}
+    let(:cookies) {MockCookies.new(utm_visitor_uuid: 1234)}
+    let(:gabbaGmp) { GabbaGMP::GabbaGMP.new("tracker", request, cookies)}
+    before do
+      stub_analytics("")
+    end
+    
+    #category, action, label = nil, value = nil, options = {}
+    
+    it "#event(category, action)" do
+      gabbaGmp.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action"}))
+    end
+    
+    it "#event(category, action, label)" do
+      gabbaGmp.event("Cats", "Action", "Label")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", el: "Label"}))
+    end
+
+    it "#event(category, action, label, value)" do
+      gabbaGmp.event("Cats", "Action", "Label", "Value")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", el: "Label", ev: "Value"}))
+    end
+
+    it "#event(category, action, label, value, options)" do
+      gabbaGmp.event("Cats", "Action", "Label", "Value", user_language: "en-au")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", el: "Label", ev: "Value", ul: "en-au"}))
+    end
+    
+    it "must not interfere with other calls if using options" do
+      gabbaGmp.event("Cats", "Action", "Label", "Value", user_language: "en-au")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", el: "Label", ev: "Value", ul: "en-au"}))
+      
+      gabbaGmp.event("Cats", "Action", "Label", "Value")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", el: "Label", ev: "Value"}))
+
+      gabbaGmp.event("Cats", "Action", "Label", "Value", document_path: "/path")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", el: "Label", ev: "Value", dp: "/path"}))
+
+    end
+  end
+end

data/spec/lib/gabba_gmp_spec.rb

@@ -0,0 +1,139 @@
+require 'spec_helper'
+require 'pry'
+
+describe GabbaGMP::GabbaGMP do
+  describe "#initialize" do
+    let(:request) {MockRequest.new}
+    let(:cookies) {MockCookies.new(utm_visitor_uuid: 1234, visitor_id: 567)}
+    before do
+      stub_analytics("")
+    end
+    
+    #index, name, value
+    it "#initialize(ga_tracking_id, request, cookies)" do
+      gabba = GabbaGMP::GabbaGMP.new("tracker123", request, cookies)
+      gabba.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker123", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action"}))
+      
+    end
+    
+    it "#initialize acceptLanguage" do
+      request.accept_language = "da , en-gb;q=0.8, en;q=0.7"
+      gabba = GabbaGMP::GabbaGMP.new("tracker123", request, cookies)
+      gabba.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker123", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", ul: "da"}))
+    end
+    
+    it "#initialize referrer" do
+      request.referrer = "http://www.example.com/my-pages"
+      gabba = GabbaGMP::GabbaGMP.new("tracker123", request, cookies)
+      gabba.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker123", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action"}))
+
+      request.referrer = "http://www.otherexample.com/my-pages"
+      gabba = GabbaGMP::GabbaGMP.new("tracker123", request, cookies)
+      gabba.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker123", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", dr: "http://www.otherexample.com/my-pages"}))
+    end
+    
+    it "#initialize(ga_tracking_id, request, cookies, options = {})" do
+      gabba = GabbaGMP::GabbaGMP.new("tracker123", request, cookies, client_id_cookie_sym: :visitor_id)
+      gabba.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker123", cid: "567", t: "event", 
+        ec: "Cats", ea: "Action"}))
+    end
+  end
+
+  describe "#add_options" do
+    let(:request) {MockRequest.new}
+    let(:cookies) {MockCookies.new(utm_visitor_uuid: 1234)}
+    let(:gabbaGmp) { GabbaGMP::GabbaGMP.new("tracker", request, cookies)}
+    before do
+      stub_analytics("")
+    end
+    it "#add_options(options)" do
+      gabbaGmp.add_options(user_language: "en-gb")
+      gabbaGmp.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", ul: "en-gb"}))
+        
+      gabbaGmp.add_options(dimension_1: "X", dimension_2: "Y", dimension_3: "Z")
+      gabbaGmp.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", ul: "en-gb", cd1: "X", cd2: "Y", cd3: "Z"}))
+
+      gabbaGmp.set_custom_var(3, "Other Dimensions", "Time")
+      gabbaGmp.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", ul: "en-gb", cd1: "X", cd2: "Y", cd3: "Time"}))
+    end
+  end
+  describe "#campaign=" do
+    let(:request) {MockRequest.new}
+    let(:cookies) {MockCookies.new(utm_visitor_uuid: 1234)}
+    let(:gabbaGmp) { GabbaGMP::GabbaGMP.new("tracker", request, cookies)}
+    before do
+      stub_analytics("")
+    end
+    it "#add_options(options)" do
+      campaign = GabbaGMP::GabbaGMP::Campaign.new()
+      campaign.name = "First Campaign"
+      campaign.source = "Bottle"
+      campaign.medium = "Spiritual"
+      campaign.keyword = "Ring"
+      campaign.content = "Campaigns"
+      
+      gabbaGmp.campaign = campaign
+      gabbaGmp.event("Cats1", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats1", ea: "Action", cn: "First Campaign", cs: "Bottle", cm: "Spiritual", ck: "Ring", cc: "Campaigns"}))
+
+      gabbaGmp.campaign = nil
+      gabbaGmp.event("Cats2", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats2", ea: "Action", cn: "First Campaign", cs: "Bottle", cm: "Spiritual", ck: "Ring", cc: "Campaigns"}))
+
+      campaign = GabbaGMP::GabbaGMP::Campaign.new()
+      campaign.keyword = "Rings"
+      
+      gabbaGmp.campaign = campaign
+      gabbaGmp.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", cn: "(direct)", cs: "(direct)", cm: "(none)", ck: "Rings"}))
+        
+      campaign = GabbaGMP::GabbaGMP::Campaign.new()
+      campaign.content = "Contents"
+      campaign.source = "Confidential"
+      
+      gabbaGmp.campaign = campaign
+      gabbaGmp.event("Cats", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats", ea: "Action", cn: "(direct)", cs: "Confidential", cm: "(none)", cc: "Contents"}))
+    end
+  end
+  describe "#campaign=" do
+    let(:request) {MockRequest.new}
+    let(:cookies) {MockCookies.new(utm_visitor_uuid: 1234)}
+    let(:gabbaGmp) { GabbaGMP::GabbaGMP.new("tracker", request, cookies)}
+    before do
+      stub_analytics("")
+    end
+    it "@logger" do
+      class LoggerClass
+        attr_accessor :info_message
+        def info(message)
+          @info_message = message
+        end
+      end
+      gabbaGmp.logger = LoggerClass.new
+      gabbaGmp.event("Cats1", "Action")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", tid: "tracker", cid: "1234", t: "event", 
+        ec: "Cats1", ea: "Action"}))
+      expect(gabbaGmp.logger.info_message).to eq("GABBA_GMP: request params: v=1&tid=tracker&dh=www.example.com&cid=1234&uip=1.2.3.4&ua=Chrome%2F1.0.0.0.0&ul=en-us&t=event&ec=Cats1&ea=Action")
+    end
+  end
+end

data/spec/lib/page_view_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+require 'pry'
+
+describe GabbaGMP::GabbaGMP::PageView do
+  describe "#page_view" do
+    let(:request) {MockRequest.new}
+    let(:cookies) {MockCookies.new(utm_visitor_uuid: 1234)}
+    let(:gabbaGmp) { GabbaGMP::GabbaGMP.new("tracker", request, cookies)}
+    before do
+      stub_analytics("")
+    end
+    
+    #request, title = nil, options = {}
+    
+    it "#page_view(request)" do
+      gabbaGmp.page_view(request)
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", dt: "", tid: "tracker", cid: "1234", t: "pageview", dp: ""}))
+
+      request.fullpath = "/amazing/things"
+      gabbaGmp.page_view(request)
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", dt: "", tid: "tracker", cid: "1234", t: "pageview", dp: "/amazing/things"}))
+    end
+    
+    it "#page_view(request, title)" do
+      gabbaGmp.page_view(request, "Title")
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", dt: "Title", tid: "tracker", cid: "1234", t: "pageview", dp: ""}))
+    end
+    
+    it "#page_view(request, title, options)" do
+      gabbaGmp.page_view(request, "Title", {document_path: "/Nowhere"})
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", dt: "Title", tid: "tracker", cid: "1234", t: "pageview", dp: "/Nowhere"}))
+    end
+    
+    it "must not interfere with other calls if using options" do
+      gabbaGmp.page_view(request, "Title", {document_path: "/Nowhere"})
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", dt: "Title", tid: "tracker", cid: "1234", t: "pageview", dp: "/Nowhere"}))
+
+      gabbaGmp.page_view(request)
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", dt: "", tid: "tracker", cid: "1234", t: "pageview", dp: ""}))
+
+      gabbaGmp.page_view(request, "Title", {user_language: "en-au"})
+      expect_query(MockRequest::DEFAULT_PARAMS.merge({v: "1", dt: "Title", tid: "tracker", cid: "1234", t: "pageview", ul: "en-au", dp: ""}))
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,48 @@
+require 'gabba-gmp'
+require 'rspec'
+
+require 'webmock/rspec'
+WebMock.disable_net_connect!
+
+def stub_analytics(expected_params)
+  stub_request(
+    :get,
+    /www.google-analytics.com\/collect?#{expected_params}/
+  ).to_return(:status => 200, :body => '', :headers => {})
+end
+
+def expect_query(query_params)
+  expect(WebMock).to have_requested(:get, "www.google-analytics.com\/collect").with(:query => query_params)
+end
+
+class MockCookies
+  def initialize(cookieSet = {})
+    @cookieList = cookieSet
+  end
+  
+  def [](key)
+    @cookieList[key]
+  end
+  def []=(key, value)
+    @cookieList[key] = value[:value]
+  end
+end
+class MockRequest
+  DEFAULT_PARAMS = {dh: "www.example.com", 
+                    uip: "1.2.3.4",
+                    ua: "Chrome/1.0.0.0.0",
+                    ul: "en-us",
+                    }
+  attr_accessor :host, :remote_ip, :user_agent, :accept_language, :referrer, :fullpath, :protocol, :host_with_port
+  
+  def initialize()
+    @host = DEFAULT_PARAMS[:dh]
+    @remote_ip = DEFAULT_PARAMS[:uip]
+    @user_agent = DEFAULT_PARAMS[:ua]
+    @accept_language = DEFAULT_PARAMS[:ul]
+    @referrer = DEFAULT_PARAMS[:dr]
+    @fullpath = DEFAULT_PARAMS[:dp]
+    @protocol = "http://"
+    @host_with_port = "www.example.com"
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gabba-gmp
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 1.0.0
 platform: ruby
 authors:
 - Julian West
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-01 00:00:00.000000000 Z
+date: 2014-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-http-persistent
@@ -88,6 +88,12 @@ files:
 - lib/gabba-gmp/page_view.rb
 - lib/gabba-gmp/parameter_map.rb
 - lib/gabba-gmp/version.rb
+- spec/lib/campaign_spec.rb
+- spec/lib/custom_vars_spec.rb
+- spec/lib/event_spec.rb
+- spec/lib/gabba_gmp_spec.rb
+- spec/lib/page_view_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/fuzzyjulz/gabba-gmp
 licenses:
 - MIT