funky 0.2.22 → 0.2.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1e12d14881465b91bcee78d6c9797bc8a12bc69a
-  data.tar.gz: 25170d89ef0c5554c562201ad37dc39141715f23
+  metadata.gz: 9ffc5fe5b87b5624e032a5771737aadcffaf905e
+  data.tar.gz: 4f5681d153e82541cb7b766cbffc727d0f3f90c4
 SHA512:
-  metadata.gz: 154c3a34ba50d72d6959a09153835ef52f5f5ccc22f3a07857709c8cc1e951f0a1b9c73cc63a1e0f929eb1bfce3681c84ddb1b6cdf7ad06ca24b2ee0ff468f90
-  data.tar.gz: 9c1cdc566145ad1f43824384babf3337bab3a7959e993ad77ed912511bbacf04469fae6f390797cce754cf5e1dee5f20b36a19379d740a09108029331be76dd6
+  metadata.gz: 76bbdb60f31e3c8f2d69b8eca1f086867918c56cc3735fa7dcc980177c3aa12d74110f19547adb215a435f4e99075192879a9fd83c7774e83eddac7cd95f0c99
+  data.tar.gz: ce1b4bcbab475fc6364bfd6d9bb3998ccf3e36653f1faacf41c2bd9b930ef94c546db3cf0d9b2e6d56499cd23f74218558e3254f95648accbd4b436982e8d417

data/CHANGELOG.md

@@ -6,6 +6,12 @@ For more information about changelogs, check
 [Keep a Changelog](http://keepachangelog.com) and
 [Vandamme](http://tech-angels.github.io/vandamme).
 
+## 0.2.23 - 2017/05/09
+
+* [FEATURE] Print out logs for each pagination
+* [BUGFIX] Use cursor-based pagination for `Funky::Page#posts` to resolve
+infinite loop issue when the page has life events with old backdated time.
+
 ## 0.2.22 - 2017/05/05
 
 * [FEATURE] Add `Funky::Page#posts`.

data/lib/funky/connections/api.rb

@@ -7,6 +7,22 @@ module Funky
   # @api private
   module Connection
     class API < Base
+      def self.fetch_all(path_query)
+        uri = URI "https://#{host}/v2.9/#{path_query}&limit=100&access_token=#{app_id}%7C#{app_secret}"
+        fetch_data_with_paging_token(uri)
+      end
+
+      def self.fetch_data_with_paging_token(uri)
+        json = json_for(uri)
+        if !json[:data].empty? && json[:paging][:next]
+          next_paging_uri = URI json[:paging][:next]
+          puts "Fetching '#{uri.path}' with #{ URI.decode_www_form(next_paging_uri.query).to_h['after'] }"
+          json[:data] + fetch_data_with_paging_token(next_paging_uri)
+        else
+          json[:data]
+        end
+      end
+
       def self.fetch(path_query, is_array: false)
         uri = URI "https://#{host}/v2.8/#{path_query}&limit=100&access_token=#{app_id}%7C#{app_secret}"
         is_array ? fetch_multiple_pages(uri).uniq : json_for(uri)
@@ -14,6 +30,7 @@ module Funky
 
       def self.fetch_multiple_pages(uri)
         json = json_for(uri)
+        puts "Fetching '#{uri.path}' until #{ URI.decode_www_form(uri.query).to_h['until'] || 'now'}"
         if json[:data].empty?
           @try_count ||= 0
           if @previous_timestamp && @try_count < 1 && (Date.parse @previous_timestamp rescue nil)

data/lib/funky/page.rb

@@ -43,7 +43,7 @@ module Funky
     # @return [Array<Funky::Post>] multiple Funky::Post objects containing data
     #   fetched by Facebook Graph API.
     def posts
-      posts = Funky::Connection::API.fetch("#{id}/posts?fields=type,created_time", is_array: true)
+      posts = Funky::Connection::API.fetch_all("#{id}/posts?fields=type,created_time")
       posts.map {|post| Post.new(post)}
     end
 

data/lib/funky/version.rb

@@ -1,3 +1,3 @@
 module Funky
-  VERSION = "0.2.22"
+  VERSION = "0.2.23"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: funky
 version: !ruby/object:Gem::Version
-  version: 0.2.22
+  version: 0.2.23
 platform: ruby
 authors:
 - Philip Nguyen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-05-06 00:00:00.000000000 Z
+date: 2017-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler