functional-light-service 0.2.5 → 0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c9ee1f86ecf3fed5b5f960947640127effa2379156378d7a3bd7efac0a0eaae
-  data.tar.gz: 948a8c0e600137d6f4c4e5b686ddae5040ef3fbb39ef8ca77f3b6d30e57ea74a
+  metadata.gz: c2e4181b50ddcb052f267df328408dd0f617132d5f856a61d100f5eaee6a7df2
+  data.tar.gz: c372e9e09e36677b7209797efd24cb14446dc52810b7e6071e4f3044814b309e
 SHA512:
-  metadata.gz: db7ae9750f2e72fc1e7e373d9b06f31cfab0d08142c7154a12c9b81e58828153eb72b48cff0c572c66a1799c82bae2c2364f8d1a3d8df04473095da99bedaf17
-  data.tar.gz: 8825e95f8b9d6c363c561345716cab58f7e47200b806114021b82ae0005e094a5c03ad4d438708efa13ea209868c0b709071a5deeff6e472a192252035cf7931
+  metadata.gz: 956079386a37611a39f581754ae6dec46ea660c939340a19773c05ee46b83368ca7ddf44534dff1c78a28d0a9aacc524f3253ebb99b41125ce3c9cffe5ceaeb8
+  data.tar.gz: ff0c84baac2722ccd747b8cd378412448021b3c56920beb316034b3a8eab15298e105dd8811b16e75e175b0145c5b3d6b186d63621cf7f60a6fe959f004c45e9

data/.travis.yml

@@ -4,14 +4,15 @@ env:
   - RUN_COVERAGE_REPORT=true
 
 rvm:
-  - 2.5.0
+  - 2.5.3
   - 2.6.0
+  - 2.7.0
 
 before_install:
   - 'echo ''gem: --no-ri --no-rdoc'' > ~/.gemrc'
+  - yes | gem update --system --force
   - gem install bundler
-  - bundle update simplecov
-  - bundle install --path vendor/bundle
+  - bundle install --gemfile=Gemfile --clean --path vendor/bundle
 
 # uncomment this line if your project needs to run something other than `rake`:
 script:
@@ -19,4 +20,5 @@ script:
   - bundle exec rubocop
 
 gemfile:
-  - gemfiles/activesupport_5.gemfile
+  - gemfiles/dry_inflector_0_2.gemfile
+  - gemfiles/i18n_1_8.gemfile

data/Appraisals

@@ -1,3 +1,3 @@
-appraise "activesupport-5" do
-  gem "activesupport", "~> 5.2.0"
+appraise "dry-inflector-0.2.0" do
+  gem "dry-inflector", "~> 0.2.0"
 end

data/CHANGELOG.md

@@ -1,3 +1,48 @@
+## 0.3.1 (2020-02-16)
+
+
+## 0.3.0 (2020-02-16)
+### Removed
+-  Rimosso completamente activesupport  ( 2020-02-16 ) [ sphynx79]
+
+
+
+## 0.2.9.2 (2020-02-16)
+### Removed
+-  Rimosso ActiveSupport::Deprecation per i warning di deprecation  ( 2020-02-16 ) [ sphynx79]
+
+
+
+## 0.2.9.1 (2020-02-16)
+### Fixed
+-  Sto cercando di sistemate il problema di travis che da errore per activesupport  ( 2020-02-16 ) [ sphynx79]
+
+
+
+## 0.2.9 (2020-02-16)
+### Fixed
+-  Travis va in errore aggiunt activesupport al mio gemfile  ( 2020-02-16 ) [ sphynx79]
+
+
+
+## 0.2.8 (2020-02-16)
+### Removed
+-  rimosso supporto a activesupport 5  ( 2020-02-16 ) [ sphynx79]
+
+
+
+## 0.2.7 (2020-02-16)
+### Fix
+-  Risolto problema travis bundle update  ( 2020-02-16 ) [ sphynx79]
+
+
+
+## 0.2.6 (2020-02-16)
+### Fixed
+-  FiFix problem /dev/null windows, e corretto il bug sul metodo failure?  ( 2020-02-16 ) [ sphynx79]
+
+
+
 ## 0.2.5 (2019-02-24)
 
 

data/VERSION

@@ -1 +1 @@
-0.2.5
+0.3.1

data/functional-light-service.gemspec

@@ -16,9 +16,11 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = FunctionalLightService::VERSION
 
-  # gem.add_dependency("activesupport", ">= 5.2.2")
+  gem.add_dependency("dry-inflector", ">= 0.2.0")
+  gem.add_dependency("i18n", ">= 1.8.2")
   
-  gem.add_development_dependency("activesupport", "~> 5.2.0")
+  gem.add_development_dependency("i18n", ">= 1.8.2")
+  gem.add_development_dependency("dry-inflector", ">= 0.2.0")
   gem.add_development_dependency("rspec", "~> 3.0")
   gem.add_development_dependency("simplecov", "~> 0.16.1")
   gem.add_development_dependency("rubocop", "~> 0.63.1")

data/gemfiles/dry_inflector_0_2.gemfile

@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "appraisal", "~> 2.0"
+gem "dry-inflector", "~> 0.2.0"
+
+gemspec :path => "../"

data/gemfiles/{activesupport_5.gemfile → i18n_1_8.gemfile}

@@ -2,7 +2,7 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "~> 5.0"
 gem "appraisal", "~> 2.0"
+gem "i18n", "~> 1.8.2"
 
 gemspec :path => "../"

data/lib/functional-light-service/action.rb

@@ -1,5 +1,3 @@
-require 'active_support/deprecation'
-
 module FunctionalLightService
   module Action
     def self.extended(base_class)
@@ -8,9 +6,10 @@ module FunctionalLightService
     end
 
     def self.included(base_class)
-      msg = "including FunctionalLightService::Action is deprecated. " \
+      msg = "DEPRECATION WARNING:\n" \
+            "Including FunctionalLightService::Action is deprecated\n" \
             "Please use `extend FunctionalLightService::Action` instead"
-      ActiveSupport::Deprecation.warn(msg)
+      print msg
       base_class.extend Macros
     end
 

data/lib/functional-light-service/configuration.rb

@@ -15,7 +15,7 @@ module FunctionalLightService
       private
 
       def _default_logger
-        logger = Logger.new("/dev/null")
+        logger = Logger.new(nil)
         logger.level = Logger::WARN
         logger
       end

data/lib/functional-light-service/context.rb

@@ -1,5 +1,3 @@
-require 'active_support/deprecation'
-
 module FunctionalLightService
   # rubocop:disable ClassLength
   class Context < Hash
@@ -35,7 +33,7 @@ module FunctionalLightService
     end
 
     def failure?
-      success? == false
+      @outcome.failure?
     end
 
     def skip_remaining?
@@ -43,7 +41,7 @@ module FunctionalLightService
     end
 
     def reset_skip_remaining!
-      @outcome = Success(nil)
+      @outcome = Success(:message => '', :error => nil)
       @skip_remaining = false
     end
 
@@ -90,14 +88,6 @@ module FunctionalLightService
       raise FailWithRollbackError
     end
 
-    def skip_all!(message = nil)
-      warning_msg = "Using skip_all! has been deprecated, " \
-                    "please use `skip_remaining!` instead."
-      ActiveSupport::Deprecation.warn(warning_msg)
-
-      skip_remaining!(message)
-    end
-
     def skip_remaining!(message = nil)
       @outcome = Success(:message => message)
       @skip_remaining = true

data/lib/functional-light-service/localization_adapter.rb

@@ -1,3 +1,5 @@
+require 'i18n'
+
 module FunctionalLightService
   class LocalizationAdapter
     def failure(message_or_key, action_class, i18n_options = {})
@@ -34,11 +36,12 @@ module FunctionalLightService
       scope = i18n_scope_from_class(action_class, type)
       options[:scope] = scope
 
-      I18n.t(key, options)
+      I18n.t(key, **options)
     end
 
     def i18n_scope_from_class(action_class, type)
-      "#{action_class.name.underscore}.light_service.#{type.to_s.pluralize}"
+      inflector = Dry::Inflector.new
+      "#{inflector.underscore(action_class.name)}.light_service.#{inflector.pluralize(type)}"
     end
   end
 end

data/lib/functional-light-service/organizer/iterate.rb

@@ -1,3 +1,5 @@
+require "dry/inflector"
+
 module FunctionalLightService
   module Organizer
     class Iterate
@@ -8,7 +10,8 @@ module FunctionalLightService
           return ctx if ctx.stop_processing?
 
           collection = ctx[collection_key]
-          item_key = collection_key.to_s.singularize.to_sym
+          inflector = Dry::Inflector.new
+          item_key = inflector.singularize(collection_key).to_sym
           collection.each do |item|
             ctx[item_key] = item
             ctx = scoped_reduce(organizer, ctx, steps)

data/lib/functional-light-service/organizer/verify_call_method_exists.rb

@@ -11,11 +11,12 @@ module FunctionalLightService
         call_method_exists = klass.methods.include?(:call)
         return if call_method_exists
 
-        warning_msg = "The <#{klass.name}> class is an organizer, " \
+        warning_msg = "DEPRECATION WARNING:" \
+                      "The <#{klass.name}> class is an organizer, " \
                       "its entry method (the one that calls with & reduce) " \
                       "should be named `call`. " \
                       "Please use #{klass}.call going forward."
-        ActiveSupport::Deprecation.warn(warning_msg)
+        print warning_msg
       end
 
       def self.caller_method(first_caller)

data/lib/functional-light-service/organizer.rb

@@ -1,5 +1,3 @@
-require 'active_support/deprecation'
-
 module FunctionalLightService
   module Organizer
     def self.extended(base_class)
@@ -8,9 +6,10 @@ module FunctionalLightService
     end
 
     def self.included(base_class)
-      warning_msg = "including FunctionalLightService::Organizer is deprecated. " \
-                    "Please use `extend FunctionalLightService::Organizer` instead"
-      ActiveSupport::Deprecation.warn(warning_msg)
+      msg = "DEPRECATION WARNING:\n" \
+            "Including FunctionalLightService::Organizer is deprecated\n" \
+            "Please use `extend FunctionalLightService::Organizer` instead"
+      print msg
       extended(base_class)
     end
 

data/lib/functional-light-service/version.rb

@@ -1,3 +1,3 @@
 module FunctionalLightService
-  VERSION = "0.2.5".freeze
+  VERSION = "0.3".freeze
 end

data/lib/functional-light-service.rb

@@ -1,5 +1,4 @@
 require 'logger'
-require 'active_support/core_ext/string'
 
 require 'functional-light-service/version'
 

data/spec/acceptance/include_warning_spec.rb

@@ -3,27 +3,27 @@ require 'spec_helper'
 describe "Including is discouraged" do
   context "when including FunctionalLightService::Organizer" do
     it "gives warning" do
-      expected_msg = "including FunctionalLightService::Organizer is deprecated. " \
+      expected_msg = "DEPRECATION WARNING:\n" \
+                     "Including FunctionalLightService::Organizer is deprecated\n" \
                      "Please use `extend FunctionalLightService::Organizer` instead"
-      expect(ActiveSupport::Deprecation).to receive(:warn)
-        .with(expected_msg)
-
-      class OrganizerIncludingLS
-        include FunctionalLightService::Organizer
-      end
+      expect do
+        class OrganizerIncludingLS
+          include FunctionalLightService::Organizer
+        end
+      end.to output(expected_msg).to_stdout
     end
   end
 
   context "when including FunctionalLightService::Action" do
     it "gives warning" do
-      expected_msg = "including FunctionalLightService::Action is deprecated. " \
+      expected_msg = "DEPRECATION WARNING:\n" \
+                     "Including FunctionalLightService::Action is deprecated\n" \
                      "Please use `extend FunctionalLightService::Action` instead"
-      expect(ActiveSupport::Deprecation).to receive(:warn)
-        .with(expected_msg)
-
-      class ActionIncludingLS
-        include FunctionalLightService::Action
-      end
+      expect do
+        class ActionIncludingLS
+          include FunctionalLightService::Action
+        end
+      end.to output(expected_msg).to_stdout
     end
   end
 end

data/spec/acceptance/not_having_call_method_warning_spec.rb

@@ -4,10 +4,6 @@ require 'test_doubles'
 describe "Organizer should invoke with/reduce from a call method" do
   context "when the organizer does not have a `call` method" do
     it "gives warning" do
-      expect(ActiveSupport::Deprecation)
-        .to receive(:warn)
-        .with(/^The <OrganizerWithoutCallMethod> class is an organizer/)
-
       class OrganizerWithoutCallMethod
         extend FunctionalLightService::Organizer
 
@@ -15,16 +11,14 @@ describe "Organizer should invoke with/reduce from a call method" do
           reduce([])
         end
       end
-
-      OrganizerWithoutCallMethod.do_something
+      expect do
+        OrganizerWithoutCallMethod.do_something
+      end.to output(/The <OrganizerWithoutCallMethod> class is an organizer/).to_stdout
     end
   end
 
   context "when the organizer has the `call` method" do
     it "does not issue a warning" do
-      expect(ActiveSupport::Deprecation)
-        .not_to receive(:warn)
-
       class OrganizerWithCallMethod
         extend FunctionalLightService::Organizer
 
@@ -32,8 +26,7 @@ describe "Organizer should invoke with/reduce from a call method" do
           reduce([])
         end
       end
-
-      OrganizerWithCallMethod.call
+      expect(OrganizerWithCallMethod.call).to be_a_kind_of(FunctionalLightService::Context)
     end
   end
 end

data/spec/spec_helper.rb

@@ -15,10 +15,6 @@ end
 require 'functional-light-service'
 require 'functional-light-service/testing'
 require "functional-light-service/functional/null"
-require 'ostruct'
-require 'pry'
 require 'support'
 require 'test_doubles'
 require 'stringio'
-
-I18n.enforce_available_locales = true

metadata

@@ -1,29 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: functional-light-service
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: '0.3'
 platform: ruby
 authors:
 - Boscolo Michele
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-24 00:00:00.000000000 Z
+date: 2020-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: dry-inflector
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+- !ruby/object:Gem::Dependency
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.0
+        version: 1.8.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.2
+- !ruby/object:Gem::Dependency
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.2
+- !ruby/object:Gem::Dependency
+  name: dry-inflector
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.0
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -101,8 +143,8 @@ files:
 - Rakefile
 - VERSION
 - functional-light-service.gemspec
-- gemfiles/activesupport_5.gemfile
-- gemfiles/activesupport_5.gemfile.lock
+- gemfiles/dry_inflector_0_2.gemfile
+- gemfiles/i18n_1_8.gemfile
 - lib/functional-light-service.rb
 - lib/functional-light-service/action.rb
 - lib/functional-light-service/configuration.rb
@@ -152,7 +194,6 @@ files:
 - spec/acceptance/organizer/reduce_until_spec.rb
 - spec/acceptance/organizer/with_callback_spec.rb
 - spec/acceptance/rollback_spec.rb
-- spec/acceptance/skip_all_warning_spec.rb
 - spec/acceptance/testing/context_factory_spec.rb
 - spec/action_expected_keys_spec.rb
 - spec/action_expects_and_promises_spec.rb
@@ -215,7 +256,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A service skeleton with an emphasis on simplicity with a pinch a functional
@@ -239,7 +280,6 @@ test_files:
 - spec/acceptance/organizer/reduce_until_spec.rb
 - spec/acceptance/organizer/with_callback_spec.rb
 - spec/acceptance/rollback_spec.rb
-- spec/acceptance/skip_all_warning_spec.rb
 - spec/acceptance/testing/context_factory_spec.rb
 - spec/action_expected_keys_spec.rb
 - spec/action_expects_and_promises_spec.rb

data/gemfiles/activesupport_5.gemfile.lock

@@ -1,82 +0,0 @@
-PATH
-  remote: ../
-  specs:
-    light-service (0.6.1)
-      activesupport (>= 3.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activesupport (5.0.0.1)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    appraisal (2.1.0)
-      bundler
-      rake
-      thor (>= 0.14.0)
-    ast (2.3.0)
-    coderay (1.1.1)
-    concurrent-ruby (1.0.2)
-    diff-lcs (1.2.5)
-    docile (1.1.5)
-    i18n (0.7.0)
-    json (2.0.2)
-    method_source (0.8.2)
-    minitest (5.9.0)
-    parser (2.3.1.2)
-      ast (~> 2.2)
-    powerpack (0.1.1)
-    pry (0.10.4)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    rainbow (2.1.0)
-    rake (11.2.2)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.2)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    rubocop (0.42.0)
-      parser (>= 2.3.1.1, < 3.0)
-      powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.8.1)
-    simplecov (0.12.0)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
-    slop (3.6.0)
-    thor (0.19.1)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.1.1)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activesupport (~> 5.0)
-  appraisal (~> 2.0)
-  light-service!
-  pry (~> 0.10)
-  rspec (~> 3.0)
-  rubocop (~> 0.36)
-  simplecov (~> 0.11)
-
-BUNDLED WITH
-   1.12.5

data/spec/acceptance/skip_all_warning_spec.rb

@@ -1,20 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe "skip_all! has been deprecated" do
-  it "is now skip_remaining!" do
-    class SkipAllDeprecatedAction
-      extend FunctionalLightService::Action
-
-      executed do |ctx|
-        ctx.skip_all!("No need to execute other actions.")
-      end
-    end
-
-    expected_msg = "Using skip_all! has been deprecated, " \
-                   "please use `skip_remaining!` instead."
-    expect(ActiveSupport::Deprecation).to receive(:warn)
-      .with(expected_msg)
-
-    SkipAllDeprecatedAction.execute
-  end
-end