full_search 0.4.8 → 0.4.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f50c2f24f4b4929d3da0744d93e33a0b6c5a6ba3743c4542612c6e1007687691
-  data.tar.gz: d497857811078992322ad4cd081e41aa476878c0950b71a2ec5bcd7a76ff8db2
+  metadata.gz: 834fb641e471174fd832f6c0e825d2486dbb94985e35f5ab95f5fc068c08ece1
+  data.tar.gz: c5d19d2c11fdf7eaa95c2af1fdc2a39d2db9d170e248591e29bba107249f691e
 SHA512:
-  metadata.gz: bf77188446fed43a0e9f69826f85ced628f5960d493cbd96d721730e9fd9d8c92ffe5c58412aee47e81feb01adca00e2e7b7641f85ea01fe2c98fcaaca05b5f1
-  data.tar.gz: 89e0b8dc7ee2b44391deb5c339e2b048c836431a5997ab19c281285b1fef79fcfe5ad4fea02793a672643899e08e5276a12dbadacf51cb3411853d389c6fbbf7
+  metadata.gz: 7bd69680899b8b405d3de387d1c3eafbb3e98ce0b08f937f7a9cac5282e5cb32cd24b96e7c20019b470937c817f419d2094ca48e9e9dd2a1fc49b9a0502295d7
+  data.tar.gz: 50f29a99547ce19b2a3c5098a992476dbd5b0423e6d251768a4ec355db482f81bd94b0e23e13e0008c671c8d35911e0394cd716cf278f1808de52f94f5daaa71

data/README.md

@@ -150,7 +150,9 @@ FTS indexes are SQLite virtual tables (`customers_fts`, `vehicles_fts`, etc.) th
 These two operations are often confused:
 
 - **Rebuild** (`full_search:rebuild` / `Customer.rebuild!`) — drops and recreates the FTS virtual table. Needed when the DSL changes (fields added/removed, tokenizer changed, etc.). The table is re-created from scratch, backfilled, triggers re-installed, and the index is optimized.
-- **Reindex** (`Customer.reindex!` / `FullSearch::Index.reindex_source_fields!`) — updates existing FTS rows with fresh values from computed `source:` fields only. The table structure is untouched. Database triggers cover regular column changes automatically; only Ruby-evaluated `source:` blocks need an explicit reindex.
+- **Reindex** (`Customer.reindex!` / `Customer.reindex_ids([ids])` / `FullSearch::Index.reindex_source_fields!`) — updates existing FTS rows with fresh values from computed `source:` fields only. The table structure is untouched. Database triggers cover regular column changes automatically, and since v0.4.9 they **preserve** existing `source:` field values rather than wiping them to `''` on UPDATE. Only Ruby-evaluated `source:` blocks need an explicit reindex.
+
+  **Important:** raw SQL operations that bypass Rails callbacks (`update_all`, `update_column`, `insert_all`, `upsert_all`, `counter_cache`, `touch`) will not run the `after_save_commit` reindex hook. Use `Model.reindex_ids(ids)` after a callback-free `update_all` that changes data backing a `source:` field, or `Model.reindex!` after a bulk insert, to keep the FTS source fields in sync.
 
 ### Setup lifecycle
 

data/lib/full_search/index.rb

@@ -452,24 +452,27 @@ module FullSearch
 
         when_clause = SoftDelete.active_update_clause(model)
 
+        update_assignments = update_assignments_sql(cols)
+
         if dsl.conditional_index?
           select_parts = cols.map { |c| column_ref(c, prefix: "new") }.join(", ")
           <<~SQL
             CREATE TRIGGER #{qt(trigger_names(model)[2])} AFTER UPDATE ON #{qt(model.table_name)} #{when_clause}
             BEGIN
-              DELETE FROM #{fts_table} WHERE rowid = old.id;
+              DELETE FROM #{fts_table} WHERE rowid = old.id
+                AND NOT EXISTS (SELECT 1 FROM #{tbl} WHERE #{tbl}.id = old.id AND (#{dsl.index_if_sql}));
+              UPDATE #{fts_table} SET #{update_assignments} WHERE rowid = new.id
+                AND EXISTS (SELECT 1 FROM #{tbl} WHERE #{tbl}.id = new.id AND (#{dsl.index_if_sql}));
               INSERT INTO #{fts_table}(rowid, #{cols_str})
-              SELECT new.id, #{select_parts} FROM #{tbl} WHERE #{tbl}.id = new.id AND (#{dsl.index_if_sql});
+                SELECT new.id, #{select_parts} FROM #{tbl} WHERE #{tbl}.id = new.id AND (#{dsl.index_if_sql})
+                  AND NOT EXISTS (SELECT 1 FROM #{fts_table} WHERE #{fts_table}.rowid = new.id);
             END;
           SQL
         else
-          values = cols.map { |c| column_ref(c, prefix: "new") }.join(", ")
           <<~SQL
             CREATE TRIGGER #{qt(trigger_names(model)[2])} AFTER UPDATE ON #{qt(model.table_name)} #{when_clause}
             BEGIN
-              DELETE FROM #{fts_table} WHERE rowid = old.id;
-              INSERT INTO #{fts_table}(rowid, #{cols_str})
-              VALUES (new.id, #{values});
+              UPDATE #{fts_table} SET #{update_assignments} WHERE rowid = new.id;
             END;
           SQL
         end
@@ -562,24 +565,27 @@ module FullSearch
 
         when_clause = SoftDelete.active_update_clause(model)
 
+        update_assignments = update_assignments_sql(cols)
+
         if dsl.conditional_index?
           select_parts = cols.map { |c| column_ref(c, prefix: "new") }.join(", ")
           <<~SQL
             CREATE TRIGGER #{qt(trigram_trigger_names(model)[2])} AFTER UPDATE ON #{qt(model.table_name)} #{when_clause}
             BEGIN
-              DELETE FROM #{trigram_table} WHERE rowid = old.id;
+              DELETE FROM #{trigram_table} WHERE rowid = old.id
+                AND NOT EXISTS (SELECT 1 FROM #{tbl} WHERE #{tbl}.id = old.id AND (#{dsl.index_if_sql}));
+              UPDATE #{trigram_table} SET #{update_assignments} WHERE rowid = new.id
+                AND EXISTS (SELECT 1 FROM #{tbl} WHERE #{tbl}.id = new.id AND (#{dsl.index_if_sql}));
               INSERT INTO #{trigram_table}(rowid, #{cols_str})
-              SELECT new.id, #{select_parts} FROM #{tbl} WHERE #{tbl}.id = new.id AND (#{dsl.index_if_sql});
+                SELECT new.id, #{select_parts} FROM #{tbl} WHERE #{tbl}.id = new.id AND (#{dsl.index_if_sql})
+                  AND NOT EXISTS (SELECT 1 FROM #{trigram_table} WHERE #{trigram_table}.rowid = new.id);
             END;
           SQL
         else
-          values = cols.map { |c| column_ref(c, prefix: "new") }.join(", ")
           <<~SQL
             CREATE TRIGGER #{qt(trigram_trigger_names(model)[2])} AFTER UPDATE ON #{qt(model.table_name)} #{when_clause}
             BEGIN
-              DELETE FROM #{trigram_table} WHERE rowid = old.id;
-              INSERT INTO #{trigram_table}(rowid, #{cols_str})
-              VALUES (new.id, #{values});
+              UPDATE #{trigram_table} SET #{update_assignments} WHERE rowid = new.id;
             END;
           SQL
         end
@@ -604,6 +610,28 @@ module FullSearch
         end
       end
 
+      # Builds `col = value` assignments for the AFTER UPDATE trigger. Source
+      # fields are deliberately excluded so a raw SQL UPDATE (e.g. a
+      # counter_cache or touch) does not wipe the previously computed source
+      # value back to an empty string. Source fields are refreshed later by the
+      # after_save_commit reindex callback on normal Rails saves.
+      #
+      # When every column is a source field (nothing to update), emit a valid
+      # no-op assignment so the generated trigger SQL stays syntactically valid.
+      def update_assignments_sql(cols)
+        assignments = cols.filter_map do |col|
+          if col.respond_to?(:unindexed?) && col.name == "indexed"
+            "#{qc(col.name)} = '1'"
+          elsif col.respond_to?(:source) && col.source
+            nil
+          else
+            "#{qc(column_name(col))} = new.#{qc(column_name(col))}"
+          end
+        end
+        assignments << "#{qc(column_name(cols.first))} = #{qc(column_name(cols.first))}" if assignments.empty?
+        assignments.join(", ")
+      end
+
       # NOTE: This lock prevents concurrent rebuilds within the same process/connection only.
       # For multi-process or multi-host deployments, run full_search:rebuild from a single
       # deployment step. See README.

data/lib/full_search/model.rb

@@ -40,6 +40,19 @@ module FullSearch
         FullSearch::Index.reindex_source_fields!(self)
       end
 
+      # Re-evaluates source: fields for a specific set of records and updates
+      # the FTS table in place. Use after bulk operations that bypass model
+      # callbacks (e.g. `update_all`, `insert_all`, `upsert_all`, `update_column`)
+      # so the source fields don't drift out of sync with the underlying rows.
+      def reindex_ids(ids)
+        source_ids = ids.to_a.map(&:to_i).reject(&:zero?)
+        return if source_ids.empty?
+
+        where(id: source_ids).find_each(batch_size: 500) do |record|
+          FullSearch::Callbacks.reindex_record!(record)
+        end
+      end
+
       def bulk_import(&block)
         FullSearch.bulk_import(self, &block)
       end
@@ -75,6 +88,13 @@ module FullSearch
 
         FullSearch::Model.evaluate_source(self, field)
       end
+
+      # Re-evaluates this record's source: fields and writes them to the FTS
+      # table immediately (synchronously). Use after a callback-free mutation
+      # (update_column, update_all, counter_cache/touch) to refresh the index.
+      def reindex_source_fields!
+        FullSearch::Callbacks.reindex_record!(self)
+      end
     end
   end
 end

data/lib/full_search/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FullSearch
-  VERSION = "0.4.8"
+  VERSION = "0.4.9"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: full_search
 version: !ruby/object:Gem::Version
-  version: 0.4.8
+  version: 0.4.9
 platform: ruby
 authors:
 - Ben D'Angelo
@@ -189,7 +189,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '2.0'
 requirements: []
-rubygems_version: 4.0.10
+rubygems_version: 4.0.18
 specification_version: 4
 summary: SQLite FTS5 full-text search for Rails/ActiveRecord
 test_files: []