full_circle 0.2.0 → 0.3.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    YTEwOGEyZGIxMWMyODc4Y2M5ZDEyNDZhODEzMTczNTUwN2VhNjJmMg==
-  data.tar.gz: !binary |-
-    YmRkNjQ4NjA5MTdmNzUyYjFhOTZjNGQ2YTZkNjU3ZmViMTM3MzVjNQ==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    NGIyMzMwNDFkOGQxZDk3YjljNjMxYmQ1ZDkzMTcwMDFkYmQ5N2JhNzFhZWJl
-    MGNlMzliYmRlNzA3OWNjNDYxYjBiMjRjYzgwZTdkMmM1MDk1ZjA4NjA0ZTFi
-    NTIyODM1NTI4ZDRjZjQ2NjhhNDVjNTdhYjc4ZGU5NjZiYjg4Mzk=
-  data.tar.gz: !binary |-
-    Zjk0YTY1YWY4ODA5NzA3Yjc1ODJkMTQ2ZDhiMDIxZmRjNGY2MmEzMjI1NTY4
-    OWRiNTFlOWEyZmNjZjE2MTZjZTI4YTZmZmExMzNlNzhmZGM2N2VmMTY1NDAz
-    NWFiODg1NDE0ZTY2OGJiY2NmMGI2Njc5MmVlYWM5OTY2YTc0ZmY=
+SHA1:
+  metadata.gz: 921cd25b80f85aafb4855127c71c39e4ac619f80
+  data.tar.gz: 6e21e8a35e78320ff841a338d631a312c15aafc5
+SHA512:
+  metadata.gz: 880020a8f93b69e06007d171a2b72b9befa6a999936c63250cd4e9f839e8e9eb72435c535aa6b48b7ffd5fbc22fd3d326ec80f31f69e719985f164793a592d6d
+  data.tar.gz: add1359cd220d2bb26458fb716672a73d3dcb2ff21e8bd091b32fe3b30ca212d471dad35b91bc72e71565df946cdf5d2e3c7701a86ac2ddbbca96915b9f0d24e

data/.gitignore

@@ -16,3 +16,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+bin/

data/.rspec

@@ -0,0 +1 @@
+--color

data/.ruby-version

@@ -0,0 +1 @@
+2.0.0-p643

data/full_circle.gemspec

@@ -10,8 +10,8 @@ Gem::Specification.new do |gem|
   gem.email         = ["aaron@animascodelabs.com"]
   gem.description   = %q{Library for interfacing with the 360Directories API}
   gem.summary       = %q{Library for interfacing with the 360Directories API}
-  gem.homepage      = "https://github.com/aaronrenner/full_circle"
-  gem.required_ruby_version = ">= 1.9.2"
+  gem.homepage      = "https://github.com/animascodelabs/full_circle"
+  gem.required_ruby_version = ">= 2.0.0"
 
   gem.files         = `git ls-files`.split($/)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
@@ -19,11 +19,9 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
 
   gem.add_dependency "multi_xml"
-  gem.add_dependency "activesupport", "~>3.2.12"
-  gem.add_development_dependency "rspec"
-  gem.add_development_dependency "vcr"
-  gem.add_development_dependency "webmock", "~> 1.8.0"
+  gem.add_dependency "activesupport", ">= 3.2"
+  gem.add_development_dependency "rspec", '~> 3.2'
+  gem.add_development_dependency "vcr", '~> 2.9'
+  gem.add_development_dependency "webmock"
   gem.add_development_dependency "rake"
-  gem.add_development_dependency "guard-rspec"
-  gem.add_development_dependency "rb-inotify", "~> 0.9"
 end

data/lib/full_circle.rb

@@ -1,4 +1,5 @@
 require 'multi_xml'
+require "active_support"
 require "active_support/core_ext"
 
 require_relative 'full_circle/version'

data/lib/full_circle/api.rb

@@ -1,6 +1,6 @@
 module FullCircle
   class API
-  
+
     attr_reader :connection
 
     def initialize(connection)

data/lib/full_circle/parsed_response.rb

@@ -18,7 +18,7 @@ module FullCircle
       collection_array
     end
 
-    
+
     private
 
     def response_hash

data/lib/full_circle/response.rb

@@ -1,7 +1,7 @@
 module FullCircle
   class Response
     attr_reader :results, :page, :total_pages, :total_results, :results_per_page
-    
+
     def initialize(results, metadata)
       @results = results
       @page = metadata.fetch(:page){1}

data/lib/full_circle/response_builder.rb

@@ -6,7 +6,7 @@ module FullCircle
     # Creates a new response builder
     # api_results - collection of objects to be built into the response
     # args
-    #   metadata: hash of metadata 
+    #   metadata: hash of metadata
     #   object_builder: The object builder to use for building api objects
     def initialize(api_results, args={})
       @api_results = api_results
@@ -21,6 +21,6 @@ module FullCircle
 
       Response.new(objects,metadata)
     end
-    
+
   end
 end

data/lib/full_circle/upcoming_event_builder.rb

@@ -39,6 +39,6 @@ module FullCircle
     def ad_id
       hash.fetch("ad"){{}}["id"]
     end
-      
+
   end
 end

data/lib/full_circle/version.rb

@@ -1,3 +1,3 @@
 module FullCircle
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/spec/fixtures/vcr_cassettes/empty_event_area_response.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: http://api.1019thewave.com/1.0/city.getEventAreas?
+    uri: http://api.1019thewave.com/1.0/city.getEventAreas
     body:
       encoding: US-ASCII
       string: ''
@@ -42,6 +42,6 @@ http_interactions:
         <city-getEventAreasResponse page="1" resultsPerPage="20" totalPages="0" totalResults="0"><eventAreas></eventAreas></city-getEventAreasResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Tue, 26 Mar 2013 19:29:44 GMT
 recorded_with: VCR 2.4.0

data/spec/fixtures/vcr_cassettes/empty_get_coupons_response.yml

@@ -42,6 +42,6 @@ http_interactions:
         <ad-getCouponsResponse><coupons></coupons></ad-getCouponsResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Mon, 18 Mar 2013 04:25:35 GMT
 recorded_with: VCR 2.4.0

data/spec/fixtures/vcr_cassettes/empty_get_events_response.yml

@@ -42,6 +42,6 @@ http_interactions:
         <ad-getEventsResponse><events></events></ad-getEventsResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Wed, 12 Dec 2012 17:31:42 GMT
 recorded_with: VCR 2.3.0

data/spec/fixtures/vcr_cassettes/empty_get_upcoming_events_response.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: http://api.boatersbluepages.com/1.0/city.getUpcomingEvents?
+    uri: http://api.boatersbluepages.com/1.0/city.getUpcomingEvents
     body:
       encoding: US-ASCII
       string: ''
@@ -43,6 +43,6 @@ http_interactions:
         totalResults="0"><events></events></city-getUpcomingEventsResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Tue, 26 Mar 2013 22:31:50 GMT
 recorded_with: VCR 2.4.0

data/spec/fixtures/vcr_cassettes/multiple_event_areas_response.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: http://api.360durango.com/1.0/city.getEventAreas?
+    uri: http://api.360durango.com/1.0/city.getEventAreas
     body:
       encoding: US-ASCII
       string: ''
@@ -46,6 +46,6 @@ http_interactions:
         id="591" name="Historic Downtown"></eventArea><eventArea id="735" name="Vallecito"></eventArea></eventAreas></city-getEventAreasResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Tue, 26 Mar 2013 19:19:20 GMT
 recorded_with: VCR 2.4.0

data/spec/fixtures/vcr_cassettes/multiple_get_coupons_response.yml

@@ -55,6 +55,6 @@ http_interactions:
         other coupons for products.</restrictions></coupon></coupons></ad-getCouponsResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Mon, 18 Mar 2013 04:30:36 GMT
 recorded_with: VCR 2.4.0

data/spec/fixtures/vcr_cassettes/multiple_get_upcoming_events_response.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: http://api.360durango.com/1.0/city.getUpcomingEvents?
+    uri: http://api.360durango.com/1.0/city.getUpcomingEvents
     body:
       encoding: US-ASCII
       string: ''
@@ -272,6 +272,6 @@ http_interactions:
         addr1=\"1911 Main Ave., Suite 100\" city=\"Durango\" state=\"CO\" zipCode=\"81301\"
         phone=\"970.247.1240\" fax=\"970.247.1771\"></address><logoImage url=\"http://tours.360durango.com/152054/logo.gif\"
         width=\"300\" height=\"263\"></logoImage></ad></event></events></city-getUpcomingEventsResponse>\n"
-    http_version: 
+    http_version:
   recorded_at: Tue, 26 Mar 2013 22:30:11 GMT
 recorded_with: VCR 2.4.0

data/spec/fixtures/vcr_cassettes/multple_get_events_response.yml

@@ -91,6 +91,6 @@ http_interactions:
         appetizers" imageURL="http://tours.360durango.com/89690/event_58652.jpg"></event></events></ad-getEventsResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Wed, 12 Dec 2012 17:31:41 GMT
 recorded_with: VCR 2.3.0

data/spec/fixtures/vcr_cassettes/single_event_areas_response.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: http://api.360durango.com/1.0/city.getEventAreas?
+    uri: http://api.360durango.com/1.0/city.getEventAreas
     body:
       encoding: US-ASCII
       string: ''
@@ -44,6 +44,6 @@ http_interactions:
         </eventAreas></city-getEventAreasResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Tue, 26 Mar 2013 19:22:34 GMT
 recorded_with: VCR 2.4.0

data/spec/fixtures/vcr_cassettes/single_get_coupons_response.yml

@@ -46,6 +46,6 @@ http_interactions:
         of Booking. No Refunds.</restrictions></coupon></coupons></ad-getCouponsResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Mon, 18 Mar 2013 04:30:35 GMT
 recorded_with: VCR 2.4.0

data/spec/fixtures/vcr_cassettes/single_get_events_response.yml

@@ -47,6 +47,6 @@ http_interactions:
         and 7p.m. to receive your second entree FREE." imageURL="http://tours.360durango.com/81213/event_58794.jpg"></event></events></ad-getEventsResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Wed, 12 Dec 2012 03:35:57 GMT
 recorded_with: VCR 2.3.0

data/spec/fixtures/vcr_cassettes/single_get_upcoming_events_response.yml

@@ -56,6 +56,6 @@ http_interactions:
         width="250" height="218"></logoImage></ad></event></events></city-getUpcomingEventsResponse>
 
 '
-    http_version: 
+    http_version:
   recorded_at: Tue, 26 Mar 2013 23:05:54 GMT
 recorded_with: VCR 2.4.0

data/spec/full_circle/api_spec.rb

@@ -6,9 +6,9 @@ describe FullCircle::API do
   let!(:api){FullCircle::API.new(FullCircle::Connection.new("360durango.com"))}
 
   describe "#fetch_events_for_ad" do
-    pending "calls the appropriate method on call_api_method" do
+    skip "calls the appropriate method on call_api_method" do
       mock_connection = double()
-      mock_connection.should_receive(:call_api_method).with("ad.getEvents",{adId: "1"}) do
+      expect(mock_connection).to receive(:call_api_method).with("ad.getEvents",{adId: "1"}) do
         class ResponseDouble
           def body
           end
@@ -19,8 +19,7 @@ describe FullCircle::API do
       described_class.new(mock_connection).fetch_events_for_ad("1")
     end
 
-    describe "event object" do
-      use_vcr_cassette "single_get_events_response"
+    describe "event object", :vcr => {cassette_name: "single_get_events_response"} do
       subject {api.fetch_events_for_ad("81213").first}
       it_behaves_like "an event"
     end
@@ -29,19 +28,19 @@ describe FullCircle::API do
       it "returns an array of one event" do
         VCR.use_cassette "single_get_events_response" do
           results = api.fetch_events_for_ad "81213"
-          results.should be_a Array
+          expect(results).to be_a Array
           results
         end
       end
 
     end
-    
+
     context "with multiple events" do
       it "returns an array of multiple events" do
         VCR.use_cassette "multple_get_events_response" do
           results = api.fetch_events_for_ad "89690"
-          results.should be_a Array
-          (results.length > 1).should be_true
+          expect(results).to be_a Array
+          expect(results.length > 1).to eq(true)
         end
       end
     end
@@ -50,7 +49,7 @@ describe FullCircle::API do
       it "returns an empty array" do
         VCR.use_cassette "empty_get_events_response" do
           results = api.fetch_events_for_ad "1"
-          results.should eq []
+          expect(results).to eq([])
         end
       end
     end
@@ -60,19 +59,19 @@ describe FullCircle::API do
 
   describe "#fetch_coupons_for_ad" do
 
-    pending "calls the appropriate method on call_api_method" do
+    skip "calls the appropriate method on call_api_method" do
       mock_connection = double()
-      mock_connection.should_receive(:call_api_method).with("ad.getCoupons",{adId: "1"})
+      expect(mock_connection).to receive(:call_api_method).with("ad.getCoupons",{adId: "1"})
 
       described_class.new(mock_connection).fetch_coupons_for_ad("1")
     end
-    
+
     context "with one coupon" do
       it "returns an array of one coupon" do
         VCR.use_cassette "single_get_coupons_response" do
           results = api.fetch_coupons_for_ad "123094"
-          results.should be_a Array
-          results.length.should eq 1
+          expect(results).to be_an(Array)
+          expect(results.length).to eq(1)
         end
       end
     end
@@ -81,8 +80,8 @@ describe FullCircle::API do
       it "returns an array of multiple coupons" do
         VCR.use_cassette "multiple_get_coupons_response" do
           results = api.fetch_coupons_for_ad "82196"
-          results.should be_a Array
-          results.length.should eq 3
+          expect(results).to be_a(Array)
+          expect(results.length).to eq(3)
         end
       end
     end
@@ -91,16 +90,16 @@ describe FullCircle::API do
       it "returns an empty array" do
         VCR.use_cassette "empty_get_coupons_response" do
           results = api.fetch_coupons_for_ad "1"
-          results.should eq []
+          expect(results).to eq([])
         end
       end
     end
   end
 
   describe "#fetch_event_areas" do
-    pending "calls the appropriate method on call_api_method" do
+    skip "calls the appropriate method on call_api_method" do
       mock_connection = double()
-      mock_connection.should_receive(:call_api_method).with("city.getEventAreas")
+      expect(mock_connection).to receive(:call_api_method).with("city.getEventAreas")
 
       described_class.new(mock_connection).fetch_event_areas
     end
@@ -109,8 +108,7 @@ describe FullCircle::API do
       it "returns an array of one event area" do
         VCR.use_cassette "single_event_areas_response" do
           results = api.fetch_event_areas
-          results.should be_a Array
-          results.length.should eq 1
+          expect(results.length).to eq(1)
         end
       end
     end
@@ -119,8 +117,7 @@ describe FullCircle::API do
       it "returns an array of multiple event areas" do
         VCR.use_cassette "multiple_event_areas_response" do
           results = api.fetch_event_areas
-          results.should be_a Array
-          results.length.should eq 7
+          expect(results.length).to eq(7)
         end
       end
     end
@@ -130,7 +127,7 @@ describe FullCircle::API do
       it "returns an empty array" do
         VCR.use_cassette "empty_event_area_response" do
           results = api.fetch_event_areas
-          results.should eq []
+          expect(results).to eq([])
         end
       end
     end
@@ -139,15 +136,14 @@ describe FullCircle::API do
 
   describe "#fetch_upcoming_events" do
 
-    pending "calls the appropriate method on call_api_method" do
+    skip "calls the appropriate method on call_api_method" do
       mock_connection = double()
-      mock_connection.should_receive(:call_api_method).with("city.getUpcomingEvents",{})
+      expect(mock_connection).to receive(:call_api_method).with("city.getUpcomingEvents",{})
 
       described_class.new(mock_connection).fetch_upcoming_events
     end
 
-    describe "event object" do
-      use_vcr_cassette "single_get_upcoming_events_response"
+    describe "event object", vcr: {cassette_name: "single_get_upcoming_events_response"} do
 
       subject {api.fetch_upcoming_events(areaId:"592").first}
       it_behaves_like "an event"
@@ -157,19 +153,17 @@ describe FullCircle::API do
       it "returns an array of one event" do
         VCR.use_cassette "single_get_upcoming_events_response" do
           results = api.fetch_upcoming_events areaId: "592"
-          results.should be_a Array
-          results.length.should be 1
+          expect(results.length).to eq(1)
         end
       end
 
     end
-    
+
     context "with multiple events" do
       it "returns an array of multiple events" do
         VCR.use_cassette "multiple_get_upcoming_events_response" do
           results = api.fetch_upcoming_events
-          results.should be_a Array
-          (results.length > 1).should be_true
+          expect(results.length > 1).to eq(true)
         end
       end
     end
@@ -179,7 +173,7 @@ describe FullCircle::API do
       it "returns an empty array" do
         VCR.use_cassette "empty_get_upcoming_events_response" do
           results = api.fetch_upcoming_events
-          results.should eq []
+          expect(results).to eq([])
         end
       end
     end

data/spec/full_circle/connection_spec.rb

@@ -4,43 +4,57 @@ describe FullCircle::Connection do
 
   subject {FullCircle::Connection.new "360durango.com"}
 
-  its(:domain) {should == "360durango.com"}
-  its(:base_uri) {should == "http://api.360durango.com/1.0/"}
+  describe "#domain" do
+    it "returns the value set in the constructor" do
+      conn = described_class.new "360durango.com"
 
-  let!(:req_stub) {stub_http_request(:get, "api.360durango.com/1.0/ad.getCoupons").with(query: {adId: "81304"})
+      expect(conn.domain).to eq('360durango.com')
+    end
+  end
+
+  describe "#base_uri" do
+    it "returns formats the domain into the proper uri" do
+      conn = described_class.new "360durango.com"
+
+      expect(conn.base_uri).to eq('http://api.360durango.com/1.0/')
+    end
+  end
+
+
+  let!(:req_stub) {stub_request(:get, "api.360durango.com/1.0/ad.getCoupons").with(query: {adId: "81304"})
     .to_return(body: "abc")
   }
 
   describe ".call_api_method" do
 
-    it "should request the correct uri" do
+    it "requests the correct uri" do
       subject.call_api_method "ad.getCoupons", adId: "81304"
 
-      req_stub.should have_been_requested
+      expect(req_stub).to have_been_requested
     end
 
-    it "should return the correct data" do
+    it "returns the correct data" do
       response = subject.call_api_method "ad.getCoupons", adId: "81304"
-      response.body.should eq("abc")
+      expect(response.body).to eq("abc")
     end
 
     context "without cache" do
-      it "should make the http request each time" do
+      it "makes the http request each time" do
         subject.call_api_method "ad.getCoupons", adId: "81304"
         subject.call_api_method "ad.getCoupons", adId: "81304"
 
-        req_stub.should have_been_requested.twice
+        expect(req_stub).to have_been_requested.twice
       end
     end
 
     context "with cache" do
       subject {FullCircle::Connection.new "360durango.com", cache: {}}
 
-      it "should make the http request each time" do
+      it "does not make the http request each time" do
         subject.call_api_method "ad.getCoupons", adId: "81304"
         subject.call_api_method "ad.getCoupons", adId: "81304"
 
-        req_stub.should have_been_requested.once
+        expect(req_stub).to have_been_requested.once
       end
     end
 

data/spec/full_circle/object_builder_spec.rb

@@ -9,14 +9,14 @@ describe FullCircle::ObjectBuilder do
 
     it "builds a new event with the appropriate attribute set" do
       object = builder.from_api_hash("id" => "123", "title" => "Hello World")
-      object.id.should eq "123"
-      object.title.should eq "Hello World"
+      expect(object.id).to eq("123")
+      expect(object.title).to eq("Hello World")
     end
-    
+
     it "builds a new event with camelcased attributes converted to underscored attributes" do
       object = builder.from_api_hash("linkUrl" => "http://www.google.com", "siteId" => "77")
-      object.link_url.should eq "http://www.google.com"
-      object.site_id.should eq "77"
+      expect(object.link_url).to eq("http://www.google.com")
+      expect(object.site_id).to eq("77")
     end
 
   end

data/spec/full_circle/parsed_response_spec.rb

@@ -9,14 +9,14 @@ describe FullCircle::ParsedResponse do
         <?xml version="1.0"?>
         <ad-getListResponse page="2" resultsPerPage="2" totalPages="541" totalResults="1081">
           <ads>
-            <ad id="81009" name="4Core" url="http://360Durango.com/Environmental/4core.html" 
-              eventCount="0" couponCount="0" jobCount="0" locationCount="1" popupCount="0" 
+            <ad id="81009" name="4Core" url="http://360Durango.com/Environmental/4core.html"
+              eventCount="0" couponCount="0" jobCount="0" locationCount="1" popupCount="0"
               slideshowCount="0" linkCount="0">
                 <address addr1="949 E 2ND AV" city="DURANGO" state="CO" zipCode="81301"></address>
             </ad>
-            <ad id="123760" name="4x4 Auto " url="http://360Durango.com/Automotive/4x4Auto.html" 
-              description="Used Car Dealership Cortez 360Durango Colorado" eventCount="0" 
-              couponCount="0" jobCount="0" locationCount="0" popupCount="0" slideshowCount="0" 
+            <ad id="123760" name="4x4 Auto " url="http://360Durango.com/Automotive/4x4Auto.html"
+              description="Used Car Dealership Cortez 360Durango Colorado" eventCount="0"
+              couponCount="0" jobCount="0" locationCount="0" popupCount="0" slideshowCount="0"
               linkCount="0">
             </ad>
           </ads>
@@ -24,15 +24,16 @@ describe FullCircle::ParsedResponse do
 EOS
       end
 
-      subject { described_class.new(xml).metadata }
-
-      its([:page]){should eq 2}
-      its([:results_per_page]){should eq 2}
-      its([ :total_pages ]){should eq 541 }
-      its([ :total_results ]){should eq 1081}
-
-
+      it 'sets the appropriate kes and values in the hash' do
+        response = described_class.new(xml)
 
+        expect(response.metadata).to eq({
+          page: 2,
+          results_per_page: 2,
+          total_pages: 541,
+          total_results: 1081
+        })
+      end
     end
 
     context "with no provided metadata" do
@@ -41,12 +42,12 @@ EOS
         <?xml version="1.0"?>
         <ad-getCouponsResponse>
           <coupons>
-            <coupon id="32025" name="90 for 90!" begin="2013-04-04" 
+            <coupon id="32025" name="90 for 90!" begin="2013-04-04"
                expire="2013-04-30" accept_offline="1" accept_online="0" acceptMobile="1" acceptPrint="1">
               <offer>Get a relaxing and restorative 90 minute massage for just $90!</offer>
               <restrictions>Service must be booked in the month of April.</restrictions>
             </coupon>
-            <coupon id="32025" name="90 for 90!" begin="2013-04-04" 
+            <coupon id="32025" name="90 for 90!" begin="2013-04-04"
                expire="2013-04-30" accept_offline="1" accept_online="0" acceptMobile="1" acceptPrint="1">
               <offer>Get a relaxing and restorative 90 minute massage for just $90!</offer>
               <restrictions>Service must be booked in the month of April.</restrictions>
@@ -56,13 +57,16 @@ EOS
 EOS
       end
 
-      subject { described_class.new(xml).metadata }
-
-      its([ :page ]){should eq 1}
-      its([ :total_pages ]){should eq 1 }
-      its([ :total_results ]) {should eq 2}
-      its([ :results_per_page ]) {should eq 2 }
+      it 'sets the appropriate kes and values in the hash' do
+        response = described_class.new(xml)
 
+        expect(response.metadata).to eq({
+          page: 1,
+          results_per_page: 2,
+          total_pages: 1,
+          total_results: 2
+        })
+      end
     end
   end
 
@@ -79,8 +83,11 @@ EOS
 EOS
       end
 
-      subject{described_class.new(xml).results}
-      it { should eq [] }
+      it 'returns an empty results array' do
+        response = described_class.new(xml)
+
+        expect(response.results).to eq([])
+      end
     end
 
     context "with one result" do
@@ -90,7 +97,7 @@ EOS
         <?xml version="1.0"?>
         <ad-getCouponsResponse>
           <coupons>
-            <coupon id="32025" name="90 for 90!" begin="2013-04-04" 
+            <coupon id="32025" name="90 for 90!" begin="2013-04-04"
                expire="2013-04-30" accept_offline="1" accept_online="0" acceptMobile="1" acceptPrint="1">
               <offer>Get a relaxing and restorative 90 minute massage for just $90!</offer>
               <restrictions>Service must be booked in the month of April.</restrictions>
@@ -100,8 +107,11 @@ EOS
 EOS
       end
 
-      subject{described_class.new(xml).results}
-      its(:length){should eq 1 }
+      it 'returns one object in the results array' do
+        response = described_class.new(xml)
+
+        expect(response.results.length).to eq(1)
+      end
 
     end
 
@@ -111,14 +121,14 @@ EOS
         <?xml version="1.0"?>
         <ad-getListResponse page="2" resultsPerPage="2" totalPages="541" totalResults="1081">
           <ads>
-            <ad id="81009" name="4Core" url="http://360Durango.com/Environmental/4core.html" 
-              eventCount="0" couponCount="0" jobCount="0" locationCount="1" popupCount="0" 
+            <ad id="81009" name="4Core" url="http://360Durango.com/Environmental/4core.html"
+              eventCount="0" couponCount="0" jobCount="0" locationCount="1" popupCount="0"
               slideshowCount="0" linkCount="0">
                 <address addr1="949 E 2ND AV" city="DURANGO" state="CO" zipCode="81301"></address>
             </ad>
-            <ad id="123760" name="4x4 Auto " url="http://360Durango.com/Automotive/4x4Auto.html" 
-              description="Used Car Dealership Cortez 360Durango Colorado" eventCount="0" 
-              couponCount="0" jobCount="0" locationCount="0" popupCount="0" slideshowCount="0" 
+            <ad id="123760" name="4x4 Auto " url="http://360Durango.com/Automotive/4x4Auto.html"
+              description="Used Car Dealership Cortez 360Durango Colorado" eventCount="0"
+              couponCount="0" jobCount="0" locationCount="0" popupCount="0" slideshowCount="0"
               linkCount="0">
             </ad>
           </ads>
@@ -126,9 +136,11 @@ EOS
 EOS
       end
 
-      subject { described_class.new(xml).results }
+      it 'returns an array with all results' do
+        response = described_class.new(xml)
 
-      its(:length){should eq 2}
+        expect(response.results.length).to eq(2)
+      end
     end
 
   end

data/spec/full_circle/response_builder_spec.rb

@@ -14,13 +14,13 @@ describe FullCircle::ResponseBuilder do
     subject {object_builder_double}
     it_behaves_like "an object builder"
   end
- 
+
   describe "#build" do
     context "with empty array of api_results" do
       subject{ described_class.new [], object_builder: object_builder_double }
-      
+
       it "calls object_builder.from_api_hash" do
-        object_builder_double.should_not_receive(:from_api_hash)
+        expect(object_builder_double).not_to receive(:from_api_hash)
         subject.build
       end
 
@@ -28,18 +28,18 @@ describe FullCircle::ResponseBuilder do
 
     context "with an array of multiple api_results" do
       subject{ described_class.new [{},{}], object_builder: object_builder_double }
-      
+
       it "calls object_builder.from_api_hash" do
-        object_builder_double.should_receive(:from_api_hash).with({}).exactly(2).times
+        expect(object_builder_double).to receive(:from_api_hash).with({}).exactly(2).times
         subject.build
       end
     end
 
     describe "response outgoing messages" do
       subject{ described_class.new [{},{}], object_builder: object_builder_double }
-      
-      it "should create a response with the correct arguments" do
-        FullCircle::Response.should_receive(:new).with([nil,nil],{})
+
+      it "creates a response with the correct arguments" do
+        expect(FullCircle::Response).to receive(:new).with([nil,nil],{})
 
         subject.build
       end

data/spec/full_circle/response_spec.rb

@@ -2,28 +2,75 @@ require 'spec_helper'
 
 describe FullCircle::Response do
 
-  describe "defaults" do
-    subject{described_class.new([],{})}
+  describe '#results' do
+    it 'defaults to an empty array' do
+      response = described_class.new([], {})
 
-    its(:results){should eq []}
-    its(:page){should eq 1}
-    its(:total_pages){should eq 1}
-    its(:results_per_page){should eq 0 }
-    its(:total_results){should eq 0 }
+      expect(response.results).to eq([])
+    end
 
+    it 'can be set to the first argument in the constructor' do
+      results = double('results', length: 0)
+
+      response = described_class.new(results, {})
+
+      expect(response.results).to eq(results)
+    end
+  end
+
+  describe '#page' do
+    it 'defaults to 1' do
+      response = described_class.new([], {})
+
+      expect(response.page).to eq(1)
+    end
+
+    it 'can be set in the metadata hash' do
+      response = described_class.new([], {page: 2 })
+
+      expect(response.page).to eq(2)
+    end
   end
 
-  describe "with metadata" do
-    subject{described_class.new([],{page: 2, total_pages:5, results_per_page: 5, total_results: 25})}
+  describe '#total_pages' do
+    it 'defaults to 1' do
+      response = described_class.new([], {})
+
+      expect(response.total_pages).to eq(1)
+    end
 
-    its(:results){should eq []}
-    its(:page){should eq 2}
-    its(:total_pages){should eq 5}
-    its(:results_per_page){should eq 5 }
-    its(:total_results){should eq 25 }
+    it 'can be set in the metadata hash' do
+      response = described_class.new([], {total_pages: 5 })
 
+      expect(response.total_pages).to eq(5)
+    end
   end
 
+  describe '#results_per_page' do
+    it 'defaults to 0' do
+      response = described_class.new([], {})
 
+      expect(response.results_per_page).to eq(0)
+    end
 
+    it 'can be set in the metadata hash' do
+      response = described_class.new([], {results_per_page: 5 })
+
+      expect(response.results_per_page).to eq(5)
+    end
+  end
+
+  describe '#total_results' do
+    it 'defaults to 0' do
+      response = described_class.new([], {})
+
+      expect(response.total_results).to eq(0)
+    end
+
+    it 'can be set in the metadata hash' do
+      response = described_class.new([], {total_results: 25 })
+
+      expect(response.total_results).to eq(25)
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -10,8 +10,8 @@ Dir["./spec/support/**/*.rb"].sort.each {|f| require f}
 VCR.configure do |c|
   c.cassette_library_dir = "spec/fixtures/vcr_cassettes"
   c.hook_into :webmock
+  c.configure_rspec_metadata!
 end
 
 RSpec.configure do |c|
-    c.extend VCR::RSpec::Macros
 end

data/spec/support/shared/cacher_examples.rb

@@ -0,0 +1,9 @@
+shared_examples_for "a cacher" do
+  it { expect(subject).to respond_to(:fetch).with(1).argument }
+
+  describe "#store" do
+    it "returns the value that is stored" do
+      expect(subject.store("key","value")).to eq("value")
+    end
+  end
+end

data/spec/support/shared/{event_spec.rb → event_examples.rb}

@@ -2,8 +2,10 @@ shared_examples_for "an event" do
   required_attrs = :id, :date, :time, :title, :all_day_event, :date_mode, :site_id,
     :type, :description
 
-  for attr in required_attrs
-    its(attr){should_not be_blank}
+  required_attrs.each do |field|
+    it "does not have a blank #{field}" do
+      expect(subject.send("#{field}")).to be_present
+    end
   end
 
 

metadata

@@ -1,127 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: full_circle
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Aaron Renner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-29 00:00:00.000000000 Z
+date: 2015-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_xml
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 3.2.12
+        version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 3.2.12
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: '2.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: '2.9'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: guard-rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rb-inotify
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '0.9'
 description: Library for interfacing with the 360Directories API
 email:
 - aaron@animascodelabs.com
@@ -130,8 +102,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
+- .ruby-version
 - Gemfile
-- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -165,10 +138,10 @@ files:
 - spec/full_circle/response_spec.rb
 - spec/full_circle/upcoming_event_builder_spec.rb
 - spec/spec_helper.rb
-- spec/support/shared/cacher_spec.rb
-- spec/support/shared/event_spec.rb
-- spec/support/shared/object_builder_spec.rb
-homepage: https://github.com/aaronrenner/full_circle
+- spec/support/shared/cacher_examples.rb
+- spec/support/shared/event_examples.rb
+- spec/support/shared/object_builder_examples.rb
+homepage: https://github.com/animascodelabs/full_circle
 licenses: []
 metadata: {}
 post_install_message: 
@@ -177,17 +150,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
-      version: 1.9.2
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Library for interfacing with the 360Directories API
@@ -212,6 +185,6 @@ test_files:
 - spec/full_circle/response_spec.rb
 - spec/full_circle/upcoming_event_builder_spec.rb
 - spec/spec_helper.rb
-- spec/support/shared/cacher_spec.rb
-- spec/support/shared/event_spec.rb
-- spec/support/shared/object_builder_spec.rb
+- spec/support/shared/cacher_examples.rb
+- spec/support/shared/event_examples.rb
+- spec/support/shared/object_builder_examples.rb

data/Guardfile

@@ -1,24 +0,0 @@
-# A sample Guardfile
-# More info at https://github.com/guard/guard#readme
-
-guard 'rspec', :cli => "--color" do
-  watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb" }
-  watch('spec/spec_helper.rb')  { "spec" }
-
-  # Rails example
-  # watch(%r{^app/(.+)\.rb$})                           { |m| "spec/#{m[1]}_spec.rb" }
-  # watch(%r{^app/(.*)(\.erb|\.haml)$})                 { |m| "spec/#{m[1]}#{m[2]}_spec.rb" }
-  # watch(%r{^app/controllers/(.+)_(controller)\.rb$})  { |m| ["spec/routing/#{m[1]}_routing_spec.rb", "spec/#{m[2]}s/#{m[1]}_#{m[2]}_spec.rb", "spec/acceptance/#{m[1]}_spec.rb"] }
-  # watch(%r{^spec/support/(.+)\.rb$})                  { "spec" }
-  # watch('config/routes.rb')                           { "spec/routing" }
-  # watch('app/controllers/application_controller.rb')  { "spec/controllers" }
-
-  # Capybara features specs
-  # watch(%r{^app/views/(.+)/.*\.(erb|haml)$})          { |m| "spec/features/#{m[1]}_spec.rb" }
-
-  # Turnip features and steps
-  # watch(%r{^spec/acceptance/(.+)\.feature$})
-  # watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$})   { |m| Dir[File.join("**/#{m[1]}.feature")][0] || 'spec/acceptance' }
-end
-

data/spec/support/shared/cacher_spec.rb

@@ -1,9 +0,0 @@
-shared_examples_for "a cacher" do
-  it {should respond_to(:fetch).with(1).argument}
-
-  describe "#store" do
-    it "should return the value that is stored" do
-      subject.store("key","value").should eq "value"
-    end
-  end
-end