fuey_client 0.4.4 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5fb665c8a62c200904e94bfbf2bd101a07e5d44d
-  data.tar.gz: 61623da20ab3162b02d17fd331985999404d8de4
+  metadata.gz: 1c63aabe5fea48616819b21441c3188c677750e0
+  data.tar.gz: d810d07322f3b770f9357969137ea8feda7a7f90
 SHA512:
-  metadata.gz: fe13631a474bfd9c84e3d5d68b95ff9c98738ae1009b0296ca35f8cffab395f70c2aa8b7e46a81e73a5e79ee37b63b1311ffc78a9c16df0b00d86372de71870f
-  data.tar.gz: ad3715338a2e689a4cdcfdb495dcc44264960748c83a58041476a236a96cab48d6b3640014343fa2586f442151b76a5e639d7d2dbd26ef4c993955864a46ed35
+  metadata.gz: 6e7da4c3baee7259706cbff6a41c0cf0001d385e4d1fe15156ac23742687881eba9b3219b5100acfae88fab9a787d972a692f5cd7a1e6c2f7b471126a21120e0
+  data.tar.gz: b3be27e62d394e0e52430f0b51fad3213aee3eec65e2896bf082e23f32dd635d8cd29fb72b3607d89a0d8ec593831927123da0a418328b90fb7eaa65b16a4410

data/lib/fuey_client/fuey/inspections/rfc_ping.rb

@@ -6,7 +6,7 @@ module Fuey
       attr_accessor :ashost, :sysnr, :client, :user, :passwd, :lang, :response
 
       def _execute
-        result, response = Support::SAP.new(config).ping
+        result, @response = Support::SAP.new(config).ping
         if result
           self.pass
         else
@@ -15,13 +15,18 @@ module Fuey
       end
 
       def to_s
-        %(RFC Ping #{ashost} with user #{user})
+        %(RFCPing #{ashost} with user #{user})
+      end
+
+      def status_message
+        return %(RFCPing #{state} for #{ashost}. #{@response}) if failed?
+        %(RFCPing #{state} for #{ashost}.)
       end
 
       def status
         {
           :settings => config.reject{|k,v| k == 'passwd'},
-          :statusMessage => response || %(#{state} RFCPing for #{ashost})
+          :statusMessage => status_message
         }.merge(super)
       end
 

data/lib/fuey_client/fuey/inspections/snmp_walk.rb

@@ -13,7 +13,7 @@ module Fuey
       end
 
       def _execute
-        response = Support::ShellCommand.new(snmp_walk_command).execute
+        @response = Support::ShellCommand.new(snmp_walk_command).execute
         result = (response =~ /#{ip}/)
         if result
           self.pass
@@ -23,7 +23,7 @@ module Fuey
       end
 
       def status_message
-        return %(#{state} #{snmp_walk_command}) if response.nil?
+        return %(SNMPWalk #{state} #{snmp_walk_command}) if @response.nil? || passed?
         %(SNMPWalk #{state}. #{response})
       end
 

data/lib/fuey_client/fuey/inspections/support/sap.rb

@@ -18,7 +18,7 @@ module Fuey
         rescue Gem::LoadError
           return [false, %(Could not RFC Ping because the sapnwrfc gem is not available)]
         rescue Exception => caught
-          return [false, caught]
+          return [false, caught.message]
         ensure
           conn.close unless conn.nil?
         end

data/lib/fuey_client/version.rb

@@ -1,3 +1,3 @@
 module FueyClient
-  VERSION = "0.4.4"
+  VERSION = "0.5.0"
 end

data/spec/fuey_client/fuey/inspections/rfc_ping_spec.rb

@@ -25,6 +25,7 @@ describe Fuey::Inspections::RFCPing do
     Given { conn.stub(:ping).and_return([false, "RFC Ping failure msg"]) }
     When  { rfc_ping.execute }
     Then  { expect( rfc_ping ).to have_aborted }
+    And   { expect( rfc_ping.status_message ).to end_with("RFC Ping failure msg") }
   end
 
   context "when the ping succeeds" do
@@ -33,5 +34,6 @@ describe Fuey::Inspections::RFCPing do
     Given { conn.stub(:ping).and_return([true, ""]) }
     When  { rfc_ping.execute }
     Then  { expect( rfc_ping ).to have_passed }
+    And   { expect( rfc_ping.status_message ).to eql("RFCPing passed for 1.0.0.1.") }
   end
 end

data/spec/fuey_client/fuey/inspections/snmpwalk_spec.rb

@@ -17,12 +17,21 @@ describe Fuey::Inspections::SNMPWalk do
       WALK
     }
 
+    context "when the walk has not been run" do
+      Given (:ip) { '172.0.0.1' }
+      Given (:snmpwalk) { Fuey::Inspections::SNMPWalk.new(:name => name, :ip => ip, :agent => agent, :oid => oid) }
+      Then  { expect( snmpwalk.status_message ).to end_with("snmpwalk -v1 -c public 172.16.0.100 1.2.9.2.5.3.5.7.111.0.2.0.1.0") }
+      And   { expect( snmpwalk.status_message ).to start_with("SNMPWalk pending") }
+    end
+
     context "when the walk fails" do
       Given (:ip) { '172.0.0.1' }
       Given { Fuey::Inspections::Support::ShellCommand.stub(:new).with("snmpwalk -v1 -c public 172.16.0.100 1.2.9.2.5.3.5.7.111.0.2.0.1.0").and_return double("ShellCommand", :execute => walk_result) }
       Given (:snmpwalk) { Fuey::Inspections::SNMPWalk.new(:name => name, :ip => ip, :agent => agent, :oid => oid) }
       When  { snmpwalk.execute }
       Then  { expect( snmpwalk ).to have_aborted }
+      And   { expect( snmpwalk.status_message ).to end_with(walk_result) }
+      And   { expect( snmpwalk.status_message ).to start_with( "SNMPWalk failed" ) }
     end
 
     context "when the walk succeeds" do
@@ -31,6 +40,8 @@ describe Fuey::Inspections::SNMPWalk do
       Given (:snmpwalk) { Fuey::Inspections::SNMPWalk.new(:name => name, :ip => ip, :agent => agent, :oid => oid) }
       When  { snmpwalk.execute }
       Then  { expect( snmpwalk ).to have_passed }
+      And   { expect( snmpwalk.status_message ).to end_with( "snmpwalk -v1 -c public 172.16.0.100 1.2.9.2.5.3.5.7.111.0.2.0.1.0" ) }
+      And   { expect( snmpwalk.status_message ).to start_with( "SNMPWalk passed" ) }
     end
 
     context "when the walk specifies the version and community" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fuey_client
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.5.0
 platform: ruby
 authors:
 - Matt Snyder
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-26 00:00:00.000000000 Z
+date: 2013-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: configurethis