ftpmvc 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e422fc8c27107d8f5d11841ca0ba9169a8d96d43
-  data.tar.gz: c82242e855e7ae69e6fba5c8d02aae82155d70ae
+  metadata.gz: 024488aeef1805a8ebc1ecb4deb605bf482e6256
+  data.tar.gz: e5993370082b5dee9fa3070597c9375e136eb70d
 SHA512:
-  metadata.gz: 6ae075d153762c9c1af03b408ae6643a2bb19b9ffa6d3bff83caaa022144027f80d7d43a9542e9e2f0aa4a15416e7b20a7384c226fbb93aab8edf80a2d5dd444
-  data.tar.gz: 16ddd750c8078e758eac91145d94e2b3672b9f28d8321ef65939a81a6cb177781d9bb27745cddaf88d9205057e2c732e0e187b5e7171f747266b11b60ded7d9f
+  metadata.gz: bdfef3b7ae0449d4478246650a184ed13b901f4d95a3896ba1cfbf5ce5fd122d4705361123cf1214be8ae6f94d07cab2b22280d915ee51bfe9f36f7e74ac26cc
+  data.tar.gz: d67691c08fcad0c1d4f5c59a070822b4ea7f18479c6ff18587fcb32f43803965925738ba5d62f980e8a6cd59165725a72094fb92306319db6f4324fd5dc451c5

data/.travis.yml

@@ -5,3 +5,6 @@ rvm:
   - 2.0.0
   - 1.9.3
 script: bundle exec rspec
+addons:
+  code_climate:
+    repo_token: 992df55b0c02e1be977aa24558bb46cca26ccb8bd58882b

data/README.md

@@ -1,4 +1,4 @@
-# Ftpmvc
+# FTPMVC
 
 TODO: Write a gem description
 

data/examples/env/env.rb

@@ -9,4 +9,7 @@ app = FTPMVC::Application.new do
   end
 end
 
-FTPMVC::Server.new(2222).start(app)
+FTPMVC::Server.new(2121).start(app) do |server|
+  puts "Server listening in #{server.host}:#{server.port}..."
+end
+

data/ftpmvc.gemspec

@@ -5,7 +5,7 @@ require 'ftpmvc/version'
 
 Gem::Specification.new do |spec|
   spec.name          = "ftpmvc"
-  spec.version       = Ftpmvc::VERSION
+  spec.version       = FTPMVC::VERSION
   spec.authors       = ["André Aizim Kelmanson"]
   spec.email         = ["akelmanson@gmail.com"]
   spec.summary       = "FTP MVC framework"
@@ -22,6 +22,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "guard-rspec"
   spec.add_development_dependency "terminal-notifier-guard"
+  spec.add_development_dependency "codeclimate-test-reporter"
   spec.add_dependency "em-ftpd"
   spec.add_dependency "activesupport"
 end

data/lib/ftpmvc/application.rb

@@ -1,3 +1,4 @@
+require 'forwardable'
 require 'ftpmvc/directory'
 require 'ftpmvc/filter'
 require 'ftpmvc/access_filesystem_filter'

data/lib/ftpmvc/directory.rb

@@ -1,3 +1,4 @@
+require 'active_support/dependencies'
 require 'active_support/core_ext/string/inflections'
 
 module FTPMVC
@@ -38,11 +39,7 @@ module FTPMVC
     end
 
     def self.build(name, &block)
-      if Object.const_defined?(specific_handler_class_name(name))
-        instance = Object::const_get(specific_handler_class_name(name)).new(name, &block)
-      else
-        instance = self.new(name, &block)
-      end
+      directory_class(name).new(name, &block)
     end
 
     def directory?(path)
@@ -57,8 +54,8 @@ module FTPMVC
       end
     end
 
-    def self.specific_handler_class_name(name)
-      "#{name.to_s.camelize}Directory"
+    def self.directory_class(name)
+      ActiveSupport::Dependencies.safe_constantize("#{name.to_s.camelize}Directory") || self
     end
   end
 end

data/lib/ftpmvc/filter.rb

@@ -1,3 +1,5 @@
+require 'forwardable'
+
 module FTPMVC
   class Filter
     extend Forwardable

data/lib/ftpmvc/server.rb

@@ -4,24 +4,37 @@ require 'ftpmvc/driver'
 module FTPMVC
   class Server
 
-    attr_reader :port
+    attr_reader :host, :port
   
     def initialize(host='0.0.0.0', port)
       @host, @port = host, port
     end
 
-    def start(root)
-      EventMachine.epoll
-      EventMachine::run do
-        signature = EventMachine::start_server(@host, @port, EM::FTPD::Server, Driver, root)
-        @port = Socket.unpack_sockaddr_in(EM.get_sockname(signature)).first
-        puts "Server listening on #{@host}:#{@port}..."
-        Thread.new { yield self } if block_given?
+    def start_in_new_thread(application)
+      queue = Queue.new
+      server_thread = Thread.new do
+        begin
+          start(application) do
+            queue << true
+          end
+        rescue => e
+          $strerr.puts "Server error: #{e.class}: #{e.message}"
+        end
+      end
+      queue.pop
+    end
+
+    def start(application)
+      EM.epoll
+      EM::run do
+        @signature = EM::start_server(@host, @port, EM::FTPD::Server, Driver, application)
+        @port = Socket.unpack_sockaddr_in(EM.get_sockname(@signature)).first
+        yield self if block_given?
       end
     end
     
     def stop
-      EM.stop
+      EM.stop_server(@signature)
     end
   end
 end

data/lib/ftpmvc/test_helpers.rb

@@ -0,0 +1,30 @@
+require 'net/ftp'
+require 'ftpmvc/server'
+
+module FTPMVC
+  module TestHelpers
+    def with_application(app)
+      FTPMVC::Server.new('127.0.0.1', 0).start_in_new_thread(app) do |server|
+        begin
+          ftp = Net::FTP.new
+          begin
+            ftp.connect('127.0.0.1', server.port)
+            yield ftp
+          ensure
+            ftp.close
+          end
+        ensure
+          server.stop
+        end
+      end
+    end
+
+    def get(ftp, path)
+      ''.tap do |response|
+        ftp.retrbinary("RETR #{path}", 1024) do |block|
+          response << block
+        end
+      end
+    end
+  end
+end

data/lib/ftpmvc/version.rb

@@ -1,3 +1,3 @@
-module Ftpmvc
-  VERSION = "0.0.1"
+module FTPMVC
+  VERSION = "0.0.2"
 end

data/lib/ftpmvc.rb

@@ -3,5 +3,5 @@ require 'ftpmvc/server'
 require 'ftpmvc/file'
 require 'ftpmvc/application'
 
-module Ftpmvc
+module FTPMVC
 end

data/spec/integration/operation_spec.rb

@@ -0,0 +1,57 @@
+require './spec/spec_helper'
+require 'ftpmvc/application'
+
+describe 'Operation' do
+  before do
+    music_directory_class = Class.new(FTPMVC::Directory) do
+      def size(path)
+        69
+      end
+
+      def get(path)
+        StringIO.new('content')
+      end
+    end
+    stub_const 'MusicDirectory', music_directory_class
+  end
+  let(:app) do
+    FTPMVC::Application.new do
+      filesystem do
+        directory :music
+      end
+    end
+  end
+
+  describe 'LIST' do
+    it 'lists files and directories' do
+      with_application(app) do |ftp|
+        ftp.login
+        expect(ftp.list('/')).to include(/music/)
+      end
+    end
+  end
+  describe 'CHDIR' do
+    it 'checks if directory exists' do
+      with_application(app) do |ftp|
+        ftp.login
+        expect { ftp.chdir('/videos') }.to raise_error(Net::FTPPermError)
+      end
+    end
+  end
+  describe 'SIZE' do
+    it 'checks if directory exists' do
+      with_application(app) do |ftp|
+        ftp.login
+        expect(ftp.size('/music/pink_floyd.mp3')).to eq 69
+      end
+    end
+  end
+  describe 'GET' do
+    it 'checks if directory exists' do
+      with_application(app) do |ftp|
+        ftp.login
+        expect(get(ftp, '/music/pink_floyd.mp3')).to eq 'content'
+      end
+    end
+  end
+end

data/spec/lib/ftpmvc/access_filesystem_filter_spec.rb

@@ -1,3 +1,5 @@
+require './spec/spec_helper'
+
 require 'ftpmvc/access_filesystem_filter'
 require 'ftpmvc/file'
 

data/spec/lib/ftpmvc/application_spec.rb

@@ -1,3 +1,5 @@
+require './spec/spec_helper'
+
 require 'ftpmvc/application'
 require 'ftpmvc/file'
 

data/spec/lib/ftpmvc/directory_spec.rb

@@ -1,3 +1,5 @@
+require './spec/spec_helper'
+
 require 'ftpmvc/directory'
 require 'ftpmvc/file'
 

data/spec/lib/ftpmvc/server_spec.rb

@@ -1,3 +1,5 @@
+require './spec/spec_helper'
+
 require 'ftpmvc/server'
 
 describe FTPMVC::Server do
@@ -8,8 +10,8 @@ describe FTPMVC::Server do
         begin
           socket = TCPSocket.new('127.0.0.1', server.port)
           socket.close
-        rescue Errno::ECONNREFUSED, Errno::EADDRNOTAVAIL
-          fail 'Cannnot connect to server'
+        rescue Errno::ECONNREFUSED, Errno::EADDRNOTAVAIL => e
+          fail "Cannnot connect to server! (#{e.class}: #{e.message})"
         ensure
           server.stop
         end

data/spec/spec_helper.rb

@@ -0,0 +1,13 @@
+if ENV.include?('CODECLIMATE_REPO_TOKEN')
+  require "codeclimate-test-reporter"
+  CodeClimate::TestReporter.start
+end
+
+require 'ftpmvc/test_helpers'
+
+RSpec.configure do |config|
+  config.include FTPMVC::TestHelpers
+  config.before :each do
+    ActiveSupport::Dependencies.clear
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ftpmvc
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - André Aizim Kelmanson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-15 00:00:00.000000000 Z
+date: 2014-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: em-ftpd
   requirement: !ruby/object:Gem::Requirement
@@ -122,11 +136,14 @@ files:
 - lib/ftpmvc/file.rb
 - lib/ftpmvc/filter.rb
 - lib/ftpmvc/server.rb
+- lib/ftpmvc/test_helpers.rb
 - lib/ftpmvc/version.rb
+- spec/integration/operation_spec.rb
 - spec/lib/ftpmvc/access_filesystem_filter_spec.rb
 - spec/lib/ftpmvc/application_spec.rb
 - spec/lib/ftpmvc/directory_spec.rb
 - spec/lib/ftpmvc/server_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/investtools/ftpmvc
 licenses:
 - MIT
@@ -147,12 +164,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: FTP MVC framework
 test_files:
+- spec/integration/operation_spec.rb
 - spec/lib/ftpmvc/access_filesystem_filter_spec.rb
 - spec/lib/ftpmvc/application_spec.rb
 - spec/lib/ftpmvc/directory_spec.rb
 - spec/lib/ftpmvc/server_spec.rb
+- spec/spec_helper.rb