ft_gem 3.2.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c87e1b362c32c626bae277df5143edae9272ecd266f35385f1357f4e160afc56
-  data.tar.gz: 1b344e81360b00da689b46c280b9bd4e5c7e396f539dbe9164f9aaba75811d79
+  metadata.gz: 35400c0fa6a2f7640b62ae165101ed26afac0c10bcacdca9bc4d0adcef9b827b
+  data.tar.gz: c34b83cdd99f07730de5c3942cd6bcbf21ad49b72d48160824ade5f9f6e80880
 SHA512:
-  metadata.gz: 5b130653d438520557292a204f73369a791c724a4e1063e947e63a77dc4853315bbb889049785313f0a9eabb8e8fa15570e74e523fad5178db2a6f141e0c9e24
-  data.tar.gz: 341027d3da3318695a647480268aa71925caab0d1dfabc82b21e778cb8ada8fd2efb27ee8b8d28c37838623858c8d55c199c04c196c9925efd6b9c5d57e2a942
+  metadata.gz: 545f3a715845a5e452e6340d3d737fe23afb3843020490855c563a2e57a1e55802216ba9f05a312f2a709ee5e9ec5ee36d21aeba292f1414344afb64a6e8c4a4
+  data.tar.gz: c3eaf501b6837dffd80b1fd2d2455b66da2571333259c2d16e53e45c5afe7cb6203f60b283372cd20fc53fba6b20e41a05a267bfd6998d11da7f1383799fe85b

data/lib/ft_gem/controllers/helpers.rb

@@ -8,17 +8,20 @@ module FtGem
 
       def feature_toggle_status(name:, user_id: nil, url: nil)
         toggles = FtShared.new.all_toggles
-        update_feature_toggles(toggles: toggles)
-        decoded_cookie = Base64.decode64(cookies[TOGGLE_COOKIE_NAME])
         index = toggles.index { |toggle| toggle['attributes']['name'] == name }
         return false if index.nil?
-        client_percentage = calc_client_percentage(decoded_cookie: decoded_cookie, toggle_name: name)
-        toggle_percentage = toggles[index.to_i]['attributes']['percentage']
+
         whitelisted = FtShared.new.whitelisted?(url: url, whitelist_urls: toggles[index.to_i]['attributes']['whitelist-urls'])
 
-        return true && whitelisted if FtGem::Services::BetaService.public_beta?(cookie: cookies[PUBLICBETA_COOKIE_NAME],toggles: toggles, index: index)
+        return true && whitelisted if FtGem::Services::BetaService.public_beta?(cookie: Base64.decode64(cookies[PUBLICBETA_COOKIE_NAME]),toggles: toggles, index: index)
         return true && whitelisted if FtGem::Services::BetaService.private_beta?(user_id: user_id, toggles: toggles, index: index)
 
+        update_feature_toggles(toggles: toggles)
+        decoded_cookie = Base64.decode64(cookies[TOGGLE_COOKIE_NAME])
+
+        client_percentage = calc_client_percentage(decoded_cookie: decoded_cookie, toggle_name: name)
+        toggle_percentage = toggles[index.to_i]['attributes']['percentage']
+
         return client_percentage.to_i <= toggle_percentage.to_i && whitelisted
       rescue StandardError => e
         Rails.logger.error "FtGem::feature_toggle_status error #{e.backtrace}"

data/lib/ft_gem/services/beta_service.rb

@@ -7,6 +7,7 @@ module FtGem
 
         attributes = toggles[index.to_i].dig('attributes')
 
+        Rails.logger.info("########### PRIVATE BETA status: #{attributes['status']}, include users: #{attributes['beta-users'].split(",").include?(user_id.to_s)} ################")
         attributes['status'] == "privatebeta" && attributes['beta-users'].split(",").include?(user_id.to_s)
       end
 
@@ -14,7 +15,9 @@ module FtGem
         return false unless toggles.present?
 
         attributes = toggles.dig(index.to_i, 'attributes')
-        cookie == "true" && attributes['status'] == "publicbeta"
+
+        Rails.logger.info("########### PUBLIC BETA cookie: #{cookie}, status: #{attributes['status']} ################")
+        attributes['status'] == "publicbeta" && cookie == "true"
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ft_gem
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.1
 platform: ruby
 authors:
 - Murray Catto