fsck 0.0.3 → 0.0.4

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 0.0.4
+
+* alias the fscked methods instead of caching
+
 ### 0.0.3
 
 * better caching, better performance

data/Gemfile.lock

@@ -1,20 +1,20 @@
 PATH
   remote: .
   specs:
-    fsck (0.0.1)
+    fsck (0.0.4)
 
 GEM
   remote: http://rubygems.org/
   specs:
     diff-lcs (1.1.2)
-    rspec (2.3.0)
-      rspec-core (~> 2.3.0)
-      rspec-expectations (~> 2.3.0)
-      rspec-mocks (~> 2.3.0)
-    rspec-core (2.3.0)
-    rspec-expectations (2.3.0)
+    rspec (2.4.0)
+      rspec-core (~> 2.4.0)
+      rspec-expectations (~> 2.4.0)
+      rspec-mocks (~> 2.4.0)
+    rspec-core (2.4.0)
+    rspec-expectations (2.4.0)
       diff-lcs (~> 1.1.2)
-    rspec-mocks (2.3.0)
+    rspec-mocks (2.4.0)
 
 PLATFORMS
   ruby

data/README.md

@@ -50,9 +50,9 @@ Fsck also provides a way to use its functionality on every object in ruby.
     
 ## Fsck: How does it work?
 
-Fsck achieves its functionality by greatly abusing `method_missing`. Each time a fscked method is called, every method defined on the object is examined. The method with the longest name is assumed to be the *intended* method.
+Fsck achieves its functionality by tapping into `method_missing`. The first time a fscked method is called, every method defined on the object is examined. The method with the longest name is assumed to be the *intended* method, and the fscked method is aliased to this method.
 
-The examination process splits the word of each method name, building a regex that allows for any number of other words to be inserted wherever. If you aren't careful with the words you choose, you may unintentionally call another method.
+The examination process splits the word of each method name, building a regular expression that allows for any number of other words to be inserted anywhere in the method name. If you aren't careful with the words you choose, you may unintentionally call another method.
 
     # you may expect this to call #each, but it will instead call #each_value
     my_hash.what_i_need_is_each_set_of_key_plus_value { |k,v| puts k }
@@ -65,7 +65,7 @@ Fsck is named after the use of the Unix file system utility, specifically as it
 
 ## Disclaimer
 
-Your application will take a more than trivial performance hit if you use this gem. The benchmark I ran on Fixnum (bench.rb) shows that using a fscked method is roughly 20 times slower. This only tests the performance of repeated fscked method calls (which should be most common use). If you're dynamically building a fscked method call based on some variable, you can expect much worse performance. Use at your own risk.
+Because Fsck now uses method aliasing, there's only a slight performance hit on the first call to a fscked method. This should be inline with many other gems out there. Performance aside, using this gem will have quite an impact on the maintainability of your code. Use at your own risk.
 
 ## License
 MIT License. Copyright 2011 Chris Thorn.

data/bench.rb

@@ -5,11 +5,21 @@ require "fsck/deep"
 
 N = 1_000
 
-Benchmark.bm(10) do |r|
+Benchmark.bmbm(10) do |r|
   r.report("vanilla") { N.times { 42.succ } }
   r.report("fscked") { N.times { 42.gimme_succ_please } }
 end
 
+# v0.0.4
+# Rehearsal ---------------------------------------------
+# vanilla     0.000000   0.000000   0.000000 (  0.000163)
+# fscked      0.000000   0.000000   0.000000 (  0.003473)
+# ------------------------------------ total: 0.000000sec
+# 
+#                 user     system      total        real
+# vanilla     0.000000   0.000000   0.000000 (  0.000100)
+# fscked      0.000000   0.000000   0.000000 (  0.000199)
+
 # v0.0.3
 #                 user     system      total        real
 # vanilla     0.000000   0.000000   0.000000 (  0.000246)

data/fsck.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
 
   s.rubyforge_project = "fsck"
   
-  s.required_ruby_version = "~> 1.9.1"
+  s.required_ruby_version = "~> 1.9.2"
   
   s.add_development_dependency "rspec", "~> 2.3"
 

data/lib/fsck/version.rb

@@ -1,3 +1,3 @@
 module Fsck
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/fsck.rb

@@ -1,9 +1,5 @@
 module Fsck
   def method_missing(sym, *args, &block)
-    @_fsck_method_name_cache ||= {}
-    
-    return send(@_fsck_method_name_cache[sym], *args, &block) if @_fsck_method_name_cache[sym]
-    
     fscked_method = sym.to_s
     
     if punctuation = fscked_method[/[!?=]$/]
@@ -17,8 +13,10 @@ module Fsck
     if matches.empty?
       super
     else
-      @_fsck_method_name_cache[sym] = matches.sort_by(&:length).last
-      send(@_fsck_method_name_cache[sym], *args, &block)
+      method = matches.sort_by(&:length).last
+      target = singleton_methods.include?(method) ? singleton_class : self.class
+      target.class_exec { alias_method(sym, method) }
+      send(sym, *args, &block)
     end
   end
   

data/spec/fsck/fsck_spec.rb

@@ -52,4 +52,24 @@ describe Fsck do
       @obj.the_method_will_be_called?
     end
   end
+  
+  describe "aliasing" do
+    it "should alias method on the first call" do
+      @obj.stub(:the_method)
+      @obj.calling_the_method
+      @obj.methods.should include(:calling_the_method)
+    end
+    
+    it "should alias method defined in the class in the scope of the class" do
+      @obj.class.send(:define_method, :the_method) {}
+      @obj.calling_the_method
+      @obj.class.instance_methods(false).should include(:calling_the_method)
+    end
+    
+    it "should alias singleton method in the scope of the singleton" do
+      @obj.define_singleton_method(:sing_method) {}
+      @obj.calling_sing_method
+      @obj.sinlgeton_methods(false).should include(:calling_sing_method)
+    end
+  end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - Chris Thorn
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-06 00:00:00 -09:00
+date: 2011-01-08 00:00:00 -09:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -72,8 +72,8 @@ required_ruby_version: !ruby/object:Gem::Requirement
       segments: 
       - 1
       - 9
-      - 1
-      version: 1.9.1
+      - 2
+      version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: