fs_api 1.0.6 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fead9d0f81c3171c55762f7c924017bfc315ae80
-  data.tar.gz: f6240a493352f56a92f74241f5693388566edec0
+  metadata.gz: 737cb0adf3eea01f33d3c9d8add3dd65ef7db522
+  data.tar.gz: 3dc3f9e843cd3bbff5357f7cb6d31275289784f6
 SHA512:
-  metadata.gz: 0fa0061247b496217a9332440972e3b7d1dc241ad7377a785a7a799ae9b7c239333152cef27e4473f34cdf2bb45083b0bcacd9aeb096a4c425d592bf64cfc1fb
-  data.tar.gz: b3b77613271f8c7727ca153ee032714369d0a3fce10862efa8bfbc41d2d20c9087e777446958bf0b93685decd636c6d4b8fc07f1265c1480b1e9cdb9b2c0c74d
+  metadata.gz: 32b7ac069457409dee2860bd439c48bdd2f36f693b29f2f34859ed1faba04b9ba307bcc2257fc28051a88f0d55d5d66bedeb6cef064ffb6dfa9584a6b5285ab7
+  data.tar.gz: 9b418d1ae0870a62c94f6a3ed88673fc821f9fde6e0ec0e323507599b7d0d163374e15c6f2ff2ee968696000998310d3e96ada693f137ebe0d795383ba68f9b3

data/lib/fs_api/service/base_service.rb

@@ -28,6 +28,10 @@ module FsApi
         if response = @api_client.get([path,id].join('/'))
           if response.code.to_i == success_status_code
             json_response = JSON.parse(response.body)
+            # Weird case when nothing is found all clients are returned
+            # #find should only return a single record
+            return nil if json_response.is_a? Array
+            # Return instance
             collection_class.new(json_response[resource_type].merge(from_api: true))
           end
         end

data/lib/fs_api/version.rb

@@ -1,3 +1,3 @@
 module FsApi
-  VERSION = "1.0.6"
+  VERSION = "1.0.7"
 end

data/spec/lib/fs_api/service/invoice_spec.rb

@@ -8,7 +8,8 @@ describe FsApi::Service::Invoice do
 
   describe "retrieval" do
     it "retrieves all invoices" do
-      stub_request(:get, "https://username:api_key@www.factuursturen.nl/api/v1/invoices").to_return(body: [json_response(:invoice)].to_json )
+      stub_request(:get, "https://username:api_key@www.factuursturen.nl/api/v1/invoices")
+        .to_return(body: [json_response(:invoice)].to_json )
 
       invoices = service.all
 
@@ -17,7 +18,8 @@ describe FsApi::Service::Invoice do
     end
 
     it "retrieves all invoices with filter" do
-      stub_request(:get, "https://username:api_key@www.factuursturen.nl/api/v1/invoices?filter=overdue").to_return(body: [json_response(:invoice)].to_json )
+      stub_request(:get, "https://username:api_key@www.factuursturen.nl/api/v1/invoices?filter=overdue")
+        .to_return(body: [json_response(:invoice)].to_json )
 
       invoices = service.all(filter: :overdue)
 
@@ -26,12 +28,22 @@ describe FsApi::Service::Invoice do
     end
 
     it "retrieves a invoice" do
-      stub_request(:get, "https://username:api_key@www.factuursturen.nl/api/v1/invoices/20150001").to_return(body: { 'invoice' => json_response(:invoice)}.to_json )
+      stub_request(:get, "https://username:api_key@www.factuursturen.nl/api/v1/invoices/20150001")
+        .to_return(body: { 'invoice' => json_response(:invoice)}.to_json )
 
       invoice = service.find('20150001')
 
       expect(invoice.invoicenr).to eq 'F20150001'
     end
+
+    it "retrieves a invoice" do
+      stub_request(:get, "https://username:api_key@www.factuursturen.nl/api/v1/invoices/bogus").
+        to_return(body: [json_response(:invoice)].to_json )
+
+      invoice = service.find('bogus')
+
+      expect(invoice).to eq nil
+    end
   end
 
   describe "deletion" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fs_api
 version: !ruby/object:Gem::Version
-  version: 1.0.6
+  version: 1.0.7
 platform: ruby
 authors:
 - Maarten van Vliet