friendly_shipping 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2ecad34500f6b87c3aa381a2fe93a9f96d5203f1
-  data.tar.gz: 5c6483ad49ba4ff5cd705dbeb9d44efa3ec865e6
+  metadata.gz: c8c1f8749c1f3c1199a3ff41ec10d3a1d92f78dd
+  data.tar.gz: f22645471497c2e0350659b4d1dd9cb35e799f22
 SHA512:
-  metadata.gz: aeb1401d8bdbda932c92e5b79a9fb7d231e67eb3635210c64c53e90805fffd7a7e98056968289b44197874350543a658327b62d4e69a1d69974d385a6352cf6b
-  data.tar.gz: 52d31ae21c4878b3e95770f59bad92a7f51619b6fb10ebe03d3295a666b9497f79c2ceb1450d366ce3e2e2e45d03cb7c43e122928e7c34f79d702d7d7003e073
+  metadata.gz: fc5b536db417d7d087ae26a3121f61438b510b14b4fc8d94b13d3e25397f7e8f1e1b4c2cdaa18f13a4265c9aad1f6cdd1dcd6a3424bd6822d2ef8dc72a78cb7b
+  data.tar.gz: f65dd002fe51c318074e6d4ae841f56d80637f7997d1becfe935e4d75f0ccc9da0d7df8746abbc38d6851068490b21d8182e67d26b912f3a5cc0995855f2fde9

data/.circleci/config.yml

@@ -37,6 +37,10 @@ jobs:
             - ./vendor/bundle
           key: v1-dependencies-{{ checksum "Gemfile.lock" }}
 
+      - run:
+          name: run Rubocop
+          command: bundle exec rubocop
+
       # run tests!
       - run:
           name: run tests

data/.rubocop-relaxed.yml

@@ -0,0 +1,170 @@
+# Relaxed.Ruby.Style
+## Version 2.2
+
+Style/Alias:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylealias
+
+Style/AsciiComments:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleasciicomments
+
+Style/BeginBlock:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylebeginblock
+
+Style/BlockDelimiters:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleblockdelimiters
+
+Style/CommentAnnotation:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylecommentannotation
+
+Style/Documentation:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styledocumentation
+
+Layout/DotPosition:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#layoutdotposition
+
+Style/DoubleNegation:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styledoublenegation
+
+Style/EndBlock:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleendblock
+
+Style/FormatString:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleformatstring
+
+Style/IfUnlessModifier:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleifunlessmodifier
+
+Style/Lambda:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylelambda
+
+Style/ModuleFunction:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylemodulefunction
+
+Style/MultilineBlockChain:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylemultilineblockchain
+
+Style/NegatedIf:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylenegatedif
+
+Style/NegatedWhile:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylenegatedwhile
+
+Style/ParallelAssignment:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleparallelassignment
+
+Style/PercentLiteralDelimiters:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylepercentliteraldelimiters
+
+Style/PerlBackrefs:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styleperlbackrefs
+
+Style/Semicolon:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylesemicolon
+
+Style/SignalException:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylesignalexception
+
+Style/SingleLineBlockParams:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylesinglelineblockparams
+
+Style/SingleLineMethods:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylesinglelinemethods
+
+Layout/SpaceBeforeBlockBraces:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#layoutspacebeforeblockbraces
+
+Layout/SpaceInsideParens:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#layoutspaceinsideparens
+
+Style/SpecialGlobalVars:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylespecialglobalvars
+
+Style/StringLiterals:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylestringliterals
+
+Style/TrailingCommaInArguments:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styletrailingcommainarguments
+
+Style/TrailingCommaInArrayLiteral:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styletrailingcommainarrayliteral
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#styletrailingcommainhashliteral
+
+Style/SymbolArray:
+  Enabled: false
+  StyleGuide: http://relaxed.ruby.style/#stylesymbolarray
+
+Style/WhileUntilModifier:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylewhileuntilmodifier
+
+Style/WordArray:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#stylewordarray
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#lintambiguousregexpliteral
+
+Lint/AssignmentInCondition:
+  Enabled: false
+  StyleGuide: https://relaxed.ruby.style/#lintassignmentincondition
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockNesting:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+

data/.rubocop.yml

@@ -0,0 +1,8 @@
+AllCops:
+  TargetRubyVersion: 2.4
+
+inherit_from:
+- .rubocop-relaxed.yml
+
+Metrics/BlockLength:
+  Enabled: false

data/Gemfile

@@ -1,13 +1,16 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in friendly_shipping.gemspec
 gemspec
 
-gem 'vcr'
-gem 'webmock'
-gem 'pry'
 gem 'dotenv'
 gem 'factory_bot'
+gem 'pry'
 gem 'rspec_junit_formatter'
+gem 'rubocop'
+gem 'vcr'
+gem 'webmock'

data/Rakefile

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/setup"
 require "friendly_shipping"

data/friendly_shipping.gemspec

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "friendly_shipping/version"
 
@@ -21,11 +22,12 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "physical", "~> 0.3.0"
-  spec.add_runtime_dependency "rest-client", "~> 2.0"
-  spec.add_runtime_dependency "dry-monads", "~> 1.0"
   spec.add_runtime_dependency "data_uri", "~> 0.0.3"
+  spec.add_runtime_dependency "dry-monads", "~> 1.0"
   spec.add_runtime_dependency "money", ">= 6.0.0"
+  spec.add_runtime_dependency "nokogiri", ">= 1.6"
+  spec.add_runtime_dependency "physical", "~> 0.3.0"
+  spec.add_runtime_dependency "rest-client", "~> 2.0"
   spec.required_ruby_version = '>= 2.4'
 
   spec.add_development_dependency "bundler"

data/lib/friendly_shipping.rb

@@ -1,13 +1,17 @@
+# frozen_string_literal: true
+
 require "physical"
 
 require "friendly_shipping/version"
 require "friendly_shipping/request"
 require "friendly_shipping/response"
 require "friendly_shipping/carrier"
-require "friendly_shipping/services/ship_engine"
 require "friendly_shipping/shipping_method"
 require "friendly_shipping/label"
 require "friendly_shipping/rate"
 
+require "friendly_shipping/services/ship_engine"
+require "friendly_shipping/services/ups"
+
 module FriendlyShipping
 end

data/lib/friendly_shipping/bad_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module FriendlyShipping
@@ -16,7 +18,7 @@ module FriendlyShipping
       parsed_body = JSON.parse(response.body)
       messages = parsed_body.fetch('errors')&.map { |e| e.fetch('message') }
       messages&.join(', ')
-    rescue JSON::ParserError, KeyError => _error
+    rescue JSON::ParserError, KeyError => _e
       nil
     end
   end

data/lib/friendly_shipping/carrier.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FriendlyShipping
   class Carrier
     attr_reader :id, :name, :code, :shipping_methods, :balance, :data
@@ -10,5 +12,9 @@ module FriendlyShipping
       @balance = balance
       @data = data
     end
+
+    def ==(other)
+      id == other.id
+    end
   end
 end

data/lib/friendly_shipping/label.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FriendlyShipping
   class Label
     attr_reader :id,
@@ -13,18 +15,18 @@ module FriendlyShipping
                 :original_response
 
     def initialize(
-        id: nil,
-        shipment_id: nil,
-        tracking_number: nil,
-        service_code: nil,
-        label_href: nil,
-        label_format: nil,
-        label_data: nil,
-        shipment_cost: nil,
-        data: {},
-        original_request: nil,
-        original_response: nil
-      )
+      id: nil,
+      shipment_id: nil,
+      tracking_number: nil,
+      service_code: nil,
+      label_href: nil,
+      label_format: nil,
+      label_data: nil,
+      shipment_cost: nil,
+      data: {},
+      original_request: nil,
+      original_response: nil
+    )
       @id = id
       @shipment_id = shipment_id
       @tracking_number = tracking_number

data/lib/friendly_shipping/rate.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FriendlyShipping
   class Rate
     class NoAmountsGiven < StandardError; end
@@ -35,6 +37,7 @@ module FriendlyShipping
 
     def total_amount
       raise NoAmountsGiven if amounts.empty?
+
       amounts.map { |_name, amount| amount }.sum
     end
   end

data/lib/friendly_shipping/request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FriendlyShipping
   class Request
     attr_reader :url, :body, :headers

data/lib/friendly_shipping/response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FriendlyShipping
   class Response
     attr_reader :status, :body, :headers

data/lib/friendly_shipping/services/ship_engine.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 require 'dry/monads/result'
 require 'friendly_shipping/services/ship_engine/client'
@@ -15,9 +16,9 @@ module FriendlyShipping
       API_PATHS = {
         carriers: "carriers",
         labels: "labels"
-      }
+      }.freeze
 
-      def initialize(token:, test: true, client: self.class::Client)
+      def initialize(token:, test: true, client: Client)
         @token = token
         @test = test
         @client = client
@@ -36,11 +37,11 @@ module FriendlyShipping
       def rate_estimates(shipment, carriers)
         request = FriendlyShipping::Request.new(
           url: API_BASE + 'rates/estimate',
-          body: SerializeRateEstimateRequest.(shipment: shipment, carriers: carriers).to_json,
+          body: SerializeRateEstimateRequest.call(shipment: shipment, carriers: carriers).to_json,
           headers: request_headers
         )
         client.post(request).fmap do |response|
-          ParseRateEstimateResponse.(response: response, request: request, carriers: carriers)
+          ParseRateEstimateResponse.call(response: response, request: request, carriers: carriers)
         end
       end
 
@@ -51,7 +52,7 @@ module FriendlyShipping
           headers: request_headers
         )
         client.post(request).fmap do |response|
-          ParseLabelResponse.(request: request, response: response)
+          ParseLabelResponse.call(request: request, response: response)
         end
       end
 

data/lib/friendly_shipping/services/ship_engine/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'dry/monads/result'
 require 'friendly_shipping/bad_request'
 require 'rest-client'
@@ -14,8 +16,8 @@ module FriendlyShipping
             )
 
             Success(convert_to_friendly_response(http_response))
-          rescue ::RestClient::Exception => error
-            Failure(error)
+          rescue ::RestClient::Exception => e
+            Failure(e)
           end
 
           def post(friendly_shipping_request)
@@ -26,11 +28,11 @@ module FriendlyShipping
             )
 
             Success(convert_to_friendly_response(http_response))
-          rescue ::RestClient::Exception => error
-            if error.http_code == 400
-              Failure(BadRequest.new(error))
+          rescue ::RestClient::Exception => e
+            if e.http_code == 400
+              Failure(BadRequest.new(e))
             else
-              Failure(error)
+              Failure(e)
             end
           end
 
@@ -42,11 +44,11 @@ module FriendlyShipping
             )
 
             Success(convert_to_friendly_response(http_response))
-          rescue ::RestClient::Exception => error
-            if error.http_code == 400
-              Failure(BadRequest.new(error))
+          rescue ::RestClient::Exception => e
+            if e.http_code == 400
+              Failure(BadRequest.new(e))
             else
-              Failure(error)
+              Failure(e)
             end
           end
 

data/lib/friendly_shipping/services/ship_engine/parse_carrier_response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module FriendlyShipping
@@ -31,14 +33,14 @@ module FriendlyShipping
         private
 
         def parse_shipping_method(carrier, shipping_method_data)
-            FriendlyShipping::ShippingMethod.new(
-              carrier: carrier,
-              name: shipping_method_data["name"],
-              service_code: shipping_method_data["service_code"],
-              domestic: shipping_method_data["domestic"],
-              international: shipping_method_data["international"],
-              multi_package: shipping_method_data["is_multi_package_supported"]
-            )
+          FriendlyShipping::ShippingMethod.new(
+            carrier: carrier,
+            name: shipping_method_data["name"],
+            service_code: shipping_method_data["service_code"],
+            domestic: shipping_method_data["domestic"],
+            international: shipping_method_data["international"],
+            multi_package: shipping_method_data["is_multi_package_supported"]
+          )
         end
       end
     end

data/lib/friendly_shipping/services/ship_engine/parse_label_response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'data_uri'
 

data/lib/friendly_shipping/services/ship_engine/parse_rate_estimate_response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'money'
 
@@ -11,8 +13,10 @@ module FriendlyShipping
             parsed_json.map do |rate|
               carrier = carriers.detect { |c| c.id == rate['carrier_id'] }
               next unless carrier
+
               shipping_method = carrier.shipping_methods.detect { |sm| sm.service_code == rate['service_code'] }
               next unless shipping_method
+
               amounts = get_amounts(rate)
               FriendlyShipping::Rate.new(
                 shipping_method: shipping_method,

data/lib/friendly_shipping/services/ship_engine/parse_void_response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'friendly_shipping/bad_request'
 
 module FriendlyShipping

data/lib/friendly_shipping/services/ship_engine/serialize_label_shipment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FriendlyShipping
   module Services
     class ShipEngine
@@ -20,7 +22,7 @@ module FriendlyShipping
             }
           }
           if shipment.options[:carrier_id]
-            shipment_hash[:shipment].merge!(carrier_id: shipment.options[:carrier_id])
+            shipment_hash[:shipment][:carrier_id] = shipment.options[:carrier_id]
           end
           shipment_hash
         end
@@ -46,25 +48,23 @@ module FriendlyShipping
           packages.map do |package|
             package_hash = serialize_weight(package.weight)
             if package.container.properties[:usps_label_messages]
-              package_hash.merge!(label_messages: package.container.properties[:usps_label_messages])
+              package_hash[:label_messages] = package.container.properties[:usps_label_messages]
             end
             package_code = package.container.properties[:usps_package_code]
             if package_code
-              package_hash.merge!(package_code: package_code)
+              package_hash[:package_code] = package_code
             else
-              package_hash.merge!(
-                dimensions: {
-                  unit: 'inch',
-                  width: package.container.width.convert_to(:inches).value.to_f.round(2),
-                  length: package.container.length.convert_to(:inches).value.to_f.round(2),
-                  height: package.container.height.convert_to(:inches).value.to_f.round(2)
-                }
-              )
+              package_hash[:dimensions] = {
+                unit: 'inch',
+                width: package.container.width.convert_to(:inches).value.to_f.round(2),
+                length: package.container.length.convert_to(:inches).value.to_f.round(2),
+                height: package.container.height.convert_to(:inches).value.to_f.round(2)
+              }
             end
             package_hash
           end
         end
-        
+
         def serialize_weight(weight)
           ounces = weight.convert_to(:ounce).value.to_f
           {

data/lib/friendly_shipping/services/ship_engine/serialize_rate_estimate_request.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FriendlyShipping
   module Services
     class ShipEngine

data/lib/friendly_shipping/services/ups.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+require 'dry/monads/result'
+require 'friendly_shipping/services/ups/client'
+require 'friendly_shipping/services/ups/serialize_access_request'
+require 'friendly_shipping/services/ups/serialize_rating_service_selection_request'
+require 'friendly_shipping/services/ups/parse_rate_response'
+require 'friendly_shipping/services/ups/shipping_methods'
+
+module FriendlyShipping
+  module Services
+    class Ups
+      include Dry::Monads::Result::Mixin
+
+      attr_reader :test, :key, :login, :password, :client
+
+      CARRIER = FriendlyShipping::Carrier.new(
+        id: 'ups',
+        name: 'United Parcel Service',
+        code: 'ups',
+        shipping_methods: SHIPPING_METHODS
+      )
+
+      TEST_URL = 'https://wwwcie.ups.com'
+      LIVE_URL = 'https://onlinetools.ups.com'
+
+      RESOURCES = {
+        rates: '/ups.app/xml/Rate'
+      }.freeze
+
+      def initialize(key:, login:, password:, test: true, client: Client)
+        @key = key
+        @login = login
+        @password = password
+        @test = test
+        @client = client
+      end
+
+      def carriers
+        Success([CARRIER])
+      end
+
+      def rate_estimates(shipment, _carriers)
+        rate_request_xml = SerializeRatingServiceSelectionRequest.call(shipment: shipment)
+        url = base_url + RESOURCES[:rates]
+        request = FriendlyShipping::Request.new(
+          url: url,
+          body: access_request_xml + rate_request_xml
+        )
+
+        client.post(request).bind do |response|
+          ParseRateResponse.call(response: response, request: request, shipment: shipment)
+        end
+      end
+
+      private
+
+      def access_request_xml
+        SerializeAccessRequest.call(key: key, login: login, password: password)
+      end
+
+      def base_url
+        test ? TEST_URL : LIVE_URL
+      end
+    end
+  end
+end

data/lib/friendly_shipping/services/ups/client.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+require 'dry/monads/result'
+require 'friendly_shipping/bad_request'
+require 'rest-client'
+
+module FriendlyShipping
+  module Services
+    class Ups
+      class Client
+        extend Dry::Monads::Result::Mixin
+        class << self
+          def post(friendly_shipping_request)
+            http_response = ::RestClient.post(
+              friendly_shipping_request.url,
+              friendly_shipping_request.body,
+              friendly_shipping_request.headers
+            )
+
+            Success(convert_to_friendly_response(http_response))
+          rescue ::RestClient::Exception => e
+            Failure(e)
+          end
+
+          private
+
+          def convert_to_friendly_response(http_response)
+            FriendlyShipping::Response.new(
+              status: http_response.code,
+              body: http_response.body,
+              headers: http_response.headers
+            )
+          end
+        end
+      end
+    end
+  end
+end

data/lib/friendly_shipping/services/ups/parse_rate_response.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require 'friendly_shipping/services/ups/parse_xml_response'
+
+module FriendlyShipping
+  module Services
+    class Ups
+      class ParseRateResponse
+        def self.call(request:, response:, shipment:)
+          parsing_result = ParseXMLResponse.call(response.body, 'RatingServiceSelectionResponse')
+          parsing_result.fmap do |xml|
+            xml.root.css('> RatedShipment').map do |rated_shipment|
+              service_code = rated_shipment.at('Service/Code').text
+              shipping_method = CARRIER.shipping_methods.detect do |sm|
+                sm.service_code == service_code && shipment.origin.country.in?(sm.origin_countries)
+              end
+              days_to_delivery = rated_shipment.at('GuaranteedDaysToDelivery').text.to_i
+              currency = Money::Currency.new(rated_shipment.at('TotalCharges/CurrencyCode').text)
+              total_cents = rated_shipment.at('TotalCharges/MonetaryValue').text.to_d * currency.subunit_to_unit
+              insurance_price = rated_shipment.at('ServiceOptionsCharges/MonetaryValue').text.to_f
+              negotiated_rate = rated_shipment.at(
+                'NegotiatedRates/NetSummaryCharges/GrandTotal/MonetaryValue'
+              )&.text.to_f
+
+              FriendlyShipping::Rate.new(
+                shipping_method: shipping_method,
+                amounts: { total: Money.new(total_cents, currency) },
+                warnings: [rated_shipment.at("RatedShipmentWarning")&.text].compact,
+                errors: [],
+                data: {
+                  insurance_price: insurance_price,
+                  negotiated_rate: negotiated_rate,
+                  days_to_delivery: days_to_delivery
+                },
+                original_request: request,
+                original_response: response
+              )
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/friendly_shipping/services/ups/parse_xml_response.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module FriendlyShipping
+  module Services
+    class Ups
+      class ParseXMLResponse
+        extend Dry::Monads::Result::Mixin
+        SUCCESSFUL_RESPONSE_STATUS_CODE = '1'
+
+        class << self
+          def call(response_body, expected_root_tag)
+            xml = Nokogiri.XML(response_body)
+            if xml.root.nil? || xml.root.name != expected_root_tag
+              Failure('Invalid document')
+            end
+            if request_successful?(xml)
+              Success(xml)
+            else
+              Failure(error_message(xml))
+            end
+          rescue Nokogiri::XML::SyntaxError => e
+            Failure(e)
+          end
+
+          private
+
+          def request_successful?(xml)
+            xml.root.at('Response/ResponseStatusCode').text == SUCCESSFUL_RESPONSE_STATUS_CODE
+          end
+
+          def error_message(xml)
+            status = xml.root.at_xpath('Response/ResponseStatusDescription')&.text
+            desc = xml.root.at_xpath('Response/Error/ErrorDescription')&.text
+            [status, desc].compact.join(": ").presence || 'UPS could not process the request.'
+          end
+        end
+      end
+    end
+  end
+end

data/lib/friendly_shipping/services/ups/serialize_access_request.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'nokogiri'
+
+module FriendlyShipping
+  module Services
+    class Ups
+      class SerializeAccessRequest
+        def self.call(login:, password:, key:)
+          xml_builder = Nokogiri::XML::Builder.new do |xml|
+            xml.AccessRequest do
+              xml.AccessLicenseNumber(key)
+              xml.UserId(login)
+              xml.Password(password)
+            end
+          end
+          xml_builder.to_xml
+        end
+      end
+    end
+  end
+end

data/lib/friendly_shipping/services/ups/serialize_address_snippet.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+module FriendlyShipping
+  module Services
+    class Ups
+      class SerializeAddressSnippet
+        class << self
+          def call(xml:, location:)
+            if location.company_name # Is this a business address?
+              name = location.company_name[0..34]
+              attention_name = location.name
+            else
+              name = location.name
+              attention_name = nil
+            end
+
+            # UPS wants a different main Name tag when it's the shipper
+            if xml.parent.name == "Shipper"
+              xml.Name(name)
+            else
+              xml.CompanyName(name)
+            end
+
+            if attention_name
+              xml.AttentionName(attention_name)
+            end
+
+            xml.PhoneNumber(location.phone) if location.phone
+
+            xml.Address do
+              xml.AddressLine1(location.address1) if location.address1
+              xml.AddressLine2(location.address2) if location.address2
+
+              xml.City(location.city) if location.city
+              xml.PostalCode(location.zip) if location.zip
+
+              # StateProvinceCode required for negotiated rates but not otherwise, for some reason
+              xml.StateProvinceCode(location.region.code) if location.region
+              xml.CountryCode(location.country.code) if location.country
+
+              # Quote residential rates by default. If UPS doesn't know if the address is residential or
+              # commercial, it will quote a residential rate by default. Even with this flag being set,
+              # if UPS knows the address is commercial it will quote a commercial rate.
+              #
+              xml.ResidentialAddressIndicator
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/friendly_shipping/services/ups/serialize_package_node.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+module FriendlyShipping
+  module Services
+    class Ups
+      class SerializePackageNode
+        def self.call(xml:, package:)
+          xml.Package do
+            xml.PackagingType do
+              xml.Code('02')
+            end
+
+            if package.dimensions.all? { |dim| !dim.value.zero? && !dim.value.infinite? }
+              xml.Dimensions do
+                xml.UnitOfMeasurement do
+                  xml.Code('IN')
+                end
+                xml.Length(package.length.convert_to(:inches).value.to_f.round(3))
+                xml.Width(package.width.convert_to(:inches).value.to_f.round(3))
+                xml.Height(package.height.convert_to(:inches).value.to_f.round(3))
+              end
+            end
+
+            xml.PackageWeight do
+              xml.UnitOfMeasurement do
+                xml.Code('LBS')
+              end
+
+              xml.Weight([package.weight.convert_to(:pounds).value.to_f.round(2).ceil, 1].max)
+            end
+
+            if package.properties[:shipper_release]
+              xml.PackageServiceOptions do
+                xml.ShipperReleaseIndicator
+              end
+            end
+
+            Array.wrap(package.properties[:reference_numbers]).each do |reference_number_info|
+              xml.ReferenceNumber do
+                xml.Code(reference_number_info[:code] || "")
+                xml.Value(reference_number_info[:value])
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/friendly_shipping/services/ups/serialize_rating_service_selection_request.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+require 'nokogiri'
+require 'friendly_shipping/services/ups/serialize_address_snippet'
+require 'friendly_shipping/services/ups/serialize_package_node'
+
+module FriendlyShipping
+  module Services
+    class Ups
+      class SerializeRatingServiceSelectionRequest
+        PICKUP_CODES = HashWithIndifferentAccess.new(
+          daily_pickup: "01",
+          customer_counter: "03",
+          one_time_pickup: "06",
+          on_call_air: "07",
+          suggested_retail_rates: "11",
+          letter_center: "19",
+          air_service_center: "20"
+        )
+
+        CUSTOMER_CLASSIFICATIONS = HashWithIndifferentAccess.new(
+          shipper_number: "00",
+          daily_rates: "01",
+          retail_rates: "04",
+          regional_rates: "05",
+          general_rates: "06",
+          standard_rates: "53"
+        )
+
+        def self.call(shipment:)
+          shipper = shipment.options[:shipper] || shipment.origin
+          pickup_type = PICKUP_CODES[shipment.options[:pickup_type] || :daily_pickup]
+          customer_classification = CUSTOMER_CLASSIFICATIONS[
+            shipment.options[:customer_classification] || :daily_rates
+          ]
+          origin_account = shipment.options[:origin_account]
+          destination_account = shipment.options[:destination_account]
+
+          xml_builder = Nokogiri::XML::Builder.new do |xml|
+            xml.RatingServiceSelectionRequest do
+              xml.Request do
+                xml.RequestAction('Rate')
+                xml.RequestOption('Shop')
+                xml.SubVersion('1707')
+              end
+
+              xml.PickupType do
+                xml.Code(pickup_type)
+              end
+              xml.CustomerClassification do
+                xml.Code(customer_classification)
+              end
+
+              xml.Shipment do
+                # not implemented: Shipment/Description element
+                xml.Shipper do
+                  SerializeAddressSnippet.call(xml: xml, location: shipper)
+
+                  xml.ShipperNumber(origin_account)
+                end
+
+                xml.ShipTo do
+                  SerializeAddressSnippet.call(xml: xml, location: shipment.destination)
+
+                  if destination_account
+                    xml.ShipperAssignedIdentificationNumber(destination_account)
+                  end
+                end
+
+                if shipper != shipment.origin
+                  xml.ShipFrom do
+                    SerializeAddressSnippet.call(xml: xml, location: shipment.origin)
+                  end
+                end
+
+                shipment.packages.each do |package|
+                  SerializePackageNode.call(xml: xml, package: package)
+                end
+              end
+            end
+          end
+          xml_builder.to_xml
+        end
+      end
+    end
+  end
+end

data/lib/friendly_shipping/services/ups/shipping_methods.rb

@@ -0,0 +1,107 @@
+# frozen_string_literal: true
+
+module FriendlyShipping
+  module Services
+    class Ups
+      EU_COUNTRIES = %w(
+        AT BE BG CY CZ DE DK EE ES FI FR GB GR HR HU IE IT LT LU LV MT NL PO PT RO SE SI SK
+      ).map { |country_code| Carmen::Country.coded(country_code) }
+
+      class << self
+        private
+
+        def countries_by_code(code)
+          all_countries = Carmen::Country.all
+          covered_countries = EU_COUNTRIES + %w(US PR CA PL MX).map do |country_code|
+            Carmen::Country.coded(country_code)
+          end
+          other_countries = Carmen::Country.all - covered_countries
+          case code
+          when 'EU' then EU_COUNTRIES
+          when 'OTHER' then other_countries
+          when 'ALL' then all_countries
+          else
+            [Carmen::Country.coded(code)]
+          end
+        end
+      end
+
+      SHIPPING_METHODS = [
+        ['US', 'international', 'UPS Standard', '11'],
+        ['US', 'international', 'UPS Worldwide Express', '07'],
+        ['US', 'international', 'UPS Worldwide Expedited', '08'],
+        ['US', 'international', 'UPS Worldwide Express Plus', '54'],
+        ['US', 'international', 'UPS Worldwide Saver', '65'],
+        ['US', 'domestic', 'UPS 2nd Day Air', '02'],
+        ['US', 'domestic', 'UPS 2nd Day Air A.M.', '59'],
+        ['US', 'domestic', 'UPS 3 Day Select', '12'],
+        ['US', 'domestic', 'UPS Ground', '03'],
+        ['US', 'domestic', 'UPS Next Day Air', '01'],
+        ['US', 'domestic', 'UPS Next Day Air Early', '14'],
+        ['US', 'domestic', 'UPS Next Day Air Saver', '13'],
+        ['CA', 'domestic', 'UPS Expedited Canadian domestic shipments', '02'],
+        ['CA', 'domestic', 'UPS Express Saver Canadian domestic shipments', '13'],
+        ['CA', 'domestic', 'UPS 3 Day Select Shipments originating in Canada to CA and US 48', '12'],
+        ['CA', 'international', 'UPS 3 Day Select Shipments originating in Canada to CA and US 48', '12'],
+        ['CA', 'domestic', 'UPS Access Point Economy Canadian domestic shipments', '70'],
+        ['CA', 'domestic', 'UPS Express Canadian domestic shipments', '01'],
+        ['CA', 'domestic', 'UPS Express Early Canadian domestic shipments', '14'],
+        ['CA', 'international', 'UPS Express Saver International shipments originating in Canada', '65'],
+        ['CA', 'international', 'UPS Standard Shipments originating in Canada (Domestic and Int’l)', '11'],
+        ['CA', 'domestic', 'UPS Standard Shipments originating in Canada (Domestic and Int’l)', '11'],
+        ['CA', 'international', 'UPS Worldwide Expedited International shipments originating in Canada', '08'],
+        ['CA', 'international', 'UPS Worldwide Express International shipments originating in Canada', '07'],
+        ['CA', 'international', 'UPS Worldwide Express Plus International shipments originating in Canada', '54'],
+        ['CA', 'international', 'UPS Express Early Shipments originating in Canada to CA and US 48', '54'],
+        ['CA', 'domestic', 'UPS Express Early Shipments originating in Canada to CA and US 48', '54'],
+        ['EU', 'domestic', 'UPS Access Point Economy Shipments within the European Union', '70'],
+        ['EU', 'international', 'UPS Expedited Shipments originating in the European Union', '08'],
+        ['EU', 'international', 'UPS Express Shipments originating in the European Union', '07'],
+        ['EU', 'international', 'UPS Standard Shipments originating in the European Union', '11'],
+        ['EU', 'international', 'UPS Worldwide Express Plus Shipments originating in the European Union', '54'],
+        ['EU', 'international', 'UPS Worldwide Saver Shipments originating in the European Union', '65'],
+        ['MX', 'domestic', 'UPS Access Point Economy Shipments within Mexico', '70'],
+        ['MX', 'international', 'UPS Expedited Shipments originating in Mexico', '08'],
+        ['MX', 'international', 'UPS Express Shipments originating in Mexico', '07'],
+        ['MX', 'international', 'UPS Standard Shipments originating in Mexico', '11'],
+        ['MX', 'international', 'UPS Worldwide Express Plus Shipments originating in Mexico', '54'],
+        ['MX', 'international', 'UPS Worldwide Saver Shipments originating in Mexico', '65'],
+        ['PL', 'domestic', 'UPS Access Point Economy Polish domestic shipments', '70'],
+        ['PL', 'domestic', 'UPS Today Dedicated Courier Polish domestic shipments', '83'],
+        ['PL', 'domestic', 'UPS Today Express Polish domestic shipments', '85'],
+        ['PL', 'domestic', 'UPS Today Express Saver Polish domestic shipments', '86'],
+        ['PL', 'domestic', 'UPS Today Standard Polish domestic shipments', '82'],
+        ['PL', 'international', 'UPS Expedited Shipments originating in Poland', '08'],
+        ['PL', 'international', 'UPS Express Shipments originating in Poland', '07'],
+        ['PL', 'international', 'UPS Express Plus Shipments originating in Poland', '54'],
+        ['PL', 'international', 'UPS Express Saver Shipments originating in Poland', '65'],
+        ['PL', 'international', 'UPS Standard Shipments originating in Poland', '11'],
+        ['PR', 'domestic', 'UPS 2nd Day Air', '02'],
+        ['PR', 'domestic', 'UPS Ground', '03'],
+        ['PR', 'domestic', 'UPS Next Day Air', '01'],
+        ['PR', 'domestic', 'UPS Next Day Air Early', '14'],
+        ['PR', 'international', 'UPS Worldwide Expedited', '08'],
+        ['PR', 'international', 'UPS Worldwide Express', '07'],
+        ['PR', 'international', 'UPS Worldwide Express Plus', '54'],
+        ['PR', 'international', 'UPS Worldwide Saver', '65'],
+        ['DE', 'domestic', 'UPS Express 12:00 German domestic shipments', '74'],
+        ['OTHER', 'domestic', 'UPS Express', '07'],
+        ['OTHER', 'domestic', 'UPS Standard', '11'],
+        ['OTHER', 'international', 'UPS Worldwide Expedited', '08'],
+        ['OTHER', 'international', 'UPS Worldwide Express Plus', '54'],
+        ['OTHER', 'international', 'UPS Worldwide Saver', '65'],
+        ['ALL', 'international', 'UPS Worldwide Express Freight', '96'],
+        ['ALL', 'international', 'UPS Worldwide Express Freight Midday', '71']
+      ].freeze.map do |origin_country_code, dom_or_intl, name, code|
+        FriendlyShipping::ShippingMethod.new(
+          name: name,
+          service_code: code,
+          domestic: dom_or_intl == 'domestic',
+          international: dom_or_intl == 'international',
+          origin_countries: countries_by_code(origin_country_code),
+          multi_package: true
+        ).freeze
+      end
+    end
+  end
+end

data/lib/friendly_shipping/shipping_method.rb

@@ -1,14 +1,25 @@
+# frozen_string_literal: true
+
 module FriendlyShipping
   class ShippingMethod
-    attr_reader :name, :service_code, :carrier
+    attr_reader :name, :service_code, :carrier, :origin_countries
 
-    def initialize(name: nil, service_code: nil, domestic: nil, international: nil, multi_package: nil, carrier: nil)
+    def initialize(
+      name: nil,
+      service_code: nil,
+      domestic: nil,
+      international: nil,
+      multi_package: nil,
+      carrier: nil,
+      origin_countries: []
+    )
       @name = name
       @service_code = service_code
       @domestic = domestic
       @international = international
       @multi_package = multi_package
       @carrier = carrier
+      @origin_countries = origin_countries
     end
 
     def domestic?

data/lib/friendly_shipping/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module FriendlyShipping
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

metadata

@@ -1,85 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: friendly_shipping
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Martin Meyerhoff
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-27 00:00:00.000000000 Z
+date: 2019-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: physical
+  name: data_uri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: 0.0.3
 - !ruby/object:Gem::Dependency
-  name: rest-client
+  name: dry-monads
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: dry-monads
+  name: money
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 6.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 6.0.0
 - !ruby/object:Gem::Dependency
-  name: data_uri
+  name: nokogiri
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: physical
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: 0.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.3
+        version: 0.3.0
 - !ruby/object:Gem::Dependency
-  name: money
+  name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.0
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.0
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -132,6 +146,8 @@ files:
 - ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop-relaxed.yml"
+- ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -156,6 +172,15 @@ files:
 - lib/friendly_shipping/services/ship_engine/parse_void_response.rb
 - lib/friendly_shipping/services/ship_engine/serialize_label_shipment.rb
 - lib/friendly_shipping/services/ship_engine/serialize_rate_estimate_request.rb
+- lib/friendly_shipping/services/ups.rb
+- lib/friendly_shipping/services/ups/client.rb
+- lib/friendly_shipping/services/ups/parse_rate_response.rb
+- lib/friendly_shipping/services/ups/parse_xml_response.rb
+- lib/friendly_shipping/services/ups/serialize_access_request.rb
+- lib/friendly_shipping/services/ups/serialize_address_snippet.rb
+- lib/friendly_shipping/services/ups/serialize_package_node.rb
+- lib/friendly_shipping/services/ups/serialize_rating_service_selection_request.rb
+- lib/friendly_shipping/services/ups/shipping_methods.rb
 - lib/friendly_shipping/shipping_method.rb
 - lib/friendly_shipping/version.rb
 homepage: https://github.com/friendly_cart/friendly_shipping