friendly_numbers 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 433e9b8147e6f42996925ee4ac1d1f85700b262ec5ea9905c046bd68d7bfa59d
-  data.tar.gz: 8761157d53a90ac189e9af187cbea8a7e45feb4a947926c28bb09026e27845ee
+  metadata.gz: '028d287d00642a2c786fbb62ec6a0fedccf2eeaf9681f56534c0198cedc15eb5'
+  data.tar.gz: 530fc07161336d27363229ecaba23583380b2d3b982d71830756776833e38c7a
 SHA512:
-  metadata.gz: 1daf85daea83121b95608527169abac068464a65300e1ddcc33e958ea32d8d2cc1b06333acb652219ab409a2a3fc9d8339d04c5ab41fd9d2f026d66105f893c3
-  data.tar.gz: bfb873a0e78426deccd60b3e9c05ddf8199987558a36b439a4da93182530f9b444f108180f7a39cf9874769b33962e2431d3b41f5f3cd34cb18a3df78bf35879
+  metadata.gz: 9754a24bb0c90f62a3ab5a05a6bf56e6aa2323e2131df719a4e8e470fa3e40a0d0960bde100e2c76844845b49c61382254d7c6ae8a464c2f30c2fcaf7f4c8f51
+  data.tar.gz: 6ce33f8a3af5b5da17266703fab1452e2c38adb6f07e2d7155f6dccf34217cb63bf2bcf9db0032dcd2d5ae861fa93777c9fa5f67a66eb509427973336ab62e3e

data/.circleci/config.yml

@@ -3,33 +3,34 @@
 version: 2.0
 
 jobs:
-  "ruby-2.4":
+  "ruby-2.5":
     docker:
-      - image: circleci/ruby:2.4
+      - image: circleci/ruby:2.5
     steps:
       - checkout
-      - run: gem install bundler -v 1.13 --no-document
+      - run: gem install bundler -v "~> 2.0" --no-document
       - run: bundle install --path vendor/bundle
       - run:
           name: Run tests
           command: rake test
 
-  "ruby-2.5":
+  "ruby-2.6":
     docker:
-      - image: circleci/ruby:2.5
+      - image: circleci/ruby:2.6
     steps:
       - checkout
-      - run: gem install bundler -v 1.13 --no-document
+      - run: gem install bundler -v "~> 2.0" --no-document
       - run: bundle install --path vendor/bundle
       - run:
           name: Run tests
           command: rake test
 
-  "ruby-2.6":
+  "ruby-2.7":
     docker:
-      - image: circleci/ruby:2.6
+      - image: circleci/ruby:2.7
     steps:
       - checkout
+      - run: gem install bundler -v "~> 2.0" --no-document
       - run: bundle install --path vendor/bundle
       - run:
           name: Run tests
@@ -39,6 +40,6 @@ workflows:
   version: 2
   build:
     jobs:
-      - "ruby-2.4"
       - "ruby-2.5"
       - "ruby-2.6"
+      - "ruby-2.7"

data/.gitignore

@@ -1,6 +1,5 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
 /doc/

data/.rubocop.yml

@@ -0,0 +1,13 @@
+inherit_mode:
+  merge:
+    - Exclude
+
+require:
+  - rubocop-performance
+  - standard/cop/semantic_blocks
+
+inherit_gem:
+  standard: config/base.yml
+
+inherit_from:
+  - .rubocop_strict.yml

data/.rubocop_strict.yml

@@ -0,0 +1,6 @@
+inherit_from:
+  - .rubocop_todo.yml
+
+Lint/Debugger:
+  Enabled: true
+  Exclude: []

data/.rubocop_todo.yml

@@ -0,0 +1,69 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config --auto-gen-only-exclude`
+# on 2020-04-19 03:43:42 +0000 using RuboCop version 0.80.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterMagicComment:
+  Exclude:
+    - 'friendly_numbers.gemspec'
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
+Layout/ExtraSpacing:
+  Exclude:
+    - 'friendly_numbers.gemspec'
+    - 'lib/friendly_numbers/seconds_to_time.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
+# SupportedStyles: space, no_space, compact
+# SupportedStylesForEmptyBraces: space, no_space
+Layout/SpaceInsideHashLiteralBraces:
+  Exclude:
+    - 'test/seconds_to_time_test.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Encoding:
+  Exclude:
+    - 'friendly_numbers.gemspec'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
+# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
+Style/HashSyntax:
+  Exclude:
+    - 'Rakefile'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'friendly_numbers.gemspec'
+    - 'lib/friendly_numbers/number_to_human_size.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantPercentQ:
+  Exclude:
+    - 'friendly_numbers.gemspec'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'Gemfile'
+    - 'Rakefile'
+    - 'friendly_numbers.gemspec'
+    - 'test/test_helper.rb'

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # master
 
+# 0.6.0 (2020-05-14)
+- BREAKING: `number_to_currency` no longer rounds when truncating to precision
+- `number_to_currency` properly handles partitioning of larger negative numbers (#2)
+
 # 0.5.0 (2019-03-28)
 - Properly escape percent sign in percentage helper
 - Fix handling of whole numbers in currency helper

data/Gemfile

@@ -2,3 +2,8 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in friendly_numbers.gemspec
 gemspec
+
+gem "bundler"
+gem "rake"
+gem "minitest"
+gem "standard"

data/Gemfile.lock

@@ -0,0 +1,45 @@
+PATH
+  remote: .
+  specs:
+    friendly_numbers (0.6.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    ast (2.4.0)
+    jaro_winkler (1.5.4)
+    minitest (5.13.0)
+    parallel (1.19.1)
+    parser (2.7.1.1)
+      ast (~> 2.4.0)
+    rainbow (3.0.0)
+    rake (13.0.1)
+    rexml (3.2.4)
+    rubocop (0.80.1)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      rexml
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    rubocop-performance (1.5.2)
+      rubocop (>= 0.71.0)
+    ruby-progressbar (1.10.1)
+    standard (0.2.3)
+      rubocop (~> 0.80.1)
+      rubocop-performance (~> 1.5.2)
+    unicode-display_width (1.6.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bundler
+  friendly_numbers!
+  minitest
+  rake
+  standard
+
+BUNDLED WITH
+   2.1.4

data/friendly_numbers.gemspec

@@ -25,8 +25,4 @@ Gem::Specification.new do |spec|
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
-
-  spec.add_development_dependency "bundler", "~> 1.13"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "minitest", "~> 5.0"
 end

data/lib/friendly_numbers/number_to_currency.rb

@@ -11,23 +11,16 @@ module FriendlyNumbers
     def convert(value, options) # :nodoc:
       options = DEFAULTS.merge(options)
 
-      whole, part = value.divmod(1)
+      value = value.truncate(options[:precision]).to_f.to_s + ("0" * options[:precision].to_i)
+      whole, part = value.split(".", 2)
 
-      parted = partition(whole, options[:separator])
+      parted = whole.reverse.gsub(/...(?!-)(?=.)/, '\&,').reverse
 
       if options[:precision].nonzero?
-        decimal = sprintf("%.0#{options[:precision]}f", part.abs)[1..-1] # Strip leading 0
+        options[:unit] + parted + "." + part[0, options[:precision]]
+      else
+        options[:unit] + parted
       end
-
-      options[:unit] + parted + decimal.to_s
-    end
-
-    def partition(whole, separator)
-      whole.to_s.chars.reverse
-        .each_slice(3)
-        .map(&:join)
-        .join(separator)
-        .reverse
     end
   end
 end

data/lib/friendly_numbers/version.rb

@@ -1,3 +1,3 @@
 module FriendlyNumbers
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,57 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: friendly_numbers
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Adam Daniels
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-03-28 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.13'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.13'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
+date: 2020-05-14 00:00:00.000000000 Z
+dependencies: []
 description: |2
     Friendly number helpers without the mess. Working on a Roda or Sinatra application
     and want to format a number into a currency or friendly file size? Got you covered.
@@ -65,8 +23,12 @@ extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_strict.yml"
+- ".rubocop_todo.yml"
 - CHANGELOG.md
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -98,7 +60,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Friendly number helpers for your non-Rails/Padrino apps.