freddy 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bc5a587ccd4505868a43c8444abdbb376d30e124
-  data.tar.gz: f4f09ae1d1f046689e71245b9170cf9154fa0946
+  metadata.gz: 593764803da4d2ba342a36a9cffcdcaa7f4feefe
+  data.tar.gz: 9b0707d5cbb886ccd0a030112c9ff30c8ee2d7b0
 SHA512:
-  metadata.gz: c9e6c129c97c63e92abdb3449f127fdb3c64dcf6b73a385b3bd3acd57682f8d3ceb30850e3a38a3431cc7bd61408f2177db9f861547beed33ff58e9babc7b4ba
-  data.tar.gz: bdcc1cbb44b821cda0494177c326eab270f254e2c0cb8988bd620f3dbb221967788c2ec58bbe23c87f416fd2f85d4d9724e80d242868fb0c47662cce64a71ec9
+  metadata.gz: 2c738e2e59c211ead4fcfbdd347fe4fb6f457f77bc7809698a4f6988ca3ee15522d44ba0922c2fbf3e456e9353d3bfe5571899602ae08bc3e00d30d9dcec3b4c
+  data.tar.gz: 062fa84e713fd6591b7c26824139e452e2981b6eb53095fe5aa09342808ce8de2de2b6e5c72afeaacf5365ae257f3389b9b8e6afed88623371643cba6efd9217

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    freddy (0.3.4)
+    freddy (0.3.5)
       bunny (= 1.6.3)
       hamster (~> 1.0.1.pre.rc3)
       symbolizer

data/freddy.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "freddy"
-  spec.version       = '0.3.4'
+  spec.version       = '0.3.5'
   spec.authors       = ["Urmas Talimaa"]
   spec.email         = ["urmas.talimaa@gmail.com"]
   spec.description   = %q{Messaging API}

data/lib/freddy.rb

@@ -8,11 +8,22 @@ require_relative 'freddy/request'
 
 class Freddy
   class ErrorResponse < StandardError
+    DEFAULT_ERROR_MESSAGE = 'Use #response to get the error response'
+
     attr_reader :response
 
     def initialize(response)
       @response = response
-      super('Use #response to get the error response')
+      super(format_message(response) || DEFAULT_ERROR_MESSAGE)
+    end
+
+    private
+
+    def format_message(response)
+      return unless response.is_a?(Hash)
+
+      message = [response[:error], response[:message]].compact.join(': ')
+      message.empty? ? nil : message
     end
   end
 

data/spec/freddy/error_response_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe Freddy::ErrorResponse do
+  subject(:error) { described_class.new(input) }
+
+  context 'with an error type' do
+    let(:input) { {error: 'SomeError'} }
+
+    describe '#response' do
+      subject { error.response }
+
+      it { should eq(input) }
+    end
+
+    describe '#message' do
+      subject { error.message }
+
+      it 'uses error type as a message' do
+        should eq('SomeError')
+      end
+    end
+  end
+
+  context 'with an error type and message' do
+    let(:input) { {error: 'SomeError', message: 'extra info'} }
+
+    describe '#response' do
+      subject { error.response }
+
+      it { should eq(input) }
+    end
+
+    describe '#message' do
+      subject { error.message }
+
+      it 'uses error type as a message' do
+        should eq('SomeError: extra info')
+      end
+    end
+  end
+
+  context 'without an error type' do
+    let(:input) { {something: 'else'} }
+
+    describe '#response' do
+      subject { error.response }
+
+      it { should eq(input) }
+    end
+
+    describe '#message' do
+      subject { error.message }
+
+      it 'uses default error message as a message' do
+        should eq('Use #response to get the error response')
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: freddy
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Urmas Talimaa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-28 00:00:00.000000000 Z
+date: 2015-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -110,6 +110,7 @@ files:
 - lib/freddy/responder_handler.rb
 - lib/freddy/sync_response_container.rb
 - spec/freddy/consumer_spec.rb
+- spec/freddy/error_response_spec.rb
 - spec/freddy/freddy_spec.rb
 - spec/freddy/message_handler_spec.rb
 - spec/freddy/request_spec.rb
@@ -137,12 +138,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: API for inter-application messaging supporting acknowledgements and request-response
 test_files:
 - spec/freddy/consumer_spec.rb
+- spec/freddy/error_response_spec.rb
 - spec/freddy/freddy_spec.rb
 - spec/freddy/message_handler_spec.rb
 - spec/freddy/request_spec.rb