frameworks-capybara 0.2.22 → 0.2.23

data/CHANGES

@@ -1,13 +1,16 @@
+0.2.23
+Updated capybara-mechanize patch to send referer header.
+
 0.2.22
-Update Centos6 sandbox DNS to sandbox.bbc.co.uk
+Update Centos6 sandbox DNS to sandbox.bbc.co.uk.
 
 0.2.21
-Add support for Centos6 sandbox
-Update Gemfile.lock to latest gem versions
+Add support for Centos6 sandbox.
+Update Gemfile.lock to latest gem versions.
 
 0.2.20
-validate_online() now takes optional hash of parameters to pass to MarkupValidator
+validate_online() now takes optional hash of parameters to pass to MarkupValidator.
 Updated proxy handling to pick up port and to work without protocol or port. 
 
 0.2.19
-Present production release
+Present production release.

data/Gemfile

@@ -4,4 +4,6 @@ platforms :jruby do
   gem "jruby-openssl"
 end
 
+gem "rspec-mocks"
+
 gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    frameworks-capybara (0.2.22)
+    frameworks-capybara (0.2.23)
       capybara (>= 1.0.0)
       capybara-celerity
       capybara-mechanize (>= 0.3.0)
@@ -96,3 +96,4 @@ DEPENDENCIES
   jruby-openssl
   rake
   rspec (>= 1.0.0)
+  rspec-mocks

data/README.rdoc

@@ -80,8 +80,10 @@ Finally this gem contains some useful monkey-patches to core libraries e.g. Capy
 
 * Run tests - 'rake'
 * Bump version - manually update file in lib/version.rb
-* Run 'bundle install' to pick up new version in Gemfile
+* Run 'bundle install --binstubs --path vendor/to' bundle pick up new version in Gemfile
+* Commit 'Gemfile.lock' changes
 * Release - 'rake release'
+* Push new tag to Github 'git push --tags'
 
 == Contributing to frameworks-capybara
  

data/lib/monkey-patches/capybara-mechanize-patches.rb

@@ -2,6 +2,7 @@ require 'capybara/mechanize/cucumber'
 require 'uri'
 class Capybara::Mechanize::Browser
   #patch to remove catching all Mechanize exceptions (which are nice and specific) and throwing a useless RuntimeError
+  #patch to add Referer (Mechanize@0.3.0 won't add Referer for urls starting with http(s)://.)
   def process_remote_request(method, url, attributes, headers)
     if remote?(url)
       uri = URI.parse(url)
@@ -9,11 +10,23 @@ class Capybara::Mechanize::Browser
       @last_remote_uri = uri
       url = uri.to_s
 
+      referer = nil
+      referer_candidate = current_url
+      unless referer_candidate.empty? or (referer_candidate.start_with?('https://') and url.start_with?('http://'))
+        referer = referer_candidate
+      end
+
       reset_cache!
       args = []
       args << attributes unless attributes.empty?
       args << headers unless headers.empty?
-      @agent.send(method, url, *args)
+
+      if method == :get
+        agent.send(method, url, attributes, referer, headers)
+      else
+        agent.send(method, url, *args)
+      end
+
       @last_request_remote = true
     end
   end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module FrameworksCapybara
-  VERSION = '0.2.22'
+  VERSION = '0.2.23'
 end

data/spec/capybara_mechanize_patches_spec.rb

@@ -0,0 +1,124 @@
+require 'spec_helper'
+require 'rspec/mocks/mock'
+require 'uri'
+
+describe Capybara::Mechanize::Browser do
+
+  RSpec::Mocks::setup(self)
+
+  it "shouldn't send referer if unknown" do
+
+    agent = double()
+    agent.stub('get' => true)
+    agent.should_receive('get').with(
+      "http://example.bbc.co.uk/test",
+      {},
+      nil,
+      {}
+    )
+
+    driver = double("Capybara::Mechanize::Driver")
+    
+    browser = Capybara::Mechanize::Browser.new(driver)
+    browser.stub('current_url' => "")
+    browser.stub('agent' => agent)
+
+    browser.process_remote_request(:get, 'http://example.bbc.co.uk/test', {}, {})
+  end
+
+  it "should not change behaviour for POST requests" do
+
+    agent = double()
+    agent.stub('post' => true)
+    agent.should_receive('post').with("http://example.bbc.co.uk/test")
+
+    driver = double("Capybara::Mechanize::Driver")
+    
+    browser = Capybara::Mechanize::Browser.new(driver)
+    browser.stub('current_url' => "http://example.bbc.co.uk/blah")
+    browser.stub('agent' => agent)
+
+    browser.process_remote_request(:post, 'http://example.bbc.co.uk/test', {}, {})
+  end
+
+  it "should not send referer for requests from HTTPs to HTTP" do
+
+    agent = double()
+    agent.stub('get' => true)
+    agent.should_receive('get').with(
+      "http://example.bbc.co.uk/test",
+      {},
+      nil,
+      {}
+    )
+
+    driver = double("Capybara::Mechanize::Driver")
+    
+    browser = Capybara::Mechanize::Browser.new(driver)
+    browser.stub('current_url' => "https://example.bbc.co.uk/blah")
+    browser.stub('agent' => agent)
+
+    browser.process_remote_request(:get, 'http://example.bbc.co.uk/test', {}, {})
+  end
+
+  it "should send referer for requests from HTTP to HTTPs" do
+
+    agent = double()
+    agent.stub('get' => true)
+    agent.should_receive('get').with(
+      "https://example.bbc.co.uk/test",
+      {},
+      "http://example.bbc.co.uk/blah",
+      {}
+    )
+
+    driver = double("Capybara::Mechanize::Driver")
+    
+    browser = Capybara::Mechanize::Browser.new(driver)
+    browser.stub('current_url' => "http://example.bbc.co.uk/blah")
+    browser.stub('agent' => agent)
+
+    browser.process_remote_request(:get, 'https://example.bbc.co.uk/test', {}, {})
+  end
+
+  it "should send referer for requests from HTTP to HTTP" do
+
+    agent = double()
+    agent.stub('get' => true)
+    agent.should_receive('get').with(
+      "http://example.bbc.co.uk/test",
+      {},
+      "http://example.bbc.co.uk/blah",
+      {}
+    )
+
+    driver = double("Capybara::Mechanize::Driver")
+    
+    browser = Capybara::Mechanize::Browser.new(driver)
+    browser.stub('current_url' => "http://example.bbc.co.uk/blah")
+    browser.stub('agent' => agent)
+
+    browser.process_remote_request(:get, 'http://example.bbc.co.uk/test', {}, {})
+  end
+
+  it "should send referer for requests from HTTPs to HTTPs" do
+    
+    agent = double()
+    agent.stub('get' => true)
+    agent.should_receive('get').with(
+      "https://example.bbc.co.uk/test",
+      {},
+      "https://example.bbc.co.uk/blah",
+      {}
+    )
+
+    driver = double("Capybara::Mechanize::Driver")
+    
+    browser = Capybara::Mechanize::Browser.new(driver)
+    browser.stub('current_url' => "https://example.bbc.co.uk/blah")
+    browser.stub('agent' => agent)
+
+    browser.process_remote_request(:get, 'https://example.bbc.co.uk/test', {}, {})
+  end
+
+end

data/spec/spec_helper.rb

@@ -13,4 +13,5 @@ Cucumber::RbSupport::RbLanguage.new(Cucumber::Runtime.new) #Need to load Cucumbe
 
 require 'frameworks/capybara'
 require 'frameworks/cucumber'
+require 'monkey-patches/capybara-mechanize-patches'
 require 'unit_test_monkeypatches.rb'

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: frameworks-capybara
 version: !ruby/object:Gem::Version 
-  prerelease: false
+  hash: 57
+  prerelease: 
   segments: 
   - 0
   - 2
-  - 22
-  version: 0.2.22
+  - 23
+  version: 0.2.23
 platform: ruby
 authors: 
 - matt robbins
@@ -14,125 +15,142 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-03-04 00:00:00 +00:00
-default_executable: 
+date: 2013-03-13 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  type: :runtime
+  prerelease: false
+  name: capybara
   version_requirements: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 23
         segments: 
         - 1
         - 0
         - 0
         version: 1.0.0
-  name: capybara
   requirement: *id001
-  prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :runtime
+- !ruby/object:Gem::Dependency 
+  prerelease: false
+  name: capybara-mechanize
   version_requirements: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 19
         segments: 
         - 0
         - 3
         - 0
         version: 0.3.0
-  name: capybara-mechanize
   requirement: *id002
-  prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :runtime
+- !ruby/object:Gem::Dependency 
+  prerelease: false
+  name: json
   version_requirements: &id003 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
-  name: json
   requirement: *id003
-  prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :runtime
+- !ruby/object:Gem::Dependency 
+  prerelease: false
+  name: headless
   version_requirements: &id004 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
-  name: headless
   requirement: *id004
-  prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :runtime
+- !ruby/object:Gem::Dependency 
+  prerelease: false
+  name: capybara-celerity
   version_requirements: &id005 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
-  name: capybara-celerity
   requirement: *id005
-  prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :runtime
+- !ruby/object:Gem::Dependency 
+  prerelease: false
+  name: w3c_validators
   version_requirements: &id006 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
-  name: w3c_validators
   requirement: *id006
-  prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :runtime
+- !ruby/object:Gem::Dependency 
+  prerelease: false
+  name: cucumber
   version_requirements: &id007 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 61
         segments: 
         - 0
         - 10
         - 5
         version: 0.10.5
-  name: cucumber
   requirement: *id007
-  prerelease: false
+  type: :runtime
 - !ruby/object:Gem::Dependency 
-  type: :development
+  prerelease: false
+  name: rake
   version_requirements: &id008 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
-  name: rake
   requirement: *id008
-  prerelease: false
-- !ruby/object:Gem::Dependency 
   type: :development
+- !ruby/object:Gem::Dependency 
+  prerelease: false
+  name: rspec
   version_requirements: &id009 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 23
         segments: 
         - 1
         - 0
         - 0
         version: 1.0.0
-  name: rspec
   requirement: *id009
-  prerelease: false
+  type: :development
 description: Gem to ease the pain of managing capybara driver config and provide a home for common utils and patches
 email: 
 - mcrobbins@gmail.com
@@ -166,13 +184,13 @@ files:
 - lib/monkey-patches/webdriver-patches.rb
 - lib/tasks/frameworks-tasks.rb
 - lib/version.rb
+- spec/capybara_mechanize_patches_spec.rb
 - spec/frameworks_capybara_spec.rb
 - spec/frameworks_cucumber_spec.rb
 - spec/mock.default/prefs.js
 - spec/profiles.ini
 - spec/spec_helper.rb
 - spec/unit_test_monkeypatches.rb
-has_rdoc: true
 homepage: 
 licenses: []
 
@@ -182,23 +200,27 @@ rdoc_options: []
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Gem to ease the pain of managing capybara driver config and provide a home for common utils and patches