fountain 0.0.12 → 0.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 10955e573502a79fef0792e0784e42223e626ed0f0b203cf06545c75f2dacf8b
-  data.tar.gz: ee896766bc863df8d400b1285b8d0674e492ee46ea2c3c3d3b92dc2ff7d9b53e
+  metadata.gz: 5d78d33209aa2c3222155ea3643333a0df696466b1589d503adcaa28ded7aeea
+  data.tar.gz: 4a6ff22d217ee2cae43e6093fa218c450ea673924a71ffcec4bb2b9bd73ebc2b
 SHA512:
-  metadata.gz: 8f4a092974c4fbc79d573d7b989feb2082246ae5f9c334b2d1056c2f39415a1eddde341d34d5b57c7d4f0c828b1ecfef38f81d0f822da769eb53299fe6d7d6b8
-  data.tar.gz: d02cc7baaec15fd06a801b0c3fb7917b0a1a07ef3b4dbc9f4c2d91e9927edf5b3a44485df52cdba1f5c47a5a93e641baff5c8d6a3cf2f52000bfb06c1a43b41d
+  metadata.gz: 957fe69e2f9b464fe77bf245f4778e931d071febb8178e476de852c0beb606d2adf49aac0a7c2d1b6c8b926125fa3873f0d66f7119033994137437be0c366fee
+  data.tar.gz: e227563179603e1f2e571f22369616bdd3915e58cb8362f195101e53c63325002933d1cb3419eedd12cc476c1d449f639d9b8f235862509182754c5249c0e683

data/.rubocop.yml

@@ -1,11 +1,25 @@
+require:
+  - rubocop-rake
+  - rubocop-rspec
+
+AllCops:
+  NewCops: enable
+  TargetRubyVersion: 2.5
+
+Layout/LineLength:
+  Max: 120
+
 Metrics/BlockLength:
   Exclude:
     - "**/*_spec.rb"
 
-Metrics/LineLength:
-  Max: 120
-
 Metrics/MethodLength:
   Max: 15
   Exclude:
     - "**/*_spec.rb"
+
+RSpec/ExampleLength:
+  Max: 15
+
+RSpec/MultipleExpectations:
+  Max: 5

data/.travis.yml

@@ -5,11 +5,10 @@ env:
 language: ruby
 
 rvm:
-  - 2.1
-  - 2.2
-  - 2.3
-  - 2.4
   - 2.5
+  - 2.6
+  - 2.7
+  - 3.0
 
 before_install:
   - gem update bundler
@@ -24,7 +23,7 @@ before_script:
   - ./cc-test-reporter before-build
 
 script:
-  - rubocop
+  - bundle exec rubocop
   - bundle exec rake
 
 after_script:

data/fountain.gemspec

@@ -15,15 +15,17 @@ Gem::Specification.new do |spec|
   spec.description   = 'Fountain REST API v2 wrapper for Ruby'
   spec.homepage      = 'https://github.com/Studiosity/fountain-ruby'
   spec.license       = 'MIT'
+  spec.required_ruby_version = ['>= 2.5.0', '< 3.1.0']
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(spec|docs)/}) }
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.11'
   spec.add_development_dependency 'rake', '~> 12.3', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop', '~> 0.53'
+  spec.add_development_dependency 'rubocop', '~> 1.21'
+  spec.add_development_dependency 'rubocop-rake', '~> 0.6'
+  spec.add_development_dependency 'rubocop-rspec', '~> 2.5'
   spec.add_development_dependency 'simplecov', '~> 0.16'
   spec.add_development_dependency 'webmock', '~> 2.3'
 end

data/lib/fountain/api/applicants.rb

@@ -50,7 +50,7 @@ module Fountain
         response = request_json(
           '/v2/applicants',
           method: :post,
-          expected_response: Net::HTTPCreated,
+          expected_response: [Net::HTTPCreated, Net::HTTPOK],
           body: {
             name: name, email: email, phone_number: phone_number
           }.merge(filtered_params)

data/lib/fountain/api/notes.rb

@@ -26,7 +26,7 @@ module Fountain
         response = request_json(
           "/v2/applicants/#{applicant_id}/notes",
           method: :post,
-          expected_response: Net::HTTPCreated,
+          expected_response: [Net::HTTPCreated, Net::HTTPOK],
           body: { content: content }
         )
         Fountain::Note.new response

data/lib/fountain/api/request_helper.rb

@@ -40,7 +40,7 @@ module Fountain
       def check_response(response, expected_response = nil)
         expected_response ||= Net::HTTPOK
         case response
-        when expected_response then nil
+        when *[expected_response].flatten then nil
         when Net::HTTPUnauthorized then raise Fountain::AuthenticationError
         when Net::HTTPNotFound then raise Fountain::NotFoundError
         else raise HTTPError, "Invalid http response code: #{response.code}"
@@ -95,7 +95,7 @@ module Fountain
       end
 
       def create_get_request(path, headers, body)
-        path += '?' + body.map { |k, v| "#{k}=#{v}" }.join('&') if body
+        path += "?#{body.map { |k, v| "#{k}=#{v}" }.join('&')}" if body
         Net::HTTP::Get.new(path, headers)
       end
 

data/lib/fountain/gem_version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Fountain
-  VERSION = '0.0.12'
+  VERSION = '0.0.13'
 end

data/lib/fountain.rb

@@ -9,12 +9,19 @@ require 'fountain/util'
 
 module Fountain
   class Error < StandardError; end
+
   class HTTPError < Error; end
+
   class NotFoundError < HTTPError; end
+
   class AuthenticationError < HTTPError; end
+
   class InvalidMethodError < HTTPError; end
+
   class JsonParseError < Error; end
+
   class MissingApiKeyError < Error; end
+
   class StatusError < Error; end
 end
 

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: fountain
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.13
 platform: ruby
 authors:
 - abrom
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-01 00:00:00.000000000 Z
+date: 2021-09-24 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.11'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.11'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -64,14 +50,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.53'
+        version: '1.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.53'
+        version: '1.21'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -156,7 +170,10 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.0
+  - - "<"
+    - !ruby/object:Gem::Version
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="