fortytwoish 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c962bb192e01699aaa98d8831af0de165086508423bde7d58fe266c021260cf
-  data.tar.gz: 5d3596927c642abdf25bb1d338e67624dc26c3f41ba318aae96c330054137ee8
+  metadata.gz: 199bf04cb32a72f5e709d526f643f59af3b5ef073b37e749af136e673064686e
+  data.tar.gz: 6281f726836f484cab6088baccc3b8d413241a37958ff0e7b8900faa6b8ca356
 SHA512:
-  metadata.gz: 72c66f0d9acdeaebd5c795d023f7efba167bfb7505dd457184ce4ca13cb03c4e81bf88be8528c6148155b770a993036106f4cb9eb1450a2f60838d44eded3ce7
-  data.tar.gz: 49a1b623bdfb9e923240a066d18debe599d8893857eac9ccf139db6f6999c2ae09151d97fe9ec30ee5d9af605c25e9ed5f3e24ab49b1f5a6f66f09d5537327b5
+  metadata.gz: 5ea9ee50d9edbaae1fb5c376a2aa1e4b9c6d199a46a52ccca52ebcc61359217dd393e20740c5cc648559806221c81bc9469d41140ab6cd069f541598a6afd242
+  data.tar.gz: 9a082f0f10177244c80076a1685d65b80b29f16196dc3a62c758575075d68ab09aee4e669bd9761582ba281cb8ed6f0705271a134ba89267cd406d378b9468a3

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+# 0.4.0
+
+* Add response body to Client
+* Configuration class removed. Now you need to configure an instance of Client class
+
+# 0.3.0
+
+* Configurable encoding added

data/README.md

@@ -18,15 +18,15 @@ Or install it yourself as:
 
     $ gem install fortytwoish
 
-## Configuaration
+## Client
 
-You can configurate by adding this code to Rails initializer for example:
+You can create and configurate a client:
 
 ```ruby
-Fortytwoish.configure do |config|
-  config.token = 'XXX'
-  config.encoding = 'GSM7' # GSM7, UCS2, BINARY are available, GSM7 is default
-end
+client = Fortytwoish::Client.new(
+  token: 'XXX',
+  encoding: 'GSM7' # GSM7, UCS2, BINARY are available, GSM7 is default
+)
 ```
 
 ## Usage
@@ -34,9 +34,26 @@ end
 Here is example usage of this gem:
 
 ```ruby
-Fortytwoish::Client.new('15415553010', 'hello, world!').send
+if client.send('15415553010', 'hello, world!') != '200' # send returns '200' in case of success
+  puts client.response_body # response_body contains detail about failed sending
+end
 ```
 
+You can send a message to multiple numbers at the same time:
+
+```ruby
+numbers = %w[
+  15415553010
+  15415553011
+  15415553012
+]
+if client.send(numbers, 'hello, world!') != '200' # send returns '200' in case of success
+  puts client.response_body # response_body contains detail about failed sending
+end
+```
+
+*Note:* In case of multiple numbers sendout the results will be `fail` if at least one message failed.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
@@ -47,12 +64,6 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/RushPlay/fortytwoish.
 
-## Release notes
-
-### 0.3.0
-
-* Configurable encoding added
-
 ## License
 
 MIT

data/lib/fortytwoish.rb

@@ -1,18 +1,10 @@
 require 'fortytwoish/version'
 require 'fortytwoish/client'
-require 'fortytwoish/configuration'
 
 module Fortytwoish
-  def self.configuration
-    @configuration ||= Configuration.new
-  end
-
-  def self.reset_configuration
-    @configuration = nil
-  end
-
-  def self.configure
-    self.configuration ||= Configuration.new
-    yield(configuration)
-  end
+  ALLOWED_ENCODINGS = [
+    GSM7 = 'GSM7',
+    UCS2 = 'UCS2',
+    BINARY = 'BINARY'
+  ]
 end

data/lib/fortytwoish/client.rb

@@ -3,46 +3,45 @@ require 'json'
 
 module Fortytwoish
   class Client
-    def initialize(numbers, message)
-      @message = message
-      @numbers = Array(numbers)
+    attr_reader :response_body
+
+    def initialize(token:, encoding: GSM7)
+      @token = token
+      @encoding = encoding
     end
 
-    def send
-      response = send_message
+    def send(numbers, message)
+      response = send_message(numbers, message)
+      @response_body = response.body
       response.code
     end
 
     private
 
-    attr_reader :message, :numbers
-
-    def configuration
-      @configuration ||= Fortytwoish.configuration
-    end
+    attr_reader :token, :encoding
 
-    def send_message
+    def send_message(numbers, message)
       uri = URI 'https://rest.fortytwo.com/1/im'
-      request = build_request(uri)
+      request = build_request(uri, numbers, message)
       Net::HTTP.start(uri.host, uri.port, use_ssl: true) do |http|
         http.request request
       end
     end
 
-    def build_request(uri)
+    def build_request(uri, numbers, message)
       request = Net::HTTP::Post.new(uri.path)
       request['Content-Type'] = 'application/json; charset=utf-8'
-      request['Authorization'] = "Token #{configuration.token}"
-      request.body = body
+      request['Authorization'] = "Token #{token}"
+      request.body = body(numbers, message)
       request
     end
 
-    def body
+    def body(numbers, message)
       {
         destinations: numbers.map { |number| { number: number } },
         sms_content: {
           message: message,
-          encoding: configuration.encoding
+          encoding: encoding
         }
       }.to_json
     end

data/lib/fortytwoish/version.rb

@@ -1,3 +1,3 @@
 module Fortytwoish
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fortytwoish
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Davor Babić
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-12 00:00:00.000000000 Z
+date: 2018-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -76,6 +76,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -85,7 +86,6 @@ files:
 - fortytwoish.gemspec
 - lib/fortytwoish.rb
 - lib/fortytwoish/client.rb
-- lib/fortytwoish/configuration.rb
 - lib/fortytwoish/version.rb
 homepage: https://github.com/rushplay/fortytwoish
 licenses:

data/lib/fortytwoish/configuration.rb

@@ -1,21 +0,0 @@
-module Fortytwoish
-  ALLOWED_ENCODINGS = [
-    GSM7 = 'GSM7',
-    UCS2 = 'UCS2',
-    BINARY = 'BINARY'
-  ]
-
-  class Configuration
-    attr_accessor :token
-    attr_reader :encoding
-
-    def initialize
-      self.encoding = GSM7
-    end
-
-    def encoding=(new_encoding)
-      return unless ALLOWED_ENCODINGS.include?(new_encoding)
-      @encoding = new_encoding
-    end
-  end
-end