fortnox-api 0.7.2 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 707b9b050edd8499029c1f2120d11edc923e868847657eb0c108789014a5e3c8
-  data.tar.gz: 7da764b991529e720f3afbbb01433da52ca4f34800951b05c4f0f1e11f646c6a
+  metadata.gz: 02c5fbd6c659d3c6cc4e9ed8dfef6e739ded62fc33107623f4dddc13d33f6672
+  data.tar.gz: 14f0815a2fd32e98055d71ef231da2b6fac4b95ecfd9dfcda59b88d1c1445c63
 SHA512:
-  metadata.gz: 075e852a210ad2313fcf1c4469cb54a857016d46963e353679f16ea9e5daf09b28857491d9ccdc9b20c2a6843d7bc79093122db5419cf4219f1d830665af27b4
-  data.tar.gz: 35f8989ec19be2bf69c4f703daf54feb8b7d09e4c6bec95455c3483b23e4f8aa74547f781f2874c39d8903761feb769474bba0795ac2b3a21142a27b4ca706dc
+  metadata.gz: 293665ff9e0b860e88c7c6c78fbcfdd0b8a8047444f23cd0560d504442e1a0ac3439c52349413cac63e0c5973d1db74dabcf7ebdd9c10bc3f1b7de922db58cbc
+  data.tar.gz: 011b4785ce46af9c4cd57939431f6b09dc6ab44d650023616fe7b0784dcde890727999eb918ac3c3db311afaaff8785d240c54e5c30f198a630b9a1bf41483b7

data/.rubocop.yml

@@ -1,7 +1,7 @@
 require: rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.5
   DisplayCopNames: true
 
 RSpec/FilePath:

data/.travis.yml

@@ -3,16 +3,9 @@ env:
   - CC_TEST_REPORTER_ID=43ea0acb059b164537ce31bf67e03e1cb552d63df1ad3e9bd95dc3d844697bb4
 language: ruby
 rvm:
-- 2.4.0
-- 2.4.1
-- 2.4.2
-- 2.4.3
-- 2.4.6
-- 2.5.0
-- 2.5.5
-- 2.6.0
-- 2.6.3
-- 2.7.0-preview1
+- 2.5.8
+- 2.6.6
+- 2.7.1
 notifications:
   slack:
     secure: UEYDtwLaQgAoMRY7ct1y0Uu5HbInMwrLo+TiYRc3rjDrzqDfDyInEr3bpckyPJ79lnzccrFezMdY4jWzRjmsvQzvYMu+DWJ1mAWOa/9Ws4YZ8nHd5KqXxVQ0EqPWuWwMOyOdyy3DK/MjUOobGSc0//Pv5DeaAAEBKLJzN+e1BQM=

data/CHANGELOG.md

@@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [0.8.0]
+### Changed
+- `Fortnox::API::CURRENT_HOUSEWORK_TYPES` is now renamed to `HOUSEWORK_TYPES`
+  and is instead a Hash with keys for the different categories of types.
+  It also includes legacy types, which means `Fortnox::API::LEGACY_HOUSEWORK_TYPES` is removed.
+
+### Removed
+- Drops support for Ruby < `2.5.0` since they are deprecated
+
 ## [0.7.2]
 ### Fixed
 - Invalid validation for Customer's account number attribute
@@ -32,6 +41,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Fixed
 - Model attribute `url` is no longer null
 
+[0.8.0]: https://github.com/accodeing/fortnox-api/compare/v0.7.2...v0.8.0
 [0.7.2]: https://github.com/accodeing/fortnox-api/compare/v0.7.1...v0.7.2
 [0.7.1]: https://github.com/accodeing/fortnox-api/compare/v0.7.0...v0.7.1
 [0.7.0]: https://github.com/accodeing/fortnox-api/compare/v0.6.3...v0.7.0

data/README.md

@@ -10,14 +10,13 @@
 [![Maintainability](https://api.codeclimate.com/v1/badges/89d30a43fedf210d470b/maintainability)](https://codeclimate.com/github/accodeing/fortnox-api/maintainability)
 [![Test Coverage](https://api.codeclimate.com/v1/badges/89d30a43fedf210d470b/test_coverage)](https://codeclimate.com/github/accodeing/fortnox-api/test_coverage)
 
-The rough status of this project is as follows (as of October 2018):
+The rough status of this project is as follows (as of December 2020):
 * Development is not as active as it used to be, but the project is not forgotten. We have an app running this gem in production and it works like a charm for what we do.
-* We are planning on generalize REST API's in general with our [rest_easy gem](https://github.com/accodeing/rest_easy).
+* We hope to be able to continue with our work with [rest_easy gem](https://github.com/accodeing/rest_easy), which generalize REST API's in general.
 * Basic structure complete. Things like getting customers and invoices, updating and saving etc.
 * Some advanced features implemented, for instance support for multiple Access Tokens and filtering entities.
 * We have ideas for more advanced features, like sorting entities, pagination of results but nothing in the pipeline right now.
 * A few models implemented. Right now we pretty good support for `Customer`, `Invoice`, `Order`, `Article`, `Label` and `Project`. Adding more models in general is quick and easy (that's the whole point with this gem), see the developer guide further down.
-* Massive refactorings no longer occurs weekly :)
 
 # Architecture overview
 The gem is structured with distinct models for the tasks of data, JSON mapping and saving state. These are called: model, type, mapper and repository.
@@ -81,7 +80,7 @@ These are responsible for the mapping between our plain old Ruby object models a
 
 # Requirements
 
-This gem is build for Ruby 2.4 or higher (see Travis configuration file for what versions we are testing against).
+This gem is built for Ruby 2.5 or higher (see Travis configuration file for what versions we are testing against).
 
 ## Installation
 
@@ -191,5 +190,9 @@ updated_customer.name #=> "Ned Stark"
 
 The update method takes an implicit hash of attributes to update, so you can update as many as you like in one go.
 
+# Development
+## Testing
+This gem has integration tests to verify the code against the real API. It uses [vcr](https://github.com/vcr/vcr) to record API endpoint responses. These responses are stored locally and are called vcr cassettes. If no cassettes are available, vcr will record new ones for you. Once in a while, it's good to throw away all cassettes and rerecord them. Fortnox updates their endpoints and we need to keep our code up to date with the reality. There's a handy rake task for removing all cassettes, see `rake -T`. Note that when rerecording all cassettes, do it one repository at a time, otherwise you'll definitely get `429 Too Many Requests` from Fortnox. Run them manually with something like `bundle exec rspec spec/fortnox/api/repositories/article_spec.rb`. Also, you will need to update some test data in specs, see notes in specs.
+
 # Contributing
 See the [CONTRIBUTE](CONTRIBUTE.md) readme.

data/Rakefile

@@ -5,3 +5,8 @@ require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
 
 task default: :spec
+
+desc 'Remove all VCR cassettes so we can rerecord them'
+task :throw_vcr_cassettes do
+  FileUtils.rm_rf(Dir.glob('spec/vcr_cassettes/**'))
+end

data/fortnox-api.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
   spec.test_files    = spec.files.grep(%r{^(spec)/})
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.4'
+  spec.required_ruby_version = '>= 2.5'
   spec.add_dependency 'countries', '~> 3.0'
   spec.add_dependency 'dry-struct', '~> 0.1'
   spec.add_dependency 'dry-types', '~> 0.8', '< 0.13.0'
@@ -33,7 +33,7 @@ Gem::Specification.new do |spec| # rubocop:disable Metrics/BlockLength
   spec.add_development_dependency 'guard', '~> 2.12'
   spec.add_development_dependency 'guard-rspec', '~> 4.5'
   spec.add_development_dependency 'pry', '~> 0'
-  spec.add_development_dependency 'rake', '~> 10.4'
+  spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.2'
   spec.add_development_dependency 'rspec-collection_matchers', '~> 0'
   spec.add_development_dependency 'rubocop', '~> 0.52.0'

data/lib/fortnox/api/mappers/base/from_json.rb

@@ -72,8 +72,8 @@ module Fortnox
 
         def default_key_from_json_transform(key)
           key = key.to_s
-          key = camelcase_to_underscore(key) unless key =~ /\A[A-Z]+\z/
-          key = strip_at_symbol(key) if key =~ /\A@.*\z/
+          key = camelcase_to_underscore(key) unless key.match?(/\A[A-Z]+\z/)
+          key = strip_at_symbol(key) if key.match?(/\A@.*\z/)
           key.downcase.to_sym
         end
 

data/lib/fortnox/api/models/document.rb

@@ -154,6 +154,9 @@ module Fortnox
         # TaxReduction The amount of tax reduction.
         attribute :tax_reduction, Types::Nullable::Integer.is(:read_only)
 
+        # TaxReductionType Tax Reduction Type
+        attribute :tax_reduction_type, Types::TaxReductionType
+
         # TermsOfDelivery Code of the terms of delivery.
         attribute :terms_of_delivery, Types::Nullable::String
 

data/lib/fortnox/api/types.rb

@@ -57,7 +57,7 @@ module Fortnox
                   next value if value.nil? || value == ''
 
                   # Fortnox only supports Swedish translation of Sweden
-                  next CountryString.new('SE') if value =~ /^s(e$|we|ve)/i
+                  next CountryString.new('SE') if value.match?(/^s(e$|we|ve)/i)
 
                   country = ::ISO3166::Country[value] ||
                             ::ISO3166::Country.find_country_by_name(value) ||
@@ -119,6 +119,11 @@ module Fortnox
                           .optional
                           .constructor(EnumConstructors.default)
 
+      TaxReductionType = Strict::String
+                         .constrained(included_in: TaxReductionTypes.values)
+                         .optional
+                         .constructor(EnumConstructors.lower_case)
+
       require 'fortnox/api/types/model'
       require 'fortnox/api/types/default_delivery_types'
       require 'fortnox/api/types/default_templates'

data/lib/fortnox/api/types/enums.rb

@@ -17,6 +17,13 @@ module Fortnox
             value.to_s.upcase unless value.nil?
           end
         end
+
+        def self.lower_case
+          lambda do |value|
+            return nil if value == ''
+            value.to_s.downcase unless value.nil?
+          end
+        end
       end
 
       ArticleTypes = Types::Strict::String.enum(
@@ -25,15 +32,31 @@ module Fortnox
       DiscountTypes = Types::Strict::String.enum(
         'AMOUNT', 'PERCENT'
       )
-      CURRENT_HOUSEWORK_TYPES = %w[
-        CONSTRUCTION ELECTRICITY GLASSMETALWORK GROUNDDRAINAGEWORK
-        MASONRY PAINTINGWALLPAPERING HVAC MAJORAPPLIANCEREPAIR
-        MOVINGSERVICES ITSERVICES CLEANING TEXTILECLOTHING
-        SNOWPLOWING GARDENING BABYSITTING OTHERCARE OTHERCOSTS
-      ].freeze
-      LEGACY_HOUSEWORK_TYPES = %w[COOKING TUTORING].freeze
+      HOUSEWORK_TYPES = {
+        rot: %w[
+          CONSTRUCTION ELECTRICITY GLASSMETALWORK GROUNDDRAINAGEWORK
+          MASONRY PAINTINGWALLPAPERING HVAC OTHERCOSTS
+        ],
+        rut: %w[
+          MAJORAPPLIANCEREPAIR MOVINGSERVICES ITSERVICES CLEANING
+          TEXTILECLOTHING SNOWPLOWING GARDENING BABYSITTING OTHERCARE
+          OTHERCOSTS
+        ],
+        legacy_rut: %w[COOKING TUTORING]
+      }.freeze
+
+      # TODO: RUT to be added:
+      # HOMEMAINTENANCE FURNISHING TRANSPORTATIONSERVICES
+      # WASHINGANDCAREOFCLOTHING
+      #
+      # TODO: GREEN to be added:
+      # SOLARCELLS STORAGESELFPRODUCEDELECTRICTY
+      # CHARGINGSTATIONELECTRICVEHICLE OTHERCOSTS
+
       HouseworkTypes = Types::Strict::String.enum(
-        *(CURRENT_HOUSEWORK_TYPES + LEGACY_HOUSEWORK_TYPES)
+        *(HOUSEWORK_TYPES[:rot] +
+          HOUSEWORK_TYPES[:rut] +
+          HOUSEWORK_TYPES[:legacy_rut]).uniq
       )
       Currencies = Types::Strict::String.enum(
         'AED', 'AFN', 'ALL', 'AMD', 'ANG', 'AOA', 'ARS', 'AUD', 'AWG', 'AZN',
@@ -67,6 +90,11 @@ module Fortnox
       ProjectStatusTypes = Types::Strict::String.enum(
         'NOTSTARTED', 'ONGOING', 'COMPLETED'
       )
+      # NOTE: Yes, these needs to be in lower case...
+      # I know, this is stupid... Fortnox: why?!
+      TaxReductionTypes = Types::Strict::String.enum(
+        'rot', 'rut', 'green', 'none'
+      )
     end
   end
 end

data/lib/fortnox/api/version.rb

@@ -2,6 +2,6 @@
 
 module Fortnox
   module API
-    VERSION = '0.7.2'
+    VERSION = '0.8.0'
   end
 end

data/spec/fortnox/api/circular_queue_spec.rb

@@ -6,11 +6,11 @@ require 'fortnox/api/circular_queue'
 describe Fortnox::API::CircularQueue do
   describe 'start index' do
     context 'when running several times' do
+      subject { Set.new(samples).size }
+
       let(:test_array) { (0..99).to_a }
       let(:samples) { Array.new(100) { described_class.new(*test_array).next } }
 
-      subject { Set.new(samples).size }
-
       # NOTE: This test is not perfect. We are testing that a random generator
       # with 100 items to choose from does not choose the same item 100 times in a row.
       # Yes, the possibility is low, but I thought I should just mention it :)
@@ -22,7 +22,7 @@ describe Fortnox::API::CircularQueue do
 
   describe '#next' do
     context 'when several items in queue' do
-      let(:queue) { described_class.new(1,2,3) }
+      let(:queue) { described_class.new(1, 2, 3) }
       let(:first_round) { Array.new(3) { queue.next } }
       let(:second_round) { Array.new(3) { queue.next } }
 

data/spec/fortnox/api/repositories/article_spec.rb

@@ -27,7 +27,7 @@ describe Fortnox::API::Repository::Article, order: :defined, integration: true d
                    '5901234123457'
 
   # When recording new VCR cassettes, expected matches must be increased
-  include_examples '.all', 26
+  include_examples '.all', 29
 
   # When recording new VCR cassettes, expected matches must be increased
   include_examples '.find', '1' do

data/spec/fortnox/api/repositories/customer_spec.rb

@@ -39,7 +39,7 @@ describe Fortnox::API::Repository::Customer, order: :defined, integration: true
   end
 
   # When recording new VCR casettes, expected matches must be increased
-  include_examples '.search', :name, 'Test', 30
+  include_examples '.search', :name, 'Test', 31
 
   describe 'country reference' do
     describe 'with valid country code \'SE\'' do

data/spec/fortnox/api/repositories/invoice_spec.rb

@@ -37,7 +37,7 @@ describe Fortnox::API::Repository::Invoice, order: :defined, integration: true d
 
   # It is not possible to delete Invoces. Therefore, expected nr of Orders
   # when running .all will continue to increase (until 100, which is max by default).
-  include_examples '.all', 97
+  include_examples '.all', 100
 
   include_examples '.find', 1 do
     let(:find_by_hash_failure) { { yourreference: 'Not found' } }
@@ -129,27 +129,27 @@ describe Fortnox::API::Repository::Invoice, order: :defined, integration: true d
 
       before { persisted_invoice }
 
-      context 'by setting value to nil' do
+      context 'when setting value to nil' do
+        subject { updated_persisted_invoice.comments }
+
         let(:updated_persisted_invoice) do
           VCR.use_cassette("#{vcr_dir}/save_old_with_nil_comments") do
             repository.save(persisted_invoice.update(comments: nil))
           end
         end
 
-        subject { updated_persisted_invoice.comments }
-
         pending { is_expected.to eq(nil) }
       end
 
-      context 'by setting value to empty string' do
+      context 'when setting value to empty string' do
+        subject { updated_persisted_invoice.comments }
+
         let(:updated_persisted_invoice) do
           VCR.use_cassette("#{vcr_dir}/save_old_with_empty_comments") do
             repository.save(persisted_invoice.update(comments: ''))
           end
         end
 
-        subject { updated_persisted_invoice.comments }
-
         it 'does not reset the value' do
           is_expected.to eq('A comment to be reset')
         end
@@ -169,7 +169,9 @@ describe Fortnox::API::Repository::Invoice, order: :defined, integration: true d
 
       before { persisted_invoice }
 
-      context 'by setting value to nil' do
+      context 'when setting value to nil' do
+        subject { updated_persisted_invoice.country }
+
         let(:updated_persisted_invoice) do
           # TODO: This VCR cassette needs to be re-recorded again
           # when the we fix #172.
@@ -178,20 +180,18 @@ describe Fortnox::API::Repository::Invoice, order: :defined, integration: true d
           end
         end
 
-        subject { updated_persisted_invoice.country }
-
         pending { is_expected.to eq(nil) }
       end
 
-      context 'by setting value to empty string' do
+      context 'when setting value to empty string' do
+        subject { updated_persisted_invoice.country }
+
         let(:updated_persisted_invoice) do
           VCR.use_cassette("#{vcr_dir}/save_old_with_empty_country") do
             repository.save(persisted_invoice.update(country: ''))
           end
         end
 
-        subject { updated_persisted_invoice.country }
-
         it 'does not reset the country' do
           is_expected.to eq('SE')
         end

data/spec/fortnox/api/repositories/project_spec.rb

@@ -22,7 +22,7 @@ describe Fortnox::API::Repository::Project, order: :defined, integration: true d
   # It is not yet possible to delete Projects. Therefore, expected nr of
   # Projects when running .all will continue to increase
   # (until 100, which is max by default).
-  include_examples '.all', 31
+  include_examples '.all', 33
 
   include_examples '.find', '1' do
     let(:find_by_hash_failure) { { offset: 10_000 } }

data/spec/fortnox/api/repositories/terms_of_payment_spec.rb

@@ -18,12 +18,12 @@ describe Fortnox::API::Repository::TermsOfPayment, order: :defined, integration:
   before { set_api_test_configuration }
 
   # When recording new VCR cassettes, code must be changed to a new unique one
-  required_hash = { code: '18DAYS' }
+  required_hash = { code: '19DAYS' }
 
   include_examples '.save', :description, additional_attrs: required_hash
 
   # When recording new VCR cassettes, expected matches needs to be increased
-  include_examples '.all', 12
+  include_examples '.all', 13
 
   include_examples '.find', '15DAYS', find_by_hash: false do
     let(:find_by_hash_failure) { { code: '15days' } }

data/spec/fortnox/api/repositories/unit_spec.rb

@@ -19,16 +19,16 @@ describe Fortnox::API::Repository::Unit, order: :defined, integration: true do
   # When recording new VCR cassettes, code needs to be changed to a unique value
   include_examples '.save',
                    :description,
-                   additional_attrs: { code: 'blarg4' }
+                   additional_attrs: { code: 'blarg5' }
 
   # When recording new VCR cassettes, code needs to be changed to a unique value
   include_examples '.save with specially named attribute',
                    { description: 'Happy clouds' },
                    :code,
-                   'woooh4'
+                   'woooh5'
 
   # When recording new VCR cassettes, expected number must be updated
-  include_examples '.all', 12
+  include_examples '.all', 14
 
   include_examples '.find', 'blarg', find_by_hash: false do
     let(:find_by_hash_failure) { { code: 'notfound' } }

data/spec/fortnox/api/types/enums_spec.rb

@@ -13,4 +13,5 @@ describe Fortnox::API::Types do
   it_behaves_like 'enum', 'VATType', 'VATTypes'
   it_behaves_like 'enum', 'DefaultDeliveryType', 'DefaultDeliveryTypeValues'
   it_behaves_like 'enum', 'ProjectStatusType', 'ProjectStatusTypes'
+  it_behaves_like 'enum', 'TaxReductionType', 'TaxReductionTypes'
 end

data/spec/fortnox/api/types/housework_types_spec.rb

@@ -14,29 +14,32 @@ describe 'HouseworkTypes', integration: true do
   before { set_api_test_configuration }
 
   let(:repository) { Fortnox::API::Repository::Order.new }
-  let(:valid_model) do
-    Fortnox::API::Model::Order.new(customer_number: '1', order_rows: [order_row])
-  end
-  let(:order_row) do
-    Fortnox::API::Types::OrderRow.new(ordered_quantity: 1,
-                                      article_number: '0000',
-                                      housework_type: housework_type)
-  end
 
-  shared_examples_for 'housework type' do |type, legacy: false|
+  shared_examples_for 'housework type' do |type, tax_reduction_type, legacy: false, housework: true|
     subject do
-      lambda do
-        VCR.use_cassette("orders/housework_type_#{type.downcase}") do
-          repository.save(valid_model)
-        end
-      end
+      cassette = "orders/housework_type_#{type.downcase}"
+      -> { VCR.use_cassette(cassette) { repository.save(document) } }
     end
 
-    let(:error_message) { 'Skattereduktion för den valda typen av husarbete har upphört.' }
-    let(:housework_type) { Fortnox::API::Types::HouseworkTypes[type] }
+    let(:document) do
+      Fortnox::API::Model::Order.new(
+        customer_number: '1',
+        tax_reduction_type: tax_reduction_type,
+        order_rows: [
+          Fortnox::API::Types::OrderRow.new(
+            ordered_quantity: 1,
+            article_number: '0000',
+            housework_type: Fortnox::API::Types::HouseworkTypes[type],
+            housework: housework
+          )
+        ]
+      )
+    end
 
     context "when creating an OrderRow with housework_type set to #{type}" do
       if legacy
+        let(:error_message) { 'Skattereduktion för den valda typen av husarbete har upphört.' }
+
         it 'raises an error' do
           is_expected.to raise_error(Fortnox::API::RemoteServerError, error_message)
         end
@@ -46,23 +49,137 @@ describe 'HouseworkTypes', integration: true do
     end
   end
 
-  it_behaves_like 'housework type', 'CONSTRUCTION'
-  it_behaves_like 'housework type', 'ELECTRICITY'
-  it_behaves_like 'housework type', 'GLASSMETALWORK'
-  it_behaves_like 'housework type', 'GROUNDDRAINAGEWORK'
-  it_behaves_like 'housework type', 'MASONRY'
-  it_behaves_like 'housework type', 'PAINTINGWALLPAPERING'
-  it_behaves_like 'housework type', 'HVAC'
-  it_behaves_like 'housework type', 'CLEANING'
-  it_behaves_like 'housework type', 'TEXTILECLOTHING'
-  it_behaves_like 'housework type', 'CLEANING'
-  it_behaves_like 'housework type', 'SNOWPLOWING'
-  it_behaves_like 'housework type', 'GARDENING'
-  it_behaves_like 'housework type', 'BABYSITTING'
-  it_behaves_like 'housework type', 'OTHERCARE'
-  it_behaves_like 'housework type', 'OTHERCOSTS'
-
-  it_behaves_like 'housework type', 'COOKING', legacy: true
-  it_behaves_like 'housework type', 'TUTORING', legacy: true
+  TYPE_ROT = Fortnox::API::Types::TaxReductionTypes['rot']
+  TYPE_RUT = Fortnox::API::Types::TaxReductionTypes['rut']
+
+  it_behaves_like 'housework type', 'CONSTRUCTION', TYPE_ROT
+  it_behaves_like 'housework type', 'ELECTRICITY', TYPE_ROT
+  it_behaves_like 'housework type', 'GLASSMETALWORK', TYPE_ROT
+  it_behaves_like 'housework type', 'GROUNDDRAINAGEWORK', TYPE_ROT
+  it_behaves_like 'housework type', 'MASONRY', TYPE_ROT
+  it_behaves_like 'housework type', 'PAINTINGWALLPAPERING', TYPE_ROT
+  it_behaves_like 'housework type', 'HVAC', TYPE_ROT
+  it_behaves_like 'housework type', 'OTHERCOSTS', TYPE_ROT, housework: false
+
+  it_behaves_like 'housework type', 'MAJORAPPLIANCEREPAIR', TYPE_RUT
+  it_behaves_like 'housework type', 'MOVINGSERVICES', TYPE_RUT
+  it_behaves_like 'housework type', 'ITSERVICES', TYPE_RUT
+  it_behaves_like 'housework type', 'CLEANING', TYPE_RUT
+  it_behaves_like 'housework type', 'TEXTILECLOTHING', TYPE_RUT
+  it_behaves_like 'housework type', 'SNOWPLOWING', TYPE_RUT
+  it_behaves_like 'housework type', 'GARDENING', TYPE_RUT
+  it_behaves_like 'housework type', 'BABYSITTING', TYPE_RUT
+  it_behaves_like 'housework type', 'OTHERCARE', TYPE_RUT
+  it_behaves_like 'housework type', 'OTHERCOSTS', TYPE_RUT, housework: false
+
+  # rubocop:disable RSpec/RepeatedDescription
+  pending 'to be added' do
+    raise Exception, 'Will be supported 2021-01-01'
+    # it_behaves_like 'housework type', 'HOMEMAINTENANCE', TYPE_RUT
+    # it_behaves_like 'housework type', 'FURNISHING', TYPE_RUT
+    # it_behaves_like 'housework type', 'TRANSPORTATIONSERVICES', TYPE_RUT
+    # it_behaves_like 'housework type', 'WASHINGANDCAREOFCLOTHING', TYPE_RUT
+  end
+
+  pending 'to be added' do
+    raise Exception, 'Will be supported 2021-01-01'
+    # it_behaves_like 'housework type', 'SOLARCELLS', TYPE_GREEN
+    # it_behaves_like 'housework type', 'STORAGESELFPRODUCEDELECTRICTY', TYPE_GREEN
+    # it_behaves_like 'housework type', 'CHARGINGSTATIONELECTRICVEHICLE', TYPE_GREEN
+    # it_behaves_like 'housework type', 'OTHERCOSTS', TYPE_GREEN
+  end
+  # rubocop:enable RSpec/RepeatedDescription
+
+  it_behaves_like 'housework type', 'COOKING', TYPE_RUT, legacy: true
+  it_behaves_like 'housework type', 'TUTORING', TYPE_RUT, legacy: true
+
+  describe 'without tax reduction type' do
+    subject do
+      cassette = 'orders/housework_without_tax_reduction_type'
+      -> { VCR.use_cassette(cassette) { repository.save(document) } }
+    end
+
+    let(:document) do
+      Fortnox::API::Model::Order.new(
+        customer_number: '1',
+        order_rows: [
+          Fortnox::API::Types::OrderRow.new(
+            ordered_quantity: 1,
+            article_number: '0000',
+            housework_type: Fortnox::API::Types::HouseworkTypes['CONSTRUCTION'],
+            housework: true
+          )
+        ]
+      )
+    end
+
+    let(:error_message) do
+      'Dokument utan angiven skattereduktionstyp får inte innehålla artikelrader med husarbetestyp.'
+    end
+
+    it 'raises an error' do
+      is_expected.to raise_error(Fortnox::API::RemoteServerError, error_message)
+    end
+  end
+
+  describe 'with OTHERCOSTS' do
+    subject do
+      cassette = 'orders/housework_othercoses_invalid'
+      -> { VCR.use_cassette(cassette) { repository.save(document) } }
+    end
+
+    let(:document) do
+      Fortnox::API::Model::Order.new(
+        customer_number: '1',
+        tax_reduction_type: TYPE_ROT,
+        order_rows: [
+          Fortnox::API::Types::OrderRow.new(
+            ordered_quantity: 1,
+            article_number: '0000',
+            housework_type: Fortnox::API::Types::HouseworkTypes['OTHERCOSTS'],
+            housework: true
+          )
+        ]
+      )
+    end
+
+    let(:error_message) { 'Kan inte sätta typen övrig kostnad på en rad markerad som husarbete.' }
+
+    it "can't have housework set to true" do
+      is_expected.to raise_error(Fortnox::API::RemoteServerError, error_message)
+    end
+  end
+
+  describe 'with wrong tax reduction type' do
+    subject do
+      cassette = 'orders/housework_invalid_tax_reduction_type'
+      -> { VCR.use_cassette(cassette) { repository.save(document) } }
+    end
+
+    let(:type) { 'CONSTRUCTION' }
+    let(:document) do
+      Fortnox::API::Model::Order.new(
+        customer_number: '1',
+        tax_reduction_type: TYPE_RUT,
+        order_rows: [
+          Fortnox::API::Types::OrderRow.new(
+            ordered_quantity: 1,
+            article_number: '0000',
+            housework_type: Fortnox::API::Types::HouseworkTypes[type],
+            housework: true
+          )
+        ]
+      )
+    end
+
+    let(:error_message) do
+      "Dokument med skattereduktionstypen '#{TYPE_RUT}' " \
+      "får inte innehålla rader med husarbetestypen '#{type}'."
+    end
+
+    it 'raises an error' do
+      is_expected.to raise_error(Fortnox::API::RemoteServerError, error_message)
+    end
+  end
 end
 # rubocop:enable RSpec/DescribeClass