format_parser 0.15.0 → 0.15.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 32b5a18eb53b1c5197a828757056354c655225fe7047418a615bfb8f950a6805
-  data.tar.gz: df289b5f4039f89d78b35e481efe50ea95f654497a7783bbaf0a35b997d630ed
+SHA1:
+  metadata.gz: b54b8e7c496c5d1e732503678bc762993bf53e9a
+  data.tar.gz: ca7ce92f31f08a049b7475746e2017e6662b331a
 SHA512:
-  metadata.gz: 358c318bf9f5262edb1acde1854e5caebaac3e945502d1d164f982f0d8fd26eb717ed5c43b3311f130d6ca2804b8c2bb1c0f1a596f462b01c59cd5a79267b0fb
-  data.tar.gz: 9482a5702896f47ba6da0d99d0e5ef31d51981bdd9271a764872fd06f0a210e19202c1c4fbd111111645d894703646648e8a7f003df7ea2419deef3254ea32da
+  metadata.gz: d3dcc4792c6097dc701beb1b124ae17ad345305b4e7e4ac46a132646ff2aefea13cdc350087f8582b9b2653b75181c6c00ffb12d6a5180716538a732cfe60c46
+  data.tar.gz: 898ea93a39709415452b5256fdcee7acb69d9a1decc14c50b52695990ae399848c3f984787ab7374efb9b04b3bb758f0487a4b9da67c7fa83396ab5a5c114218

data/format_parser.gemspec

@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'ks', '~> 0.0.1'
+  spec.add_dependency 'ks', '~> 0.0'
   spec.add_dependency 'exifr', '~> 1.0'
   spec.add_dependency 'id3tag', '~> 0.10', '>= 0.10.1'
   spec.add_dependency 'faraday', '~> 0.13'

data/lib/audio.rb

@@ -4,6 +4,15 @@ module FormatParser
 
     NATURE = :audio
 
+    # Title of the audio
+    attr_accessor :title
+
+    # Album of the audio
+    attr_accessor :album
+
+    # Artist of the audio
+    attr_accessor :artist
+
     # Type of the file (e.g :mp3)
     attr_accessor :format
 

data/lib/format_parser/version.rb

@@ -1,3 +1,3 @@
 module FormatParser
-  VERSION = '0.15.0'
+  VERSION = '0.15.1'
 end

data/lib/parsers/mp3_parser.rb

@@ -81,6 +81,8 @@ class FormatParser::MP3Parser
 
     first_frame = initial_frames.first
 
+    id3tags_hash = blend_id3_tags_into_hash(*tags)
+
     file_info = FormatParser::Audio.new(
       format: :mp3,
       # media_duration_frames is omitted because the frames
@@ -88,9 +90,15 @@ class FormatParser::MP3Parser
       # do not tell anything of substance
       num_audio_channels: first_frame.channels,
       audio_sample_rate_hz: first_frame.sample_rate,
-      intrinsics: blend_id3_tags_into_hash(*tags).merge(id3tags: tags)
+      intrinsics: id3tags_hash.merge(id3tags: tags)
     )
 
+    extra_file_attirbutes = fetch_extra_attributes_from_id3_tags(id3tags_hash)
+
+    extra_file_attirbutes.each do |name, value|
+      file_info.send(:"#{name}=", value)
+    end
+
     if maybe_xing_header
       duration = maybe_xing_header.frames * SAMPLES_PER_FRAME / first_frame.sample_rate.to_f
       _bit_rate = maybe_xing_header.byte_count * 8 / duration / 1000
@@ -275,5 +283,15 @@ class FormatParser::MP3Parser
     end
   end
 
+  def fetch_extra_attributes_from_id3_tags(id3tags_hash)
+    attrs = {}
+
+    attrs[:title] = FormatParser.string_to_lossy_utf8(id3tags_hash[:title]) unless id3tags_hash[:title].to_s.empty?
+    attrs[:album] = FormatParser.string_to_lossy_utf8(id3tags_hash[:album]) unless id3tags_hash[:album].to_s.empty?
+    attrs[:artist] = FormatParser.string_to_lossy_utf8(id3tags_hash[:artist]) unless id3tags_hash[:artist].to_s.empty?
+
+    attrs
+  end
+
   FormatParser.register_parser self, natures: :audio, formats: :mp3, priority: 99
 end

data/spec/parsers/mp3_parser_spec.rb

@@ -15,6 +15,30 @@ describe FormatParser::MP3Parser do
     expect(parsed.media_duration_seconds).to be_within(0.1).of(0.836)
   end
 
+  describe 'title/artist/album attributes' do
+    let(:parsed) { subject.call(File.open(fpath, 'rb')) }
+
+    context 'when exist in id3 tags' do
+      let(:fpath) { fixtures_dir + '/MP3/Cassy.mp3' }
+
+      it 'set the attributes' do
+        expect(parsed.artist).to eq('WeTransfer Studios/GIlles Peterson')
+        expect(parsed.title).to eq('Cassy')
+        expect(parsed.album).to eq('The Psychology of DJing')
+      end
+    end
+
+    context 'when do not exist in id3 tags' do
+      let(:fpath) { fixtures_dir + '/MP3/atc_fixture_vbr.mp3' }
+
+      it 'set attributes with nil' do
+        expect(parsed.title).to be_nil
+        expect(parsed.artist).to be_nil
+        expect(parsed.album).to be_nil
+      end
+    end
+  end
+
   it 'decodes and estimates duration for a CBR MP3' do
     fpath = fixtures_dir + '/MP3/atc_fixture_cbr.mp3'
     parsed = subject.call(File.open(fpath, 'rb'))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: format_parser
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.15.1
 platform: ruby
 authors:
 - Noah Berman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-17 00:00:00.000000000 Z
+date: 2019-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ks
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.1
+        version: '0.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.0.1
+        version: '0.0'
 - !ruby/object:Gem::Dependency
   name: exifr
   requirement: !ruby/object:Gem::Requirement
@@ -284,7 +284,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A library for efficient parsing of file metadata