form_robot 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31bee54546f4b5e857693c61fe336fe1fa6f478f
-  data.tar.gz: 87af9b8860f8c764570e7b1fffaf3fdb9027664f
+  metadata.gz: dfe0f0db451116944eb4652cae87febc70f036a4
+  data.tar.gz: d54bb3c76b69f9d763a84752798d9baf52aa77db
 SHA512:
-  metadata.gz: 25f760bdf6dfd4d1def35b27d88c26f2179c8adece29b0d50c4d3a1a4b326e21fd56ac9f0f1069b3630bffbb1f176549340cffbadc2a155cd22036ceca053424
-  data.tar.gz: f72b3754c6cc93a39e9bc5376883ad3996efa2213d89694e37db79423767a6a5fcf6cf5f8066fc93982b57e76d3a760f1becd05997c62329dd14c71ba569f211
+  metadata.gz: 777bafd297b3cd932c8128729a5fbb0dd4ecbdb10baa99bbda424cd89679eae37ec32ea8cedc47801682b0f26aa2dc1a73065c1c8a0afe42efcccce4f0945044
+  data.tar.gz: f952dffee9bddab2bce259339f598d721c848b0b25655f73557e6e36320c6a7b9dd38cb856b09c5db73a7b6393496adfaf96c47650bf18b24c4b12b3b28e9d5e

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## 0.0.4
+
+Use string hash keys everywhere, because of the way that JSON parses and because of the way that Mechanize set field values
+
 ## 0.0.3
 
 Make sure that the robot's response is in UTF-8

data/lib/form_robot/robot.rb

@@ -14,6 +14,7 @@ class Robot
             task = instructions
             @was_successful = carry_out_single( task )
             @failure_reason = 'Unable to ' + ( task[:description] || 'perform task' ) unless @was_successful
+            @was_successful
         end
     end
 
@@ -22,16 +23,16 @@ class Robot
     end
 
     private
-        def carry_out_single ( go_to_url: nil, enter_params: {}, look_for_text: nil, description: nil )
-            form_with_params = @mech.get( go_to_url ).forms.detect do |form|
-                enter_params.keys.all? do |key|
+        def carry_out_single ( args = {} )
+            page = args.has_key?( 'go_to_url' ) ? @mech.get( args['go_to_url'] ) : @mech.page
+            form_with_params = page.forms.detect do |form|
+                args['enter_params'].keys.all? do |key|
                     form.keys.include? key
                 end
             end
-            form_with_params.set_fields( enter_params )
+            form_with_params.set_fields( args['enter_params'] )
             form_with_params.submit
 
-            @mech.page.encoding = 'utf-8'
-            look_for_text ? @mech.page.parser.to_s.match(look_for_text) : true
+            args.has_key?( 'look_for_text' ) ? @mech.page.parser.to_s.match( args['look_for_text'] ) : true
         end
 end

data/lib/form_robot/version.rb

@@ -1,3 +1,3 @@
 module FormRobot
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/test/lib/form_robot/encoding_test.rb

@@ -5,8 +5,8 @@ describe Robot do
 
     it 'must give a UTF-8 response' do
         instructions = {
-            go_to_url: 'http://www.google.com',
-            enter_params: {
+            'go_to_url' => 'http://www.google.com',
+            'enter_params' => {
                 'q' => 'broughton',
             },
         };

data/test/lib/form_robot/json_test.rb

@@ -0,0 +1,28 @@
+require_relative '../../test_helper'
+
+require 'json'
+
+describe Robot do
+    r = Robot.new
+
+    it 'must be able to read data parsed from JSON' do
+        json = '{
+            "instructions": [
+                {
+                    "go_to_url": "http://www.google.com",
+                    "enter_params": {
+                        "q": "Ruby on Rails"
+                    }
+                },
+                {
+                    "enter_params": {
+                        "q": "Perl Dancer"
+                    }
+                }
+            ]
+        }'
+        instructions = JSON.parse(json)
+        r.carry_out(instructions['instructions'])
+        assert_match( /www\.perldancer\.org/, r.last_response )
+    end
+end

data/test/lib/form_robot/robot_test.rb

@@ -5,11 +5,11 @@ describe Robot do
 
     it 'must be able to do a Google search' do
         instructions = {
-            go_to_url: 'http://www.google.com',
-            enter_params: {
+            'go_to_url' => 'http://www.google.com',
+            'enter_params' => {
                 'q' => 'RubyGems',
             },
-            look_for_text: 'rubygems.org',
+            'look_for_text' => 'rubygems.org',
         };
         robot.carry_out(instructions)
         assert robot.was_successful
@@ -17,18 +17,18 @@ describe Robot do
 
     it 'must be able to handle multiple instructions' do
         instructions = [{
-            go_to_url: 'http://www.linkedin.com/',
-            enter_params: {
+            'go_to_url' => 'http://www.linkedin.com/',
+            'enter_params' => {
                 'first' => 'Keith',
                 'last' => 'Broughton',
             },
-            look_for_text: 'Republic of Ireland',
+            'look_for_text' => 'Republic of Ireland',
         }, {
-            go_to_url: 'https://github.com/',
-            enter_params: {
+            'go_to_url' => 'https://github.com/',
+            'enter_params' => {
                 'q' => 'mongoid',
             },
-            look_for_text: 'Ruby ODM framework for MongoDB',
+            'look_for_text' => 'Ruby ODM framework for MongoDB',
         }];
         robot.carry_out(instructions)
         assert robot.was_successful

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: form_robot
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Keith Broughton
@@ -71,6 +71,7 @@ files:
 - lib/form_robot/robot.rb
 - lib/form_robot/version.rb
 - test/lib/form_robot/encoding_test.rb
+- test/lib/form_robot/json_test.rb
 - test/lib/form_robot/robot_test.rb
 - test/lib/form_robot/version_test.rb
 - test/test_helper.rb
@@ -101,6 +102,7 @@ summary: The Form Robot gem accepts a list of instructions to perform against a
   of URLs and HTML forms.
 test_files:
 - test/lib/form_robot/encoding_test.rb
+- test/lib/form_robot/json_test.rb
 - test/lib/form_robot/robot_test.rb
 - test/lib/form_robot/version_test.rb
 - test/test_helper.rb