forkwell_cop 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 4febb7ef97cb22fae4c138681d08467f749c4c18
-  data.tar.gz: 7ebe87bb23b123a8b68426608f041396f1256ffa
+SHA256:
+  metadata.gz: 9471e0d96dc7446a0aa0e51b8a20b8099c8700c77619df97ca8ff60598ce8ecc
+  data.tar.gz: 59a40a93d9cc3b477c6f245a4db0b0a6f5c79cea733a65c0fd7749ecbff83cf8
 SHA512:
-  metadata.gz: 8f10466d68c5464eeeb452d8722f999f10413b71c281dd802045789b9d02ebf393f65d94631f363d57f7c171afcc2b0c05eccee565ba4b51a1677be12df928e7
-  data.tar.gz: 515d1e2faf48bb7599da2cad9a54ef55499772b064a13b81cb008cc67c2d65035dfcdeed0026146a481c1981565acdd62bd3a29d2a1ceb1f245cc7dc1f52af1b
+  metadata.gz: 6388f534a80731b024f14366ff8742447cda65beee90e96ac818db3b104ec588c3864fc99ccc586ffcd5c8cc1dbc96a62cbbe01f32bee6c7d7e6a8f0548061a6
+  data.tar.gz: 923e0a4e9934d554413b2c1a6b4eb995a16072c29a0185c2dd71e042da83644897c35b3aff320cf477046ca85dff5ab9368a62bb32d78ff5b557dc39ab9d7c2e

data/.ruby-version

@@ -1 +1 @@
-2.4.1
+2.5.1

data/.travis.yml

@@ -1,5 +1,5 @@
 sudo: false
 language: ruby
-before_install: gem install bundler -v 1.13.1
+before_install: gem install bundler -v 1.17.3
 notifications:
   email: false

data/config/enabled.yml

@@ -1,3 +1,6 @@
+require:
+  - rubocop-performance
+
 AllCops:
   # .ruby-version の指定と合わせるため指定しない
   # TargetRubyVersion: ~
@@ -13,6 +16,8 @@ AllCops:
     - 'bin/rspec'
     - 'bin/rubocop'
     - 'bin/spring'
+    - 'bin/webpack'
+    - 'bin/webpack-dev-server'
 
 Rails:
   Enabled: true
@@ -48,6 +53,17 @@ Metrics/CyclomaticComplexity:
 Metrics/PerceivedComplexity:
   Max: 9
 
+Naming/AccessorMethodName:
+  Exclude:
+    # # action_args を使うため
+    # before_action :set_user
+    #
+    # def set_user(id)
+    #   @user = User.find(id)
+    # end
+    - '**/*_controller.rb'
+    - 'app/controllers/concerns/**/*.rb'
+
 # # 宗教の違いを許容する
 # def some_method_with_parameters param1, param2
 #  # body omitted
@@ -59,16 +75,6 @@ Metrics/PerceivedComplexity:
 Style/MethodDefParentheses:
   Enabled: false
 
-Style/AccessorMethodName:
-  Exclude:
-    # # action_args を使うため
-    # before_action :set_user
-    #
-    # def set_user(id)
-    #   @user = User.find(id)
-    # end
-    - '**/*_controller.rb'
-
 # 日本語コメントを許容する
 Style/AsciiComments:
   Enabled: false
@@ -86,7 +92,7 @@ Style/LambdaCall:
 # and_in_a_method_call({
 #   no: :difference
 # })
-Layout/IndentHash:
+Layout/IndentFirstHashElement:
   EnforcedStyle: consistent
 
 # ドキュメントの無い public クラスを許容する
@@ -96,3 +102,36 @@ Style/Documentation:
 # email など NOT NULL でもデフォルト値を指定できないカラムは存在する
 Rails/NotNullColumn:
   Enabled: false
+
+# map...flatten はだいたい flat_map に直せるのでチェックしておく
+Performance/FlatMap:
+  EnabledForFlattenWithoutParams: true
+
+# alias, alias_method で細かい挙動が変わるため、使い分ける必要がある
+#
+# 参考: http://blog.bigbinary.com/2012/01/08/alias-vs-alias-method.html
+Style/Alias:
+  Enabled: false
+
+# - Emacs のデフォルトが with_first_parameter
+# - Vim のデフォルトが with_fixed_indentation
+#
+# という宗教の違いを許容する
+Layout/AlignParameters:
+  Enabled: false
+
+# データ移行のために execute を使うことがあるため許容する
+Rails/ReversibleMigration:
+  Enabled: false
+
+# typo に気付けるようにするため
+Rails/UnknownEnv:
+  Environments:
+    - development
+    - test
+    - production
+    - staging
+
+# 子レコードを残しておきたい場合もあるため許容する
+Rails/HasManyOrHasOneDependent:
+  Enabled: false

data/config/todo.yml

@@ -21,12 +21,6 @@ Rails/OutputSafety:
 Rails/Validation:
   Enabled: false
 
-Style/Alias:
-  Enabled: true
-
-Layout/AlignParameters:
-  Enabled: true
-
 Style/BlockDelimiters:
   Enabled: false
 
@@ -45,13 +39,10 @@ Style/ClassVars:
 Style/DoubleNegation:
   Enabled: true
 
-Style/HashSyntax:
-  Enabled: false
-
 Layout/MultilineMethodCallIndentation:
   Enabled: false
 
-Style/VariableNumber:
+Naming/VariableNumber:
   Enabled: false
 
 Style/GuardClause:
@@ -89,10 +80,30 @@ Style/EmptyMethod:
 Rails/FilePath:
   Enabled: false
 
-# https://github.com/bbatsov/rubocop/blob/v0.47.1/lib/rubocop/cop/rails/reversible_migration.rb
-Rails/ReversibleMigration:
-  Enabled: false
-
 # https://github.com/bbatsov/rubocop/blob/v0.47.1/lib/rubocop/cop/rails/skips_model_validations.rb
 Rails/SkipsModelValidations:
   Enabled: false
+
+# https://github.com/bbatsov/rubocop/blob/v0.48.0/lib/rubocop/cop/lint/ambiguous_block_association.rb
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
+
+# https://github.com/bbatsov/rubocop/blob/v0.48.0/lib/rubocop/cop/style/symbol_array.rb
+Style/SymbolArray:
+  Enabled: false
+
+# https://github.com/bbatsov/rubocop/blob/v0.50.0/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb
+Layout/EmptyLineAfterMagicComment:
+  Enabled: false
+
+# https://github.com/bbatsov/rubocop/blob/v0.52.0/lib/rubocop/cop/style/rescue_standard_error.rb
+Style/RescueStandardError:
+  Enabled: false
+
+# https://github.com/bbatsov/rubocop/blob/v0.53.0/lib/rubocop/cop/naming/memoized_instance_variable_name.rb
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+
+# https://github.com/bbatsov/rubocop/blob/v0.53.0/lib/rubocop/cop/naming/uncommunicative_method_param_name.rb
+Naming/UncommunicativeMethodParamName:
+  Enabled: false

data/forkwell_cop.gemspec

@@ -1,7 +1,6 @@
-# coding: utf-8
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'forkwell_cop/version'
 
@@ -17,7 +16,8 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0")
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 0.49'
-  spec.add_development_dependency 'bundler', '~> 1.13'
+  spec.add_dependency 'rubocop', '~> 0.68'
+  spec.add_dependency 'rubocop-performance', '~> 1.3.0'
+  spec.add_development_dependency 'bundler', '~> 1.17.3'
   spec.add_development_dependency 'rake', '~> 10.0'
 end

data/lib/forkwell_cop/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ForkwellCop
-  VERSION = '0.5.0'
+  VERSION = '0.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: forkwell_cop
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - grooves
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-01 00:00:00.000000000 Z
+date: 2019-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
+        version: '0.68'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.49'
+        version: '0.68'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: 1.17.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: 1.17.3
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -90,8 +104,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: RuboCop configration in Forkwell