forest_liana 9.3.7 → 9.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0fa0601f889d02cbdc81c73031621ae62ed6517e6a606e1d5b177f4d0315e357
-  data.tar.gz: 8972e07871d08cf8a4254608d2ebfdd40a05612c031972e1b6b51f6f751a664a
+  metadata.gz: 103afe5988f7c2264d766f270e9fe94acabafd3dff2771616406d24235e178db
+  data.tar.gz: 351d284979c39cd903b40f74149bc71a8d4cfde44ec7a9e99f6e12a69a743229
 SHA512:
-  metadata.gz: 94ae6c97585ecb0d68caee75c6196ef344455b4d88d26f2d1a9777439bd245a3bf17e1101b5d5879578cea6941da2c4113e50f72e2e302d59a464aae893d04b4
-  data.tar.gz: 2d3d66dea8726e2351ab0f79290990b4ae6bec5b18ea6cc9e00f1a98b247eed3a21c25cf94d2ac8d9dac9ee05e3a1bcaff9d1536b1505ada8bfcf8c1df8843ff
+  metadata.gz: '099ff2ca0f05fd7ce0a27aa6935ed16ee856559096b0f750b30d30bf3a3c7ea94b6572fec0823381fb17fed5adc719915de86349876b9f861c1184c56ed367cb'
+  data.tar.gz: '08c6baba0689e84bb23c7535f9748c25fdabb31ec0ada34a5f61f8c05df3e39cd58038c84cc9279d84fbbcd3b2e85681b0404c555e39bd1fdc971309ff5674dd'

data/app/services/forest_liana/ability/permission.rb

@@ -16,7 +16,8 @@ module ForestLiana
         collection_name = ForestLiana.name_for(collection)
 
         begin
-          is_allowed = collections_data[collection_name][action].include? user_data['roleId']
+          is_allowed = (collections_data.key?(collection_name) && collections_data[collection_name][action].include?(user_data['roleId']))
+
           # re-fetch if user permission is not allowed (may have been changed)
           unless is_allowed
             collections_data = get_collections_permissions_data(true)
@@ -25,7 +26,7 @@ module ForestLiana
 
           is_allowed
         rescue
-          raise ForestLiana::Errors::ExpectedError.new(409, :conflict, "The collection #{collection} doesn't exist", 'collection not found')
+          raise ForestLiana::Errors::ExpectedError.new(409, :conflict, "The collection #{collection_name} doesn't exist", 'collection not found')
         end
       end
 

data/lib/forest_liana/version.rb

@@ -1,3 +1,3 @@
 module ForestLiana
-  VERSION = "9.3.7"
+  VERSION = "9.3.8"
 end

data/spec/services/forest_liana/ability/permission_spec.rb

@@ -79,6 +79,7 @@ module ForestLiana
           end
         end
 
+
         it 'should throw an exception when the collection doesn\'t exist' do
             expect {dummy_class.is_crud_authorized?('browse', user, String)}.to raise_error(ForestLiana::Errors::ExpectedError, 'The collection String doesn\'t exist')
         end
@@ -163,6 +164,53 @@ module ForestLiana
           expect(dummy_class.is_crud_authorized?('browse', user, Island)).to equal true
         end
 
+        it 'should re-fetch the permission once when collection_name doesn\'t exist' do
+          Rails.cache.write(
+            'forest.collections',
+            {
+              "collections" => {
+                "Fake_collection_name" => {
+                  "collection" => {
+                    "browseEnabled" => { "roles" => [1] },
+                    "readEnabled" => { "roles" => [1] },
+                    "editEnabled" => { "roles" => [1] },
+                    "addEnabled" => { "roles" => [1] },
+                    "deleteEnabled" => { "roles" => [1] },
+                    "exportEnabled" => { "roles" => [1] }
+                  },
+                  "actions" => {
+
+                  }
+                }
+              }
+            }
+          )
+
+          allow_any_instance_of(ForestLiana::Ability::Fetch)
+            .to receive(:get_permissions)
+              .and_return(
+                {
+                  "collections" => {
+                    "Island" => {
+                      "collection" => {
+                        "browseEnabled" => { "roles" => [1] },
+                        "readEnabled" => { "roles" => [1] },
+                        "editEnabled" => { "roles" => [1] },
+                        "addEnabled" => { "roles" => [1] },
+                        "deleteEnabled" => { "roles" => [1] },
+                        "exportEnabled" => { "roles" => [1] }
+                      },
+                      "actions" => {
+
+                      }
+                    }
+                  }
+                }
+              )
+
+          expect(dummy_class.is_crud_authorized?('browse', user, Island)).to equal true
+        end
+
         it 'should return false when user permission is not allowed' do
           Rails.cache.delete('forest.users')
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: forest_liana
 version: !ruby/object:Gem::Version
-  version: 9.3.7
+  version: 9.3.8
 platform: ruby
 authors:
 - Sandro Munda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-06-07 00:00:00.000000000 Z
+date: 2024-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails