forest_liana 9.20.5 → 9.20.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a276e10f6f55ce7c4b4aedf82f58847599273e82fa86b001d02573ff56d70a59
-  data.tar.gz: a8527baf9d848dbf81e3d989cd473718c859df54339df0e5172e795260b3410b
+  metadata.gz: 31b55dea3884f93640870ded7c0f4079cea1792d7842b05c0b3d1c610a463d0b
+  data.tar.gz: bc7faa9c4f0302159f57d5e1e376d697047fd0a0c2ad1c94f3fb651078a87395
 SHA512:
-  metadata.gz: 6516197269ef7e03df7e4c75f1c474147b9332b82945a8f688791f5e739e204dc5b443b572812f8394a93e15a7cad73e43d853056116a375c568f56db9dd99bd
-  data.tar.gz: f1966c816f63eba307e6e318d7ada4f7e3bf9280360695d6eb95859e7122cfbf8fbc2d34e2a68a5ab5489203c44e4aece02fb4759c6931fd3ed9d3e589530d0f
+  metadata.gz: 2e707a5df3a857e9bbb61c0cefa2d593feae5b724f05b3d18f45df2a0abdcc724d6db0367b514e89d9074c5646b8994d2c2d0330735b9da8e4a3810f5460317d
+  data.tar.gz: f757f804039e32d4ef70b0b544ca1297933d633ef063ff692fa79c5fc8d7ee5daeee817a859956c7ed4fcfaaab966ef2fc6dd70d47061cbcd1218e059136bcad

data/app/controllers/forest_liana/associations_controller.rb

@@ -27,6 +27,11 @@ module ForestLiana
     def count
       find_resource
       find_association
+      # NOTICE: find_association renders a 404 (without halting) when the
+      #         association name does not resolve; stop here instead of falling
+      #         through and dereferencing a nil @association, which surfaced as
+      #         a double-render / 500 rather than the intended 404.
+      return if performed?
       begin
         getter = HasManyGetter.new(@resource, @association, params, forest_user)
         getter.count

data/lib/forest_liana/version.rb

@@ -1,3 +1,3 @@
 module ForestLiana
-  VERSION = "9.20.5"
+  VERSION = "9.20.6"
 end

data/spec/requests/count_spec.rb

@@ -74,6 +74,20 @@ describe 'Requesting Owner', :type => :request  do
     end
   end
 
+  describe 'count on an unknown relationship' do
+    params = {
+      fields: { 'Tree' => 'id,name,owner' },
+      page: { 'number' => '1', 'size' => '10' },
+      searchExtended: '0',
+      timezone: 'Europe/Paris'
+    }
+
+    it 'should respond 404 instead of 500' do
+      get '/forest/Owner/5/relationships/unknown_things/count', params: params, headers: headers
+      expect(response.status).to eq(404)
+    end
+  end
+
   describe 'deactivate_count_response' do
     params = {
       fields: { 'Owner' => 'id,name' },

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: forest_liana
 version: !ruby/object:Gem::Version
-  version: 9.20.5
+  version: 9.20.6
 platform: ruby
 authors:
 - Sandro Munda