forest_liana 9.20.12 → 9.20.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 113a6c37672221a6fb2b94fb001ae0c04101b239e4b1eb6c8046d3c4485da005
-  data.tar.gz: 928f89e4c0bfa3c5cb925b64ae437caf73aed141f704fafec4464da49d9a5a09
+  metadata.gz: 3e53d6922c4422fed246ccc6d625ac21668788f962873e6b04e83689684e9a39
+  data.tar.gz: 63d031e91c573ec7413d82bfa0c718b3b61736d6aa6583efd5a7dc848e7baf1b
 SHA512:
-  metadata.gz: 07b02e0de1972b2ce1fba69415e2719695eebd0ab69791f34270873667916088a87d214824520b6a26ddf21b6af7dadff2defa69c712f79e1258ac3d6a5e4dcf
-  data.tar.gz: 6e71fa92203f7ad24a9c5e581b3c57789c479cfd94651040a9078bf075358ddc53256dad73ce4453b14f282fdad5f895bd8bf124167386c4bf50ef0b9f221aac
+  metadata.gz: 3a56ce38a01bbebe42696a893bf6e50e762135c8b0579ac488e578468469a3a381963bee3ed1a9c5efb5c73b168aaf80bcfe410ec2f90c25ac80235c29799778
+  data.tar.gz: f93ccc8fcd6cfdbb189e623a3cd3095d79bbd8fd94a70cda8d0cf263476ea6fe3226617b8ebffc3b14a804153f975dddd6903a9791b7c75e85da5e15c72a3b91

data/app/services/forest_liana/resources_getter.rb

@@ -6,7 +6,7 @@ module ForestLiana
       @resource = resource
       @params = params
       @user = forest_user
-      @count_needs_includes = !@params[:search].nil?
+      @count_needs_includes = @params[:search].present?
       @collection_name = ForestLiana.name_for(@resource)
       @collection = get_collection(@collection_name)
       @fields_to_serialize = get_fields_to_serialize

data/app/services/forest_liana/search_query_builder.rb

@@ -9,7 +9,8 @@ module ForestLiana
       @includes = includes
       @collection = collection
       @fields_searched = []
-      @search = @params[:search]
+      # '' is truthy, so without .presence an empty search still builds LIKE '%%' predicates.
+      @search = @params[:search].presence
       @user = user
     end
 

data/lib/forest_liana/version.rb

@@ -1,3 +1,3 @@
 module ForestLiana
-  VERSION = "9.20.12"
+  VERSION = "9.20.13"
 end

data/spec/services/forest_liana/has_many_getter_pagination_spec.rb

@@ -158,5 +158,36 @@ module ForestLiana
         expect(records.map(&:name)).to contain_exactly('cedar', 'pine')
       end
     end
+
+    describe 'with extended search and an empty search string' do
+      let(:params) do
+        {
+          id: island.id,
+          association_name: 'trees',
+          search: '',
+          'searchExtended' => '1',
+          page: { size: 15, number: 1 },
+          timezone: 'America/Nome'
+        }
+      end
+
+      it 'treats an empty search as a no-op instead of building predicates it cannot join' do
+        subject.perform
+
+        expect { subject.records.to_a }.not_to raise_error
+        expect(subject.records.to_a.map(&:name)).to contain_exactly('cedar', 'olive', 'pine', 'fig')
+        expect(subject.count).to eq(@trees.size)
+      end
+
+      describe 'with a record whose searched columns are all NULL' do
+        before(:each) { Tree.create!(name: nil, island: island) }
+
+        it 'is a no-op, not a filter: the record is still returned' do
+          subject.perform
+
+          expect(subject.records.to_a.map(&:name)).to contain_exactly('cedar', 'olive', 'pine', 'fig', nil)
+        end
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: forest_liana
 version: !ruby/object:Gem::Version
-  version: 9.20.12
+  version: 9.20.13
 platform: ruby
 authors:
 - Sandro Munda