forest_liana 8.0.14 → 8.0.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e58456aa931649225eed7877b806e8f46e38aff513b4bd1d47ed4ca6d1a7c4e2
-  data.tar.gz: e29ceefbdda9bc4d9dd1eee4daf32a10093bc1f3e8a3e6c809b5e5aa4283c35e
+  metadata.gz: f05d57e597b220694bfa6681b6fd44ce847bbc3d9bed60c23547f4b6f879bcb5
+  data.tar.gz: d3bbd0453df99c237ead29a3d86b7b67a64dc6ceedf03420cc99ccd39eefd1ff
 SHA512:
-  metadata.gz: 1865aee0aee41357c69048badaa0b7372a93b503d45fc7ee2c0c752960230403b332239aa9633b501ed73d5237b57d651deee4b59f52a678c9f41925c6f91670
-  data.tar.gz: 24067eabbacc781a120caa9606335f6d9c18ca6564ddd7e71424ae6cca8d6afa32b02f0cf35805e3bc987ffb14fe26284bce5d53aef11829018898e903bb0db9
+  metadata.gz: 03506c47bf6f748129c80823b372246845f215d253b7b3ee3d2d14a27b4588c4014fa6a27d05a8199bee5134549663637c19f35327a87ff3ee0a0f4bfba82632
+  data.tar.gz: 2b55b11b94dc2fa393bcdbb66bf2a16305b193f004399ac4b79c2a33ac0c0d81f1fed98c8c798725c1504e38a718990ff402e6e1fdb2f1e91726306ff6c3cb29

data/app/controllers/forest_liana/application_controller.rb

@@ -4,6 +4,7 @@ require 'csv'
 module ForestLiana
   class ApplicationController < ForestLiana::BaseController
     rescue_from ForestLiana::Ability::Exceptions::AccessDenied, with: :render_error
+    rescue_from ForestLiana::Errors::HTTP403Error, with: :render_error
     rescue_from ForestLiana::Errors::HTTP422Error, with: :render_error
 
     def self.papertrail?

data/app/services/forest_liana/ability/fetch.rb

@@ -2,20 +2,12 @@ module ForestLiana
   module Ability
     module Fetch
       def get_permissions(route)
-        begin
-          response = ForestLiana::ForestApiRequester.get(route)
+        response = ForestLiana::ForestApiRequester.get(route)
 
-          if response.is_a?(Net::HTTPOK)
-            JSON.parse(response.body)
-          else
-            raise "Forest API returned an #{ForestLiana::Errors::HTTPErrorHelper.format(response)}"
-          end
-        rescue => exception
-          FOREST_REPORTER.report exception
-          FOREST_LOGGER.error 'Cannot retrieve the permissions from the Forest server.'
-          FOREST_LOGGER.error 'Which was caused by:'
-          ForestLiana::Errors::ExceptionHelper.recursively_print(exception, margin: ' ', is_error: true)
-          nil
+        if response.is_a?(Net::HTTPOK)
+          JSON.parse(response.body)
+        else
+          raise ForestLiana::Errors::HTTP403Error.new("Permission could not be retrieved")
         end
       end
     end

data/app/services/forest_liana/ability/permission.rb

@@ -6,7 +6,7 @@ module ForestLiana
     module Permission
       include Fetch
 
-      TTL = (ENV['FOREST_PERMISSIONS_EXPIRATION_IN_SECONDS'] || 1).to_i.second
+      TTL = (ENV['FOREST_PERMISSIONS_EXPIRATION_IN_SECONDS'] || 900).to_i.second
 
       def is_crud_authorized?(action, user, collection)
         return true unless has_permission_system?

data/lib/forest_liana/version.rb

@@ -1,3 +1,3 @@
 module ForestLiana
-  VERSION = "8.0.14"
+  VERSION = "8.0.15"
 end

data/spec/services/forest_liana/ability/permission_spec.rb

@@ -327,6 +327,17 @@ module ForestLiana
           expect {dummy_class.is_smart_action_authorized?(user, String, parameters, '/forest/actions/my_action', 'POST')}.to raise_error(ForestLiana::Errors::ExpectedError, 'The collection String doesn\'t exist')
         end
       end
+
+      describe 'when the server doesn\'t return an success response' do
+        before do
+          Rails.cache.clear
+        end
+
+        it 'should return an exception' do
+          allow(ForestLiana::ForestApiRequester).to receive(:get).and_return(instance_double(HTTParty::Response, code: 500, body: nil))
+          expect { dummy_class.is_crud_authorized?('browse', user, Island.first) }.to raise_error(ForestLiana::Errors::HTTP403Error, 'Permission could not be retrieved')
+        end
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: forest_liana
 version: !ruby/object:Gem::Version
-  version: 8.0.14
+  version: 8.0.15
 platform: ruby
 authors:
 - Sandro Munda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-16 00:00:00.000000000 Z
+date: 2023-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails