forest_admin_agent 1.39.4 → 1.40.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 70619859806c445a79898fd7c0ccc1d8584d1d32441b2b41d9a955577effaf70
-  data.tar.gz: 9aec675836fe8747de7d4a52ce392e0df50593c6b30dffa86d0c28349a142bcb
+  metadata.gz: a3449a32087ea2e6d73f842dc2ea471f3c6ff5b8977cc14739be8b52e56a7a55
+  data.tar.gz: efe4a6b6741625d381ee569918883ad2c514738ae459e78250dcd7e92601be7f
 SHA512:
-  metadata.gz: b4d575fee79985367b338dcda0e3d646ce32e119ada6db4370acb4a402e11824330732160e4636d96c3cdf91704e6fc8e216082ac4ee091300325a61d6465853
-  data.tar.gz: b48ea6b3ac88d37052c9bfb04d26e3179ef4182c96dce7df018847fab099971e83d3a9630d6c77430a738b273bac27571f2d03fe88f719b6a92e04b303697599
+  metadata.gz: 2b1ffd855a60f2982d11e9c84e42000a36bbfbc78ea7106c4a12bac3ec564aba01b4559e7d4c3ea63b27d47348ac857fbb4d69e2a802b5a5c1765c8005996933
+  data.tar.gz: a8d6416b4074df609fa8f177f61fa9685f3f80ea962b496f1e4ce121dd1d2dc080f8c26b2ef3b41be2c4b3d864398f793f3402a6e55ffd0f84bceb264bd569ee

data/lib/forest_admin_agent/services/permissions.rb

@@ -201,7 +201,8 @@ module ForestAdminAgent
         smart_action_approval = SmartActionChecker.new(
           request[:params],
           collection,
-          collection_actions[action['name'].to_sym],
+          # The schema scope lets the checker skip select-all resolution for global actions.
+          collection_actions[action['name'].to_sym].merge(scope: collection.schema[:actions][action['name']]&.scope),
           caller,
           user_data[:roleId],
           filter

data/lib/forest_admin_agent/services/smart_action_checker.rb

@@ -20,12 +20,24 @@ module ForestAdminAgent
       end
     end
 
+    class ApprovalSelectionTooLargeError < UnprocessableError
+      def initialize(max)
+        super(
+          "This action requires approval and cannot be triggered on more than #{max} records at once. " \
+          'Please refine your selection.'
+        )
+      end
+    end
+
     class SmartActionChecker
       include ForestAdminAgent::Utils
       include ForestAdminDatasourceToolkit::Utils
       include ForestAdminDatasourceToolkit::Components::Query
       include ForestAdminDatasourceToolkit::Components::Query::ConditionTree
 
+      # The Forest server's cap on approval record ids; max_records_for_approval may only lower it.
+      MAX_RECORDS_FOR_APPROVAL = 500
+
       attr_reader :parameters, :collection, :smart_action, :caller, :role_id, :filter, :attributes
 
       def initialize(parameters, collection, smart_action, caller, role_id, filter)
@@ -66,9 +78,19 @@ module ForestAdminAgent
           end
         elsif smart_action[:approvalRequired].include?(role_id) && smart_action[:triggerEnabled].include?(role_id)
           if condition_by_role_id(smart_action[:approvalRequiredConditions]).nil? || match_conditions(:approvalRequiredConditions)
+            # Global actions target no specific records — never resolve.
+            if attributes[:all_records] && smart_action[:scope] != ForestAdminDatasourceCustomizer::Decorators::Action::Types::ActionScope::GLOBAL
+              record_ids = resolve_select_all_record_ids
+            end
+
             raise CustomActionRequiresApprovalError.new(
               'This action requires to be approved.',
-              details: { user_approval_enabled: smart_action[:userApprovalEnabled] }
+              details: {
+                user_approval_enabled: smart_action[:userApprovalEnabled],
+                # camelCase: sent verbatim in the error data, the key the frontend reads.
+                roleIdsAllowedToApprove: smart_action[:userApprovalEnabled],
+                **(record_ids ? { recordIds: record_ids } : {})
+              }
             )
           elsif condition_by_role_id(smart_action[:triggerConditions]).nil? || match_conditions(:triggerConditions)
             return true
@@ -78,6 +100,27 @@ module ForestAdminAgent
         raise CustomActionTriggerForbiddenError, 'You don\'t have the permission to trigger this action.'
       end
 
+      # Fetching cap+1 distinguishes "over the cap" from "exactly the cap".
+      def resolve_select_all_record_ids
+        configured = ForestAdminAgent::Facades::Container.config_from_cache[:max_records_for_approval]
+        # Anything but a positive Integer gets the default (a negative LIMIT means unlimited on
+        # some datasources, and a String would raise on comparison).
+        max = if configured.is_a?(Integer) && configured.positive?
+                [configured, MAX_RECORDS_FOR_APPROVAL].min
+              else
+                MAX_RECORDS_FOR_APPROVAL
+              end
+        records = collection.list(
+          caller,
+          filter.override(page: Page.new(offset: 0, limit: max + 1)),
+          Projection.new.with_pks(collection)
+        )
+
+        raise ApprovalSelectionTooLargeError, max if records.size > max
+
+        Utils::Id.pack_ids(collection, records)
+      end
+
       def match_conditions(condition_name)
         pks = Schema.primary_keys(collection)
 

data/lib/forest_admin_agent/utils/schema/schema_emitter.rb

@@ -6,7 +6,7 @@ module ForestAdminAgent
     module Schema
       class SchemaEmitter
         LIANA_NAME = "agent-ruby"
-        LIANA_VERSION = "1.39.4"
+        LIANA_VERSION = "1.40.0"
 
         def self.generate(datasource)
           datasource.collections

data/lib/forest_admin_agent/version.rb

@@ -1,3 +1,3 @@
 module ForestAdminAgent
-  VERSION = "1.39.4"
+  VERSION = "1.40.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: forest_admin_agent
 version: !ruby/object:Gem::Version
-  version: 1.39.4
+  version: 1.40.0
 platform: ruby
 authors:
 - Matthieu
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-08-26 00:00:00.000000000 Z
+date: 2026-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport