foreman_teamdynamix 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 45a95aef7db1039e18557aa32808537189ba6bcc
-  data.tar.gz: cda36d5138cda78d1863ca58277c91320be283fb
+  metadata.gz: 3fca2ef501936519c40478d00bea14fed471e379
+  data.tar.gz: 442cd61aa226a3b3ace8b3507963ecf02108b8ea
 SHA512:
-  metadata.gz: 9a299726f597546ae462d497ae462bf95c276e964286ccb34aaedc56f0e83af9a574e69258e4e4d7456a00a390d9845361270bb8d3b43ea89082f69c770188c8
-  data.tar.gz: e0d4dc4ce8f5bd3214e600686a95d6173aa60a1e4460ff10678898c3c556866cfda5252cb23a43039f822957aefa0ad08299e48d9aa25669b180974af7e94e14
+  metadata.gz: 3f670d6544df6d4a70c61aed2ff54a498deae3720ad0d9675a507756a2a7c2e5d64af2890d4e9a11710fe10526566e259dc28bee00732e71a3f086a79a6297dd
+  data.tar.gz: 1145611226ba984de9499af93b028cd479d3899e596c6e8b0ba54979370037696b0483263791ee1113101d9e9513a5a0853b55b123cd18ec13773bcf6180ef3f

data/README.md

@@ -42,11 +42,6 @@ Example Configuration
         value: "Asset for host running on OS #{host.operatingsystem_id}"
     :delete:
       :StatusId: 642
-    :search:
-      AppID: 741
-      StatusName: In Use
-      RequestingCustomerID: 00000000-0000-0000-0000-000000000000
-      OwningDepartmentID: 15798
   :fields:
     Asset ID: ID
     Owner: OwningCustomerName
@@ -85,11 +80,11 @@ Add the teamdynamix config to <foreman_repo>/config/settings.yaml
 
 ## Rake Task
 ```
-rake hosts:sync_with_teamdynamix
+rake teamydynamix:sync:hosts
 ```
-Gets existing assets in TeamDynamix based on search params [:teamdynamix][:api][:search]. Then scans the hosts and sync them with TeamDynamix.
+Scans the hosts and sync them with TeamDynamix.
 * If host has teamdynamix_asset_id, update the corresponding TeamDynamix asset.
-* If host name matches the asset Name or SerialNumber, update the host and the corresponding TeamDynamix asset.
+* If host name matches the asset SerialNumber, update the host and the corresponding TeamDynamix asset.
 * If host has no matching asset, create an asset in TeamDynamix with configured fields.
 
 ## Test mode

data/app/models/concerns/foreman_teamdynamix/host_extensions.rb

@@ -7,7 +7,7 @@ module ForemanTeamdynamix
     end
 
     included do
-      after_validation :create_teamdynamix_asset, on: :create
+      before_create :create_teamdynamix_asset
       before_destroy :retire_teamdynamix_asset
       validates :teamdynamix_asset_id, uniqueness: { :allow_blank => true }
     end
@@ -15,8 +15,18 @@ module ForemanTeamdynamix
     private
 
     def create_teamdynamix_asset
-      asset = td_api.create_asset(self)
-      self.teamdynamix_asset_id = asset['ID']
+      # when the asset is already in teamdynamix
+      assets = td_api.search_asset(SerialLike: name)
+
+      if assets.empty?
+        asset = td_api.create_asset(self)
+        self.teamdynamix_asset_id = asset['ID']
+      elsif assets.length > 1
+        raise 'Found more than 1 existing asset'
+      else
+        self.teamdynamix_asset_id = assets.first['ID']
+        td_api.update_asset(self)
+      end
     rescue StandardError => e
       errors.add(:base, _("Could not create the asset for the host in TeamDynamix: #{e.message}"))
       false

data/app/overrides/{add_tab.rb → teamdynamix_add_tab.rb}

@@ -1,6 +1,6 @@
 if SETTINGS[:teamdynamix]
   Deface::Override.new(:virtual_path => 'hosts/show',
-                       :name => 'add_tab_link',
+                       :name => 'teamdynamix_add_tab',
                        :insert_bottom => 'ul#myTab',
                        :text =>
                        "<li><a href='#teamdynamix' data-toggle='tab'><%= _(teamdynamix_title) %></a></li>")

data/app/overrides/{add_tab_link.rb → teamdynamix_add_tab_link.rb}

@@ -1,6 +1,6 @@
 if SETTINGS[:teamdynamix]
   Deface::Override.new(:virtual_path => 'hosts/show',
-                       :name => 'create_link',
+                       :name => 'teamdynamix_add_tab_link',
                        :insert_bottom => 'div#myTabContent',
                        :text =>
                        "\n  <div id='teamdynamix' class='tab-pane'

data/app/services/teamdynamix_api.rb

@@ -26,6 +26,8 @@ class TeamdynamixApi
 
   def asset_exist?(asset_id)
     get_asset(asset_id).present?
+  rescue RuntimeError
+    false
   end
 
   def create_asset(host)

data/lib/foreman_teamdynamix/version.rb

@@ -1,3 +1,3 @@
 module ForemanTeamdynamix
-  VERSION = '0.0.1'.freeze
+  VERSION = '0.1.0'.freeze
 end

data/lib/tasks/teamdynamix.rake

@@ -0,0 +1,52 @@
+desc <<-DESC.strip_heredoc.squish
+  Scans existing hosts and creates or updates the asset in TeamDynamix.
+    * If found, update the fields in the TeamDynamix asset.
+    * If not found, create a TeamDynamix asset with desired fields.
+
+  It could be run for all the hosts as:
+    * rake teamydynamix:sync:hosts
+
+DESC
+namespace :teamdynamix do
+  namespace :sync do
+    task :hosts => :environment do
+      td_api = TeamdynamixApi.instance
+      errors = []
+      creates = 0
+      updates_from_serial_matching = 0
+      update_from_asset_id = 0
+
+      console_user = User.find_by(login: 'foreman_console_admin')
+      User.current = console_user
+
+      Host.all.each do |h|
+        # if asset exists, update it
+        if td_api.asset_exist?(h.teamdynamix_asset_id)
+          td_api.update_asset(h)
+          update_from_asset_id += 1
+        else
+          assets = td_api.search_asset(SerialLike: h.name)
+          if assets.empty?
+            asset = td_api.create_asset(h)
+            h.teamdynamix_asset_id = asset['ID']
+            errors.push("Could not save host: #{h.name} (#{h.id})") unless h.save
+            creates += 1
+          elsif assets.length > 1
+            errors.push("Could not sync: Found more than 1 asset for #{h.name} (#{h.id})")
+          else
+            h.teamdynamix_asset_id = assets.first['ID']
+            td_api.update_asset(h)
+            errors.push("Could not save host: #{h.name} (#{h.id})") unless h.save
+            updates_from_serial_matching += 1
+          end
+        end
+      end
+      puts "Assets created: #{creates}" unless creates.eql?(0)
+      unless updates_from_serial_matching.eql?(0)
+        puts "Assets updated from serial search: #{updates_from_serial_matching}"
+      end
+      puts "Assets updated from ID: #{update_from_asset_id}" unless update_from_asset_id.eql?(0)
+      puts "Errors:\n#{errors.join("\n")}" unless errors.empty?
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_teamdynamix
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Nipendar Tyagi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-14 00:00:00.000000000 Z
+date: 2018-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -66,8 +66,8 @@ files:
 - app/controllers/concerns/foreman_teamdynamix/hosts_controller_extensions.rb
 - app/helpers/concerns/foreman_teamdynamix/hosts_helper_extensions.rb
 - app/models/concerns/foreman_teamdynamix/host_extensions.rb
-- app/overrides/add_tab.rb
-- app/overrides/add_tab_link.rb
+- app/overrides/teamdynamix_add_tab.rb
+- app/overrides/teamdynamix_add_tab_link.rb
 - app/services/teamdynamix_api.rb
 - app/views/foreman_teamdynamix/hosts/_teamdynamix.html.erb
 - config/routes.rb
@@ -76,7 +76,7 @@ files:
 - lib/foreman_teamdynamix/engine.rb
 - lib/foreman_teamdynamix/version.rb
 - lib/tasks/foreman_teamdynamix_tasks.rake
-- lib/tasks/sync_hosts_with_teamdynamix.rake
+- lib/tasks/teamdynamix.rake
 - locale/Makefile
 - locale/en/foreman_teamdynamix.po
 - locale/foreman_teamdynamix.pot

data/lib/tasks/sync_hosts_with_teamdynamix.rake

@@ -1,96 +0,0 @@
-desc <<-DESC.strip_heredoc.squish
-  Scans existing hosts and creates or updates the asset in TeamDynamix.
-    * If found, update the fields in the TeamDynamix asset.
-    * If not found, create a TeamDynamix asset with desired fields.
-    * If host does not have a teamdynamix_asset_id or it is deleted via backend, it creates a new asset.
-
-  It could be run for all the hosts as:
-    * rake hosts:sync_with_teamdynamix
-
-  Or for specific hosts as (No space b/w hostnames):
-    * rake hosts:sync_with_teamdynamix[hostname1,hostname2,..,hostnameX]
-DESC
-namespace :hosts do
-  task :sync_with_teamdynamix => :environment do |_task|
-    @td_api = TeamdynamixApi.instance
-    @errors = []
-    @hosts_synced = []
-
-    set_current_user
-
-    sync_existing_assets_to_hosts
-
-    create_assets_for_unmapped_hosts
-
-    print_summary
-  end
-
-  def set_current_user
-    console_user = User.find_by(login: 'foreman_console_admin')
-    User.current = console_user
-  end
-
-  # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-  def sync_existing_assets_to_hosts
-    # sending empty search param to get all the assets in TD at once
-    # Note: due to a limitation(possibly a bug) in TD search asset api
-    #       each and every search payload returns all the assets.
-    search_params = SETTINGS[:teamdynamix][:api][:search] || {}
-    @teamdynamix_assets = @td_api.search_asset(search_params)
-    @teamdynamix_assets.each do |asset|
-      asset_id = asset['ID']
-      # WHEN Asset is already mapped to a host
-      # THEN update the asset in TD as per current configuration
-      host = Host.find_by(teamdynamix_asset_id: asset_id)
-      if host.present?
-        @hosts_synced << host.id
-        @td_api.update_asset(host)
-        next
-      end
-      hosts = Host.where(name: [asset['Name'], asset['SerialNumber']])
-      # WHEN Asset does not have a matching host, THEN Do nothing
-      next if hosts.blank?
-      # WHEN Asset has more than one  matching host, THEN report error
-      if hosts.count > 1
-        @errors << "#{hosts.count} matching hosts found for asset with ID #{asset['ID']}"
-        next
-      end
-      # WHEN Asset has a uniquely matching host which is not yet synced
-      # THEN update the host with the asset ID
-      # AND update the asset in TD as per current configuration
-      host = hosts.first
-      @hosts_synced << host.id
-      host.teamdynamix_asset_id = asset_id
-      @errors << "failed to update host ##{host.id} for asset ID ##{asset_id}" unless host.save
-      @td_api.update_asset(host)
-    end
-  rescue StandardError => e
-    @errors << "component: syncing_assets_to_hosts, asset_id: #{asset['ID']},
-                asset_name: #{asset['Name']}, Error: #{e.message}"
-  end
-  # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
-
-  # sync hosts that do not have assets created in Teamdynamix
-  def create_assets_for_unmapped_hosts
-    @unmapped_hosts = Host.where.not(id: @hosts_synced)
-    @unmapped_hosts.each do |host|
-      asset = @td_api.create_asset(host)
-      host.teamdynamix_asset_id = asset['ID']
-      @errors << "failed to update host ##{host.id} for asset ID ##{asset_id}" unless host.save
-    end
-  rescue StandardError => e
-    @errors << "component: creating_new_assets, host: #{host.id}, hostname: #{host.name}, Error: #{e.message}"
-  end
-
-  def print_summary
-    puts "\n Summary:"
-    puts "\t Total Assets in TD: #{@teamdynamix_assets.count}"
-    puts "\t Hosts with matching asset: #{@hosts_synced.uniq.count}"
-    puts "\t Hosts with no assets: #{@unmapped_hosts}" if @unmapped_hosts.present?
-    return if @errors.blank?
-    puts "\n Errors: #{@errors.count}"
-    @errors.each do |error|
-      puts "\t#{error}"
-    end
-  end
-end