foreman_rh_cloud 3.0.20 → 3.0.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a6bf66d7fd1c5302e88b9cd6f28f36c36d9ba8ecfcba3f32e4076c5ba856a05
-  data.tar.gz: d9d67e5ec55ac92e3101544c9e2d7f8f3d8e40112927c70efc23ddb117e8f96b
+  metadata.gz: f19ab6e45bf75f915a43c8db5e829f77fe6e5e7b62998d42fe4207ce37dcc062
+  data.tar.gz: c2bf184dcdfaefe41c1d13116ede5236c381c1f0bc8e71353d2875eee9cb289e
 SHA512:
-  metadata.gz: c241a52fe6d3f028777c0c70cea3cc68a2008cf2392d4dd9608b5332614638dce68baade016fddd46985ddcf6cddfa9638d28a86c6f645147ed52a304063a4a4
-  data.tar.gz: f32f203c82ddc7d4964155ac0afcfa18fc6cd6501df8a9bff9197e6fc03590cd5c71720fb8c512c64c920b503ed01d7a6118f2633e64f36f5a05ffd222af4197
+  metadata.gz: 7f2e16294caeae0098b8b8367082d75af4a706f74022dba22c040d9f545b4c99ca3c31be0d3db568c2a2dfc3de5509590a9602b026caad6ea0fb1b53a3ccc9f2
+  data.tar.gz: 9cc8d2349b5879d84bb9d2e95157c3eaafbff04823ea6704889b2678dc9a6a1f8fe300f09d28eef47c62cbbeccd94d96b0bbd7518969f8edbdbfb338a2fff1c7

data/README.md

@@ -42,7 +42,7 @@ In UI: Configure -> Insights -> Sync now
 
 From command-line:
 
-    /usr/sbin/foreman-rake rh_cloud_inventory:sync
+    /usr/sbin/foreman-rake rh_cloud_insights:sync
 
 #### Synchronize inventory status
 
@@ -51,11 +51,11 @@ In UI: Configure -> Inventory Upload -> Sync inventory status
 From command-line:
 
     # all organizations
-    /usr/sbin/foreman-rake rh_cloud_insights:sync
+    /usr/sbin/foreman-rake rh_cloud_inventory:sync
 
     # specific organization with id 1
     export organization_id=1
-    /usr/sbin/foreman-rake rh_cloud_insights:sync
+    /usr/sbin/foreman-rake rh_cloud_inventory:sync
 
 ## TODO
 

data/app/controllers/insights_cloud/api/machine_telemetries_controller.rb

@@ -10,27 +10,28 @@ module InsightsCloud::Api
 
     skip_after_action :log_response_body, :only => [:forward_request]
     skip_before_action :check_media_type, :only => [:forward_request]
+    after_action :update_host_insights_status, only: [:forward_request]
 
     # The method that "proxies" requests over to Cloud
     def forward_request
       certs = candlepin_id_cert @organization
-      cloud_response = ::ForemanRhCloud::CloudRequestForwarder.new.forward_request(request, controller_name, @branch_id, certs)
+      @cloud_response = ::ForemanRhCloud::CloudRequestForwarder.new.forward_request(request, controller_name, @branch_id, certs)
 
-      if cloud_response.code == 401
+      if @cloud_response.code == 401
         return render json: {
           :message => 'Authentication to the Insights Service failed.',
           :headers => {},
         }, status: :bad_gateway
       end
 
-      if cloud_response.headers[:content_disposition]
-        return send_data cloud_response, disposition: cloud_response.headers[:content_disposition], type: cloud_response.headers[:content_type]
+      if @cloud_response.headers[:content_disposition]
+        return send_data @cloud_response, disposition: @cloud_response.headers[:content_disposition], type: @cloud_response.headers[:content_type]
       end
 
-      assign_header(response, cloud_response, :x_resource_count, true)
-      assign_header(response, cloud_response, :x_rh_insights_request_id, false)
+      assign_header(response, @cloud_response, :x_resource_count, true)
+      assign_header(response, @cloud_response, :x_rh_insights_request_id, false)
 
-      render json: cloud_response, status: cloud_response.code
+      render json: @cloud_response, status: @cloud_response.code
     end
 
     def branch_info
@@ -69,5 +70,14 @@ module InsightsCloud::Api
       @branch_id = cp_owner_id(@organization)
       return render_message "Branch ID not found for organization #{@organization.title}", :status => 400 unless @branch_id
     end
+
+    def update_host_insights_status
+      return unless request.path == '/redhat_access/r/insights/platform/ingress/v1/upload' ||
+                    request.path.include?('/redhat_access/r/insights/uploads/')
+
+      data = @cloud_response.code.to_s.start_with?('2')
+      host_status = @host.get_status(InsightsClientReportStatus)
+      host_status.update(reported_at: Time.now.utc, status: host_status.to_status(data: data))
+    end
   end
 end

data/app/models/insights_client_report_status.rb

@@ -0,0 +1,58 @@
+class InsightsClientReportStatus < HostStatus::Status
+  REPORT_INTERVAL = 48.hours
+
+  REPORTING             = 0 # host_registration_insights = true & getting data
+  NO_REPORT             = 1 # host_registration_insights = true & not getting data
+  NOT_MANAGED           = 2 # host_registration_insights = false
+  NOT_MANAGED_WITH_DATA = 3 # host_registration_insights = false & getting data
+
+  def self.status_name
+    N_('Insights')
+  end
+
+  def to_label(_options = {})
+    case status
+      when REPORTING
+        N_('Reporting')
+      when NO_REPORT
+        N_('Not reporting')
+      when NOT_MANAGED
+        N_('Not reporting (not set by registration)')
+      when NOT_MANAGED_WITH_DATA
+        N_('Reporting (not set by registration)')
+    end
+  end
+
+  def to_global(_options = {})
+    case status
+      when REPORTING
+        ::HostStatus::Global::OK
+      when NO_REPORT
+        ::HostStatus::Global::ERROR
+      when NOT_MANAGED
+        ::HostStatus::Global::OK
+      when NOT_MANAGED_WITH_DATA
+        ::HostStatus::Global::WARN
+    end
+  end
+
+  def to_status(data: false)
+    if insights_param
+      return REPORTING if data
+      return in_interval? ? REPORTING : NO_REPORT
+    end
+
+    data ? NOT_MANAGED_WITH_DATA : NOT_MANAGED
+  end
+
+  private
+
+  def in_interval?
+    return false unless reported_at
+    (Time.now.utc - reported_at).to_i < REPORT_INTERVAL.to_i
+  end
+
+  def insights_param
+    host.host_params_hash.dig('host_registration_insights', :value)
+  end
+end

data/app/services/foreman_rh_cloud/cloud_connector.rb

@@ -59,7 +59,7 @@ module ForemanRhCloud
     end
 
     def foreman_host
-      ::Host.unscoped.friendly.find(::SmartProxy.default_capsule.name)
+      ForemanRhCloud.foreman_host
     end
   end
 end

data/app/subscribers/foreman_rh_cloud/insights_subscriber.rb

@@ -0,0 +1,9 @@
+module ForemanRhCloud
+  class InsightsSubscriber < ::Foreman::BaseSubscriber
+    def call(*args)
+      host = args.first.payload[:object]
+      host_status = host.get_status(InsightsClientReportStatus)
+      host_status.update(status: host_status.to_status)
+    end
+  end
+end

data/db/seeds.d/179_ui_notifications.rb

@@ -0,0 +1,11 @@
+blueprints = [
+  {
+    group: N_('Red Hat Insights'),
+    name: 'insights_satellite_hits',
+    message: N_('Satellite server has %{hits_count} recommendations by Red Hat'),
+    level: 'warning',
+  },
+]
+
+blueprints.each { |blueprint| UINotifications::Seed.new(blueprint).configure }
+

data/lib/foreman_inventory_upload.rb

@@ -57,10 +57,14 @@ module ForemanInventoryUpload
   end
 
   def self.slice_size
-    # for testing set ENV to 'https://ci.cloud.redhat.com/api/ingress/v1/upload'
     @slice_size ||= (ENV['SATELLITE_INVENTORY_SLICE_SIZE'] || '1000').to_i
   end
 
+  def self.max_org_size
+    # Set max amount of hosts per organization for automatic uploads
+    @max_org_size ||= (ENV['SATELLITE_INVENTORY_MAX_ORG_SIZE'] || 150_000).to_i
+  end
+
   def self.ensure_folder(folder)
     FileUtils.mkdir_p(folder)
     folder

data/lib/foreman_inventory_upload/async/generate_all_reports_job.rb

@@ -13,8 +13,14 @@ module ForemanInventoryUpload
         organizations = Organization.unscoped.all
 
         organizations.map do |organization|
-          GenerateReportJob.perform_later(ForemanInventoryUpload.generated_reports_folder, organization.id)
-        end
+          total_hosts = ForemanInventoryUpload::Generators::Queries.for_org(organization.id, use_batches: false).count
+
+          if total_hosts <= ForemanInventoryUpload.max_org_size
+            GenerateReportJob.perform_later(ForemanInventoryUpload.generated_reports_folder, organization.id)
+          else
+            logger.info("Skipping automatic uploads for organization #{organization.name}, too many hosts (#{total_hosts}/#{ForemanInventoryUpload.max_org_size})")
+          end
+        end.compact
       ensure
         self.class.set(:wait => 24.hours).perform_later
       end

data/lib/foreman_inventory_upload/generators/queries.rb

@@ -49,8 +49,9 @@ module ForemanInventoryUpload
         for_org(org_ids)
       end
 
-      def self.for_org(organization_id)
-        for_slice(Host.unscoped.where(organization_id: organization_id)).in_batches(of: ForemanInventoryUpload.slice_size)
+      def self.for_org(organization_id, use_batches: true)
+        base_query = for_slice(Host.unscoped.where(organization_id: organization_id))
+        use_batches ? base_query.in_batches(of: ForemanInventoryUpload.slice_size) : base_query
       end
 
       def self.organizations_for_user(portal_user)

data/lib/foreman_inventory_upload/generators/tags.rb

@@ -6,12 +6,14 @@ module ForemanInventoryUpload
       end
 
       def generate
-        locations +
-        hostgroups +
-        host_collections +
-        organizations +
-        content_data +
-        satellite_server_data
+        (
+          locations +
+          hostgroups +
+          host_collections +
+          organizations +
+          content_data +
+          satellite_server_data
+        ).reject { |key, value| value.empty? }
       end
 
       def generate_parameters

data/lib/foreman_rh_cloud.rb

@@ -38,12 +38,25 @@ module ForemanRhCloud
   end
 
   def self.proxy_setting(logger: Foreman::Logging.logger('background'))
+    fix_port(proxy_string(logger: logger))
+  end
+
+  def self.proxy_string(logger: Foreman::Logging.logger('background'))
     HttpProxy.default_global_content_proxy&.full_url ||
     ForemanRhCloud.cdn_proxy(logger: logger) ||
     ForemanRhCloud.global_foreman_proxy ||
     ''
   end
 
+  def self.fix_port(uri_string)
+    return '' if uri_string.empty?
+
+    uri = URI(uri_string)
+    uri.send(:define_singleton_method, :default_port, -> { nil })
+
+    uri.to_s
+  end
+
   def self.cdn_proxy(logger: Foreman::Logging.logger('app'))
     proxy_config = SETTINGS[:katello][:cdn_proxy]
     return nil unless proxy_config
@@ -82,4 +95,9 @@ module ForemanRhCloud
 
     transformed_uri.to_s
   end
+
+  # For testing purposes we can override the default hostname with an environment variable SATELLITE_RH_CLOUD_FOREMAN_HOST
+  def self.foreman_host
+    @foreman_host ||= ::Host.unscoped.friendly.find(ENV['SATELLITE_RH_CLOUD_FOREMAN_HOST'] || ::SmartProxy.default_capsule.name)
+  end
 end

data/lib/foreman_rh_cloud/engine.rb

@@ -78,7 +78,10 @@ module ForemanRhCloud
 
         register_global_js_file 'global'
 
-        register_custom_status(InventorySync::InventoryStatus)
+        register_custom_status InventorySync::InventoryStatus
+        register_custom_status InsightsClientReportStatus
+
+        subscribe 'host_created.event.foreman', ForemanRhCloud::InsightsSubscriber
 
         extend_page 'hosts/show' do |context|
           context.add_pagelet :main_tabs,
@@ -119,12 +122,29 @@ module ForemanRhCloud
     end
 
     config.to_prepare do
-      RemoteExecutionFeature.register(
-        :rh_cloud_remediate_hosts,
-        N_('Apply Insights recommendations'),
-        description: N_('Run remediation playbook generated by Insights'),
-        host_action_button: false
-      )
+      # skip database manipulations while tables do not exist, like in migrations
+      if ActiveRecord::Base.connection.data_source_exists?(ForemanTasks::Task.table_name) &&
+
+        RemoteExecutionFeature.register(
+          :rh_cloud_remediate_hosts,
+          N_('Apply Insights recommendations'),
+          description: N_('Run remediation playbook generated by Insights'),
+          host_action_button: false
+        )
+        # skip object creation when admin user is not present, for example in test DB
+        if User.unscoped.find_by_login(User::ANONYMOUS_ADMIN).present?
+          unless ForemanTasks::RecurringLogic.joins(:tasks).merge(
+            ForemanTasks::Task.where(label: 'InventorySync::Async::InventoryScheduledSync')
+          ).exists?
+            User.as_anonymous_admin do
+              recurring_logic = ForemanTasks::RecurringLogic.new_from_cronline("0 0 * * *")
+              recurring_logic.save!
+              recurring_logic.start(InventorySync::Async::InventoryScheduledSync)
+            end
+          end
+        end
+      end
+    rescue ActiveRecord::NoDatabaseError
     end
   end
 end

data/lib/foreman_rh_cloud/version.rb

@@ -1,3 +1,3 @@
 module ForemanRhCloud
-  VERSION = '3.0.20'.freeze
+  VERSION = '3.0.21'.freeze
 end

data/lib/insights_cloud/async/insights_full_sync.rb

@@ -6,11 +6,16 @@ module InsightsCloud
       include ::ForemanRhCloud::CloudAuth
 
       def plan
-        # This can be turned off when we enable automatic status syncs
-        # This step will query cloud inventory to retrieve inventory uuids for each host
-        plan_hosts_sync
-        plan_self
-        plan_rules_sync
+        sequence do
+          # This can be turned off when we enable automatic status syncs
+          # This step will query cloud inventory to retrieve inventory uuids for each host
+          plan_hosts_sync
+          plan_self
+          concurrence do
+            plan_rules_sync
+            plan_notifications
+          end
+        end
       end
 
       def run
@@ -40,6 +45,10 @@ module InsightsCloud
         plan_action InsightsRulesSync
       end
 
+      def plan_notifications
+        plan_action InsightsGenerateNotifications
+      end
+
       def query_insights_hits
         hits_response = RestClient::Request.execute(
           method: :get,

data/lib/insights_cloud/async/insights_generate_notifications.rb

@@ -0,0 +1,58 @@
+require 'rest-client'
+
+module InsightsCloud
+  module Async
+    class InsightsGenerateNotifications < ::Actions::EntryAction
+      # cache blueprint on class level, so it won't be reloaded on subsequent calls
+      def self.blueprint
+        @blueprint ||= NotificationBlueprint.find_by(name: 'insights_satellite_hits')
+      end
+
+      def run
+        add_satellite_notifications
+      end
+
+      def add_satellite_notifications
+        hits_count = InsightsHit.where(host_id: foreman_host.id).count
+
+        # Remove stale notifications
+        blueprint.notifications.destroy_all
+
+        if hits_count > 0
+          add_notification(hits_count)
+        end
+      end
+
+      private
+
+      def logger
+        action_logger
+      end
+
+      def foreman_host
+        ForemanRhCloud.foreman_host
+      end
+
+      def blueprint
+        self.class.blueprint
+      end
+
+      def add_notification(hits_count)
+        Notification.create!(
+          initiator: User.anonymous_admin,
+          audience: ::Notification::AUDIENCE_ADMIN,
+          message: UINotifications::StringParser.new(blueprint.message, {hits_count: hits_count}).to_s,
+          notification_blueprint: blueprint,
+          actions: {
+            links: [
+              {
+                href: Rails.application.routes.url_helpers.foreman_rh_cloud_insights_cloud_path(search: "hostname=#{foreman_host.name}"),
+                title: _('Fix host'),
+              },
+            ],
+          }
+        )
+      end
+    end
+  end
+end

data/lib/inventory_sync/async/inventory_scheduled_sync.rb

@@ -0,0 +1,17 @@
+module InventorySync
+  module Async
+    class InventoryScheduledSync < ::Actions::EntryAction
+      include ::Actions::RecurringAction
+
+      def plan
+        Organization.unscoped.each do |org|
+          plan_org_sync(org)
+        end
+      end
+
+      def plan_org_sync(org)
+        plan_action InventoryFullSync, org
+      end
+    end
+  end
+end

data/lib/tasks/insights.rake

@@ -1,15 +1,7 @@
 namespace :rh_cloud_insights do
-  desc "Synchronize Insights inventory"
-  task sync: :environment do
-    if ! ENV['organization_id'].nil?
-      organizations = [ Organization.where(:id => ENV['organization_id']).first ]
-    else
-      organizations = Organization.all
-    end
-
-    organizations.each do |organization|
-      ForemanTasks.async_task(InventorySync::Async::InventoryFullSync, organization)
-      puts "Synchronized inventory for organization '#{organization.name}'"
-    end
+  desc "Synchronize Insights hosts hits"
+  task sync: [:environment, 'dynflow:client'] do
+    ForemanTasks.sync_task(InsightsCloud::Async::InsightsFullSync)
+    puts "Synchronized Insights hosts hits data"
   end
 end

data/lib/tasks/rh_cloud_inventory.rake

@@ -52,9 +52,17 @@ namespace :rh_cloud_inventory do
     end
   end
 
-  desc "Synchronize Insights hosts hits"
-  task sync: :environment do
-    ForemanTasks.sync_task(InsightsCloud::Async::InsightsFullSync)
-    puts "Synchronized Insights hosts hits data"
+  desc "Synchronize Hosts inventory"
+  task sync: [:environment, 'dynflow:client'] do
+    if ! ENV['organization_id'].nil?
+      organizations = [ Organization.where(:id => ENV['organization_id']).first ]
+    else
+      organizations = Organization.all
+    end
+
+    organizations.each do |organization|
+      ForemanTasks.async_task(InventorySync::Async::InventoryFullSync, organization)
+      puts "Synchronized inventory for organization '#{organization.name}'"
+    end
   end
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "foreman_rh_cloud",
-  "version": "3.0.20",
+  "version": "3.0.21",
   "description": "Inventory Upload =============",
   "main": "index.js",
   "scripts": {

data/test/jobs/insights_full_sync_test.rb

@@ -3,6 +3,7 @@ require 'test_helper'
 class InsightsFullSyncTest < ActiveSupport::TestCase
   setup do
     InsightsCloud::Async::InsightsFullSync.any_instance.stubs(:plan_rules_sync)
+    InsightsCloud::Async::InsightsFullSync.any_instance.stubs(:plan_notifications)
 
     uuid1 = 'accdf444-5628-451d-bf3e-cf909ad72756'
     @host1 = FactoryBot.create(:host, :managed, name: 'host1')
@@ -60,6 +61,7 @@ class InsightsFullSyncTest < ActiveSupport::TestCase
 
     InsightsCloud::Async::InsightsFullSync.any_instance.expects(:plan_hosts_sync)
     InsightsCloud::Async::InsightsFullSync.any_instance.expects(:plan_rules_sync)
+    InsightsCloud::Async::InsightsFullSync.any_instance.expects(:plan_notifications)
     ForemanTasks.sync_task(InsightsCloud::Async::InsightsFullSync)
 
     @host1.reload

data/test/models/insights_client_report_status_test.rb

@@ -0,0 +1,77 @@
+require 'test_plugin_helper'
+
+class InsightsClientReportStatusTest < ActiveSupport::TestCase
+  describe 'to_status' do
+    let(:host) { FactoryBot.create(:host, :managed) }
+
+    setup do
+      CommonParameter.where(name: 'host_registration_insights').destroy_all
+    end
+
+    test 'host_registration_insights = true & is getting data' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+
+      assert_equal 0, host_status.to_status(data: true)
+    end
+
+    test 'host_registration_insights = true & no data in less than 48 hours' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      host_status.update(reported_at: 1.day.ago)
+      assert_equal 0, host_status.to_status
+    end
+
+    test 'host_registration_insights = true & no data in more than 48 hours' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      host_status.update(reported_at: 3.days.ago)
+      assert_equal 1, host_status.to_status
+    end
+
+    test 'host_registration_insights = false & no data' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false)
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      assert_equal 2, host_status.to_status
+    end
+
+    test 'host_registration_insights = false & getting data' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false)
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      assert_equal 3, host_status.to_status(data: true)
+    end
+
+    test 'host_registration_insights = nil & is getting data' do
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      assert_equal 3, host_status.to_status(data: true)
+    end
+
+    test 'host_registration_insights = nil & no data in less than 48 hours' do
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      host_status.update(reported_at: 1.day.ago)
+      assert_equal 2, host_status.to_status
+    end
+
+    test 'host_registration_insights = nil & no data in more than 48 hours' do
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      host_status.update(reported_at: 3.days.ago)
+      assert_equal 2, host_status.to_status
+    end
+
+    test 'override param on host level from `false` to `true`' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false)
+      FactoryBot.create(:host_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true, host: host)
+
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      assert_equal 0, host_status.to_status(data: true)
+    end
+
+    test 'override param on host level from `true` to `false`' do
+      FactoryBot.create(:common_parameter, name: 'host_registration_insights', key_type: 'boolean', value: true)
+      FactoryBot.create(:host_parameter, name: 'host_registration_insights', key_type: 'boolean', value: false, host: host)
+
+      host_status = Host.find_by_name(host.name).reload.get_status(InsightsClientReportStatus)
+      assert_equal 2, host_status.to_status
+    end
+  end
+end

data/test/unit/rh_cloud_http_proxy_test.rb

@@ -2,16 +2,16 @@ require 'test_plugin_helper'
 
 class RhCloudHttpProxyTest < ActiveSupport::TestCase
   setup do
-    @global_content_proxy_mock = 'http://global:content@localhost:8888'
-    @global_foreman_proxy_mock = 'http://global:foreman@localhost:8888'
+    @global_content_proxy_mock = 'http://global:content@localhost:80'
+    @global_foreman_proxy_mock = 'http://global:foreman@localhost:80'
     @katello_cdn_proxy_mock = {
       host: 'localhost',
-      port: '8888',
+      port: '80',
       user: 'katello',
       password: 'cdn',
       scheme: 'http',
     }
-    @katello_cdn_proxy_string_mock = 'http://katello:cdn@localhost:8888'
+    @katello_cdn_proxy_string_mock = 'http://katello:cdn@localhost:80'
   end
 
   test 'selects global content proxy' do

data/test/unit/tags_generator_test.rb

@@ -52,6 +52,16 @@ class TagsGeneratorTest < ActiveSupport::TestCase
     assert_equal @host.organization_id.to_s, actual['organization_id'].first.last
   end
 
+  test 'filters tags with empty values' do
+    generator = create_generator
+
+    @host.stubs(:content_view)
+
+    actual = generator.generate.group_by { |key, value| key }
+
+    assert_equal false, actual.key?('content_view')
+  end
+
   private
 
   def create_generator

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_rh_cloud
 version: !ruby/object:Gem::Version
-  version: 3.0.20
+  version: 3.0.21
 platform: ruby
 authors:
 - Foreman Red Hat Cloud team
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-26 00:00:00.000000000 Z
+date: 2021-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: katello
@@ -160,6 +160,7 @@ files:
 - app/helpers/foreman_inventory_upload_helper.rb
 - app/helpers/foreman_inventory_upload_host_helper.rb
 - app/models/concerns/rh_cloud_host.rb
+- app/models/insights_client_report_status.rb
 - app/models/insights_facet.rb
 - app/models/insights_hit.rb
 - app/models/insights_resolution.rb
@@ -174,6 +175,7 @@ files:
 - app/services/foreman_rh_cloud/cloud_request_forwarder.rb
 - app/services/foreman_rh_cloud/remediations_retriever.rb
 - app/services/foreman_rh_cloud/template_renderer_helper.rb
+- app/subscribers/foreman_rh_cloud/insights_subscriber.rb
 - app/views/hosts/_insights_tab.html.erb
 - app/views/job_templates/rh_cloud_remediations.erb
 - app/views/layouts/foreman_rh_cloud/application.html.erb
@@ -190,6 +192,7 @@ files:
 - db/migrate/20210214000002_add_rule_id_to_hits.foreman_rh_cloud.rb
 - db/migrate/20210307000001_add_unique_to_insights_facet.foreman_rh_cloud.rb
 - db/migrate/20210404000001_change_resolutions.foreman_rh_cloud.rb
+- db/seeds.d/179_ui_notifications.rb
 - db/seeds.d/50_job_templates.rb
 - lib/foreman_inventory_upload.rb
 - lib/foreman_inventory_upload/async/async_helpers.rb
@@ -213,6 +216,7 @@ files:
 - lib/foreman_rh_cloud/version.rb
 - lib/insights_cloud.rb
 - lib/insights_cloud/async/insights_full_sync.rb
+- lib/insights_cloud/async/insights_generate_notifications.rb
 - lib/insights_cloud/async/insights_resolutions_sync.rb
 - lib/insights_cloud/async/insights_rules_sync.rb
 - lib/insights_cloud/async/insights_scheduled_sync.rb
@@ -220,6 +224,7 @@ files:
 - lib/inventory_sync/async/host_result.rb
 - lib/inventory_sync/async/inventory_full_sync.rb
 - lib/inventory_sync/async/inventory_hosts_sync.rb
+- lib/inventory_sync/async/inventory_scheduled_sync.rb
 - lib/inventory_sync/async/query_inventory_job.rb
 - lib/tasks/foreman_rh_cloud_tasks.rake
 - lib/tasks/insights.rake
@@ -242,6 +247,7 @@ files:
 - test/jobs/insights_rules_sync_test.rb
 - test/jobs/inventory_full_sync_test.rb
 - test/jobs/upload_report_job_test.rb
+- test/models/insights_client_report_status_test.rb
 - test/test_plugin_helper.rb
 - test/unit/archived_report_generator_test.rb
 - test/unit/fact_helpers_test.rb
@@ -630,7 +636,7 @@ homepage: https://github.com/theforeman/foreman_rh_cloud
 licenses:
 - GPL-3.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -645,9 +651,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
-signing_key: 
+rubygems_version: 3.2.15
+signing_key:
 specification_version: 4
 summary: Summary of ForemanRhCloud.
 test_files:
@@ -657,13 +662,14 @@ test_files:
 - test/controllers/reports_controller_test.rb
 - test/controllers/uploads_controller_test.rb
 - test/controllers/uploads_settings_controller_test.rb
-- test/factories/inventory_upload_factories.rb
 - test/factories/insights_factories.rb
-- test/jobs/upload_report_job_test.rb
+- test/factories/inventory_upload_factories.rb
 - test/jobs/insights_full_sync_test.rb
 - test/jobs/insights_resolutions_sync_test.rb
 - test/jobs/insights_rules_sync_test.rb
 - test/jobs/inventory_full_sync_test.rb
+- test/jobs/upload_report_job_test.rb
+- test/models/insights_client_report_status_test.rb
 - test/test_plugin_helper.rb
 - test/unit/archived_report_generator_test.rb
 - test/unit/fact_helpers_test.rb