foreman_rh_cloud 14.4.0 → 14.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '03458c064241e69e2f5384094f124fd0911a9bb2b08a0e299581c8d5c22ef5da'
-  data.tar.gz: 4a14089d8e6410a5389473824d6206637370a34c552dcd178fe843b2eea3307c
+  metadata.gz: b3d41bcf3b5de41dab8c50751aecf9374fcb0bce44f1e0896011161b25ace53e
+  data.tar.gz: 8eb6a78729500fcb4ae06e8a35e452a0ed7a57e8dbc9f1d8ddf46b8c2a341016
 SHA512:
-  metadata.gz: c5daadeadfe2543a242aea723e832b4fcc5f7ac31a598fc05f34792e1c58042ec993718e07b96bff3841b35f366438b8ed7e52166fe94ea118f635f9caadfa16
-  data.tar.gz: c6008984ca0d88a5bcc51a1d6fd288e031b51238a0c561fcdb414cc967b7814750a529c5f5c0916866401dd922b71efd9fc20ad0b927fb2faec36ee21d5ae859
+  metadata.gz: d42639d1e4cb269096eb8cabe57a4337ee9c3e04e6339d2fdf8ac79ccf87188d60293820b5c6c61d79d03ecf40b5c042c2da8e81bb70251dda030cc24c74d1e2
+  data.tar.gz: c709b8044deff700aa3c541c6c21a9afdec88a449366785251057c64f1d85f73b9080b4391aca99d7564657509e3ee53c03de90f9f6d98dc9239d9de9a29f053

data/app/controllers/api/v2/rh_cloud/cloud_request_controller.rb

@@ -3,6 +3,7 @@ module Api::V2::RhCloud
     include ForemanRhCloud::IopSmartProxyAccess
     layout false
 
+    before_action :set_admin_user, only: [:update]
     before_action :require_non_iop_smart_proxy, only: [:update]
 
     KNOWN_DIRECTIVES = {

data/app/controllers/api/v2/rh_cloud/inventory_controller.rb

@@ -7,7 +7,7 @@ module Api
         include InventoryUpload::TaskActions
         include ForemanRhCloud::IopSmartProxyAccess
 
-        before_action :require_non_iop_smart_proxy, only: [:enable_cloud_connector]
+        before_action :require_non_iop_smart_proxy, only: [:announce_to_sources]
 
         api :GET, "/organizations/:organization_id/rh_cloud/report", N_("Download latest report")
         param :organization_id, Integer, required: true, desc: N_("Set the current organization context for the request")
@@ -70,10 +70,16 @@ module Api
           render json: { message: error.message }, status: :bad_request
         end
 
-        api :POST, "/rh_cloud/enable_connector", N_("Enable cloud connector")
-        def enable_cloud_connector
-          cloud_connector = ForemanRhCloud::CloudConnector.new
-          render json: cloud_connector.install.to_json
+        api :POST, "/rh_cloud/announce_to_sources", N_("Schedule a task to register in Red Hat Sources for cloud connector")
+        param :instance_id, String, required: true, desc: N_("RHC instance ID to register with Red Hat Sources")
+        def announce_to_sources
+          Setting[:rhc_instance_id] = params[:instance_id]
+
+          task = ForemanTasks.async_task(InsightsCloud::Async::CloudConnectorAnnounceTask, true)
+
+          render json: {
+            task: task,
+          }, status: :accepted
         end
       end
     end

data/app/controllers/foreman_inventory_upload/accounts_controller.rb

@@ -29,7 +29,6 @@ module ForemanInventoryUpload
 
       render json: {
         accounts: accounts,
-        CloudConnectorStatus: ForemanInventoryUpload::UploadsSettingsController.cloud_connector_status,
       }, status: :ok
     end
 

data/app/controllers/foreman_inventory_upload/uploads_controller.rb

@@ -1,22 +1,11 @@
 module ForemanInventoryUpload
   class UploadsController < ::ApplicationController
     include InventoryUpload::ReportActions
-    include ForemanRhCloud::IopSmartProxyAccess
-
-    before_action :require_non_iop_smart_proxy, only: [:enable_cloud_connector]
 
     def download_file
       filename, file = report_file(params[:organization_id])
 
       send_file file, disposition: 'attachment', filename: filename
     end
-
-    def enable_cloud_connector
-      # Set the autoupload to true, since it's required by the feature.
-      Setting[:allow_auto_inventory_upload] = true
-
-      cloud_connector = ForemanRhCloud::CloudConnector.new
-      render json: cloud_connector.install.to_json
-    end
   end
 end

data/app/controllers/foreman_inventory_upload/uploads_settings_controller.rb

@@ -9,7 +9,6 @@ module ForemanInventoryUpload
         ipsObfuscationEnabled: Setting[:obfuscate_inventory_ips],
         excludePackagesEnabled: Setting[:exclude_installed_packages],
         allowAutoInsightsMismatchDelete: Setting[:allow_auto_insights_mismatch_delete],
-        CloudConnectorStatus: ForemanInventoryUpload::UploadsSettingsController.cloud_connector_status,
         lastSyncTask: last_successful_inventory_sync_task,
       }, status: :ok
     end
@@ -19,13 +18,6 @@ module ForemanInventoryUpload
       index
     end
 
-    def self.cloud_connector_status
-      cloud_connector = ForemanRhCloud::CloudConnector.new
-      job = cloud_connector&.latest_job
-      return nil unless job
-      { id: job.id, task: ForemanTasks::Task.where(:id => job.task_id).first }
-    end
-
     def last_successful_inventory_sync_task
       task = ForemanTasks::Task.where(label: 'InventorySync::Async::InventoryFullSync', result: 'success')
                         .reorder('ended_at desc').first

data/app/services/foreman_rh_cloud/cloud_presence.rb

@@ -74,6 +74,9 @@ module ForemanRhCloud
 
     def register_rhc_instance
       raise Foreman::Exception.new('rhc_instance_id is empty, cannot register RHC to the cloud') if Setting[:rhc_instance_id].empty?
+
+      return :already_registered if rhc_connection_exists?
+
       source_id = satellite_instance_source || create_satellite_instance_source
 
       create_response = JSON.parse(
@@ -95,6 +98,22 @@ module ForemanRhCloud
       @satellite_instance_source = create_response['id']
     end
 
+    def rhc_connection_exists?
+      response = JSON.parse(
+        execute_cloud_request(
+          method: :get,
+          url: rhc_connection_url,
+          headers: {
+            content_type: :json,
+          },
+          ssl_client_cert: OpenSSL::X509::Certificate.new(certs[:cert]),
+          ssl_client_key: OpenSSL::PKey.read(certs[:key])
+        )
+      )
+
+      response['data']&.any?
+    end
+
     private
 
     def sources_url(path)
@@ -113,6 +132,10 @@ module ForemanRhCloud
       sources_url('/sources')
     end
 
+    def rhc_connection_url
+      sources_url("/rhc_connections?filter[rhc_id]=#{Setting[:rhc_instance_id]}")
+    end
+
     def create_rhc_connections_url
       sources_url('/rhc_connections')
     end

data/config/routes.rb

@@ -7,8 +7,6 @@ Rails.application.routes.draw do
     get 'settings', to: 'uploads_settings#index'
     post 'setting', to: 'uploads_settings#set_advanced_setting'
 
-    post 'cloud_connector', to: 'uploads#enable_cloud_connector'
-
     resources :tasks, only: [:create, :show]
 
     get 'status', to: 'cloud_status#index'
@@ -72,7 +70,7 @@ Rails.application.routes.draw do
       end
 
       namespace 'rh_cloud' do
-        post 'enable_connector', to: 'inventory#enable_cloud_connector'
+        post 'announce_to_sources', to: 'inventory#announce_to_sources'
         post 'cloud_request', to: 'cloud_request#update'
         get 'advisor_engine_config', to: 'advisor_engine_config#show'
 

data/lib/foreman_rh_cloud/engine.rb

@@ -61,6 +61,7 @@ module ForemanRhCloud
           ForemanRhCloud::Engine.register_scheduled_task(InventorySync::Async::InventoryScheduledSync, '0 0 * * *')
           ForemanRhCloud::Engine.register_scheduled_task(InsightsCloud::Async::InsightsScheduledSync, '0 0 * * *')
           ForemanRhCloud::Engine.register_scheduled_task(InsightsCloud::Async::InsightsClientStatusAging, '0 0 * * *')
+          ForemanRhCloud::Engine.register_scheduled_task(InsightsCloud::Async::CloudConnectorAnnounceTask, '0 0 * * *')
         end
       end
     rescue ActiveRecord::NoDatabaseError
@@ -80,12 +81,6 @@ module ForemanRhCloud
         host_action_button: false,
         provided_inputs: ['playbook_url', 'report_url', 'correlation_id', 'report_interval']
       )
-      RemoteExecutionFeature.register(
-        :ansible_configure_cloud_connector,
-        N_('Configure Cloud Connector on given hosts'),
-        :description => N_('Configure Cloud Connector on given hosts'),
-        :proxy_selector_override => ::RemoteExecutionProxySelector::INTERNAL_PROXY
-      )
     end
 
     # Ideally this code belongs to an initializer. The problem is that Katello controllers are not initialized completely until after the end of the to_prepare blocks

data/lib/foreman_rh_cloud/plugin.rb

@@ -31,8 +31,7 @@ module ForemanRhCloud
             :generate_foreman_rh_cloud,
             'foreman_inventory_upload/reports': [:generate],
             'foreman_inventory_upload/tasks': [:create],
-            'api/v2/rh_cloud/inventory': [:get_hosts, :remove_hosts, :sync_inventory_status, :download_file, :generate_report, :enable_cloud_connector],
-            'foreman_inventory_upload/uploads': [:enable_cloud_connector],
+            'api/v2/rh_cloud/inventory': [:get_hosts, :remove_hosts, :sync_inventory_status, :download_file, :generate_report, :announce_to_sources],
             'foreman_inventory_upload/uploads_settings': [:set_advanced_setting],
             'foreman_inventory_upload/missing_hosts': [:remove_hosts],
             'insights_cloud/settings': [:update],
@@ -123,6 +122,8 @@ module ForemanRhCloud
         role 'ForemanRhCloud Read Only', read_only_permissions, 'Role granting read-only permissions to view
                                                                  Insights Compliance, Vulnerability, Advisor, and host inventory'
 
+        role 'Cloud Connector', [:dispatch_cloud_requests], 'Role granting permission to dispatch cloud connector requests'
+
         add_permissions_to_default_roles Role::ORG_ADMIN => plugin_permissions,
           Role::MANAGER => plugin_permissions,
           Role::SYSTEM_ADMIN => plugin_permissions

data/lib/foreman_rh_cloud/version.rb

@@ -1,3 +1,3 @@
 module ForemanRhCloud
-  VERSION = '14.4.0'.freeze
+  VERSION = '14.5.0'.freeze
 end

data/lib/insights_cloud/async/cloud_connector_announce_task.rb

@@ -1,39 +1,96 @@
 module InsightsCloud
   module Async
     class CloudConnectorAnnounceTask < ::Actions::EntryAction
-      def self.subscribe
-        Actions::RemoteExecution::RunHostsJob
-      end
+      include ::Actions::RecurringAction
+      include ::ForemanRhCloud::CertAuth
+      include ForemanInventoryUpload::Async::DelayedStart
 
-      def self.connector_feature_id
-        @connector_feature_id ||= RemoteExecutionFeature.feature!(ForemanRhCloud::CloudConnector::CLOUD_CONNECTOR_FEATURE).id
-      end
+      def plan(immediate = false)
+        if ForemanRhCloud.with_iop_smart_proxy?
+          logger.debug('Sources announcement skipped: running in IoP mode')
+          return
+        end
 
-      def plan(job_invocation)
-        return unless connector_playbook_job?(job_invocation)
+        if Setting[:rhc_instance_id].blank?
+          logger.debug('Sources announcement skipped: rhc_instance_id is not set')
+          return
+        end
 
-        plan_self
+        unless Setting[:allow_auto_inventory_upload]
+          logger.debug(
+            'Cloud connector is configured (rhc_instance_id is set) but automatic inventory upload is disabled. ' \
+            'Enable the "Automatic inventory upload" setting for full cloud connector functionality.'
+          )
+        end
+
+        if immediate
+          plan_self
+        else
+          after_delay do
+            plan_self
+          end
+        end
       end
 
-      def finalize
+      def run
+        registered = []
+        confirmed_by_remediation = []
+        already_registered = []
+        skipped = []
+        failed = {}
+
         Organization.unscoped.each do |org|
+          unless cert_auth_available?(org)
+            skipped << org.name
+            next
+          end
+
+          if recent_cloud_remediation?(org)
+            confirmed_by_remediation << org.name
+            next
+          end
+
           presence = ForemanRhCloud::CloudPresence.new(org, logger)
-          presence.announce_to_sources
+          result = presence.announce_to_sources
+          if result == :already_registered
+            already_registered << org.name
+          else
+            registered << org.name
+          end
         rescue StandardError => ex
-          logger.warn(ex)
+          logger.warn("Failed to announce to Sources for organization #{org.name}: #{ex}")
+          logger.debug { ex.backtrace.join("\n") }
+          failed[org.name] = ex.message
         end
-      end
 
-      def rescue_strategy_for_self
-        Dynflow::Action::Rescue::Skip
+        parts = []
+        parts << "Registered: #{registered.join(', ')}" if registered.any?
+        parts << "Already registered: #{already_registered.join(', ')}" if already_registered.any?
+        parts << "Already registered (recent cloud remediation): #{confirmed_by_remediation.join(', ')}" if confirmed_by_remediation.any?
+        parts << "Skipped (no manifest): #{skipped.join(', ')}" if skipped.any?
+        if failed.any?
+          failed_details = failed.map { |name, msg| "#{name}: #{msg}" }.join('; ')
+          parts << "Failed: #{failed_details}"
+        end
+        output[:status] = parts.join('. ')
+
+        error!("Sources announcement failed for: #{failed.keys.join(', ')}") if failed.any?
       end
 
-      def connector_playbook_job?(job_invocation)
-        job_invocation&.remote_execution_feature_id == connector_feature_id
+      def recent_cloud_remediation?(org)
+        feature = RemoteExecutionFeature.find_by(label: 'rh_cloud_connector_run_playbook')
+        return false unless feature
+
+        JobInvocation.where(remote_execution_feature_id: feature.id)
+                     .joins(:task)
+                     .joins(targeting: :hosts)
+                     .where(hosts: { organization_id: org.id })
+                     .where('foreman_tasks_tasks.started_at > ?', 24.hours.ago)
+                     .exists?
       end
 
-      def connector_feature_id
-        self.class.connector_feature_id
+      def rescue_strategy_for_self
+        Dynflow::Action::Rescue::Skip
       end
 
       def logger

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "foreman_rh_cloud",
-  "version": "14.4.0",
+  "version": "14.5.0",
   "description": "Inventory Upload =============",
   "main": "index.js",
   "scripts": {

data/test/controllers/inventory_upload/api/inventory_controller_test.rb

@@ -35,20 +35,22 @@ module InventoryUpload::Api
       assert_equal test_task.id.to_s, actual_task['id']
     end
 
-    test 'Starts cloud connector configuration job' do
-      test_job = FactoryBot.create(:job_invocation)
+    test 'Triggers Sources announcement task' do
+      test_task = FactoryBot.create(:some_task)
 
-      ForemanRhCloud::CloudConnector.any_instance
-        .expects(:install)
-        .returns(test_job)
+      ForemanTasks.expects(:async_task)
+        .with(InsightsCloud::Async::CloudConnectorAnnounceTask, true)
+        .returns(test_task)
 
-      post :enable_cloud_connector
+      post :announce_to_sources, params: { instance_id: 'test-instance-id' }
 
       assert_response :success
 
-      actual_job = @response.parsed_body
+      assert_equal 'test-instance-id', Setting[:rhc_instance_id]
 
-      assert_equal test_job.id, actual_job['id']
+      actual_task = @response.parsed_body['task']
+      assert_not_nil actual_task
+      assert_equal test_task.id.to_s, actual_task['id']
     end
   end
 end

data/test/jobs/cloud_connector_announce_task_test.rb

@@ -1,125 +1,135 @@
-require 'json'
 require 'test_plugin_helper'
 require 'foreman_tasks/test_helpers'
-require "#{ForemanTasks::Engine.root}/test/support/dummy_dynflow_action"
 
 class CloudConnectorAnnounceTaskTest < ActiveSupport::TestCase
   include Dynflow::Testing::Factories
 
   setup do
-    RemoteExecutionFeature.register(
-      :ansible_configure_cloud_connector,
-      N_('Configure Cloud Connector on given hosts'),
-      :description => N_('Configure Cloud Connector on given hosts'),
-      :proxy_selector_override => ::RemoteExecutionProxySelector::INTERNAL_PROXY
-    )
+    InsightsCloud::Async::CloudConnectorAnnounceTask.any_instance
+                                                    .stubs(:recent_cloud_remediation?).returns(false)
+  end
+
+  teardown do
+    ForemanRhCloud.unstub(:with_iop_smart_proxy?)
+  end
+
+  test 'announces to sources for all organizations when rhc_instance_id is set' do
+    Setting[:rhc_instance_id] = 'test-rhc-id'
+
+    InsightsCloud::Async::CloudConnectorAnnounceTask.any_instance
+                                                    .stubs(:cert_auth_available?).returns(true)
 
-    @job_invocation = generate_job_invocation(:ansible_configure_cloud_connector)
+    ForemanRhCloud::CloudPresence.any_instance
+                                 .expects(:announce_to_sources)
+                                 .times(Organization.unscoped.count)
 
-    # reset connector feature ID cache
-    InsightsCloud::Async::CloudConnectorAnnounceTask.instance_variable_set(:@connector_feature_id, nil)
+    action = create_and_plan_action(InsightsCloud::Async::CloudConnectorAnnounceTask)
+    action = run_action(action)
+
+    status = action.output[:status].to_s
+    assert_match(/Registered:|Already registered:/, status)
+    refute_match(/Skipped/, status)
+    refute_match(/Failed/, status)
   end
 
-  test 'It executes cloud presence announcer' do
-    ForemanRhCloud::CloudPresence.any_instance.expects(:announce_to_sources).times(Organization.unscoped.count)
+  test 'skips when rhc_instance_id is not set' do
+    Setting[:rhc_instance_id] = nil
+
+    action = create_and_plan_action(InsightsCloud::Async::CloudConnectorAnnounceTask)
 
-    action = create_and_plan_action(InsightsCloud::Async::CloudConnectorAnnounceTask, @job_invocation)
-    finalize_action(action)
+    assert_empty action.execution_plan.planned_run_steps
   end
 
-  private
-
-  def generate_job_invocation(feature_name)
-    job_template = FactoryBot.build(
-      :job_template,
-      :template => 'BLEH'
-    )
-    feature = RemoteExecutionFeature.feature!(feature_name).id
-
-    job_invocation = FactoryBot.create(
-      :job_invocation,
-      remote_execution_feature_id: feature,
-      task_id: FactoryBot.create(:dynflow_task).id
-    )
-
-    job_template.template_inputs << playbook_url_input = FactoryBot.build(:template_input,
-      :name => 'playbook_url',
-      :input_type => 'user',
-      :required => true)
-    job_template.template_inputs << report_url_input = FactoryBot.build(:template_input,
-      :name => 'report_url',
-      :input_type => 'user',
-      :required => true)
-    job_template.template_inputs << correlation_id_input = FactoryBot.build(:template_input,
-      :name => 'correlation_id',
-      :input_type => 'user',
-      :required => true)
-    job_template.template_inputs << report_interval_input = FactoryBot.build(:template_input,
-      :name => 'report_interval',
-      :input_type => 'user',
-      :required => true)
-
-    template_invocation = FactoryBot.build(:template_invocation,
-      :template => job_template,
-      :job_invocation => job_invocation)
-
-    template_invocation.input_values << FactoryBot.create(
-      :template_invocation_input_value,
-      :template_invocation => template_invocation,
-      :template_input => playbook_url_input,
-      :value => 'http://example.com/TEST_PLAYBOOK'
-    )
-    template_invocation.input_values << FactoryBot.create(
-      :template_invocation_input_value,
-      :template_invocation => template_invocation,
-      :template_input => report_url_input,
-      :value => 'http://example.com/TEST_REPORT'
-    )
-    template_invocation.input_values << FactoryBot.create(
-      :template_invocation_input_value,
-      :template_invocation => template_invocation,
-      :template_input => correlation_id_input,
-      :value => 'TEST_CORRELATION'
-    )
-    template_invocation.input_values << FactoryBot.create(
-      :template_invocation_input_value,
-      :template_invocation => template_invocation,
-      :template_input => report_interval_input,
-      :value => '1'
-    )
-
-    @host1 = FactoryBot.create(:host, :with_insights_hits, name: 'host1')
-    @host1.insights.uuid = 'TEST_UUID1'
-    @host1.insights.save!
-    @host2 = FactoryBot.create(:host, :with_insights_hits, name: 'host2')
-    @host2.insights.uuid = 'TEST_UUID2'
-    @host2.insights.save!
-
-    targeting = FactoryBot.create(:targeting, hosts: [@host1, @host2])
-    job_invocation.targeting = targeting
-    job_invocation.save!
-
-    job_invocation.template_invocations << FactoryBot.create(
-      :template_invocation,
-      run_host_job_task: FactoryBot.create(:dynflow_task),
-      host_id: @host1.id
-    )
-    job_invocation.template_invocations << FactoryBot.create(
-      :template_invocation,
-      run_host_job_task: FactoryBot.create(:dynflow_task),
-      host_id: @host2.id
-    )
-
-    fake_output = (1..5).map do |i|
-      { 'timestamp' => (Time.now - (5 - i)).to_f, 'output' => "#{i}\n" }
-    end
-    Support::DummyDynflowAction.any_instance.stubs(:live_output).returns(fake_output)
-    Support::DummyDynflowAction.any_instance.stubs(:exit_status).returns(0)
+  test 'skips when rhc_instance_id is empty string' do
+    Setting[:rhc_instance_id] = ''
+
+    action = create_and_plan_action(InsightsCloud::Async::CloudConnectorAnnounceTask)
+
+    assert_empty action.execution_plan.planned_run_steps
+  end
+
+  test 'skips when in IoP mode' do
+    Setting[:rhc_instance_id] = 'test-rhc-id'
+    ForemanRhCloud.stubs(:with_iop_smart_proxy?).returns(true)
+
+    action = create_and_plan_action(InsightsCloud::Async::CloudConnectorAnnounceTask)
+
+    assert_empty action.execution_plan.planned_run_steps
+  end
+
+  test 'skips organizations without a manifest' do
+    Setting[:rhc_instance_id] = 'test-rhc-id'
+
+    InsightsCloud::Async::CloudConnectorAnnounceTask.any_instance
+                                                    .stubs(:cert_auth_available?).returns(false)
+
+    ForemanRhCloud::CloudPresence.any_instance
+                                 .expects(:announce_to_sources)
+                                 .never
 
-    job_invocation
+    action = create_and_plan_action(InsightsCloud::Async::CloudConnectorAnnounceTask)
+    action = run_action(action)
+
+    status = action.output[:status].to_s
+    assert_match(/Skipped \(no manifest\):/, status)
+    refute_match(/Registered/, status)
+    refute_match(/Failed/, status)
+  end
+
+  test 'still runs when allow_auto_inventory_upload is disabled' do
+    Setting[:rhc_instance_id] = 'test-rhc-id'
+    Setting[:allow_auto_inventory_upload] = false
+
+    InsightsCloud::Async::CloudConnectorAnnounceTask.any_instance
+                                                    .stubs(:cert_auth_available?).returns(true)
+
+    ForemanRhCloud::CloudPresence.any_instance
+                                 .expects(:announce_to_sources)
+                                 .times(Organization.unscoped.count)
+
+    action = create_and_plan_action(InsightsCloud::Async::CloudConnectorAnnounceTask)
+    action = run_action(action)
+
+    assert_match(/Registered:|Already registered:/, action.output[:status].to_s)
+  end
+
+  test 'skips orgs with recent cloud remediation jobs' do
+    Setting[:rhc_instance_id] = 'test-rhc-id'
+
+    InsightsCloud::Async::CloudConnectorAnnounceTask.any_instance
+                                                    .stubs(:cert_auth_available?).returns(true)
+    InsightsCloud::Async::CloudConnectorAnnounceTask.any_instance
+                                                    .stubs(:recent_cloud_remediation?).returns(true)
+
+    ForemanRhCloud::CloudPresence.any_instance
+                                 .expects(:announce_to_sources)
+                                 .never
+
+    action = create_and_plan_action(InsightsCloud::Async::CloudConnectorAnnounceTask)
+    action = run_action(action)
+
+    status = action.output[:status].to_s
+    assert_match(/Already registered \(recent cloud remediation\):/, status)
+    refute_match(/\bRegistered:/, status)
   end
 
-  def read_jsonl(jsonl)
-    jsonl.lines.map { |l| JSON.parse(l) }
+  test 'continues processing other orgs when one fails and task errors' do
+    Setting[:rhc_instance_id] = 'test-rhc-id'
+
+    InsightsCloud::Async::CloudConnectorAnnounceTask.any_instance
+                                                    .stubs(:cert_auth_available?).returns(true)
+
+    call_count = 0
+    ForemanRhCloud::CloudPresence.any_instance.stubs(:announce_to_sources).with do
+      call_count += 1
+      raise(StandardError.new('API error')) if call_count == 1
+      true
+    end
+
+    action = create_and_plan_action(InsightsCloud::Async::CloudConnectorAnnounceTask)
+
+    error = assert_raises(StandardError) { run_action(action) }
+    assert_match(/Sources announcement failed for:/, error.message)
+    assert_equal Organization.unscoped.count, call_count
   end
 end

data/webpack/ForemanInventoryUpload/Components/PageHeader/components/SyncButton/__tests__/integrations.test.js

@@ -3,24 +3,16 @@ import { render, screen, fireEvent } from '@testing-library/react';
 import { Provider } from 'react-redux';
 import configureMockStore from 'redux-mock-store';
 import thunk from 'redux-thunk';
-import * as API from 'foremanReact/redux/API';
 import ConnectedSyncButton from '../index';
-import { successResponse } from './SyncButtonFixtures';
-import { INVENTORY_SYNC } from '../SyncButtonConstants';
-
-jest.spyOn(API, 'post');
 
 const mockStore = configureMockStore([thunk]);
 
+afterEach(() => {
+  jest.clearAllMocks();
+});
+
 describe('SyncButton integration test', () => {
   it('dispatches sync action when button is clicked', () => {
-    API.post.mockImplementation(({ handleSuccess, key, ...action }) => {
-      if (key === INVENTORY_SYNC && handleSuccess) {
-        handleSuccess(successResponse);
-      }
-      return { type: 'API_POST', ...action };
-    });
-
     const store = mockStore({
       API: {},
     });

data/webpack/InsightsCloudSync/Components/InsightsTable/__tests__/InsightsTableActions.test.js

@@ -117,10 +117,10 @@ describe('InsightsTable actions', () => {
       expect(push).toHaveBeenCalled();
 
       const apiAction = dispatch.mock.calls.find(
-        call => call[0] && call[0].key === INSIGHTS_HITS_API_KEY
+        call => call[0] && call[0].payload?.key === INSIGHTS_HITS_API_KEY
       );
       expect(apiAction).toBeTruthy();
-      const getArg = apiAction[0];
+      const getArg = apiAction[0].payload;
       expect(getArg.url).toBe(INSIGHTS_HITS_PATH);
       expect(getArg.params.page).toBe(2);
       expect(getArg.params.per_page).toBe(7);

data/webpack/InsightsCloudSync/__tests__/InsightsCloudSyncActions.test.js

@@ -1,3 +1,4 @@
+import { API_OPERATIONS } from 'foremanReact/redux/API';
 import { syncInsights } from '../InsightsCloudSyncActions';
 import { INSIGHTS_CLOUD_SYNC } from '../InsightsCloudSyncConstants';
 
@@ -17,17 +18,18 @@ describe('InsightsCloudSync actions', () => {
 
     expect(dispatch).toHaveBeenCalledTimes(1);
     const dispatched = dispatch.mock.calls[0][0];
-    expect(dispatched.key).toBe(INSIGHTS_CLOUD_SYNC);
-    expect(dispatched.url).toBe('/insights_cloud/tasks');
-    expect(typeof dispatched.handleSuccess).toBe('function');
-    expect(typeof dispatched.errorToast).toBe('function');
+    expect(dispatched.type).toBe(API_OPERATIONS.POST);
+    expect(dispatched.payload.key).toBe(INSIGHTS_CLOUD_SYNC);
+    expect(dispatched.payload.url).toBe('/insights_cloud/tasks');
+    expect(typeof dispatched.payload.handleSuccess).toBe('function');
+    expect(typeof dispatched.payload.errorToast).toBe('function');
   });
 
   it('errorToast returns failure message with error details', () => {
     syncInsights(jest.fn(), '')(dispatch);
     const dispatched = dispatch.mock.calls[0][0];
 
-    const result = dispatched.errorToast('some error');
+    const result = dispatched.payload.errorToast('some error');
     expect(result).toContain('some error');
   });
 });

data/webpack/InsightsVulnerabilityActionsBar/__tests__/InsightsVulnerabilityActionsBar.test.js

@@ -1,13 +1,11 @@
 import React from 'react';
 import { render, screen } from '@testing-library/react';
 import '@testing-library/jest-dom';
-import * as ForemanContext from 'foremanReact/Root/Context/ForemanContext';
 import { ForemanHostsIndexActionsBarContext } from 'foremanReact/components/HostsIndex';
 import * as ConfigHooks from '../../common/Hooks/ConfigHooks';
 import InsightsVulnerabilityActionsBar from '../index';
 
 jest.mock('../../common/Hooks/ConfigHooks');
-jest.mock('foremanReact/Root/Context/ForemanContext');
 jest.mock('../InsightsVulnerabilityActionsBarActions');
 
 const mockContextValue = {
@@ -16,11 +14,9 @@ const mockContextValue = {
   setMenuOpen: jest.fn(),
 };
 
-const renderComponent = (contextOverrides = {}, orgId = 1) => {
+const renderComponent = (contextOverrides = {}) => {
   const contextValue = { ...mockContextValue, ...contextOverrides };
 
-  ForemanContext.useForemanOrganization.mockReturnValue({ id: orgId });
-
   return render(
     <ForemanHostsIndexActionsBarContext.Provider value={contextValue}>
       <InsightsVulnerabilityActionsBar />

data/webpack/test_setup.js

@@ -0,0 +1 @@
+import 'foremanJSTestSetup';

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_rh_cloud
 version: !ruby/object:Gem::Version
-  version: 14.4.0
+  version: 14.5.0
 platform: ruby
 authors:
 - Foreman Red Hat Cloud team
@@ -107,7 +107,6 @@ files:
 - app/overrides/layouts/base/styles.html.erb.deface
 - app/services/foreman_rh_cloud/branch_info.rb
 - app/services/foreman_rh_cloud/cert_auth.rb
-- app/services/foreman_rh_cloud/cloud_connector.rb
 - app/services/foreman_rh_cloud/cloud_ping_service.rb
 - app/services/foreman_rh_cloud/cloud_presence.rb
 - app/services/foreman_rh_cloud/cloud_request.rb
@@ -478,20 +477,14 @@ files:
 - webpack/InsightsVulnerabilityHostIndexExtensions/__tests__/CVECountCell.test.js
 - webpack/IopPathwayDetails/IopPathwayDetails.js
 - webpack/IopRecommendationDetails/IopRecommendationDetails.js
-- webpack/__mocks__/foremanReact/Root/Context/ForemanContext.js
-- webpack/__mocks__/foremanReact/common/I18n.js
 - webpack/__mocks__/foremanReact/common/MountingService.js
-- webpack/__mocks__/foremanReact/common/helpers.js
 - webpack/__mocks__/foremanReact/components/ConfirmModal/index.js
 - webpack/__mocks__/foremanReact/components/Head.js
 - webpack/__mocks__/foremanReact/components/HostsIndex/index.js
 - webpack/__mocks__/foremanReact/components/Layout/LayoutConstants.js
 - webpack/__mocks__/foremanReact/components/ToastsList/index.js
 - webpack/__mocks__/foremanReact/components/common/dates/RelativeDateTime.js
-- webpack/__mocks__/foremanReact/constants.js
 - webpack/__mocks__/foremanReact/redux.js
-- webpack/__mocks__/foremanReact/redux/API/APISelectors.js
-- webpack/__mocks__/foremanReact/redux/API/index.js
 - webpack/__mocks__/foremanReact/redux/middlewares/IntervalMiddleware.js
 - webpack/__mocks__/foremanReact/routes/RouterSelector.js
 - webpack/__mocks__/foremanReact/routes/common/PageLayout/PageLayout.js
@@ -514,6 +507,7 @@ files:
 - webpack/common/table/helpers.js
 - webpack/global_index.js
 - webpack/index.js
+- webpack/test_setup.js
 homepage: https://github.com/theforeman/foreman_rh_cloud
 licenses:
 - GPL-3.0

data/app/services/foreman_rh_cloud/cloud_connector.rb

@@ -1,74 +0,0 @@
-require 'securerandom'
-
-module ForemanRhCloud
-  class CloudConnector
-    CLOUD_CONNECTOR_USER = 'cloud_connector_user'.freeze
-    CLOUD_CONNECTOR_TOKEN_NAME = 'Cloud connector access token'.freeze
-    CLOUD_CONNECTOR_FEATURE = 'ansible_configure_cloud_connector'.freeze
-
-    def install
-      user = service_user
-      token_value = personal_access_token(user)
-      target_host = foreman_host
-      composer = nil
-
-      input = {
-        :satellite_cloud_connector_user => service_user.login,
-        :satellite_cloud_connector_password => token_value,
-      }
-
-      if (http_proxy = ForemanRhCloud.proxy_setting)
-        input[:satellite_cloud_connector_http_proxy] = http_proxy
-      end
-
-      Taxonomy.as_taxonomy(target_host.organization, target_host.location) do
-        composer = ::JobInvocationComposer.for_feature(
-          CLOUD_CONNECTOR_FEATURE,
-          [target_host.id],
-          input
-        )
-        composer.trigger!
-      end
-
-      composer.job_invocation
-    end
-
-    def latest_job
-      feature_id = RemoteExecutionFeature.find_by_label(CLOUD_CONNECTOR_FEATURE)&.id
-      return nil unless feature_id
-      JobInvocation.where(:remote_execution_feature_id => feature_id).includes(:task).reorder('foreman_tasks_tasks.started_at DESC').first
-    end
-
-    def personal_access_token(user)
-      access_token = PersonalAccessToken.find_by_name(CLOUD_CONNECTOR_TOKEN_NAME)
-
-      access_token&.destroy! # destroy the old token if exists
-
-      personal_access_token = PersonalAccessToken.new(:name => CLOUD_CONNECTOR_TOKEN_NAME, :user => user)
-      token_value = personal_access_token.generate_token
-      personal_access_token.save!
-
-      token_value
-    end
-
-    def service_user
-      user = User.find_by_login(CLOUD_CONNECTOR_USER)
-
-      if user.nil?
-        user = User.create!(
-          :login => CLOUD_CONNECTOR_USER,
-          :password => SecureRandom.base64(255),
-          :description => "This is a service user used by cloud connector to talk to the Satellite API",
-          :auth_source => AuthSourceInternal.first,
-          :admin => true
-        )
-      end
-
-      user
-    end
-
-    def foreman_host
-      ForemanRhCloud.foreman_host
-    end
-  end
-end

data/webpack/__mocks__/foremanReact/Root/Context/ForemanContext.js

@@ -1,6 +0,0 @@
-export const useForemanSettings = jest.fn(() => ({ perPage: 20 }));
-export const useForemanOrganization = jest.fn(() => ({
-  id: 1,
-  title: 'some-org',
-}));
-export const useForemanContext = jest.fn(() => ({ metadata: {} }));

data/webpack/__mocks__/foremanReact/common/I18n.js

@@ -1,6 +0,0 @@
-export { sprintf } from 'jed';
-
-export const translate = s => s;
-
-export const ngettext = (singular, plural, count) =>
-  count === 1 ? singular : plural;

data/webpack/__mocks__/foremanReact/common/helpers.js

@@ -1,14 +0,0 @@
-import camelCase from 'lodash/camelCase';
-
-export const getURIQuery = jest.fn(() => ({}));
-
-export const noop = Function.prototype;
-
-export const propsToCamelCase = ob => {
-  if (typeof ob !== 'object' || ob === null) return ob;
-
-  return Object.keys(ob).reduce((memo, key) => {
-    memo[camelCase(key)] = ob[key];
-    return memo;
-  }, {});
-};

data/webpack/__mocks__/foremanReact/constants.js

@@ -1,24 +0,0 @@
-export const STATUS = {
-  PENDING: 'PENDING',
-  RESOLVED: 'RESOLVED',
-  ERROR: 'ERROR',
-};
-
-export const getControllerSearchProps = (
-  controller,
-  id = 'searchBar',
-  canCreateBookmarks = true
-) => ({
-  controller,
-  autocomplete: {
-    id,
-    searchQuery: '',
-    url: `${controller}/auto_complete_search`,
-    useKeyShortcuts: true,
-  },
-  bookmarks: {
-    url: '/api/bookmarks',
-    canCreateBookmarks,
-    documentationUrl: `4.1.5Searching`,
-  },
-});

data/webpack/__mocks__/foremanReact/redux/API/APISelectors.js

@@ -1,24 +0,0 @@
-import { STATUS } from '../../constants';
-
-export const selectAPI = state => state.API || {};
-
-export const selectAPIByKey = (state, key) => selectAPI(state)[key] || {};
-
-export const selectAPIStatus = (state, key) =>
-  selectAPIByKey(state, key).status;
-
-export const selectAPIPayload = (state, key) =>
-  selectAPIByKey(state, key).payload || {};
-
-export const selectAPIResponse = (state, key) =>
-  selectAPIByKey(state, key).response || {};
-
-export const selectAPIError = (state, key) =>
-  selectAPIStatus(state, key) === STATUS.ERROR
-    ? selectAPIResponse(state, key)
-    : null;
-
-export const selectAPIErrorMessage = (state, key) => {
-  const error = selectAPIError(state, key);
-  return error && error.message;
-};

data/webpack/__mocks__/foremanReact/redux/API/index.js

@@ -1,12 +0,0 @@
-export const get = data => ({ type: 'get-some-type', ...data });
-export const put = data => ({ type: 'put-some-type', ...data });
-export const post = data => ({ type: 'post-some-type', ...data });
-export const patch = data => ({ type: 'patch-some-type', ...data });
-
-export const API = {
-  get: jest.fn(),
-  put: jest.fn(),
-  post: jest.fn(),
-  delete: jest.fn(),
-  patch: jest.fn(),
-};