foreman_remote_execution 4.2.3 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a9f5c20b58b5911c612164cc806d63b3096c81506b18cd11423fb4b073bdec4
-  data.tar.gz: 2c8615b8ef06bf5d5adc3e62ab2a36906714ebe9e99adbf13dfb3eaa742819d6
+  metadata.gz: f170eb66eb23ab9e671ff1137c9ca830041743eb83836947cf11da32432f119d
+  data.tar.gz: 0f4d52cce40bc8c9f89eb4e65242b1e3a25e4d0ce5ba9cf24b5fc9ff23346267
 SHA512:
-  metadata.gz: 549daa0a07ac47a7ed596187fd86943d9e1e517dab1d653af8f454ccee9e2b83fa85b6e2ec188201e5f849978b50b69108a0dbf6a6c67844b909de3b1b1e846f
-  data.tar.gz: b6e71fedfb385b05aa488fd65b68c2c242eba84783da007e26a6cf5f5b1b837de7bcbcfeecc72459b4c48cee93513f45948aa14318bbc548a52f159f2ae967cd
+  metadata.gz: 5964ee1b1bc9b3983f6f2677f9e38dbaf41416d16ace8ee1dcfc43f63d7250154b62722b191cc62b2b29c073d8035e0f813d5e576db167b05b1a2ea56cef6ce4
+  data.tar.gz: 3cf702ec56abf119a67f6bbbd1a0d2b6b2dbb067ee99ea31735d2b5bcedc87b194d992e48ffcfe8848799cc16eb872623523d73d16b5f8e6ddd8d47400d51e80

data/.github/workflows/js_ci.yml

@@ -0,0 +1,29 @@
+name: JS
+on:
+  pull_request:
+    paths:
+      - 'webpack/**'
+      - 'package.json'
+      - '.github/workflows/js_ci.yml'
+jobs:
+  test_js:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [12]
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup Node
+        uses: actions/setup-node@v1
+        with:
+          node-version:  ${{ matrix.node-version }}
+      - name: Npm install
+        run: |
+          npm install
+      - name: Run plugin linter
+        run: |
+          npm run lint
+      - name: Run plugin tests
+        run: |
+          npm run test

data/.github/workflows/{ci.yml → ruby_ci.yml}

@@ -1,5 +1,9 @@
-name: CI
-on: [pull_request]
+name: Ruby
+on:
+  pull_request:
+  push:
+    branches:
+      - master
 env:
   RAILS_ENV: test
   DATABASE_URL: postgresql://postgres:@localhost/test
@@ -12,16 +16,17 @@ jobs:
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.6
-      - name: Setup
-        run: |
-          gem install bundler
-          bundle install --jobs=3 --retry=3
+          ruby-version: 2.5
+          bundler-cache: true
       - name: Run rubocop
-        run: bundle exec rubocop
+        if: github.event_name != 'push'
+        run: bundle exec rubocop --format github
   test_ruby:
     runs-on: ubuntu-latest
     needs: rubocop
+    timeout-minutes: 30
+    env:
+      BUNDLE_WITHOUT: journald:development:console:libvirt
     services:
       postgres:
         image: postgres:12.1
@@ -31,7 +36,7 @@ jobs:
       fail-fast: false
       matrix:
         foreman-core-branch: [develop]
-        ruby-version: [2.5, 2.6]
+        ruby-version: [2.5, 2.7]
         node-version: [12]
     steps:
       - run: sudo apt-get update
@@ -43,59 +48,26 @@ jobs:
       - uses: actions/checkout@v2
         with:
           path: foreman_remote_execution
+      - name: Setup Bundler
+        run: |
+          echo "gem 'foreman_remote_execution', path: './foreman_remote_execution'" > bundler.d/foreman_remote_execution.local.rb
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
       - name: Setup Node
+        if: github.event_name != 'push'
         uses: actions/setup-node@v1
         with:
           node-version:  ${{ matrix.node-version }}
-      - uses: actions/cache@v1
-        with:
-          path: vendor/bundle
-          key: ${{ runner.os }}-fgems-${{ matrix.ruby-version }}-${{ hashFiles('Gemfile.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-fgems-${{ matrix.ruby-version }}-
-      - name: Setup Bundler
-        run: |
-          echo "gem 'foreman_remote_execution', path: './foreman_remote_execution'" > bundler.d/foreman_remote_execution.local.rb
-          gem install bundler
-          bundle config set without journald development console libvirt
-          bundle config set path vendor/bundle
-      - name: Prepare test env
+      - name: Prepare test DB
+        if: github.event_name != 'push'
         run: |
-          bundle install --jobs=3 --retry=3
           bundle exec rake db:create
           bundle exec rake db:migrate
       - name: Run plugin tests
+        if: github.event_name != 'push'
         run: |
           bundle exec rake test:foreman_remote_execution
           bundle exec rake test TEST="test/unit/foreman/access_permissions_test.rb"
-  test_js:
-    runs-on: ubuntu-latest
-    needs: rubocop
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby-version: [2.6]
-        node-version: [10, 12]
-    steps:
-      - uses: actions/checkout@v2
-      - name: Setup Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version: ${{ matrix.ruby-version }}
-      - name: Setup Node
-        uses: actions/setup-node@v1
-        with:
-          node-version:  ${{ matrix.node-version }}
-      - name: Nmp install
-        run: |
-          npm install
-      - name: Run plugin linter
-        run: |
-          npm run lint
-      - name: Run plugin tests
-        run: |
-          npm run test

data/.prettierrc

@@ -0,0 +1,4 @@
+{
+  "singleQuote": true,
+  "trailingComma": "es5"
+}

data/.rubocop.yml

@@ -1,29 +1,27 @@
-require:
-  - rubocop-minitest
-  - rubocop-performance
-  - rubocop-rails
+inherit_gem:
+  theforeman-rubocop:
+    - lenient.yml
+    - minitest.yml
 
 inherit_from: .rubocop_todo.yml
 
+inherit_mode:
+  merge:
+    - Exclude
+
 AllCops:
   TargetRubyVersion: 2.5
   TargetRailsVersion: 5.2
   Exclude:
     - 'node_modules/**/*'
+    - 'vendor/bundle/**/*'
 
 Bundler/OrderedGems:
   Enabled: false
 
-Layout/ArgumentAlignment:
-  EnforcedStyle: with_fixed_indentation
-  IndentationWidth: 2
-
 Layout/DotPosition:
   Enabled: false
 
-Layout/FirstArgumentIndentation:
-  EnforcedStyle: consistent
-
 Layout/HashAlignment:
   Enabled: false
 
@@ -33,6 +31,9 @@ Layout/LineLength:
 Layout/ParameterAlignment:
   Enabled: false
 
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
 Lint/BooleanSymbol:
   Enabled: false
 
@@ -42,12 +43,6 @@ Metrics:
 Performance/Casecmp:
   Enabled: false
 
-Performance/RedundantMatch:
-  Enabled: true
-
-Performance/RedundantMerge:
-  Enabled: true
-
 Performance/RegexpMatch:
   Enabled: false
 
@@ -66,12 +61,6 @@ Rails/BulkChangeTable:
 Rails/RefuteMethods:
   Enabled: false
 
-Style/Alias:
-  EnforcedStyle: prefer_alias_method
-
-Style/AndOr:
-  EnforcedStyle: conditionals
-
 # Don't prefer is_a? over kind_of?
 Style/ClassCheck:
   Enabled: false
@@ -83,13 +72,6 @@ Style/CollectionMethods:
 Style/ConditionalAssignment:
   Enabled: false
 
-# Don't enforce documentation
-Style/Documentation:
-  Enabled: false
-
-Style/EmptyMethod:
-  EnforcedStyle: expanded
-
 # Don't enforce frozen string literals
 Style/FrozenStringLiteralComment:
   Enabled: false
@@ -104,10 +86,6 @@ Style/IfUnlessModifier:
 Style/InverseMethods:
   Enabled: false
 
-# disabled until we can configure "+" as concat sign
-Style/LineEndConcatenation:
-  Enabled: false
-
 Style/MultipleComparison:
   Enabled: false
 
@@ -123,19 +101,5 @@ Style/ParenthesesAroundCondition:
 Style/PreferredHashMethods:
   Enabled: false
 
-# Both double and single quotes are OK
-Style/StringLiterals:
-  Enabled: false
-
-Style/TernaryParentheses:
-  EnforcedStyle: require_parentheses_when_complex
-
-Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: comma
-
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: comma
-
-#Allow both ['a', 'b'], %w[a b] and %w(a b) style arrays
-Style/WordArray:
+Style/RaiseArgs:
   Enabled: false

data/.rubocop_todo.yml

@@ -1,41 +1,67 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config --exclude-limit 0`
-# on 2020-03-14 13:43:47 +0100 using RuboCop version 0.80.1.
+# `rubocop --auto-gen-config`
+# on 2020-12-02 23:05:20 UTC using RuboCop version 1.5.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-Minitest/GlobalExpectations:
-  Enabled: false
-
 # Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: TreatCommentsAsGroupSeparators, Include.
+# Configuration parameters: Include.
 # Include: **/*.gemspec
-Gemspec/OrderedDependencies:
-  Enabled: false
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'foreman_remote_execution.gemspec'
+    - 'foreman_remote_execution_core.gemspec'
 
-# Offense count: 14
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, Severity.
+# SupportedStylesAlignWith: start_of_line, begin
+Layout/BeginEndAlignment:
+  Exclude:
+    - 'lib/foreman_remote_execution_core/script_runner.rb'
+
+# Offense count: 13
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
 # SupportedStyles: case, end
 Layout/CaseIndentation:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/job_invocations_controller.rb'
+    - 'app/controllers/job_templates_controller.rb'
+    - 'app/models/host_status/execution_status.rb'
 
 # Offense count: 4
 # Cop supports --auto-correct.
 Layout/EmptyLines:
-  Enabled: false
+  Exclude:
+    - 'app/models/template_invocation.rb'
+    - 'test/unit/input_template_renderer_test.rb'
+    - 'test/unit/job_invocation_composer_test.rb'
+    - 'test/unit/remote_execution_feature_test.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAliasSyntax, AllowedMethods.
+# AllowedMethods: alias_method, public, protected, private
+Layout/EmptyLinesAroundAttributeAccessor:
+  Exclude:
+    - 'app/lib/foreman_remote_execution/renderer/scope/input.rb'
+    - 'app/models/job_invocation_composer.rb'
 
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, no_empty_lines
 Layout/EmptyLinesAroundBlockBody:
-  Enabled: false
+  Exclude:
+    - 'extra/cockpit/foreman-cockpit-session'
+    - 'test/unit/input_template_renderer_test.rb'
+    - 'test/unit/job_invocation_composer_test.rb'
+    - 'test/unit/targeting_test.rb'
 
-# Offense count: 20
+# Offense count: 21
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
@@ -47,208 +73,377 @@ Layout/EmptyLinesAroundClassBody:
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
 Layout/EmptyLinesAroundModuleBody:
-  Enabled: false
+  Exclude:
+    - 'app/helpers/concerns/foreman_remote_execution/hosts_helper_extensions.rb'
+    - 'app/lib/actions/middleware/bind_job_invocation.rb'
+    - 'test/functional/api/v2/job_templates_controller_test.rb'
 
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: Width, IgnoredPatterns.
 Layout/IndentationWidth:
-  Enabled: false
+  Exclude:
+    - 'app/models/template_invocation.rb'
+    - 'extra/cockpit/foreman-cockpit-session'
 
-# Offense count: 9
+# Offense count: 7
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented
 Layout/MultilineOperationIndentation:
-  Enabled: false
+  Exclude:
+    - 'app/helpers/job_invocations_helper.rb'
+    - 'app/helpers/remote_execution_helper.rb'
+    - 'app/models/job_invocation_composer.rb'
+    - 'app/models/remote_execution_provider.rb'
+    - 'lib/foreman_remote_execution_core/dispatcher.rb'
 
-# Offense count: 5
+# Offense count: 7
 # Cop supports --auto-correct.
 Layout/SpaceAfterComma:
-  Enabled: false
+  Exclude:
+    - 'app/helpers/job_invocation_output_helper.rb'
+    - 'db/migrate/20200623073022_rename_sudo_password_to_effective_user_password.rb'
+    - 'test/functional/ui_job_wizard_controller_test.rb'
+    - 'test/unit/job_invocation_composer_test.rb'
 
-# Offense count: 28
+# Offense count: 29
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
 # SupportedStylesForExponentOperator: space, no_space
 Layout/SpaceAroundOperators:
-  Enabled: false
-
-# Offense count: 54
+  Exclude:
+    - 'app/controllers/ui_job_wizard_controller.rb'
+    - 'app/helpers/job_invocations_helper.rb'
+    - 'db/migrate/20150708133242_add_invocation.rb'
+    - 'extra/cockpit/foreman-cockpit-session'
+    - 'test/helpers/remote_execution_helper_test.rb'
+    - 'test/unit/input_template_renderer_test.rb'
+    - 'test/unit/job_invocation_composer_test.rb'
+
+# Offense count: 58
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
 # SupportedStyles: space, no_space, compact
 # SupportedStylesForEmptyBrackets: space, no_space
 Layout/SpaceInsideArrayLiteralBrackets:
-  Enabled: false
+  Exclude:
+    - 'app/helpers/concerns/foreman_remote_execution/hosts_helper_extensions.rb'
+    - 'app/helpers/remote_execution_helper.rb'
+    - 'app/lib/actions/remote_execution/run_host_job.rb'
+    - 'app/models/host_status/execution_status.rb'
+    - 'app/models/job_invocation.rb'
+    - 'app/models/job_invocation_composer.rb'
+    - 'app/models/job_template.rb'
+    - 'app/models/remote_execution_feature.rb'
+    - 'extra/cockpit/foreman-cockpit-session'
+    - 'lib/foreman_remote_execution/engine.rb'
+    - 'test/unit/execution_task_status_mapper_test.rb'
+    - 'test/unit/job_invocation_composer_test.rb'
+    - 'test/unit/targeting_test.rb'
 
-# Offense count: 95
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideHashLiteralBraces:
-  Enabled: false
+# Offense count: 2
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: enums
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - 'lib/foreman_remote_execution/engine.rb'
+
+# Offense count: 2
+Lint/MissingSuper:
+  Exclude:
+    - 'app/services/ui_notifications/remote_execution_jobs/base_job_finish.rb'
+    - 'lib/foreman_remote_execution_core/log_filter.rb'
 
 # Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
-  Enabled: false
+  Exclude:
+    - 'app/models/job_invocation_composer.rb'
+    - 'extra/cockpit/foreman-cockpit-session'
+    - 'lib/foreman_remote_execution/engine.rb'
+    - 'lib/foreman_remote_execution_core/script_runner.rb'
+    - 'test/factories/foreman_remote_execution_factories.rb'
 
 # Offense count: 15
 # Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
 Lint/UnusedMethodArgument:
-  Enabled: false
+  Exclude:
+    - 'app/helpers/concerns/foreman_remote_execution/hosts_helper_extensions.rb'
+    - 'app/helpers/remote_execution_helper.rb'
+    - 'app/lib/actions/remote_execution/run_host_job.rb'
+    - 'app/models/host_status/execution_status.rb'
+    - 'app/models/job_invocation.rb'
+    - 'app/models/job_invocation_composer.rb'
+    - 'app/models/job_template.rb'
+    - 'app/models/remote_execution_provider.rb'
+    - 'lib/foreman_remote_execution_core/script_runner.rb'
+    - 'test/benchmark/run_hosts_job_benchmark.rb'
+    - 'test/support/remote_execution_helper.rb'
 
 # Offense count: 4
 Lint/UselessAssignment:
-  Enabled: false
+  Exclude:
+    - 'app/lib/foreman_remote_execution/renderer/scope/input.rb'
+    - 'app/models/job_template.rb'
+    - 'app/models/remote_execution_feature.rb'
+    - 'extra/cockpit/foreman-cockpit-session'
 
-# Offense count: 1
+# Offense count: 31
+# Cop supports --auto-correct.
+Minitest/GlobalExpectations:
+  Exclude:
+    - 'test/helpers/remote_execution_helper_test.rb'
+    - 'test/unit/actions/run_hosts_job_test.rb'
+    - 'test/unit/concerns/foreman_tasks_cleaner_extensions_test.rb'
+    - 'test/unit/concerns/host_extensions_test.rb'
+    - 'test/unit/job_invocation_test.rb'
+    - 'test/unit/remote_execution_provider_test.rb'
+    - 'test/unit/targeting_test.rb'
+
+# Offense count: 2
 Naming/AccessorMethodName:
-  Enabled: false
+  Exclude:
+    - 'app/lib/actions/remote_execution/run_hosts_job.rb'
+    - 'app/models/concerns/foreman_remote_execution/host_extensions.rb'
 
-# Offense count: 5
-# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# Offense count: 6
+# Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, Regex, IgnoreExecutableScripts, AllowedAcronyms.
 # AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
 Naming/FileName:
-  Enabled: false
+  Exclude:
+    - 'db/seeds.d/100-assign_features_with_templates.rb'
+    - 'db/seeds.d/20-permissions.rb'
+    - 'db/seeds.d/50-notification_blueprints.rb'
+    - 'db/seeds.d/60-ssh_proxy_feature.rb'
+    - 'db/seeds.d/70-job_templates.rb'
+    - 'db/seeds.d/90-bookmarks.rb'
 
 # Offense count: 1
 # Configuration parameters: ForbiddenDelimiters.
 # ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
-  Enabled: false
+  Exclude:
+    - 'lib/foreman_remote_execution_core/fake_script_runner.rb'
 
 # Offense count: 2
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
 Naming/MethodParameterName:
-  Enabled: false
+  Exclude:
+    - 'app/helpers/remote_execution_helper.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredName.
 Naming/RescuedExceptionsVariableName:
-  Enabled: false
+  Exclude:
+    - 'Rakefile'
 
 # Offense count: 1
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: snake_case, normalcase, non_integer
-Naming/VariableNumber:
-  Enabled: false
+# Configuration parameters: MinSize.
+Performance/CollectionLiteralInLoop:
+  Exclude:
+    - 'db/seeds.d/90-bookmarks.rb'
+
+# Offense count: 11
+# Cop supports --auto-correct.
+Rails/ContentTag:
+  Exclude:
+    - 'app/helpers/job_invocations_helper.rb'
+    - 'app/helpers/remote_execution_helper.rb'
 
 # Offense count: 7
 # Configuration parameters: Include.
 # Include: db/migrate/*.rb
 Rails/CreateTableWithTimestamps:
-  Enabled: false
+  Exclude:
+    - 'db/migrate/20150708133241_add_targeting.rb'
+    - 'db/migrate/20150708133242_add_invocation.rb'
+    - 'db/migrate/20150708133305_add_template_invocation.rb'
+    - 'db/migrate/20151124162300_create_job_template_effective_users.rb'
+    - 'db/migrate/20160108134600_create_template_input_sets.rb'
+    - 'db/migrate/20160118124600_create_remote_execution_features.rb'
 
 # Offense count: 1
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible
 Rails/Date:
-  Enabled: false
+  Exclude:
+    - 'foreman_remote_execution.gemspec'
 
-# Offense count: 13
+# Offense count: 11
 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
 Rails/HelperInstanceVariable:
-  Enabled: false
+  Exclude:
+    - 'app/helpers/job_invocation_output_helper.rb'
+    - 'app/helpers/job_invocations_chart_helper.rb'
+    - 'app/helpers/remote_execution_helper.rb'
 
 # Offense count: 13
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/InverseOf:
-  Enabled: false
+  Exclude:
+    - 'app/models/concerns/foreman_remote_execution/foreman_tasks_task_extensions.rb'
+    - 'app/models/concerns/foreman_remote_execution/foreman_tasks_triggering_extensions.rb'
+    - 'app/models/concerns/foreman_remote_execution/host_extensions.rb'
+    - 'app/models/concerns/foreman_remote_execution/template_extensions.rb'
+    - 'app/models/job_invocation_task_group.rb'
+    - 'app/models/job_template.rb'
+    - 'app/models/template_invocation.rb'
 
 # Offense count: 1
 # Configuration parameters: Include.
 # Include: app/controllers/**/*.rb
 Rails/LexicallyScopedActionFilter:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/api/v2/job_invocations_controller.rb'
 
 # Offense count: 1
+# Cop supports --auto-correct.
 # Configuration parameters: Include.
 # Include: **/Rakefile, **/*.rake
 Rails/RakeEnvironment:
-  Enabled: false
+  Exclude:
+    - 'lib/tasks/foreman_remote_execution_tasks.rake'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Rails/RedundantForeignKey:
+  Exclude:
+    - 'app/models/job_template.rb'
+    - 'app/models/template_invocation.rb'
 
 # Offense count: 1
 Rails/ReflectionClassName:
-  Enabled: false
+  Exclude:
+    - 'app/models/job_template.rb'
 
-# Offense count: 21
-# Configuration parameters: Blacklist, Whitelist.
-# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
+# Offense count: 4
+# Configuration parameters: ForbiddenMethods, AllowedMethods.
+# ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all
 Rails/SkipsModelValidations:
-  Enabled: false
+  Exclude:
+    - 'app/lib/actions/middleware/bind_job_invocation.rb'
+    - 'app/models/concerns/foreman_remote_execution/smart_proxy_extensions.rb'
+    - 'test/unit/input_template_renderer_test.rb'
+    - 'test/unit/job_invocation_composer_test.rb'
 
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible
 Rails/TimeZone:
-  Enabled: false
+  Exclude:
+    - 'app/models/job_invocation_composer.rb'
+    - 'test/functional/api/v2/job_invocations_controller_test.rb'
+    - 'test/unit/job_invocation_composer_test.rb'
 
-# Offense count: 7
+# Offense count: 2
 # Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle.
+Style/CaseLikeIf:
+  Exclude:
+    - 'app/lib/actions/remote_execution/run_host_job.rb'
+    - 'app/models/job_invocation_composer.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/foreman_remote_execution/concerns/api/v2/registration_controller_extensions.rb'
+    - 'app/controllers/foreman_remote_execution/concerns/api/v2/subnets_controller_extensions.rb'
+    - 'app/models/concerns/foreman_remote_execution/orchestration/ssh.rb'
+    - 'app/models/host_status/execution_status.rb'
+    - 'app/models/setting/remote_execution.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: ==, equal?, eql?
+Style/ClassEqualityComparison:
+  Exclude:
+    - 'app/helpers/job_invocations_chart_helper.rb'
+    - 'app/helpers/remote_execution_helper.rb'
+    - 'app/models/ssh_execution_provider.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: Keywords.
-# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
+# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
 Style/CommentAnnotation:
-  Enabled: false
-
-# Offense count: 1
-Style/DoubleNegation:
-  Enabled: false
+  Exclude:
+    - 'app/models/job_invocation_composer.rb'
+    - 'db/seeds.d/90-bookmarks.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/Encoding:
-  Enabled: false
+  Exclude:
+    - 'foreman_remote_execution_core.gemspec'
 
 # Offense count: 8
 # Cop supports --auto-correct.
 Style/ExpandPathArguments:
-  Enabled: false
+  Exclude:
+    - 'Rakefile'
+    - 'foreman_remote_execution.gemspec'
+    - 'foreman_remote_execution_core.gemspec'
+    - 'lib/foreman_remote_execution/engine.rb'
+    - 'lib/foreman_remote_execution_core/polling_script_runner.rb'
+    - 'test/benchmark/run_hosts_job_benchmark.rb'
+    - 'test/benchmark/targeting_benchmark.rb'
 
 # Offense count: 12
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: format, sprintf, percent
 Style/FormatString:
-  Enabled: false
-
-# Offense count: 62
-# Configuration parameters: EnforcedStyle.
+  Exclude:
+    - 'app/controllers/api/v2/job_invocations_controller.rb'
+    - 'app/controllers/job_templates_controller.rb'
+    - 'app/helpers/job_invocations_chart_helper.rb'
+    - 'app/lib/actions/remote_execution/run_host_job.rb'
+    - 'app/lib/actions/remote_execution/run_hosts_job.rb'
+    - 'app/models/job_invocation_composer.rb'
+    - 'app/models/remote_execution_provider.rb'
+    - 'app/models/ssh_execution_provider.rb'
+    - 'extra/cockpit/foreman-cockpit-session'
+
+# Offense count: 61
+# Configuration parameters: MaxUnannotatedPlaceholdersAllowed.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
-  Enabled: false
+  EnforcedStyle: template
 
-# Offense count: 21
+# Offense count: 23
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
 
+# Offense count: 1
+# Cop supports --auto-correct.
 Style/HashEachMethods:
-  Enabled: false
-
-Style/HashTransformKeys:
-  Enabled: false
+  Exclude:
+    - 'app/models/concerns/foreman_remote_execution/errors_flattener.rb'
 
-Style/HashTransformValues:
-  Enabled: false
-
-# Offense count: 26
+# Offense count: 6
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'app/helpers/job_invocations_chart_helper.rb'
+    - 'app/models/concerns/foreman_remote_execution/host_extensions.rb'
+    - 'app/models/input_template_renderer.rb'
+    - 'app/models/job_invocation.rb'
+    - 'app/models/job_invocation_composer.rb'
+
+# Offense count: 29
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -256,18 +451,33 @@ Style/PercentLiteralDelimiters:
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: AllowedCompactTypes.
 # SupportedStyles: compact, exploded
 Style/RaiseArgs:
-  Enabled: false
+  EnforcedStyle: exploded
 
-# Offense count: 15
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantBegin:
+  Exclude:
+    - 'extra/cockpit/foreman-cockpit-session'
+
+# Offense count: 16
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleReturnValues.
 Style/RedundantReturn:
-  Enabled: false
-
-# Offense count: 76
+  Exclude:
+    - 'app/helpers/remote_execution_helper.rb'
+    - 'app/models/concerns/foreman_remote_execution/errors_flattener.rb'
+    - 'app/models/foreign_input_set.rb'
+    - 'app/models/host_status/execution_status.rb'
+    - 'app/models/job_invocation.rb'
+    - 'extra/cockpit/foreman-cockpit-session'
+    - 'lib/foreman_remote_execution_core/polling_script_runner.rb'
+    - 'lib/foreman_remote_execution_core/script_runner.rb'
+    - 'test/support/remote_execution_helper.rb'
+
+# Offense count: 79
 # Cop supports --auto-correct.
 Style/RedundantSelf:
   Enabled: false
@@ -275,25 +485,39 @@ Style/RedundantSelf:
 # Offense count: 3
 # Cop supports --auto-correct.
 Style/RescueModifier:
-  Enabled: false
+  Exclude:
+    - 'extra/cockpit/foreman-cockpit-session'
+    - 'lib/foreman_remote_execution/engine.rb'
 
-# Offense count: 11
+# Offense count: 13
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: implicit, explicit
 Style/RescueStandardError:
-  Enabled: false
+  Exclude:
+    - 'Rakefile'
+    - 'app/lib/actions/remote_execution/run_host_job.rb'
+    - 'app/lib/proxy_api/remote_execution_ssh.rb'
+    - 'app/models/concerns/foreman_remote_execution/orchestration/ssh.rb'
+    - 'app/models/input_template_renderer.rb'
+    - 'app/models/job_invocation_composer.rb'
+    - 'lib/foreman_remote_execution_core/polling_script_runner.rb'
+    - 'lib/foreman_remote_execution_core/script_runner.rb'
+    - 'lib/tasks/foreman_remote_execution_tasks.rake'
 
-# Offense count: 37
+# Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: MinSize.
-# SupportedStyles: percent, brackets
-Style/SymbolArray:
-  EnforcedStyle: brackets
+# Configuration parameters: AllowModifier.
+Style/SoleNestedConditional:
+  Exclude:
+    - 'app/helpers/concerns/foreman_remote_execution/job_templates_extensions.rb'
 
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.
 # IgnoredMethods: respond_to, define_method
 Style/SymbolProc:
-  Enabled: false
+  Exclude:
+    - 'app/models/concerns/foreman_remote_execution/foreman_tasks_cleaner_extensions.rb'
+    - 'app/models/concerns/foreman_remote_execution/host_extensions.rb'
+    - 'app/models/job_invocation_composer.rb'