foreman_remote_execution 16.3.2 → 16.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7254f1da767b1e48ba82c93e57cd093611b42cb302e9eca41f0bb844a0d1883
-  data.tar.gz: c19c6c596d7e531794003be27795b665ad4e2ef9055e94a51c4d6c50c361a75f
+  metadata.gz: 2db78eb6979bd486194e94b58c14978db6d08c02f675a042bd9827c9101b0639
+  data.tar.gz: c9060344c28a222b93fed7f26794fde15827030ae7b3b6197a66b9f86413b656
 SHA512:
-  metadata.gz: 792c2e9e61c5e42e471832f47503189eab7edb69a2f4c857a1ab9b659eef114da16fc89b08d78f891b600997f92221cbe0651249fbe953f8ad0f9bd5d9de4c37
-  data.tar.gz: 0e3797e25d92fb9e39606913937c0cb9a266f48c1780141969927362e095bd253a75426cf7e6309c14f4d981d29b77ff5aea018ad3a8f0b14fe49818d2c46050
+  metadata.gz: 478f4cc9af2467020b4498bdd757d9f3b33a5e233c65b0b941cb0eda2deacf0689077907298e111c7cc1ec13e64508c9cd33d0870df70fe8a7247dd99e9433a9
+  data.tar.gz: f2bf38fe739e5043ba595448090a4231a52ef923464eec41b470d71c8ccdf3f83c8faec3a47627c5a606601d343b42302093a3a22474f57dded90375933a506e

data/app/lib/proxy_api/remote_execution_ssh.rb

@@ -11,6 +11,15 @@ module ::ProxyAPI
       raise ProxyException.new(url, e, N_('Unable to fetch public key'))
     end
 
+    def ca_pubkey
+      get('ca_pubkey')&.strip
+    rescue RestClient::ResourceNotFound => e
+      Rails.logger.warn(format(N_("Unable to fetch CA public key: %{error}"), error: e.message))
+      nil
+    rescue => e
+      raise ProxyException.new(url, e, N_('Unable to fetch CA public key'))
+    end
+
     def drop_from_known_hosts(hostname)
       delete('known_hosts/' + hostname)
     rescue => e

data/app/models/concerns/foreman_remote_execution/host_extensions.rb

@@ -108,7 +108,12 @@ module ForemanRemoteExecution
     end
 
     def remote_execution_ssh_keys
-      remote_execution_proxies(%w(SSH Script), false).values.flatten.uniq.map { |proxy| proxy.pubkey }.compact.uniq
+      # only include public keys from SSH proxies that don't have SSH cert verification configured
+      remote_execution_proxies(%w(SSH Script), false).values.flatten.uniq.map { |proxy| proxy.pubkey if proxy.ca_pubkey.blank? }.compact.uniq
+    end
+
+    def remote_execution_ssh_ca_keys
+      remote_execution_proxies(%w(SSH Script), false).values.flatten.uniq.map { |proxy| proxy.ca_pubkey }.compact.uniq
     end
 
     def drop_execution_interface_cache
@@ -139,10 +144,13 @@ module ForemanRemoteExecution
 
     def extend_host_params_hash(params)
       keys = remote_execution_ssh_keys
+      ca_keys = remote_execution_ssh_ca_keys
       source = 'global'
-      if keys.present?
-        value, safe_value = params.fetch('remote_execution_ssh_keys', {}).values_at(:value, :safe_value).map { |v| [v].flatten.compact }
-        params['remote_execution_ssh_keys'] = {:value => value + keys, :safe_value => safe_value + keys, :source => source}
+      {keys: keys, ca_keys: ca_keys}.each do |key_set_name, key_set|
+        if key_set.present?
+          value, safe_value = params.fetch("remote_execution_ssh_#{key_set_name}", {}).values_at(:value, :safe_value).map { |v| [v].flatten.compact }
+          params["remote_execution_ssh_#{key_set_name}"] = {:value => value + key_set, :safe_value => safe_value + key_set, :source => source}
+        end
       end
       [:remote_execution_ssh_user, :remote_execution_effective_user_method,
        :remote_execution_connect_by_ip].each do |key|

data/app/models/concerns/foreman_remote_execution/smart_proxy_extensions.rb

@@ -11,6 +11,10 @@ module ForemanRemoteExecution
       self[:pubkey] || update_pubkey
     end
 
+    def ca_pubkey
+      self[:ca_pubkey] || update_ca_pubkey
+    end
+
     def update_pubkey
       return unless has_feature?(%w(SSH Script))
 
@@ -19,6 +23,15 @@ module ForemanRemoteExecution
       key
     end
 
+    def update_ca_pubkey
+      return unless has_feature?(%w(SSH Script))
+
+      # smart proxy is not required to have a CA pubkey, in which case an empty string is returned
+      key = ::ProxyAPI::RemoteExecutionSSH.new(:url => url).ca_pubkey&.presence
+      self.update_attribute(:ca_pubkey, key)
+      key
+    end
+
     def drop_host_from_known_hosts(host)
       ::ProxyAPI::RemoteExecutionSSH.new(:url => url).drop_from_known_hosts(host)
     end
@@ -26,6 +39,7 @@ module ForemanRemoteExecution
     def refresh
       errors = super
       update_pubkey
+      update_ca_pubkey
       errors
     end
   end

data/app/views/api/v2/smart_proxies/ca_pubkey.json.rabl

@@ -0,0 +1 @@
+attribute :ca_pubkey => :remote_execution_ca_pubkey

data/db/migrate/20250606125543_add_ca_pub_key_to_smart_proxy.rb

@@ -0,0 +1,5 @@
+class AddCAPubKeyToSmartProxy < ActiveRecord::Migration[7.0]
+  def change
+    add_column :smart_proxies, :ca_pubkey, :text
+  end
+end

data/lib/foreman_remote_execution/plugin.rb

@@ -213,6 +213,7 @@ Foreman::Plugin.register :foreman_remote_execution do
   extend_template_helpers ForemanRemoteExecution::RendererMethods
 
   extend_rabl_template 'api/v2/smart_proxies/main', 'api/v2/smart_proxies/pubkey'
+  extend_rabl_template 'api/v2/smart_proxies/main', 'api/v2/smart_proxies/ca_pubkey'
   extend_rabl_template 'api/v2/interfaces/main', 'api/v2/interfaces/execution_flag'
   extend_rabl_template 'api/v2/subnets/show', 'api/v2/subnets/remote_execution_proxies'
   extend_rabl_template 'api/v2/hosts/main', 'api/v2/host/main'

data/lib/foreman_remote_execution/version.rb

@@ -1,3 +1,3 @@
 module ForemanRemoteExecution
-  VERSION = '16.3.2'.freeze
+  VERSION = '16.4.0'.freeze
 end

data/test/unit/concerns/host_extensions_test.rb

@@ -12,6 +12,7 @@ class ForemanRemoteExecutionHostExtensionsTest < ActiveSupport::TestCase
 
     before do
       SmartProxy.any_instance.stubs(:pubkey).returns(sshkey)
+      SmartProxy.any_instance.stubs(:ca_pubkey).returns(nil)
       Setting[:remote_execution_ssh_user] = 'root'
       Setting[:remote_execution_effective_user_method] = 'sudo'
     end
@@ -61,6 +62,48 @@ class ForemanRemoteExecutionHostExtensionsTest < ActiveSupport::TestCase
     end
   end
 
+  describe 'has ssh CA key configured' do
+    let(:host) { FactoryBot.create(:host, :with_execution) }
+    let(:sshkey) { 'ssh-rsa AAAAB3NzaC1yc2EAAAABJQ foo@example.com' }
+    let(:ca_sshkey) { 'ssh-rsa AAAAB3NzaC1yc2EAAAABJE bar@example.com' }
+
+    before do
+      SmartProxy.any_instance.stubs(:pubkey).returns(sshkey)
+      SmartProxy.any_instance.stubs(:ca_pubkey).returns(ca_sshkey)
+      Setting[:remote_execution_ssh_user] = 'root'
+      Setting[:remote_execution_effective_user_method] = 'sudo'
+    end
+
+    it 'has CA ssh keys in the parameters' do
+      assert_includes host.remote_execution_ssh_ca_keys, ca_sshkey
+    end
+
+    it 'excludes ssh keys from proxies that have SSH CA key configured' do
+      assert_empty host.remote_execution_ssh_keys
+    end
+
+    it 'merges ssh CA keys from host parameters and proxies' do
+      key = 'ssh-rsa not-even-a-key something@somewhere.com'
+      host.host_parameters << FactoryBot.create(:host_parameter, :host => host, :name => 'remote_execution_ssh_ca_keys', :value => [key])
+      assert_includes host.host_param('remote_execution_ssh_ca_keys'), key
+      assert_includes host.host_param('remote_execution_ssh_ca_keys'), ca_sshkey
+    end
+
+    it 'has ssh CA keys in the parameters even when no user specified' do
+      FactoryBot.create(:smart_proxy, :ssh)
+      host.interfaces.first.subnet.remote_execution_proxies.clear
+      User.current = nil
+      assert_includes host.remote_execution_ssh_ca_keys, ca_sshkey
+    end
+
+    it 'merges ssh CA key as a string from host parameters and proxies' do
+      key = 'ssh-rsa not-even-a-key something@somewhere.com'
+      host.host_parameters << FactoryBot.create(:host_parameter, :host => host, :name => 'remote_execution_ssh_ca_keys', :value => key)
+      assert_includes host.host_param('remote_execution_ssh_ca_keys'), key
+      assert_includes host.host_param('remote_execution_ssh_ca_keys'), ca_sshkey
+    end
+  end
+
   context 'host has multiple nics' do
     let(:host) { FactoryBot.build(:host, :with_execution) }
 

data/webpack/JobInvocationDetail/JobInvocationHostTable.js

@@ -24,7 +24,13 @@ import TableIndexPage from 'foremanReact/components/PF4/TableIndexPage/TableInde
 import { getControllerSearchProps } from 'foremanReact/constants';
 import { Icon } from 'patternfly-react';
 import PropTypes from 'prop-types';
-import React, { useEffect, useMemo, useState, useRef } from 'react';
+import React, {
+  useEffect,
+  useMemo,
+  useState,
+  useRef,
+  useCallback,
+} from 'react';
 import { FormattedMessage } from 'react-intl';
 import { useHistory } from 'react-router-dom';
 import { useForemanSettings } from 'foremanReact/Root/Context/ForemanContext';
@@ -131,19 +137,22 @@ const JobInvocationHostTable = ({
   });
 
   // Search filter
-  const constructFilter = (filter = initialFilter, search = urlSearchQuery) => {
-    const dropdownFilterClause =
-      filter && filter !== 'all_statuses'
-        ? `job_invocation.result = ${filter}`
-        : null;
-    const parts = [dropdownFilterClause, search];
-    return parts
-      .filter(x => x)
-      .map(fragment => `(${fragment})`)
-      .join(' AND ');
-  };
+  const constructFilter = useCallback(
+    (filter = initialFilter, search = urlSearchQuery) => {
+      const dropdownFilterClause =
+        filter && filter !== 'all_statuses'
+          ? `job_invocation.result = ${filter}`
+          : null;
+      const parts = [dropdownFilterClause, search];
+      return parts
+        .filter(x => x)
+        .map(fragment => `(${fragment})`)
+        .join(' AND ');
+    },
+    [initialFilter, urlSearchQuery]
+  );
 
-  const handleResponse = (data, key) => {
+  const handleResponse = useCallback((data, key) => {
     if (key === JOB_INVOCATION_HOSTS) {
       const ids = data.data.results.map(i => i.id);
 
@@ -152,76 +161,94 @@ const JobInvocationHostTable = ({
     }
 
     setStatus(STATUS_UPPERCASE.RESOLVED);
-  };
+  }, []);
 
   // Call hosts data with params
-  const makeApiCall = (requestParams, callParams = {}) => {
-    dispatch(
-      APIActions.get({
-        key: callParams.key ?? ALL_JOB_HOSTS,
-        url: callParams.url ?? `/api/job_invocations/${id}/hosts`,
-        params: requestParams,
-        handleSuccess: data => handleResponse(data, callParams.key),
-        handleError: () => setStatus(STATUS_UPPERCASE.ERROR),
-        errorToast: ({ response }) =>
-          response?.data?.error?.full_messages?.[0] || response,
-      })
-    );
-  };
+  const makeApiCall = useCallback(
+    (requestParams, callParams = {}) => {
+      dispatch(
+        APIActions.get({
+          key: callParams.key ?? ALL_JOB_HOSTS,
+          url: callParams.url ?? `/api/job_invocations/${id}/hosts`,
+          params: requestParams,
+          handleSuccess: data => handleResponse(data, callParams.key),
+          handleError: () => setStatus(STATUS_UPPERCASE.ERROR),
+          errorToast: ({ response }) =>
+            response?.data?.error?.full_messages?.[0] || response,
+        })
+      );
+    },
+    [dispatch, id, handleResponse]
+  );
 
-  const filterApiCall = newAPIOptions => {
-    const newParams = newAPIOptions?.params ?? newAPIOptions ?? {};
+  const filterApiCall = useCallback(
+    newAPIOptions => {
+      const newParams = newAPIOptions?.params ?? newAPIOptions ?? {};
 
-    const filterSearch = constructFilter(
-      initialFilter,
-      newParams.search ?? urlSearchQuery
-    );
+      const filterSearch = constructFilter(
+        initialFilter,
+        newParams.search ?? urlSearchQuery
+      );
 
-    const finalParams = {
-      ...defaultParams,
-      ...newParams,
-    };
+      const finalParams = {
+        ...defaultParams,
+        ...newParams,
+      };
 
-    if (filterSearch === AWAITING_STATUS_FILTER) {
-      finalParams.awaiting = 'true';
-    } else if (filterSearch !== '') {
-      finalParams.search = filterSearch;
-    }
+      if (filterSearch === AWAITING_STATUS_FILTER) {
+        finalParams.awaiting = 'true';
+      } else if (filterSearch !== '') {
+        finalParams.search = filterSearch;
+      }
 
-    makeApiCall(finalParams, { key: JOB_INVOCATION_HOSTS });
+      makeApiCall(finalParams, { key: JOB_INVOCATION_HOSTS });
 
-    const urlSearchParams = new URLSearchParams(window.location.search);
+      const urlSearchParams = new URLSearchParams(window.location.search);
 
-    ['page', 'per_page', 'order'].forEach(key => {
-      if (finalParams[key]) urlSearchParams.set(key, finalParams[key]);
-    });
+      ['page', 'per_page', 'order'].forEach(key => {
+        if (finalParams[key]) urlSearchParams.set(key, finalParams[key]);
+      });
 
-    history.push({ search: urlSearchParams.toString() });
-  };
+      history.push({ search: urlSearchParams.toString() });
+    },
+    [
+      initialFilter,
+      urlSearchQuery,
+      defaultParams,
+      makeApiCall,
+      history,
+      constructFilter,
+    ]
+  );
 
   // Filter change
-  const handleFilterChange = newFilter => {
-    onFilterUpdate(newFilter);
-  };
+  const handleFilterChange = useCallback(
+    newFilter => {
+      onFilterUpdate(newFilter);
+    },
+    [onFilterUpdate]
+  );
 
   // Effects
   // run after mount
+  const initializedRef = useRef(false);
   useEffect(() => {
-    // Job Invo template load
-    makeApiCall(
-      {},
-      {
-        url: `/job_invocations/${id}/hosts`,
-        key: LIST_TEMPLATE_INVOCATIONS,
+    if (!initializedRef.current) {
+      // Job Invo template load
+      makeApiCall(
+        {},
+        {
+          url: `/job_invocations/${id}/hosts`,
+          key: LIST_TEMPLATE_INVOCATIONS,
+        }
+      );
+
+      if (initialFilter === '') {
+        onFilterUpdate('all_statuses');
       }
-    );
-
-    if (initialFilter === '') {
-      onFilterUpdate('all_statuses');
+      initializedRef.current = true;
     }
-
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
+  }, [makeApiCall, id, initialFilter, onFilterUpdate]);
 
   useEffect(() => {
     if (initialFilter !== '') filterApiCall();
@@ -230,8 +257,7 @@ const JobInvocationHostTable = ({
       prevStatusLabel.current = statusLabel;
       filterApiCall();
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [initialFilter, statusLabel, id]);
+  }, [initialFilter, statusLabel, id, filterApiCall]);
 
   const {
     updateSearchQuery: updateSearchQueryBulk,

data/webpack/JobInvocationDetail/index.js

@@ -79,15 +79,14 @@ const JobInvocationDetailPage = ({
     return () => {
       dispatch(stopInterval(JOB_INVOCATION_KEY));
     };
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [dispatch, id, finished, autoRefresh]);
 
+  const taskId = task?.id;
   useEffect(() => {
-    if (task?.id !== undefined) {
-      dispatch(getTask(`${task?.id}`));
+    if (taskId !== undefined) {
+      dispatch(getTask(`${taskId}`));
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [dispatch, task?.id]);
+  }, [dispatch, taskId]);
 
   const pageStatus =
     items.id === undefined

data/webpack/JobWizard/JobWizard.js

@@ -89,9 +89,6 @@ export const JobWizard = ({ rerunData }) => {
         concurrency_control = {},
       },
     }) => {
-      if (category !== job_category) {
-        setCategory(job_category);
-      }
       const advancedTemplateValues = {};
       const defaultTemplateValues = {};
       const inputs = template_inputs;
@@ -131,8 +128,7 @@ export const JobWizard = ({ rerunData }) => {
         };
       });
     },
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-    [category.length]
+    [setTemplateValues, setAdvancedValues]
   );
   useEffect(() => {
     if (rerunData) {
@@ -153,8 +149,7 @@ export const JobWizard = ({ rerunData }) => {
         },
       });
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [rerunData]);
+  }, [rerunData, setDefaults]);
   useEffect(() => {
     if (jobTemplateID) {
       dispatch(
@@ -199,8 +194,14 @@ export const JobWizard = ({ rerunData }) => {
         })
       );
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [rerunData, jobTemplateID, dispatch]);
+  }, [
+    rerunData,
+    jobTemplateID,
+    dispatch,
+    setDefaults,
+    setTemplateValues,
+    setAdvancedValues,
+  ]);
 
   const [isStartsBeforeError, setIsStartsBeforeError] = useState(false);
   const [isStartsAtError, setIsStartsAtError] = useState(false);
@@ -514,7 +515,7 @@ JobWizard.propTypes = {
     }),
     execution_timeout_interval: PropTypes.number,
     time_to_pickup: PropTypes.number,
-    remote_execution_feature_id: PropTypes.string,
+    remote_execution_feature_id: PropTypes.number,
     template_invocations: PropTypes.arrayOf(
       PropTypes.shape({
         template_id: PropTypes.number,

data/webpack/JobWizard/autofill.js

@@ -95,6 +95,14 @@ export const useAutoFill = ({
         });
       }
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [fills]);
+  }, [
+    fills,
+    setFills,
+    setSelectedTargets,
+    setHostsSearchQuery,
+    setJobTemplateID,
+    setTemplateValues,
+    setAdvancedValues,
+    dispatch,
+  ]);
 };

data/webpack/JobWizard/steps/AdvancedFields/__tests__/__snapshots__/AdvancedFields.test.js.snap

@@ -57,7 +57,7 @@ Array [
         "port": null,
         "preventInvalidHostname": false,
         "protocol": null,
-        "query": "resource=ForemanTasks%3A%3ATask&name=some+search",
+        "query": "resource=ForemanTasks%3A%3ATask",
         "urn": null,
         "username": null,
       },

data/webpack/JobWizard/steps/CategoryAndTemplate/index.js

@@ -55,8 +55,13 @@ const ConnectedCategoryAndTemplate = ({
         })
       );
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [jobCategoriesStatus]);
+  }, [
+    jobCategoriesStatus,
+    dispatch,
+    isCategoryPreselected,
+    setCategory,
+    setJobTemplate,
+  ]);
 
   const jobCategories = useSelector(selectJobCategories);
   const jobTemplatesSearch = useSelector(selectJobTemplatesSearch);
@@ -73,22 +78,29 @@ const ConnectedCategoryAndTemplate = ({
               per_page: 'all',
             }),
             handleSuccess: response => {
-              if (!jobTemplate)
-                setJobTemplate(
-                  current =>
-                    current ||
-                    Number(
-                      filterJobTemplates(response?.data?.results)[0]?.id
-                    ) ||
-                    null
-                );
+              const filteredTemplates = filterJobTemplates(
+                response?.data?.results
+              );
+              setJobTemplate(current => {
+                // Check if current template is in the new category's template list.
+                // This preserves the user's selection when changing categories on rerun,
+                // preventing the category from flashing and reverting back (Issue #38899).
+                // We check the state value (current) rather than the prop to avoid race conditions.
+                if (
+                  current &&
+                  filteredTemplates.some(template => template.id === current)
+                ) {
+                  return current;
+                }
+                // Otherwise, select the first template from the new category
+                return Number(filteredTemplates[0]?.id) || null;
+              });
             },
           })
         );
       }
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [category, dispatch]);
+  }, [category, dispatch, jobTemplatesSearch, setJobTemplate]);
 
   const jobTemplates = useSelector(selectJobTemplates);
 

data/webpack/JobWizard/steps/HostsAndInputs/SelectAPI.js

@@ -1,4 +1,4 @@
-import React from 'react';
+import React, { useCallback } from 'react';
 import { useSelector, useDispatch } from 'react-redux';
 import URI from 'urijs';
 import { SelectVariant } from '@patternfly/react-core/deprecated';
@@ -8,16 +8,21 @@ import { SearchSelect } from '../form/SearchSelect';
 
 export const useNameSearchAPI = (apiKey, url) => {
   const dispatch = useDispatch();
-  const uri = new URI(url);
-  const onSearch = search =>
-    dispatch(
-      get({
-        key: apiKey,
-        url: uri.addSearch({
-          search: `name~"${search}"`,
-        }),
-      })
-    );
+
+  const onSearch = useCallback(
+    search => {
+      const uri = new URI(url);
+      dispatch(
+        get({
+          key: apiKey,
+          url: uri.addSearch({
+            search: `name~"${search}"`,
+          }),
+        })
+      );
+    },
+    [dispatch, apiKey, url]
+  );
 
   const response = useSelector(state => selectResponse(state, apiKey));
   const isLoading = useSelector(state => selectIsLoading(state, apiKey));

data/webpack/JobWizard/steps/form/ResourceSelect.js

@@ -1,4 +1,4 @@
-import React, { useState, useEffect } from 'react';
+import React, { useState, useEffect, useRef, useCallback } from 'react';
 import PropTypes from 'prop-types';
 import {
   Select,
@@ -25,28 +25,30 @@ export const ResourceSelect = ({
   const { perPage } = useForemanSettings();
   const maxResults = perPage;
   const dispatch = useDispatch();
-  const uri = new URI(url);
-  const onSearch = search => {
-    dispatch(
-      get({
-        key: apiKey,
-        url: uri.addSearch(search),
-      })
-    );
-  };
+  const onSearch = useCallback(
+    search => {
+      const uri = new URI(url);
+      dispatch(
+        get({
+          key: apiKey,
+          url: uri.addSearch(search),
+        })
+      );
+    },
+    [dispatch, apiKey, url]
+  );
 
   const response = useSelector(state => selectResponse(state, apiKey));
   const isLoading = useSelector(state => selectIsLoading(state, apiKey));
   const [isOpen, setIsOpen] = useState(false);
   const [typingTimeout, setTypingTimeout] = useState(null);
+  const initializedRef = useRef(false);
   useEffect(() => {
-    onSearch(selected ? { id: selected } : {});
-    if (typingTimeout) {
-      return () => clearTimeout(typingTimeout);
+    if (!initializedRef.current) {
+      onSearch(selected ? { id: selected } : {});
+      initializedRef.current = true;
     }
-    return undefined;
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
+  }, [onSearch, selected]);
   let selectOptions = [];
   if (response.subtotal > maxResults) {
     selectOptions = [

data/webpack/JobWizard/steps/form/SearchSelect.js

@@ -1,4 +1,4 @@
-import React, { useState, useEffect } from 'react';
+import React, { useState, useEffect, useRef } from 'react';
 import PropTypes from 'prop-types';
 import {
   Select,
@@ -25,14 +25,13 @@ export const SearchSelect = ({
   const [onSearch, response, isLoading] = useNameSearch(apiKey, url);
   const [isOpen, setIsOpen] = useState(false);
   const [typingTimeout, setTypingTimeout] = useState(null);
+  const initializedRef = useRef(false);
   useEffect(() => {
-    onSearch(selected.name || '');
-    if (typingTimeout) {
-      return () => clearTimeout(typingTimeout);
+    if (!initializedRef.current) {
+      onSearch(selected.name || '');
+      initializedRef.current = true;
     }
-    return undefined;
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
+  }, [onSearch, selected.name]);
   let selectOptions = [];
   if (response.subtotal > maxResults) {
     selectOptions = [

data/webpack/JobWizard/validation.js

@@ -46,8 +46,6 @@ export const useValidation = ({ advancedValues, templateValues }) => {
         setValid(currValid => ({ ...currValid, advanced: false }));
       }
     });
-
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [advancedValues, templateValues]);
+  }, [advancedValues, templateValues, templateInputs, advancedTemplateInputs]);
   return [valid, setValid];
 };

data/webpack/react_app/components/TargetingHosts/index.js

@@ -1,4 +1,4 @@
-import React, { useEffect, useState } from 'react';
+import React, { useEffect, useState, useCallback, useRef } from 'react';
 import { useSelector, useDispatch } from 'react-redux';
 
 import { get } from 'foremanReact/redux/API';
@@ -50,38 +50,55 @@ const WrappedTargetingHosts = () => {
   const [apiUrl, setApiUrl] = useState(getApiUrl(searchQuery, pagination));
   const intervalExists = useSelector(selectIntervalExists);
 
-  const handleSearch = (query, status) => {
-    const defaultPagination = { page: 1, per_page: pagination.per_page };
-    stopApiInterval();
-
-    setApiUrl(getApiUrl(buildSearchQuery(query, status), defaultPagination));
-    setSearchQuery(query);
-    setPagination(defaultPagination);
-  };
-
-  const handlePagination = args => {
-    stopApiInterval();
-    setPagination(args);
-    setApiUrl(getApiUrl(buildSearchQuery(searchQuery, statusFilter), args));
-  };
-
-  const stopApiInterval = () => {
+  const stopApiInterval = useCallback(() => {
     if (intervalExists) {
       dispatch(stopInterval(TARGETING_HOSTS));
     }
-  };
-
-  const getData = url =>
-    withInterval(
-      get({
-        key: TARGETING_HOSTS,
-        url,
-        handleError: () => {
-          dispatch(stopInterval(TARGETING_HOSTS));
-        },
-      }),
-      1000
-    );
+  }, [dispatch, intervalExists]);
+
+  // Use ref to avoid infinite loop from handleSearch depending on pagination.per_page
+  const perPageRef = useRef(pagination.per_page);
+
+  const handleSearch = useCallback(
+    (query, status) => {
+      const defaultPagination = { page: 1, per_page: perPageRef.current };
+      stopApiInterval();
+
+      setApiUrl(getApiUrl(buildSearchQuery(query, status), defaultPagination));
+      setSearchQuery(query);
+      setPagination(defaultPagination);
+    },
+    [stopApiInterval]
+  );
+
+  // Keep ref in sync with pagination
+  useEffect(() => {
+    perPageRef.current = pagination.per_page;
+  }, [pagination.per_page]);
+
+  const handlePagination = useCallback(
+    args => {
+      stopApiInterval();
+      setPagination(args);
+      setApiUrl(getApiUrl(buildSearchQuery(searchQuery, statusFilter), args));
+    },
+    [searchQuery, statusFilter, stopApiInterval]
+  );
+
+  const getData = useCallback(
+    url =>
+      withInterval(
+        get({
+          key: TARGETING_HOSTS,
+          url,
+          handleError: () => {
+            dispatch(stopInterval(TARGETING_HOSTS));
+          },
+        }),
+        1000
+      ),
+    [dispatch]
+  );
 
   useEffect(() => {
     dispatch(getData(apiUrl));
@@ -93,11 +110,11 @@ const WrappedTargetingHosts = () => {
     return () => {
       dispatch(stopInterval(TARGETING_HOSTS));
     };
-  }, [dispatch, apiUrl, autoRefresh]);
+  }, [dispatch, apiUrl, autoRefresh, getData]);
 
   useEffect(() => {
     handleSearch(searchQuery, statusFilter);
-  }, [statusFilter, searchQuery]);
+  }, [statusFilter, searchQuery, handleSearch]);
 
   return (
     <TargetingHostsPage

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 16.3.2
+  version: 16.4.0
 platform: ruby
 authors:
 - Foreman Remote Execution team
 bindir: bin
 cert_chain: []
-date: 2025-12-08 00:00:00.000000000 Z
+date: 2026-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -223,6 +223,7 @@ files:
 - app/views/api/v2/remote_execution_features/index.json.rabl
 - app/views/api/v2/remote_execution_features/main.json.rabl
 - app/views/api/v2/remote_execution_features/show.json.rabl
+- app/views/api/v2/smart_proxies/ca_pubkey.json.rabl
 - app/views/api/v2/smart_proxies/pubkey.json.rabl
 - app/views/api/v2/subnets/remote_execution_proxies.json.rabl
 - app/views/api/v2/template_invocations/base.json.rabl
@@ -340,6 +341,7 @@ files:
 - db/migrate/20240522093412_add_smart_proxy_id_to_template_invocation.rb
 - db/migrate/20240522093413_migrate_smart_proxy_ids_to_template_invocations.rb
 - db/migrate/20241126150849_remove_remote_execution_workers_pool_size.rb
+- db/migrate/20250606125543_add_ca_pub_key_to_smart_proxy.rb
 - db/seeds.d/100-assign_features_with_templates.rb
 - db/seeds.d/20-permissions.rb
 - db/seeds.d/50-notification_blueprints.rb
@@ -606,7 +608,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.3
 specification_version: 4
 summary: A plugin bringing remote execution to the Foreman, completing the config
   management functionality with remote management functionality.