foreman_remote_execution 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9b67393920eea010c57e8994ea08e08b39ac660d
-  data.tar.gz: 5d99f91e886a5c512faced47136702fb4660977c
+  metadata.gz: fbd4cc854e9c31820b3dc2a1f9003613c5aa5ca1
+  data.tar.gz: 3f6b42cc33bac2022990315ed31d29fd537a5df9
 SHA512:
-  metadata.gz: f72a2ec071b11e5de82585ecaf63371d267215074d1e246bf2d2b29da086d09075b243a798689b1b54a92adf748726b753c7e3c6dd0c4a2a5c2ae795a5dcae9c
-  data.tar.gz: 7290328eb26ea95a4fb882a6f8d1258dc51052e289098105c6e261be6203cb06d8254c2eb223640ec30fa8cc6b1359b6dc99f18ab9f5468a7b642c7b209e00f3
+  metadata.gz: 7bdbfca1932005c1d8fe09c9a72adb2b72bedd9455a9a6bed8e53fd3fa750dbf659920a6f443503007ac529da9136a5bbee8964fa9271123227e7f501d3ff31e
+  data.tar.gz: 8f7d084a004c1c8b0705e2f37625801090cfb789990a14ce50613781e21e72c9be595f14e0c05a3cb915d70d68fd94966bc5ff9bea80cd13bb58c807fdba56c4

data/app/models/remote_execution_feature.rb

@@ -1,7 +1,7 @@
 class RemoteExecutionFeature < ActiveRecord::Base
   attr_accessible :label, :name, :provided_input_names, :description, :job_template_id
 
-  validate :label, :name, :presence => true, :unique => true
+  validates :label, :name, :presence => true, :uniqueness => true
 
   belongs_to :job_template
 

data/db/migrate/20150612121541_add_job_template_to_template.rb

@@ -1,6 +1,6 @@
 class AddJobTemplateToTemplate < ActiveRecord::Migration
   def change
-    add_column :templates, :job_name, :string
-    add_column :templates, :provider_type, :string
+    add_column :templates, :job_name, :string, :limit => 255
+    add_column :templates, :provider_type, :string, :limit => 255
   end
 end

data/db/migrate/20150616080015_create_template_input.rb

@@ -1,13 +1,13 @@
 class CreateTemplateInput < ActiveRecord::Migration
   def change
     create_table :template_inputs do |t|
-      t.string :name, :null => false
+      t.string :name, :null => false, :limit => 255
       t.boolean :required, :null => false, :default => false
-      t.string :input_type, :null => false
-      t.string :fact_name
-      t.string :variable_name
-      t.string :puppet_class_name
-      t.string :puppet_parameter_name
+      t.string :input_type, :null => false, :limit => 255
+      t.string :fact_name, :limit => 255
+      t.string :variable_name, :limit => 255
+      t.string :puppet_class_name, :limit => 255
+      t.string :puppet_parameter_name, :limit => 255
       t.text :description
       t.integer :template_id
 

data/db/migrate/20150708133241_add_targeting.rb

@@ -1,10 +1,10 @@
 class AddTargeting < ActiveRecord::Migration
   def change
     create_table :targetings do |t|
-      t.string :search_query
+      t.string :search_query, :limit => 255
       t.references :bookmark
       t.references :user
-      t.string :targeting_type, :null => false
+      t.string :targeting_type, :null => false, :limit => 255
       t.timestamps
     end
 

data/db/migrate/20150708133242_add_invocation.rb

@@ -2,7 +2,7 @@ class AddInvocation< ActiveRecord::Migration
   def change
     create_table :job_invocations do |t|
       t.references :targeting, :null => false
-      t.string :job_name, :null => false
+      t.string :job_name, :null => false, :limit => 255
     end
 
     add_index :job_invocations, [:targeting_id], :name => 'job_invocations_targeting_id'

data/db/migrate/20150708133305_add_template_invocation.rb

@@ -12,7 +12,7 @@ class AddTemplateInvocation < ActiveRecord::Migration
     create_table :template_invocation_input_values do |t|
       t.references :template_invocation, :null => false
       t.references :template_input, :null => false
-      t.string :value, :null => false
+      t.string :value, :null => false, :limit => 255
     end
 
     add_index :template_invocation_input_values, [:template_invocation_id, :template_input_id], :name => 'template_invocation_input_values_ti_ti_ids'

data/db/migrate/20150812145900_add_last_task_id_to_job_invocation.rb

@@ -1,6 +1,6 @@
 class AddLastTaskIdToJobInvocation < ActiveRecord::Migration
   def change
-    add_column :job_invocations, :last_task_id, :string
+    add_column :job_invocations, :last_task_id, :string, :limit => 255
     add_index :job_invocations, [:last_task_id], :name => 'job_invocations_last_task_id'
   end
 end

data/db/migrate/20150826191632_create_target_remote_execution_proxies.rb

@@ -3,7 +3,7 @@ class CreateTargetRemoteExecutionProxies < ActiveRecord::Migration
     create_table :target_remote_execution_proxies do |t|
       t.integer :remote_execution_proxy_id
       t.integer :target_id
-      t.string :target_type
+      t.string :target_type, :limit => 255
 
       t.timestamps
     end

data/db/migrate/20151120171100_add_effective_user_to_template_invocation.rb

@@ -1,5 +1,5 @@
 class AddEffectiveUserToTemplateInvocation < ActiveRecord::Migration
   def change
-    add_column :template_invocations, :effective_user, :string
+    add_column :template_invocations, :effective_user, :string, :limit => 255
   end
 end

data/db/migrate/20151124162300_create_job_template_effective_users.rb

@@ -2,7 +2,7 @@ class CreateJobTemplateEffectiveUsers < ActiveRecord::Migration
   def change
     create_table :job_template_effective_users do |t|
       t.integer :job_template_id
-      t.string :value
+      t.string :value, :limit => 255
       t.boolean :overridable
       t.boolean :current_user
     end

data/db/migrate/20151203100824_add_description_to_job_invocation.rb

@@ -1,7 +1,7 @@
 class AddDescriptionToJobInvocation < ActiveRecord::Migration
   def up
-    add_column :job_invocations, :description, :string
-    add_column :templates, :description_format, :string
+    add_column :job_invocations, :description, :string, :limit => 255
+    add_column :templates, :description_format, :string, :limit => 255
   end
 
   def down

data/db/migrate/20160108141144_make_job_name_default_to_something.rb

@@ -1,9 +1,9 @@
 class MakeJobNameDefaultToSomething < ActiveRecord::Migration
   def up
-    change_column :templates, :job_name, :string, :default => 'Miscellaneous'
+    change_column :templates, :job_name, :string, :default => 'Miscellaneous', :limit => 255
   end
 
   def down
-    change_column :templates, :job_name, :string, :default => nil
+    change_column :templates, :job_name, :string, :default => nil, :limit => 255
   end
 end

data/db/migrate/20160113161916_add_run_host_job_task_id_to_template_invocation.rb

@@ -1,6 +1,6 @@
 class AddRunHostJobTaskIdToTemplateInvocation < ActiveRecord::Migration
   def change
-    add_column :template_invocations, :run_host_job_task_id, :string
+    add_column :template_invocations, :run_host_job_task_id, :string, :limit => 255
     add_index :template_invocations, [:run_host_job_task_id], :name => 'template_invocations_run_host_job_task_id'
   end
 end

data/db/migrate/20160118124600_create_remote_execution_features.rb

@@ -1,14 +1,12 @@
 class CreateRemoteExecutionFeatures < ActiveRecord::Migration
   def change
     create_table :remote_execution_features do |t|
-      t.string :label, :index => true, :null => false
-      t.string :name, :null => false
-      t.string :description
+      t.string :label, :index => true, :null => false, :limit => 255
+      t.string :name, :null => false, :limit => 255
+      t.string :description, :limit => 255
       t.text :provided_inputs
-      t.integer :job_template_id
+      t.integer :job_template_id, :index => true
     end
-    add_index :remote_execution_features, :label
-    add_index :remote_execution_features, :job_template_id
     add_foreign_key :remote_execution_features, :templates, :column => :job_template_id
   end
 end

data/lib/foreman_remote_execution/version.rb

@@ -1,3 +1,3 @@
 module ForemanRemoteExecution
-  VERSION = '0.3.1'
+  VERSION = '0.3.2'
 end

data/lib/tasks/foreman_remote_execution_tasks.rake

@@ -36,14 +36,9 @@ namespace :foreman_remote_execution do
   end
 end
 
-Rake::Task[:test].enhance do
-  Rake::Task['test:foreman_remote_execution'].invoke
-end
+Rake::Task[:test].enhance ['test:foreman_remote_execution']
 
 load 'tasks/jenkins.rake'
 if Rake::Task.task_defined?(:'jenkins:unit')
-  Rake::Task['jenkins:unit'].enhance do
-    Rake::Task['test:foreman_remote_execution'].invoke
-    Rake::Task['foreman_remote_execution:rubocop'].invoke
-  end
+  Rake::Task['jenkins:unit'].enhance ['test:foreman_remote_execution', 'foreman_remote_execution:rubocop']
 end

data/test/factories/foreman_remote_execution_factories.rb

@@ -66,6 +66,7 @@ FactoryGirl.modify do
   factory :smart_proxy do
     trait :ssh do
       features { [FactoryGirl.build(:feature, :ssh)] }
+      pubkey 'ssh-rsa AAAAB3N...'
     end
   end
 

data/test/test_plugin_helper.rb

@@ -1,6 +1,6 @@
 # This calls the main test_helper in Foreman-core
 require 'test_helper'
-
+require 'database_cleaner'
 require 'dynflow/testing'
 
 # Add plugin to FactoryGirl's paths

data/test/unit/execution_task_status_mapper_test.rb

@@ -3,7 +3,7 @@ require 'test_plugin_helper'
 describe HostStatus::ExecutionStatus::ExecutionTaskStatusMapper do
 
   describe '.sql_conditions_for(status)' do
-    subject { HostStatus::ExecutionStatus::ExecutionTaskStatusMapper }
+    let(:subject) { HostStatus::ExecutionStatus::ExecutionTaskStatusMapper }
 
     it 'accepts status number as well as string representation' do
       subject.sql_conditions_for(HostStatus::ExecutionStatus::ERROR).must_equal subject.sql_conditions_for('failed')
@@ -18,7 +18,7 @@ describe HostStatus::ExecutionStatus::ExecutionTaskStatusMapper do
   let(:mapper) { HostStatus::ExecutionStatus::ExecutionTaskStatusMapper.new(task) }
 
   describe '#status' do
-    subject { mapper }
+    let(:subject) { mapper }
 
     describe 'is queued' do
       context 'when there is no task' do
@@ -65,7 +65,7 @@ describe HostStatus::ExecutionStatus::ExecutionTaskStatusMapper do
   end
 
   describe '#status_label' do
-    subject { mapper.status_label }
+    let(:subject) { mapper.status_label }
 
     context 'status is OK' do
       before do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Foreman Remote Execution team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-27 00:00:00.000000000 Z
+date: 2016-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface