foreman_remote_execution 0.0.10 → 0.1.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NGRlODQ0Y2VkM2NhNDdjMmQwOGI1Nzg4NzYxODg4ZjBlNTkxY2NiNQ==
-  data.tar.gz: !binary |-
-    ZGY2YjZkZGY4MzliZmMxMzg5Y2U2Yjg0NGRiNzQ5ZjZkZjA4YmIzYg==
+SHA1:
+  metadata.gz: 9a83d62de427a930126dbdac52051e2a6ca6e0cc
+  data.tar.gz: a304bc71914618eb42fa1648b4f6ce3f2f31fceb
 SHA512:
-  metadata.gz: !binary |-
-    MzE5ZjU3MjUyZTRhNTY5OTIwNzU1OWRjZTgwMzFmMmVlMzgxOTUzNzJkZWM2
-    ZTgyOGFlYzc1ZDA5NzVmNzM1MmM5NjQ3YWU2ZmZjZDA2YTE0N2ZmNDQwMzNj
-    OGRiMmUxOTVjNzMwOTNhZDIwNGFkZjdiZWM5NjI0MWI5YjNiYTY=
-  data.tar.gz: !binary |-
-    YzgyYzRmYTExZDlmNDczZGExMWQzN2UyM2FlMTYzY2RmODIyMmI3MjNkZWJj
-    OTY4YTIyNzg2ODI3NDgzYjk2ODAwNzcwMmYxNjAwMmQwMDlmMWFmNGUzOGM0
-    MDY1YjdkZjY2OWE3MjcwYzBlNTU2ZTNjMGE3MWZjN2VlMzNiYmQ=
+  metadata.gz: 9afcf6f187db3707ed4842ad877d8273c3bead70b25f0fb078dacc2888d0218cbed4d41c2b2e85e874cc88522946488915ff123883e12f507638c9ef1581f9ea
+  data.tar.gz: 8a38221109dea89d1b5c91f84179727e563b2f880a948b83029adda2df3b6ffddd058dcc5e5651cb32d06bc1c6ada3bc6ddcc6b15e83fb8c3f9db71296c8d371

data/README.md

@@ -5,36 +5,29 @@
 
 # Foreman Remote Execution
 
-A plugin bringing remote execution to the Foreman, completing the config 
+A plugin bringing remote execution to the Foreman, completing the config
 management functionality with remote management functionality.
 
-## Installation
+* Website: [theforeman.org](http://theforeman.org)
+* Support: [Foreman support](http://theforeman.org/support.html)
 
-See [How_to_Install_a_Plugin](http://projects.theforeman.org/projects/foreman/wiki/How_to_Install_a_Plugin)
-for how to install Foreman plugins
+## Features
 
-## Usage
+* Visualize remote execution job process live
+![job detail](http://theforeman.org/plugins/foreman_remote_execution/0.0/job_detail_1.png)
+* Schedule or run jobs on hosts
+![invocation form](http://theforeman.org/plugins/foreman_remote_execution/0.0/invocation_form.png)
+* Create templates to customize your jobs
+![job templates](http://theforeman.org/plugins/foreman_remote_execution/0.0/job_template_form.png)
 
-*Usage here*
+## Installation and usage
 
-## Generating the docs
-
-0. ``cd doc``
-
-0. ``mkdir .bin`` # only first time
-
-1. ``bundle install``
-
-2. ``bundle exec rake plantuml_install`` to install prerequisites
-
-3. ``bundle exec jekyll serve`` to see the rendered changes locally
-
-4. ``bundle exec rake publish`` to publish the changes to Github pages
+Check the Foreman manual [remote execution section](http://theforeman.org/plugins/foreman_remote_execution/)
 
 ## Links
 
-* [the project page](http://theforeman.github.io/foreman_remote_execution/)
-* [the issue tracker](http://projects.theforeman.org/projects/foreman_remote_execution)
+* [Design document](http://theforeman.github.io/foreman_remote_execution/design/)
+* [Issue tracker](http://projects.theforeman.org/projects/foreman_remote_execution)
 
 ## Contributing
 

data/app/assets/javascripts/template_invocation.js

@@ -24,6 +24,33 @@ function refresh_search_query(value){
   $('textarea#targeting_search_query').val($('span#bookmark_query_map span#bookmark-' + id).data('query'));
 }
 
+function show_preview_hosts_modal() {
+  var modal_window = $('#previewHostsModal');
+
+  var form = $('form#job_invocation_form');
+  var data = form.serializeArray();
+
+  request = $.ajax({
+    data: data,
+    type: 'GET',
+    url: modal_window.attr('data-url'),
+    success: function(request) {
+      modal_window.find('.modal-body').html(request);
+    },
+    complete: function() {
+      modal_window.modal({'show': true});
+      modal_window.find('a[rel="popover-modal"]').popover();
+    }
+  });
+}
+
+function close_preview_hosts_modal() {
+  var modal_window = $('#previewHostsModal');
+  modal_window.modal('hide');
+  modal_window.removeData();
+  modal_window.find('.modal-body').html('');
+}
+
 function job_invocation_form_binds() {
   $('input.job_template_selector').on('click', function () {
     parent_fieldset = $(this).closest('fieldset');
@@ -40,6 +67,8 @@ function job_invocation_form_binds() {
 
   $('button#refresh_execution_form').on('click', refresh_execution_form);
 
+  $('button#preview_hosts').on('click', show_preview_hosts_modal);
+
   $('textarea#targeting_search_query').on('change', refresh_execution_form);
 
   $('select#targeting_bookmark_id').on('change', refresh_search_query);

data/app/controllers/job_invocations_controller.rb

@@ -56,12 +56,25 @@ class JobInvocationsController < ApplicationController
     @composer = JobInvocationComposer.new.compose_from_params(params)
   end
 
+  def preview_hosts
+    composer = JobInvocationComposer.new.compose_from_params(params)
+
+    @hosts = composer.targeted_hosts.limit(Setting[:entries_per_page])
+    @additional = composer.targeted_hosts.count - Setting[:entries_per_page]
+    @dynamic = composer.targeting.dynamic?
+    @query = composer.displayed_search_query
+
+    render :partial => 'job_invocations/preview_hosts_list'
+  end
+
   private
 
   def action_permission
     case params[:action]
       when 'rerun'
         'create'
+      when 'preview_hosts'
+        'create'
       else
         super
     end

data/app/controllers/job_templates_controller.rb

@@ -11,7 +11,7 @@ class JobTemplatesController < ::TemplatesController
   end
 
   def preview
-    base = Host.authorized(:view_hosts)
+    base = Host.authorized(:view_hosts, Host)
     host = params[:preview_host_id].present? ? base.find(params[:preview_host_id]) : base.first
     @template.template = params[:template]
     renderer = InputTemplateRenderer.new(@template, host)

data/app/helpers/remote_execution_helper.rb

@@ -11,7 +11,7 @@ module RemoteExecutionHelper
     options = { :class => 'statistics-pie small', :expandable => true, :border => 0, :show_title => true }
 
     if (bulk_task = invocation.last_task)
-      failed_tasks = bulk_task.sub_tasks.select { |sub_task| %w(warning error).include? sub_task.result }
+      failed_tasks = bulk_task.sub_tasks.select { |sub_task| task_failed? sub_task }
       cancelled_tasks, failed_tasks = failed_tasks.partition { |task| task_cancelled? task }
       success = bulk_task.output['success_count'] || 0
       cancelled = cancelled_tasks.length
@@ -42,6 +42,10 @@ module RemoteExecutionHelper
     end
   end
 
+  def task_failed?(task)
+    %w(warning error).include? task.result
+  end
+
   def task_cancelled?(task)
     task.execution_plan.errors.map(&:exception).any? { |exception| exception.class == ::ForemanTasks::Task::TaskCancelledException }
   end
@@ -77,7 +81,7 @@ module RemoteExecutionHelper
     if task.nil?
       []
     else
-      [display_link_if_authorized(_("Details"), hash_for_template_invocation_path(:id => task).merge(:auth_object => host, :permission => :view_foreman_tasks))]
+      [display_link_if_authorized(_("Details"), hash_for_template_invocation_path(:id => task).merge(:auth_object => host, :permission => :view_hosts))]
     end
   end
 
@@ -86,17 +90,19 @@ module RemoteExecutionHelper
     template_invocation.nil? ? _('N/A') : _(RemoteExecutionProvider.provider_for(template_invocation.template.provider_type))
   end
 
+  # rubocop:disable Metrics/AbcSize
   def job_invocation_task_buttons(task)
     buttons = []
     buttons << link_to(_('Refresh'), {}, :class => 'btn btn-default', :title => _('Refresh this page'))
-    if authorized_for(:permission => :create_job_invocations)
+    if authorized_for(hash_for_new_job_invocation_path)
       buttons << link_to(_("Rerun"), rerun_job_invocation_path(:id => task.locks.where(:resource_type => 'JobInvocation').first.resource),
                          :class => "btn btn-default",
                          :title => _('Rerun the job'))
     end
-    if authorized_for(:permission => :create_job_invocations)
+    if authorized_for(hash_for_new_job_invocation_path)
       buttons << link_to(_("Rerun failed"), rerun_job_invocation_path(:id => task.locks.where(:resource_type => 'JobInvocation').first.resource, :failed_only => 1),
                          :class => "btn btn-default",
+                         :disabled => !task.sub_tasks.any? { |sub_task| task_failed?(sub_task) },
                          :title => _('Rerun on failed hosts'))
     end
     if authorized_for(:permission => :view_foreman_tasks, :auth_object => task)
@@ -113,6 +119,7 @@ module RemoteExecutionHelper
     end
     return buttons
   end
+  # rubocop:enable Metrics/AbcSize
 
   def template_invocation_task_buttons(task)
     buttons = []

data/app/lib/actions/remote_execution/run_host_job.rb

@@ -6,8 +6,6 @@ module Actions
         :link
       end
 
-      include ::Dynflow::Action::Cancellable
-
       def plan(job_invocation, host, template_invocation, proxy, connection_options = {})
         action_subject(host, :job_name => job_invocation.job_name)
         hostname = find_ip_or_hostname(host)
@@ -27,7 +25,16 @@ module Actions
         link!(job_invocation)
         link!(template_invocation)
 
-        plan_action(RunProxyCommand, proxy, hostname, script, { :connection_options => connection_options })
+        provider = template_invocation.template.provider_type.to_s
+        plan_action(RunProxyCommand, proxy, hostname, script, { :connection_options => connection_options }.merge(provider_settings(provider, host)))
+        plan_self
+      end
+
+      def finalize(*args)
+        host = Host.find(input[:host][:id])
+        host.refresh_statuses
+      rescue => e
+        Foreman::Logging.exception "Could not update execution status for #{input[:host][:name]}", e
       end
 
       def humanized_output
@@ -55,6 +62,15 @@ module Actions
 
         return host.fqdn
       end
+
+      def provider_settings(provider, host)
+        case provider
+        when 'Ssh'
+          { :ssh_user => host.params['remote_execution_ssh_user'] || Setting[:remote_execution_ssh_user] }
+        else
+          {}
+        end
+      end
     end
   end
 end

data/app/lib/proxy_api/remote_execution_ssh.rb

@@ -0,0 +1,14 @@
+module ::ProxyAPI
+  class RemoteExecutionSSH < ::ProxyAPI::Resource
+    def initialize(args)
+      @url = args[:url] + '/ssh'
+      super args
+    end
+
+    def pubkey
+      get('pubkey').strip
+    rescue => e
+      raise ProxyException.new(url, e, N_('Unable to fetch public key'))
+    end
+  end
+end

data/app/models/concerns/foreman_remote_execution/host_extensions.rb

@@ -6,8 +6,30 @@ module ForemanRemoteExecution
       alias_method_chain :build_required_interfaces, :remote_execution
       alias_method_chain :reload, :remote_execution
       alias_method_chain :becomes, :remote_execution
+      alias_method_chain :params, :remote_execution
 
       has_many :targeting_hosts, :dependent => :destroy, :foreign_key => 'host_id'
+
+      has_one :execution_status_object, :class_name => 'HostStatus::ExecutionStatus', :foreign_key => 'host_id'
+
+      scoped_search :in => :execution_status_object, :on => :status, :rename => :'execution_status',
+                    :complete_value => { :ok => HostStatus::ExecutionStatus::OK, :error => HostStatus::ExecutionStatus::ERROR }
+    end
+
+    def execution_status(options = {})
+      @execution_status ||= get_status(HostStatus::ExecutionStatus).to_status(options)
+    end
+
+    def execution_status_label(options = {})
+      @execution_status_label ||= get_status(HostStatus::ExecutionStatus).to_label(options)
+    end
+
+    def params_with_remote_execution
+      params = params_without_remote_execution
+      keys = remote_execution_ssh_keys
+      params['remote_execution_ssh_keys'] = keys unless keys.blank?
+      params['remote_execution_ssh_user'] = Setting[:remote_execution_ssh_user] unless params.key?('remote_execution_ssh_user')
+      params
     end
 
     def execution_interface
@@ -32,13 +54,17 @@ module ForemanRemoteExecution
       proxies
     end
 
+    def remote_execution_ssh_keys
+      remote_execution_proxies('Ssh').values.flatten.uniq.map { |proxy| proxy.pubkey }.compact.uniq
+    end
+
     def drop_execution_interface_cache
       @execution_interface = nil
     end
 
     def becomes_with_remote_execution(*args)
       became = becomes_without_remote_execution(*args)
-      became.drop_execution_interface_cache
+      became.drop_execution_interface_cache if became.respond_to? :drop_execution_interface_cache
       became
     end
 

data/app/models/concerns/foreman_remote_execution/smart_proxy_extensions.rb

@@ -0,0 +1,26 @@
+module ForemanRemoteExecution
+  module SmartProxyExtensions
+    extend ActiveSupport::Concern
+
+    included do
+      alias_method_chain :refresh, :remote_execution
+    end
+
+    def pubkey
+      self[:pubkey] || update_pubkey
+    end
+
+    def update_pubkey
+      return unless has_feature?('Ssh')
+      key = ::ProxyAPI::RemoteExecutionSSH.new(:url => url).pubkey
+      self.update_attribute(:pubkey, key) if key
+      key
+    end
+
+    def refresh_with_remote_execution
+      errors = refresh_without_remote_execution
+      update_pubkey
+      errors
+    end
+  end
+end

data/app/models/host_status/execution_status.rb

@@ -0,0 +1,49 @@
+class HostStatus::ExecutionStatus < HostStatus::Status
+  OK = 0
+  ERROR = 1
+
+  def relevant?
+    execution_tasks.present?
+  end
+
+  def to_status(options = {})
+    if last_stopped_task.nil? || last_stopped_task.result == 'success'
+      OK
+    else
+      ERROR
+    end
+  end
+
+  def to_global(options = {})
+    if to_status(options) == ERROR
+      return HostStatus::Global::ERROR
+    else
+      return HostStatus::Global::OK
+    end
+  end
+
+  def self.status_name
+    N_('Execution')
+  end
+
+  def to_label(options = {})
+    case to_status(options)
+      when OK
+        execution_tasks.present? ? N_('Last execution succeeded') : N_('No execution finished yet')
+      when ERROR
+        N_('Last execution failed')
+      else
+        N_('Unknown execution status')
+    end
+  end
+
+  private
+
+  def last_stopped_task
+    @last_stopped_task ||= execution_tasks.order(:started_at).where(:state => 'stopped').last
+  end
+
+  def execution_tasks
+    ForemanTasks::Task::DynflowTask.for_action(Actions::RemoteExecution::RunHostJob).for_resource(host)
+  end
+end

data/app/models/job_invocation_composer.rb

@@ -118,8 +118,16 @@ class JobInvocationComposer
     Bookmark.authorized(:view_bookmarks).my_bookmarks.where(:controller => ['hosts', 'dashboard'])
   end
 
+  def targeted_hosts
+    if displayed_search_query.blank?
+      Host.where('1 = 0')
+    else
+      Host.authorized(Targeting::RESOLVE_PERMISSION, Host).search_for(displayed_search_query)
+    end
+  end
+
   def targeted_hosts_count
-    Host.authorized(:view_hosts, Host).search_for(displayed_search_query).count
+    targeted_hosts.count
   rescue
     0
   end
@@ -232,6 +240,6 @@ class JobInvocationComposer
   end
 
   def validate_host_ids(ids)
-    Host.authorized(:view_hosts, Host).where(:id => ids).pluck(:id)
+    Host.authorized(Targeting::RESOLVE_PERMISSION, Host).where(:id => ids).pluck(:id)
   end
 end

data/app/models/job_template.rb

@@ -28,6 +28,7 @@ class JobTemplate < ::Template
                   end
                 }
 
+  validates :job_name, :presence => true, :unless => ->(job_template) { job_template.snippet }
   validates :provider_type, :presence => true
   validate :provider_type_whitelist
 

data/app/models/setting/remote_execution.rb

@@ -13,7 +13,10 @@ class Setting::RemoteExecution < Setting
                  N_("Search for remote execution proxy outside of the proxies assigned to the host. " +
                  "If locations or organizations are enabled, the search will be limited to the host's " +
                  "organization or location."),
-                 false),
+                 true),
+        self.set('remote_execution_ssh_user',
+                 N_("Default user to use for SSH.  You may override per host by setting a parameter called remote_execution_ssh_user."),
+                 'root'),
       ].each { |s| self.create! s.update(:category => "Setting::RemoteExecution") }
     end
 

data/app/models/targeting.rb

@@ -3,6 +3,7 @@ class Targeting < ActiveRecord::Base
   STATIC_TYPE = 'static_query'
   DYNAMIC_TYPE = 'dynamic_query'
   TYPES = { STATIC_TYPE => N_('Static Query'), DYNAMIC_TYPE => N_('Dynamic Query') }
+  RESOLVE_PERMISSION = :view_hosts
 
   belongs_to :user
   belongs_to :bookmark
@@ -26,7 +27,7 @@ class Targeting < ActiveRecord::Base
     self.search_query = bookmark.query if dynamic? && bookmark.present?
     self.touch(:resolved_at)
     self.save!
-    self.hosts = User.as(user.login) { Host.authorized('edit_hosts', Host).search_for(search_query) }
+    self.hosts = User.as(user.login) { Host.authorized(RESOLVE_PERMISSION, Host).search_for(search_query) }
   end
 
   def dynamic?
@@ -49,8 +50,9 @@ class Targeting < ActiveRecord::Base
   private
 
   def bookmark_or_query_is_present
-    if bookmark.nil? && search_query.nil?
-      errors.add :base, _('Bookmark or search query can\'t be nil')
+    if bookmark.blank? && search_query.blank?
+      errors.add :bookmark_id, _('Must select a bookmark or enter a search query')
+      errors.add :search_query, _('Must select a bookmark or enter a search query')
     end
   end
 

data/app/views/job_invocations/_form.html.erb

@@ -17,6 +17,9 @@
         <%= button_tag(:type => 'button', :class => 'btn btn-default btn-sm', :title => _("Refresh"), :id => 'refresh_execution_form') do %>
           <%= icon_text('refresh') %>
         <% end %>
+        <%= button_tag(:type => 'button', :class => 'btn btn-default btn-sm', :title => _("Preview"), :id => 'preview_hosts') do %>
+          <%= icon_text('eye-open') %>
+        <% end %>
       </div>
     </div>
 
@@ -80,6 +83,6 @@
       <%= text_f f, :start_before, :label => _('Start before') %>
     </fieldset>
   </div>
-
+  <%= render :partial => 'preview_hosts_modal' %>
   <%= submit_or_cancel f %>
 <% end %>

data/app/views/job_invocations/_preview_hosts_list.html.erb

@@ -0,0 +1,19 @@
+<% if @dynamic -%>
+<div class="alert alert-info alert-dismissable">
+    <p><%= _("The final host list may change because the selected query is dynamic.  It will be rerun during execution.") %></p>
+</div>
+<% end -%>
+
+<% if @hosts.any? -%>
+  <ul>
+    <% @hosts.each do |host| -%>
+        <li><%= link_to h(host.name), host_path(host), :target => '_blank' %></li>
+    <% end -%>
+
+    <% if @additional > 0 -%>
+        <li><%= link_to(_("...and %{count} more" % {:count => @additional}), hosts_path(:search => @query, :page => 2), :target => '_blank') %></li>
+    <% end -%>
+  </ul>
+<% else -%>
+  <h3><%= _("No hosts found.") %></h3>
+<% end -%>

data/app/views/job_invocations/_preview_hosts_modal.html.erb

@@ -0,0 +1,13 @@
+<!-- modal window -->
+<div class="modal fade" id="previewHostsModal" role="dialog" aria-hidden="true" data-url="<%= preview_hosts_job_invocations_path %>">
+  <div class="modal-dialog">
+    <div class="modal-content">
+      <div class="modal-header">
+        <button type="button" class="close" onclick="close_preview_hosts_modal(); return false;"><span aria-hidden="true">&times;</span><span class="sr-only"><%= _('Close') %></span></button>
+        <h4 class="modal-title">Preview Hosts</h4>
+      </div>
+      <div class="modal-body" style="overflow-y: auto; max-height: 500px;">
+      </div>
+    </div>
+  </div>
+</div>

data/app/views/job_invocations/new.html.erb

@@ -1,8 +1,4 @@
 <% javascript 'template_invocation' %>
 <% stylesheet 'template_invocation' %>
-
-<div class="row form-group">
-  <h1 class="col-md-8"><%= _('New Job Invocation') %></h1>
-</div>
-
+<% title _('Job invocation') %>
 <%= render :partial => 'form' %>

data/app/views/job_invocations/show.js.erb

@@ -1,3 +1,4 @@
+$('div.btn-group').html('<%= button_group(job_invocation_task_buttons(@job_invocation.last_task)).html_safe %>');
 $('div#status_chart').html('<%=j job_invocation_chart(@job_invocation) %>');
 $('div#status').flot_pie();
 

data/app/views/unattended/snippets/_remote_execution_ssh_keys.erb

@@ -0,0 +1,18 @@
+<%#
+  kind: snippet
+  name: remote_execution_ssh_keys
+%>
+
+<% if @host.params['remote_execution_ssh_keys'].present? %>
+<% ssh_user = @host.params['remote_execution_ssh_user'] || 'root' %>
+<% ssh_path = "~#{ssh_user}/.ssh" %>
+
+mkdir -p <%= ssh_path %>
+
+cat << EOF >> <%= ssh_path %>/authorized_keys
+<%= @host.params['remote_execution_ssh_keys'].join("\n") %>
+EOF
+
+chmod 700 <%= ssh_path %>
+chmod 600 <%= ssh_path %>/authorized_keys
+<% end %>

data/config/routes.rb

@@ -16,6 +16,7 @@ Rails.application.routes.draw do
   resources :job_invocations, :only => [:new, :create, :show, :index] do
     collection do
       post 'refresh'
+      get 'preview_hosts'
       get 'auto_complete_search'
     end
     member do

data/db/migrate/20151013135415_add_pub_key_to_smart_proxy.rb

@@ -0,0 +1,5 @@
+class AddPubKeyToSmartProxy < ActiveRecord::Migration
+  def change
+    add_column :smart_proxies, :pubkey, :text
+  end
+end

data/db/seeds.d/80-provision_templates.rb

@@ -0,0 +1,21 @@
+ProvisioningTemplate.without_auditing do
+  templates = [{:name => "remote_execution_ssh_keys", :source => "snippets/_remote_execution_ssh_keys.erb", :snippet => true}]
+
+  defaults = {:vendor => "Remote Execution", :default => true, :locked => true}
+
+  templates.each do |template|
+    next if ProvisioningTemplate.find_by_name(template[:name])
+
+    template.merge!(defaults)
+
+    t= ProvisioningTemplate.create({
+      :snippet => false,
+      :template => File.read(File.join("#{ForemanRemoteExecution::Engine.root}/app/views/unattended", template.delete(:source)))
+    }.merge(template))
+
+    t.organizations << (Organization.all - t.organizations)
+    t.locations << (Location.all - t.locations)
+
+    raise "Unable to create template #{t.name}: #{format_errors t}" if t.nil? || t.errors.any?
+  end
+end

data/lib/foreman_remote_execution/engine.rb

@@ -27,7 +27,7 @@ module ForemanRemoteExecution
 
     initializer 'foreman_remote_execution.register_plugin', after: :finisher_hook do |_app|
       Foreman::Plugin.register :foreman_remote_execution do
-        requires_foreman '>= 1.9'
+        requires_foreman '>= 1.10'
 
         apipie_documented_controllers ["#{ForemanRemoteExecution::Engine.root}/app/controllers/api/v2/*.rb"]
 
@@ -42,7 +42,7 @@ module ForemanRemoteExecution
           permission :destroy_job_templates, { :job_templates => [:destroy],
                                                :'api/v2/job_templates' => [:destroy] }, :resource_type => 'JobTemplate'
           permission :lock_job_templates, { :job_templates => [:lock, :unlock] }, :resource_type => 'JobTemplate'
-          permission :create_job_invocations, { :job_invocations => [:new, :create, :refresh, :rerun],
+          permission :create_job_invocations, { :job_invocations => [:new, :create, :refresh, :rerun, :preview_hosts],
                                                 'api/v2/job_invocations' => [:create] }, :resource_type => 'JobInvocation'
           permission :view_job_invocations, { :job_invocations => [:index, :show, :auto_complete_search], :template_invocations => [:show],
                                               'api/v2/job_invocations' => [:index, :show] }, :resource_type => 'JobInvocation'
@@ -64,6 +64,7 @@ module ForemanRemoteExecution
              parent: :monitor_menu,
              after: :audits
 
+        register_custom_status HostStatus::ExecutionStatus
         # add dashboard widget
         # widget 'foreman_remote_execution_widget', name: N_('Foreman plugin template widget'), sizex: 4, sizey: 1
       end
@@ -103,10 +104,9 @@ module ForemanRemoteExecution
       (Taxonomy.descendants + [Taxonomy]).each { |klass| klass.send(:include, ForemanRemoteExecution::TaxonomyExtensions) }
 
       User.send(:include, ForemanRemoteExecution::UserExtensions)
-      (Host::Base.descendants + [Host::Base]).each do |klass|
-        klass.send(:include, ForemanRemoteExecution::HostExtensions)
-        klass.send(:include, ForemanTasks::Concerns::HostActionSubject)
-      end
+
+      Host::Managed.send(:include, ForemanRemoteExecution::HostExtensions)
+      Host::Managed.send(:include, ForemanTasks::Concerns::HostActionSubject)
 
       (Nic::Base.descendants + [Nic::Base]).each do |klass|
         klass.send(:include, ForemanRemoteExecution::NicExtensions)
@@ -115,6 +115,7 @@ module ForemanRemoteExecution
       Bookmark.send(:include, ForemanRemoteExecution::BookmarkExtensions)
       HostsHelper.send(:include, ForemanRemoteExecution::HostsHelperExtensions)
 
+      SmartProxy.send(:include, ForemanRemoteExecution::SmartProxyExtensions)
       Subnet.send(:include, ForemanRemoteExecution::SubnetExtensions)
 
       # We need to explicitly force to load the Task model due to Rails loader

data/lib/foreman_remote_execution/version.rb

@@ -1,3 +1,3 @@
 module ForemanRemoteExecution
-  VERSION = '0.0.10'
+  VERSION = '0.1.0'
 end

data/test/functional/api/v2/job_invocations_controller_test.rb

@@ -29,7 +29,7 @@ module Api
 
         invocation = ActiveSupport::JSON.decode(@response.body)
         assert_equal attrs[:job_name], invocation['job_name']
-        assert_response 200
+        assert_response :success
       end
 
       test "should create valid with template_id" do
@@ -38,7 +38,7 @@ module Api
 
         invocation = ActiveSupport::JSON.decode(@response.body)
         assert_equal attrs[:job_name], invocation['job_name']
-        assert_response 200
+        assert_response :success
       end
     end
   end

data/test/unit/concerns/host_extensions_test.rb

@@ -9,6 +9,35 @@ describe ForemanRemoteExecution::HostExtensions do
 
   after { User.current = nil }
 
+  context 'ssh user' do
+    let(:host) { FactoryGirl.build(:host, :with_execution) }
+    let(:sshkey) { 'ssh-rsa AAAAB3NzaC1yc2EAAAABJQ foo@example.com' }
+
+    before do
+      SmartProxy.any_instance.stubs(:pubkey).returns(sshkey)
+      Setting[:remote_execution_ssh_user] = 'root'
+    end
+
+    it 'has ssh user in the parameters' do
+      host.params['remote_execution_ssh_user'].must_equal Setting[:remote_execution_ssh_user]
+    end
+
+    it 'can override ssh user' do
+      host.host_parameters << FactoryGirl.build(:host_parameter, :name => 'remote_execution_ssh_user', :value => 'amy')
+      host.params['remote_execution_ssh_user'].must_equal 'amy'
+    end
+  end
+
+  context 'ssh keys' do
+    let(:host) { FactoryGirl.build(:host, :with_execution) }
+    let(:sshkey) { 'ssh-rsa AAAAB3NzaC1yc2EAAAABJQ foo@example.com' }
+
+    it 'has ssh keys in the parameters' do
+      SmartProxy.any_instance.stubs(:pubkey).returns(sshkey)
+      host.remote_execution_ssh_keys.must_include sshkey
+    end
+  end
+
   context 'host has multiple nics' do
     let(:host) { FactoryGirl.build(:host, :with_execution) }
 

data/test/unit/job_invocation_composer_test.rb

@@ -317,14 +317,14 @@ describe JobInvocationComposer do
       end
 
       describe '#targeted_hosts_count' do
+        let(:host) { FactoryGirl.create(:host) }
+
         it 'obeys authorization' do
-          composer
+          composer.stubs(:displayed_search_query => "name = #{host.name}")
           Host.expects(:authorized).with(:view_hosts, Host).returns(Host.scoped)
           composer.targeted_hosts_count
         end
 
-        let(:host) { FactoryGirl.create(:host) }
-
         it 'searches hosts based on displayed_search_query' do
           composer.stubs(:displayed_search_query => "name = #{host.name}")
           composer.targeted_hosts_count.must_equal 1
@@ -334,6 +334,11 @@ describe JobInvocationComposer do
           composer.stubs(:displayed_search_query => "name = ")
           composer.targeted_hosts_count.must_equal 0
         end
+
+        it 'returns 0 when no query is present' do
+          composer.stubs(:displayed_search_query => '')
+          composer.targeted_hosts_count.must_equal 0
+        end
       end
 
       describe '#template_invocation_input_value_for(input)' do

data/test/unit/job_template_test.rb

@@ -1,6 +1,19 @@
 require 'test_plugin_helper'
 
 describe JobTemplate do
+  context 'when creating a template' do
+    let(:job_template) { FactoryGirl.build(:job_template, :job_name => '') }
+
+    it 'needs a job_name' do
+      refute job_template.valid?
+    end
+
+    it 'does not need a job_name if it is a snippet' do
+      job_template.snippet = true
+      assert job_template.valid?
+    end
+  end
+
   context 'cloning' do
     let(:job_template) { FactoryGirl.build(:job_template, :with_input) }
 

data/test/unit/targeting_test.rb

@@ -38,7 +38,7 @@ describe Targeting do
   context 'cannot create without search term or bookmark' do
     before do
       targeting.targeting_type = Targeting::DYNAMIC_TYPE
-      targeting.search_query = nil
+      targeting.search_query = ''
       targeting.bookmark = nil
     end
     it { refute_valid targeting }

metadata

@@ -1,83 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: foreman_remote_execution
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.1.0
 platform: ruby
 authors:
 - Foreman Remote Execution team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-09 00:00:00.000000000 Z
+date: 2015-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.2.8
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.2.8
 - !ruby/object:Gem::Dependency
   name: foreman-tasks
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.6
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: A plugin bringing remote execution to the Foreman, completing the config
@@ -127,10 +127,10 @@ extra_rdoc_files:
 - README.md
 - LICENSE
 files:
-- .gitignore
-- .rubocop.yml
-- .rubocop_todo.yml
-- .tx/config
+- ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
+- ".tx/config"
 - Gemfile
 - LICENSE
 - README.md
@@ -151,17 +151,20 @@ files:
 - app/lib/actions/remote_execution/run_host_job.rb
 - app/lib/actions/remote_execution/run_hosts_job.rb
 - app/lib/actions/remote_execution/run_proxy_command.rb
+- app/lib/proxy_api/remote_execution_ssh.rb
 - app/mailers/.gitkeep
 - app/models/concerns/foreman_remote_execution/bookmark_extensions.rb
 - app/models/concerns/foreman_remote_execution/errors_flattener.rb
 - app/models/concerns/foreman_remote_execution/foreman_tasks_task_extensions.rb
 - app/models/concerns/foreman_remote_execution/host_extensions.rb
 - app/models/concerns/foreman_remote_execution/nic_extensions.rb
+- app/models/concerns/foreman_remote_execution/smart_proxy_extensions.rb
 - app/models/concerns/foreman_remote_execution/subnet_extensions.rb
 - app/models/concerns/foreman_remote_execution/taxonomy_extensions.rb
 - app/models/concerns/foreman_remote_execution/template_extensions.rb
 - app/models/concerns/foreman_remote_execution/template_relations.rb
 - app/models/concerns/foreman_remote_execution/user_extensions.rb
+- app/models/host_status/execution_status.rb
 - app/models/input_template_renderer.rb
 - app/models/job_invocation.rb
 - app/models/job_invocation_api_composer.rb
@@ -197,6 +200,8 @@ files:
 - app/views/job_invocations/_host_actions_td.html.erb
 - app/views/job_invocations/_host_provider_td.html.erb
 - app/views/job_invocations/_host_status_td.html.erb
+- app/views/job_invocations/_preview_hosts_list.html.erb
+- app/views/job_invocations/_preview_hosts_modal.html.erb
 - app/views/job_invocations/_tab_hosts.html.erb
 - app/views/job_invocations/_tab_overview.html.erb
 - app/views/job_invocations/index.html.erb
@@ -219,6 +224,7 @@ files:
 - app/views/templates/puppet_run_once.erb
 - app/views/templates/run_command.erb
 - app/views/templates/service_action.erb
+- app/views/unattended/snippets/_remote_execution_ssh_keys.erb
 - config/routes.rb
 - db/migrate/20150612121541_add_job_template_to_template.rb
 - db/migrate/20150616080015_create_template_input.rb
@@ -231,8 +237,10 @@ files:
 - db/migrate/20150827144500_change_targeting_search_query_type.rb
 - db/migrate/20150827152730_add_options_to_template_input.rb
 - db/migrate/20150903192731_add_execution_to_interface.rb
+- db/migrate/20151013135415_add_pub_key_to_smart_proxy.rb
 - db/seeds.d/60-ssh_proxy_feature.rb
 - db/seeds.d/70-job_templates.rb
+- db/seeds.d/80-provision_templates.rb
 - doc/.bin/.gitkeep
 - doc/.gitignore
 - doc/Gemfile
@@ -306,12 +314,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -340,4 +348,3 @@ test_files:
 - test/unit/targeting_test.rb
 - test/unit/template_input_test.rb
 - test/unit/template_invocation_input_value_test.rb
-has_rdoc: