foreman_pipeline 0.0.1 → 0.0.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YTM3MmMwNTFhYmUwNDY4NzZhZTljMDgwZjRiYTcxYTY2YTBlOWRjMA==
+    OWEyOTk0NWZhOThkMGJhYTJlZmFiM2Q2ZmFmNjBhN2QyMTk0ZTFmMQ==
   data.tar.gz: !binary |-
-    ZGExMWRhZDE2YTJkZjA0NmU1NzUwYWMyZTA1OTM1MmQyZWRlZWViZg==
+    MGFlODFhZTMxMjUxODExZmZlYWMxMmE1MGY0NDBhYzU0MTZmNmY3OA==
 SHA512:
   metadata.gz: !binary |-
-    YjkwZDQyMmIzNjU1YmZmMTUwMDkxODc5NmU1ZmE2ODRlN2RhYzUyNDA0MjA4
-    ZTgwNTQ1YmQxN2E2NjAwN2E5N2E1Mzc0ODllOWM5ODMwMDQ2MTA0ZjMyYzYz
-    NzVmMjllNGFlNTkyMDY2ZWQ4NzUyM2FlZTM0NjczYzQ3ZGY2YmI=
+    YWVhNjAyOTFhYTdiN2I4MzIwNzJkNTUxMzc5MWNjYTlmNjQ4ZjFlNTZkNzMx
+    MjQ5NDk1MTZhODY1ZWE4MTg5NDQzOGUxZDBlY2JmZTM3Y2Y5YjA0ZThmOTE2
+    MzgxMGMxMjgzZWVhNTY2ZmFiYzk0ZDg5NDM1MWI0ZWJkMTJkNDA=
   data.tar.gz: !binary |-
-    MjU4NDNhNmYwMmJkMzlhNzQwMmYxMzgzMTY2OWY2MzI4OWRkOThmMGMwYWQz
-    ZWFjZjk4Y2RlNzJkNGRjOGQ4MDk1ZDE3ZDE1MDgwNWI4MDIwNWQ0N2YyOGNm
-    ZWQ5NDlmYTgwMjg2NDQwNGU3ZDhlOWVlNDUyYTdmYTljZjZlOTI=
+    ZmExZGVmOGQ4ZmYyOWUxODc1YzQwNDk0MDVjOGE4Zjc1MDhiMjFjNGY0MmRj
+    N2RjNTMyZWViNWNkMDAzNWU1ZmQwMGQxMDlhNDkwMzdkMzNlZDlkYzA4NTU1
+    ZmUyMDE4OTYyNjY3MGU4NGEzZGFiZjg1YTE0ZjBkNTczMDgwN2U=

data/README.md

@@ -4,7 +4,18 @@ This project provides support for Jenkins builds triggered from within Foreman.
 
 ##Installation##
 
-from source:
+```
+gem install foreman_pipeline
+```
+
+and
+
+```
+#foreman/bundler.d/*.local.rb
+gem 'foreman_pipeline'
+```
+
+or from source:
 
 ```
 #foreman/bundler.d/*.local.rb
@@ -31,6 +42,7 @@ rake foreman_pipeline:seed
 |:-------:|:-------:|:-------------------:|:------------------:|:----------------:|
 |>= 1.9   | >= 2.3  | ~> 0.0.1            | < 2.0.0            |   0.0.1          |
 
+
 ##Usage##
 
 See [wiki](https://github.com/xprazak2/foreman-pipeline/wiki/Jobs).

data/Rakefile

@@ -1,40 +1,2 @@
 #!/usr/bin/env rake
-begin
-  require 'bundler/setup'
-rescue LoadError
-  puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
-end
-begin
-  require 'rdoc/task'
-rescue LoadError
-  require 'rdoc/rdoc'
-  require 'rake/rdoctask'
-  RDoc::Task = Rake::RDocTask
-end
-
-RDoc::Task.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'ForemanPipeline'
-  rdoc.options << '--line-numbers'
-  rdoc.rdoc_files.include('README.rdoc')
-  rdoc.rdoc_files.include('lib/**/*.rb')
-end
-
-APP_RAKEFILE = File.expand_path("../test/dummy/Rakefile", __FILE__)
-load 'rails/tasks/engine.rake'
-
-
-
-Bundler::GemHelper.install_tasks
-
-require 'rake/testtask'
-
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.libs << 'test'
-  t.pattern = 'test/**/*_test.rb'
-  t.verbose = true
-end
-
-
-task :default => :test
+# useful tasks to be found in lib/foreman_pipeline/tasks

data/app/controllers/foreman_pipeline/api/jobs_controller.rb

@@ -200,7 +200,7 @@ module ForemanPipeline
       rollback = {:occured => false}
       Job.transaction do
         projects = params[:projects].map do |p|
-          JenkinsProject.create(:name => p, :organization => @organization)
+          JenkinsProject.create(:name => p, :organization_id => @organization.id)
         end
         projects_to_add = projects.delete_if { |p| @job.jenkins_projects.include? p }
         @job.jenkins_projects = @job.jenkins_projects + projects_to_add

data/app/lib/actions/foreman_pipeline/job/create_host.rb

@@ -18,9 +18,7 @@ module Actions
 
         def run
           hostgroup = Hostgroup.find(input[:hostgroup_id])
-          location = Location.where(:name => "foreman_pipeline").first_or_create
-          location.subnet_ids = (location.subnet_ids + [hostgroup.subnet_id]).uniq
-          location.save!
+          location = Location.where(:name => "foreman_pipeline").first
           host = ::Host::Managed.new(
                     name:                 input[:name],
                     hostgroup:            hostgroup,

data/app/lib/actions/foreman_pipeline/job/cv_promote_job_hook.rb

@@ -7,15 +7,15 @@ module Actions
           Katello::ContentView::Promote
         end
 
-        def plan(version, environment, is_force = false)          
+        def plan(version, environment, is_force = false)
           valid_jobs = version.content_view.jobs.select { |job| job.is_valid? }
           jobs_to_run = valid_jobs.select { |job| version.eql? job.target_cv_version }
-          allowed_jobs = jobs_to_run.select { |job| job.levelup_trigger && !job.version_already_promoted? }
-          
+          allowed_jobs = jobs_to_run.select { |job| job.levelup_trigger && job.not_yet_promoted? }
+
           plan_self(:trigger => trigger.output,
                     :job_ids => allowed_jobs.map(&:id),
-                    :job_names => allowed_jobs.map(&:name))    
-        end        
+                    :job_names => allowed_jobs.map(&:name))
+        end
       end
     end
   end

data/app/lib/actions/foreman_pipeline/job/cv_publish_job_hook.rb

@@ -10,7 +10,7 @@ module Actions
         def plan(content_view, descripton)
           valid_jobs = content_view.jobs.select { |job| job.is_valid? }
           jobs_to_run = valid_jobs.select { |job| job.environment.library? }
-          allowed_jobs = jobs_to_run.select { |job| job.levelup_trigger && !job.version_already_promoted? }
+          allowed_jobs = jobs_to_run.select { |job| job.levelup_trigger && job.not_yet_promoted? }
 
           plan_self(:trigger => trigger.output,
                     :job_ids => allowed_jobs.map(&:id),

data/app/lib/actions/foreman_pipeline/job/multiple_promotions.rb

@@ -6,12 +6,11 @@ module Actions
 
         def plan(job)
           sequence do
-            job.to_environments.each do |env|
+            job.envs_for_promotion.each do |env|
               plan_action(::Actions::Katello::ContentView::Promote, job.target_cv_version, env, false)
             end
           end
         end
-
       end
     end
   end

data/app/lib/actions/foreman_pipeline/job/promote.rb

@@ -9,8 +9,9 @@ module Actions
         end
 
         def run
-          unless job.environment.successors.empty?
-            fail "Content View promotion disabled" if job.to_environments.empty?
+          unless job.environment.successors.empty? #when we are not at the end of lifecycle path
+            fail "Content View promotion disabled" unless job.should_be_promoted?
+            fail "Content view already promoted to the next environment(s), skipping promotion(s)" unless job.promotion_safe?
             promote_environment
           end
         end

data/app/lib/actions/foreman_pipeline/job/repo_sync_job_hook.rb

@@ -11,7 +11,7 @@ module Actions
           valid_jobs = repo.jobs.select { |job| job.is_valid? }
 
           jobs_to_run = valid_jobs.select { |job| job.target_cv_version_avail? }
-          allowed_jobs = jobs_to_run.select { |job| job.sync_trigger && !job.version_already_promoted? }
+          allowed_jobs = jobs_to_run.select { |job| job.sync_trigger && job.not_yet_promoted? }
           grouped_jobs = allowed_jobs.group_by(&:target_cv_version).values
 
           if grouped_jobs.max_by(&:length).length > 1

data/app/lib/actions/foreman_pipeline/job/run_job_manually.rb

@@ -4,16 +4,21 @@ module Actions
       class RunJobManually < Actions::EntryAction
 
         def plan(job)
-          if job.is_valid? && job.target_cv_version_avail? && !job.version_already_promoted?
+          if job.is_valid? && job.target_cv_version_avail? && job.not_yet_promoted?
             plan_action(DeployNewHost, job)
             plan_self(:info => "Manually triggered job started.", :name => job.name)
           else
-            plan_self(:info => "Manually triggered job execution skipped, check job configuration.", :name => job.name)
+            plan_self(:info => "Manually triggered job execution skipped, check job configuration.", :name => job.name, :fail => true)
           end
         end
 
         def run
           output = input
+          fail input[:info] if input[:fail]
+        end
+
+        def rescue_strategy_for_self
+          Dynflow::Action::Rescue::Skip
         end
 
         def humanized_name

data/app/models/foreman_pipeline/concerns/content_view_extension.rb

@@ -1,4 +1,4 @@
-module ForemanPipeline
+  module ForemanPipeline
   module Concerns
     module ContentViewExtension
       extend ActiveSupport::Concern
@@ -6,7 +6,7 @@ module ForemanPipeline
       included do
         has_many :jobs, :class_name => 'ForemanPipeline::Job', :inverse_of => :content_view, :dependent => :nullify
       end
-            
+
     end
   end
 end

data/app/models/foreman_pipeline/concerns/content_view_repository_extension.rb

@@ -4,9 +4,9 @@ module ForemanPipeline
       extend ActiveSupport::Concern
 
       included do
-        belongs_to :job, :class_name => 'ForemanPipeline::Job', :foreign_key => :content_view_id, :primary_key => :content_view_id        
+        belongs_to :job, :class_name => 'ForemanPipeline::Job', :foreign_key => :content_view_id, :primary_key => :content_view_id
       end
-      
+
     end
-  end  
+  end
 end

data/app/models/foreman_pipeline/concerns/kt_environment_extension.rb

@@ -8,7 +8,7 @@ module ForemanPipeline
          :dependent => :destroy, :foreign_key => :to_environment_id
         has_many :jobs, :through => :job_to_environments, :class_name => 'ForemanPipeline::Job', :dependent => :nullify
       end
-      
+
       def full_paths
         return [self.full_path] unless library?
         successors.map(&:full_path)

data/app/models/foreman_pipeline/concerns/repository_extension.rb

@@ -4,9 +4,9 @@ module ForemanPipeline
       extend ActiveSupport::Concern
 
       included do
-        has_many :jobs, :class_name => 'ForemanPipeline::Job', :source => :job, :through => :content_view_repositories     
+        has_many :jobs, :class_name => 'ForemanPipeline::Job', :source => :job, :through => :content_view_repositories
       end
 
     end
-  end   
+  end
 end

data/app/models/foreman_pipeline/jenkins_instance.rb

@@ -9,6 +9,8 @@ module ForemanPipeline
     include Glue::ElasticSearch::JenkinsInstance
     include ForemanPipeline::Authorization::JenkinsInstance
 
+    attr_accessible :name, :url, :organization_id, :pubkey, :jenkins_home, :cert_path, :jenkins_user_id
+
     belongs_to :organization
     has_many :jobs, :class_name => "ForemanPipeline::Job", :dependent => :nullify
     belongs_to :jenkins_user, :class_name => "ForemanPipeline::JenkinsUser"

data/app/models/foreman_pipeline/jenkins_project.rb

@@ -8,6 +8,8 @@ module ForemanPipeline
 
     belongs_to :organization
 
+    attr_accessible :name, :organization_id
+
     has_many :job_jenkins_projects, :dependent => :destroy
     has_many :jobs, :through => :job_jenkins_projects, :class_name => 'ForemanPipeline::Job'
 

data/app/models/foreman_pipeline/jenkins_project_param.rb

@@ -9,7 +9,7 @@ module ForemanPipeline
     self.inheritance_column = :_inheritance_type_disabled
     belongs_to :organization
     belongs_to :jenkins_project, :class_name => "ForemanPipeline::JenkinsProject"
-    attr_accessible :name, :type, :description, :value
+    attr_accessible :name, :type, :description, :value, :organization_id, :jenkins_project_id
 
     TYPES = ["string", "boolean", "text"]
     validates :type, :inclusion => { :in => TYPES }

data/app/models/foreman_pipeline/jenkins_user.rb

@@ -11,5 +11,7 @@ module ForemanPipeline
 
     validates :name, :presence => true
     validates :token, :presence => true
+
+    attr_accessible :name, :token, :organization_id
   end
-end
+end

data/app/models/foreman_pipeline/job.rb

@@ -26,7 +26,10 @@ module ForemanPipeline
 
     validates :name, :presence => true
     validates :organization, :presence => true
-    validate :no_composite_view
+    validate :no_composite_view, :check_env_succession
+
+    attr_accessible :name, :content_view_id, :hostgroup_id, :organization_id, :compute_resource_id, :jenkins_instance_id,
+      :environment_id, :manual_trigger, :levelup_trigger, :sync_trigger
 
     def is_valid?
       !self.attributes.values.include?(nil) && !self.jenkins_instance.jenkins_user.nil?
@@ -39,22 +42,41 @@ module ForemanPipeline
     def target_cv_version
       fail "Cannot fetch target version, no environment set" if environment.nil?
       fail "Cannot fetch target version, no content view set" if content_view.nil?
+      fail "Content view has no versions!" if content_view.content_view_versions.empty?
       self.environment.content_view_versions.where(:content_view_id => self.content_view.id).first
     end
 
     def init_run
       fail "Cannnot contact Jenkins server: no Jenkins Instance set for the job: #{name}" if jenkins_instance.nil?
-      fail "Cannot log in to Jenkins server:
-            no Jenkins User set for the Jenkins Instance: #{jenkins_instancej.name}" if jenkins_instance.jenkins_user.nil?
+      fail "Cannot log in to Jenkins server: no Jenkins User set for the Jenkins Instance: #{jenkins_instance.name}" if jenkins_instance.jenkins_user.nil?
       jenkins_instance.create_client(jenkins_instance.jenkins_user.name, jenkins_instance.jenkins_user.token)
     end
 
-    def version_already_promoted?
-      self.target_cv_version.environments.include?(self.environment.successor)
+    #Is any to_env set? (Do we want to promote to any env?)
+    def should_be_promoted?
+      !to_environments.empty?
+    end
+
+    # this shlould make sure not to trigger cyclic runs in hook actions
+    def not_yet_promoted?
+      # no to_envs means we do not want to promote, no need to check further here
+      return true if to_environments.empty?
+      #we want to promote, but are any of to_envs safe to promote to?
+      can_be_promoted?
+    end
+
+    #If we want to promote, is it safe (or could we get a cycle)?
+    def promotion_safe?
+      should_be_promoted? ? can_be_promoted? : false
+    end
+
+    #we have some to_envs set (== we want to promote), but cv version may already be in those envs
+    def envs_for_promotion
+      to_environments.reject { |env| target_cv_version.environments.include?(env) }
     end
 
-    def environment_in_paths?(env_id)
-      paths.map(&:full_path).flatten.uniq.map(&:id).include? env_id
+    def can_be_promoted?
+      !envs_for_promotion.empty?
     end
 
     def available_compute_resources
@@ -68,5 +90,14 @@ module ForemanPipeline
        "Cannot add content view, only non-composites allowed.") if !content_view.nil? && content_view.composite?
     end
 
+    def check_env_succession
+      if environment && should_be_promoted?
+        to_environments.each do |to_env|
+          unless to_env.prior == environment
+            errors.add(:base, "Environment succession violation: #{to_env.name}")
+          end
+        end
+      end
+    end
   end
 end

data/app/models/foreman_pipeline/job_jenkins_project.rb

@@ -9,6 +9,8 @@ module ForemanPipeline
 
     after_destroy :remove_orphaned_projects
 
+    attr_accessible :job_id, :jenkins_project_id
+
     private
 
     def org_membership

data/app/models/foreman_pipeline/job_to_environment.rb

@@ -7,6 +7,8 @@ module ForemanPipeline
     belongs_to :organization
     validate :org_membership
 
+    attr_accessible :job_id, :environment_id, :organization_id
+
     private
 
     def org_membership

data/config/routes.rb

@@ -5,13 +5,13 @@ class ActionDispatch::Routing::Mapper
 end
 
 ForemanPipeline::Engine.routes.draw do
-  
+
 
   scope :foreman_pipeline, :path => '/foreman_pipeline' do
-    
+
     namespace :api do
-    
-      api_resources :organizations, :only => [] do  
+
+      api_resources :organizations, :only => [] do
         api_resources :jobs do
           member do
             put :set_content_view
@@ -23,7 +23,7 @@ ForemanPipeline::Engine.routes.draw do
             get :run_job
             put :add_projects
             put :remove_projects
-            put :set_to_environments            
+            put :set_to_environments
             get :available_paths
           end
         end
@@ -46,8 +46,8 @@ ForemanPipeline::Engine.routes.draw do
         api_resources :jenkins_project_params, :only => [:update]
 
         api_resources :jenkins_users, :only => [:index, :create, :destroy, :show, :update]
-        
+
       end
     end
-  end  
+  end
 end

data/db/migrate/20141014125836_make_content_view_and_hostgroup_optional_for_job.rb

@@ -1,5 +1,5 @@
 class MakeContentViewAndHostgroupOptionalForJob < ActiveRecord::Migration
-  def up    
+  def up
     change_column_null :integration_jobs, :content_view_id, true
     change_column_null :integration_jobs, :hostgroup_id, true
   end

data/lib/foreman_pipeline/engine.rb

@@ -2,13 +2,17 @@ module ForemanPipeline
   class Engine < ::Rails::Engine
     isolate_namespace ForemanPipeline
     require 'foreman_deployments'
+    require 'bastion'
+    require 'katello'
 
     initializer 'foreman_pipeline.mount_engine', :after => :build_middleware_stack do |app|
       app.routes_reloader.paths << "#{ForemanPipeline::Engine.root}/config/mount_engine.rb"
     end
 
     initializer 'foreman_pipeline.load_app_instance_data' do |app|
-      app.config.paths['db/migrate'] += ForemanPipeline::Engine.paths['db/migrate'].existent
+      ForemanPipeline::Engine.paths['db/migrate'].existent.each do |path|
+        app.config.paths['db/migrate'] << path
+      end
       app.config.autoload_paths += Dir["#{config.root}/app/lib"]
       app.config.autoload_paths += Dir["#{config.root}/app/views/foreman"]
     end
@@ -29,6 +33,10 @@ module ForemanPipeline
       }
     end
 
+    initializer "foreman_pipeline.apipie" do
+      Apipie.configuration.checksum_path += ['/foreman_pipeline/api/']
+    end
+
     initializer 'foreman_pipeline.register_actions', :before => 'foreman_tasks.initialize_dynflow' do |app|
       ForemanTasks.dynflow.require!
 
@@ -39,7 +47,7 @@ module ForemanPipeline
 
     config.to_prepare do
 
-      Bastion.register_plugin({
+      ::Bastion.register_plugin({
         :name => 'foreman_pipeline',
         :javascript => 'foreman_pipeline/foreman_pipeline',
         :stylesheet => 'foreman_pipeline/foreman_pipeline',

data/lib/foreman_pipeline/plugin.rb

@@ -1,8 +1,9 @@
 Foreman::Plugin.register :foreman_pipeline do
-  
+  requires_foreman '>= 1.9'
+
   sub_menu :top_menu, :foreman_pipeline_menu, :caption => N_('Pipeline') do
     menu :top_menu,
-         :jobs,       
+         :jobs,
          :caption => N_("Jobs"),
          :url => '/jobs',
          :url_hash => {:controller => 'foreman_pipeline/api/jobs', :action => 'index'},

data/lib/foreman_pipeline/tasks/foreman_pipeline_seed.rake

@@ -3,16 +3,26 @@ namespace :foreman_pipeline  do
   desc "seeding the database"
   task :seed => :environment do
     defaults = {:default => true, :locked => false}
-    templates = [{:name => "foreman_pipeline_jenkins_pubkey", :source => "snippets/_jenkins_instance_pubkey.erb", :snippet => true}]
+    ProvisioningTemplate.without_auditing do
+      [
+        {:name => "foreman_pipeline_jenkins_pubkey", :source => "snippets/_jenkins_instance_pubkey.erb", :snippet => true}
+      ].each do |template|
+          template[:template] = File.read(File.join(ForemanPipeline::Engine.root, "app/views/foreman/unattended", template.delete(:source)))
 
-    templates.each do |template|
-      template[:template] = File.read(File.join(ForemanPipeline::Engine.root, "app/views/foreman/unattended", template.delete(:source)))
-
-      ::ConfigTemplate.find_or_create_by_name(template) do |tmplt|
-        tmplt.update_attributes(defaults.merge(template))
-      end
+          ProvisioningTemplate.find_or_create_by_name(template) do |tmplt|
+            tmplt.update_attributes(defaults.merge(template))
+          end
+        end
     end
-    
+
+    loc = Location.new(:name => "foreman_pipeline")
+    loc.organizations = Organization.all
+    loc.environments = Environment.all
+    loc.domains = Domain.all
+    loc.media = Medium.all
+    loc.subnets = Subnet.all
+    loc.compute_resources = ComputeResource.all
+    loc.smart_proxies = SmartProxy.all
+    loc.save!
   end
-  
 end

data/lib/foreman_pipeline/tasks/foreman_pipeline_test.rake

@@ -1,34 +1,24 @@
 require File.expand_path("../engine", File.dirname(__FILE__))
 
 namespace :test do
-  
-  namespace :foreman_pipeline do
-    
-    task :test => ['db:test:prepare'] do
-      test_task = Rake::TestTask.new('foreman_pipeline_test_task') do |t|
-        t.libs << ["test", "#{ForemanPipeline::Engine.root}/test"]
-        t.test_files = ["#{ForemanPipeline::Engine.root}/test/**/*_test.rb"]
-        t.verbose = true
-      end
-      Rake::Task[test_task.name].invoke
-    end
 
-    task :spec => ['db:test:prepare'] do
-      test_task = Rake::TestTask.new('foreman_pipeline_spec_task') do |t|
-        t.libs << ["spec", "#{ForemanPipeline::Engine.root}/spec", "test", "#{ForemanPipeline::Engine.root}/test"]
-        t.test_files = ["#{ForemanPipeline::Engine.root}/spec/**/*_spec.rb"]
-        t.verbose = true
-      end
-      Rake::Task[test_task.name].invoke
+  task :foreman_pipeline => ['db:test:prepare'] do
+    test_task = Rake::TestTask.new('foreman_pipeline_test_task') do |t|
+      t.libs << ["test", "#{ForemanPipeline::Engine.root}/test"]
+      t.test_files = ["#{ForemanPipeline::Engine.root}/test/**/*_test.rb"]
+      t.verbose = true
     end
+    Rake::Task[test_task.name].invoke
   end
+end
 
+Rake::Task[:test].enhance do
+  Rake::Task['test:foreman_pipeline'].invoke
+end
 
-  desc "run all plugin's tests"
-  task :foreman_pipeline do
-    Rake::Task['test:foreman_pipeline:test'].invoke
-    Rake::Task['test:foreman_pipeline:spec'].invoke
+load 'tasks/jenkins.rake'
+if Rake::Task.task_defined?(:'jenkins:unit')
+  Rake::Task["jenkins:unit"].enhance do
+    Rake::Task['test:foreman_pipeline'].invoke
   end
-
-end
-  
+end

data/lib/foreman_pipeline/version.rb

@@ -1,3 +1,3 @@
 module ForemanPipeline
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/test/factories/hostgroup_factory.rb

@@ -1,6 +1,5 @@
 FactoryGirl.define do
   factory :pipeline_hostgroup, :class => Hostgroup do
     sequence(:name) { |n| "hostgroup#{n}" }
-    compute_profile
   end
 end

data/test/foreman_pipeline_plugin_test_helper.rb

@@ -1,17 +1,44 @@
 require "test_helper"
 
-def katello_root
-  "#{ForemanPipeline::Engine::Railties.engines
-    .select {|engine| engine.railtie_name == "katello"}
-    .first.config.root}"
-end
-
-require "#{katello_root}/spec/models/model_spec_helper"
-FactoryGirl.definition_file_paths << File.join(katello_root, 'test', 'factories')
+FactoryGirl.definition_file_paths << File.join(Katello::Engine.root, 'test', 'factories')
 FactoryGirl.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
 FactoryGirl.reload
 
+require "#{Katello::Engine.root}/test/support/fixtures_support"
+
+module FixtureTestCase
+  extend ActiveSupport::Concern
+
+  included do
+    extend ActiveRecord::TestFixtures
+
+    self.use_transactional_fixtures = true
+    self.use_instantiated_fixtures = false
+    self.pre_loaded_fixtures = true
+
+    Katello::FixturesSupport.set_fixture_classes(self)
+
+    self.fixture_path = Dir.mktmpdir("katello_fixtures")
+    FileUtils.cp(Dir.glob("#{Katello::Engine.root}/test/fixtures/models/*"), self.fixture_path)
+    FileUtils.cp(Dir.glob("#{Rails.root}/test/fixtures/*"), self.fixture_path)
+    fixtures(:all)
+    FIXTURES = load_fixtures
+
+    # load_permissions
+
+    Setting::Katello.load_defaults
+  end
+
+  module ClassMethods
+    def before_suite
+      @@admin = ::User.find(FIXTURES['users']['admin']['id'])
+      User.current = @@admin
+    end
+  end
+end
+
 class ActiveSupport::TestCase
+  include FixtureTestCase
 
   def get_organization(org = nil)
     saved_user = User.current
@@ -24,5 +51,4 @@ class ActiveSupport::TestCase
     User.current = saved_user
     organization
   end
-
 end

data/test/unit/jenkins_instance_test.rb

@@ -0,0 +1,31 @@
+require 'foreman_pipeline_plugin_test_helper'
+
+class JenkinsInstanceTest < ActiveSupport::TestCase
+
+  def setup
+    @org = get_organization
+    @valid_url = "http://somewhere.com:8080"
+    @valid_home = "/var/lib/jenkins"
+    @valid_cert_path = "/home/user/.ssh/foreman-jenkins"
+  end
+
+  test "should be valid" do
+    @instance = ForemanPipeline::JenkinsInstance.create(:name => "test_jenkins_instance",
+                                                        :url => @valid_url,
+                                                        :cert_path => @valid_cert_path,
+                                                        :jenkins_home => @valid_home,
+                                                        :organization_id => @org.id)
+    assert @instance.errors.empty?
+  end
+
+  test "should have url" do
+    @instance = ForemanPipeline::JenkinsInstance.create(:name => "test_jenkins_instance",
+                                                        :url => "invalid url",
+                                                        :cert_path => @valid_cert_path,
+                                                        :jenkins_home => @valid_home,
+                                                        :organization_id => @org.id)
+    refute @instance.errors.empty?
+  end
+
+
+end

data/test/unit/job_test.rb

@@ -5,7 +5,7 @@ class JobTest < ActiveSupport::TestCase
   def setup
     @organization = get_organization
     @compute_resource = FactoryGirl.create(:compute_resource, :libvirt)
-    @hostgroup = FactoryGirl.create(:pipeline_hostgroup, :compute_profile => @compute_profile)
+    @hostgroup = FactoryGirl.create(:pipeline_hostgroup)
     @content_view = FactoryGirl.create(:katello_content_view)
     @jenkins_user = FactoryGirl.create(:jenkins_user, :organization => get_organization)
     @jenkins_instance = FactoryGirl.create(:jenkins_instance, :jenkins_user => @jenkins_user, :organization => get_organization)
@@ -23,4 +23,213 @@ class JobTest < ActiveSupport::TestCase
     assert job.is_valid?
   end
 
-end
+  test "should find target cv" do
+    cv = Katello::ContentView.find(katello_content_views(:acme_default))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [to_env])
+    target_v = cv.content_view_versions.select { |v| v.environments.include?(env) && !v.environments.include?(to_env) }.first
+    assert_equal target_v, job.target_cv_version
+  end
+
+  test "should not find target cv" do
+    cv = Katello::ContentView.find(katello_content_views(:acme_default))
+    env = Katello::KTEnvironment.find(katello_environments(:test))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env)
+
+    assert_equal nil, job.target_cv_version
+  end
+
+  test "should find envs for promotion" do
+    cv = Katello::ContentView.find(katello_content_views(:acme_default))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [to_env, to_env2])
+    assert_equal [to_env, to_env2], job.envs_for_promotion
+  end
+
+  test "envs_for_promotion should exclude one env from promotions" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [to_env, to_env2])
+    assert_equal [to_env2], job.envs_for_promotion
+  end
+
+  test "job can be promoted" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [to_env, to_env2])
+    assert job.can_be_promoted?
+  end
+
+  test "job cannot be promoted" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [to_env])
+    refute job.can_be_promoted?
+  end
+
+  test "is promotion safe" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+    to_env2 = Katello::KTEnvironment.find(katello_environments(:staging))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [to_env, to_env2])
+    assert job.promotion_safe?
+  end
+
+  test "is not promotion safe" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env)
+    refute job.promotion_safe?
+  end
+
+  test "is not promotion safe again" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [to_env])
+    refute job.promotion_safe?
+  end
+
+  test "should detect env succession violation" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+    to_env = Katello::KTEnvironment.find(katello_environments(:test))
+
+    job = ForemanPipeline::Job.new(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [to_env])
+    job.save
+    assert_equal "Environment succession violation: #{to_env.name}", job.errors[:base].first
+  end
+
+  test "was not yet promoted" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [])
+    assert job.not_yet_promoted?
+  end
+
+  test "there should be env for promotion" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
+    env = Katello::KTEnvironment.find(katello_environments(:dev))
+    to_env = Katello::KTEnvironment.find(katello_environments(:test))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [to_env])
+    assert_equal 1, job.envs_for_promotion.count
+    assert_equal to_env, job.envs_for_promotion.first
+  end
+
+  test "there shloud not be env for promotion" do
+    cv = Katello::ContentView.find(katello_content_views(:library_dev_view))
+    env = Katello::KTEnvironment.find(katello_environments(:library))
+    to_env = Katello::KTEnvironment.find(katello_environments(:dev))
+
+    job = ForemanPipeline::Job.create(:name => "test job",
+                                      :organization => @organization,
+                                      :hostgroup => @hostgroup,
+                                      :compute_resource => @compute_resource,
+                                      :content_view => cv,
+                                      :jenkins_instance => @jenkins_instance,
+                                      :environment => env,
+                                      :to_environments => [to_env])
+    assert job.envs_for_promotion.empty?
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_pipeline
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Ondřej Pražák
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-02 00:00:00.000000000 Z
+date: 2015-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foreman_deployments
@@ -25,35 +25,49 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.0.1
 - !ruby/object:Gem::Dependency
-  name: bastion
+  name: jenkins_api_client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 1.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 1.4.0
 - !ruby/object:Gem::Dependency
-  name: net-ssh
+  name: katello
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - <=
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.9.2
+        version: 2.4.0.rc2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - <=
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.9.2
+        version: 2.4.0.rc2
 - !ruby/object:Gem::Dependency
-  name: net-scp
+  name: bastion
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: net-ssh
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
@@ -67,19 +81,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: jenkins_api_client
+  name: net-scp
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: less-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 2.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 2.5.0
 description: Jenkins is able to deploy artifacts onto newly provisioned host by Foreman
 email:
 - oprazak@redhat.com
@@ -294,6 +322,7 @@ files:
 - test/factories/hostgroup_factory.rb
 - test/factories/jenkins_instance_related_factory.rb
 - test/foreman_pipeline_plugin_test_helper.rb
+- test/unit/jenkins_instance_test.rb
 - test/unit/job_test.rb
 - test/unit/sanity_test.rb
 homepage: https://github.com/xprazak2/foreman-pipeline
@@ -315,7 +344,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: Makes Foreman talk to Jenkins CI server.
@@ -324,4 +353,5 @@ test_files:
 - test/factories/jenkins_instance_related_factory.rb
 - test/foreman_pipeline_plugin_test_helper.rb
 - test/unit/sanity_test.rb
+- test/unit/jenkins_instance_test.rb
 - test/unit/job_test.rb