foreman_netbox 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c6e291e619bba70de7b1c7c67832419452ef5342d2bd008961be87a2152ee86
-  data.tar.gz: 9bad853a3329b00878bfaea36939fa2ab02b0957540d2b2bae1b30781a7ddc0c
+  metadata.gz: e2c91a8bd4a7bee1886c7d066161f77810c6cb11180feb3a10e559e317de1f57
+  data.tar.gz: a0cecb684f0a2b3c6866afa1cd0ec59809f9f9f24d8f9d8c4161f0b4ffb2d40c
 SHA512:
-  metadata.gz: 3612479271e7bec9c1499e482691cae0e4e2f7aed0b3d8de93085d98630d3faef83fd82ba4200c377b4ab497ebba63106c6ef4542c28a4c6cecd0c4d638161c9
-  data.tar.gz: ca1bfcace00f154324c72738a75059f66103ad200548c5314e5303ce6be656d1e21a2627f95f4c648ecf26c8e821cd6a28ebc92d78c381c49b78dce0acc267b2
+  metadata.gz: 02bb7f16c232d7fae6b8f51b7959c2a89161eef2625a2daae1e0c7c97a93d898a7d99e4efc396a61a59e570a4c9f90693e05edbb5fe9ce6bbb375e2ee71fccd2
+  data.tar.gz: fb3f6c70f8e3b4594438ca99d72078ac5193e586d8abb449d452cfec17cba0f502908acd60744a70c66bb6b660df4c7e0a1260e1e2fa65a3a9c38b3348436248

data/README.md

@@ -1,16 +1,17 @@
 # ForemanNetbox
 
-[<img src="https://opensourcelogos.aws.dmtech.cloud/dmTECH_opensource_logo.svg" height="21" width="130">](https://www.dmtech.de/)
+[<img src="https://raw.githubusercontent.com/dm-drogeriemarkt/.github/refs/heads/main/assets/dmtech-open-source-badge.svg">](https://www.dmtech.de/)
 
 This is a plugin for Foreman that introduces integration with [NetBox](https://netbox.readthedocs.io)
 
 ## Compatibility
 
-| Netbox Version | Plugin Version |
-| -------------- | -------------- |
-| 2.8            | 1.0            |
-| 2.11           | 1.1            |
-| 3.3            | 1.2            |
+| Foreman Version | Netbox Version | Plugin Version |
+| --------------- | -------------- | -------------- |
+| <3.13           | 2.8            | 1.0            |
+| <3.13           | 2.11           | 1.1            |
+| <3.13           | 3.3            | 1.2            |
+| >=3.13          | 3.5            | 2.0            |
 
 ## Installation
 

data/app/interactors/foreman_netbox/delete_host/delete_device.rb

@@ -10,7 +10,7 @@ module ForemanNetbox
       end
 
       def call
-        ForemanNetbox::API.client.dcim.devices.find_by(name: context.host.name)&.delete
+        ForemanNetbox::Api.client.dcim.devices.find_by(name: context.host.name)&.delete
       rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
         ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
         context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/delete_host/delete_virtual_machine.rb

@@ -10,7 +10,7 @@ module ForemanNetbox
       end
 
       def call
-        ForemanNetbox::API.client.virtualization.virtual_machines.find_by(name: context.host.name)&.delete
+        ForemanNetbox::Api.client.virtualization.virtual_machines.find_by(name: context.host.name)&.delete
       rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
         ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
         context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_device/create.rb

@@ -12,7 +12,7 @@ module ForemanNetbox
         end
 
         def call
-          context.device = ForemanNetbox::API.client::DCIM::Device.new(params).save
+          context.device = ForemanNetbox::Api.client::DCIM::Device.new(params).save
         rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
           ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
           context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_device/find.rb

@@ -21,17 +21,17 @@ module ForemanNetbox
         def find_by_serial
           serial = netbox_params.dig(:device, :serial)
 
-          ForemanNetbox::API.client.dcim.devices.filter(serial: serial).first if serial
+          ForemanNetbox::Api.client.dcim.devices.filter(serial: serial).first if serial
         end
 
         def find_by_mac
-          ForemanNetbox::API.client.dcim.devices.filter(mac_address: mac).first if mac
+          ForemanNetbox::Api.client.dcim.devices.filter(mac_address: mac).first if mac
         end
 
         def find_by_name
           name = netbox_params.dig(:device, :name)
 
-          ForemanNetbox::API.client.dcim.devices.find_by(name: name)
+          ForemanNetbox::Api.client.dcim.devices.find_by(name: name)
         end
       end
     end

data/app/interactors/foreman_netbox/sync_host/sync_device/organizer.rb

@@ -24,7 +24,7 @@ module ForemanNetbox
           SyncDevice::Create,
           SyncDevice::SyncInterfaces::Organizer,
           SyncDevice::Update,
-          SyncDevice::SaveNetboxUrl
+          SyncDevice::SaveNetboxURL
       end
     end
   end

data/app/interactors/foreman_netbox/sync_host/sync_device/save_netbox_url.rb

@@ -3,7 +3,7 @@
 module ForemanNetbox
   module SyncHost
     module SyncDevice
-      class SaveNetboxUrl
+      class SaveNetboxURL
         include ::Interactor
 
         around do |interactor|

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_device_role/create.rb

@@ -12,7 +12,7 @@ module ForemanNetbox
           end
 
           def call
-            context.device_role = ForemanNetbox::API.client::DCIM::DeviceRole.new(params).save
+            context.device_role = ForemanNetbox::Api.client::DCIM::DeviceRole.new(params).save
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_device_role/find.rb

@@ -8,7 +8,7 @@ module ForemanNetbox
           include ::Interactor
 
           def call
-            context.device_role = ForemanNetbox::API.client.dcim.device_roles.find_by(params)
+            context.device_role = ForemanNetbox::Api.client.dcim.device_roles.find_by(params)
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/create.rb

@@ -13,7 +13,7 @@ module ForemanNetbox
           end
 
           def call
-            context.device_type = ForemanNetbox::API.client::DCIM::DeviceType.new(params).save
+            context.device_type = ForemanNetbox::Api.client::DCIM::DeviceType.new(params).save
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/find.rb

@@ -8,7 +8,7 @@ module ForemanNetbox
           include ::Interactor
 
           def call
-            context.device_type = ForemanNetbox::API.client.dcim.device_types.find_by(params)
+            context.device_type = ForemanNetbox::Api.client.dcim.device_types.find_by(params)
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/sync_manufacturer/create.rb

@@ -13,7 +13,7 @@ module ForemanNetbox
             end
 
             def call
-              context.manufacturer = ForemanNetbox::API.client::DCIM::Manufacturer.new(params).save
+              context.manufacturer = ForemanNetbox::Api.client::DCIM::Manufacturer.new(params).save
             rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
               ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
               context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/sync_manufacturer/find.rb

@@ -23,13 +23,13 @@ module ForemanNetbox
             def find_by_slug
               params = netbox_params.fetch(:manufacturer).slice(:slug)
 
-              ForemanNetbox::API.client.dcim.manufacturers.find_by(params)
+              ForemanNetbox::Api.client.dcim.manufacturers.find_by(params)
             end
 
             def find_by_name
               params = netbox_params.fetch(:manufacturer).slice(:name)
 
-              ForemanNetbox::API.client.dcim.manufacturers.find_by(params)
+              ForemanNetbox::Api.client.dcim.manufacturers.find_by(params)
             end
           end
         end

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/create.rb

@@ -17,7 +17,7 @@ module ForemanNetbox
                          .select { |i| i[:name] }
                          .reject { |i| interfaces.map(&:name).include?(i[:name]) }
                          .map do |new_interface|
-                           ForemanNetbox::API.client::DCIM::Interface.new(
+                           ForemanNetbox::Api.client::DCIM::Interface.new(
                              new_interface.except(:type)
                                           .merge(
                                             type: new_interface.dig(:type, :value),

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/find.rb

@@ -8,7 +8,7 @@ module ForemanNetbox
           include ::Interactor
 
           def call
-            context.interfaces = ForemanNetbox::API.client.dcim.interfaces.filter(params)
+            context.interfaces = ForemanNetbox::Api.client.dcim.interfaces.filter(params)
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/create.rb

@@ -14,14 +14,14 @@ module ForemanNetbox
                 interface_id = interfaces_map.fetch(ip_address.dig(:interface, :name), nil)
 
                 next unless interface_id
-                next unless ForemanNetbox::API.client
+                next unless ForemanNetbox::Api.client
                                               .ipam
                                               .ip_addresses
                                               .filter(interface_id: interface_id, address: ip_address[:address])
                                               .total
                                               .zero?
 
-                ForemanNetbox::API.client::IPAM::IpAddress.new(
+                ForemanNetbox::Api.client::IPAM::IpAddress.new(
                   ip_address.slice(:address)
                             .merge(
                               assigned_object_type: 'dcim.interface', assigned_object_id: interface_id,

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/find.rb

@@ -9,7 +9,7 @@ module ForemanNetbox
             include ::Interactor
 
             def call
-              context.ip_addresses = ForemanNetbox::API.client.ipam.ip_addresses.filter(params)
+              context.ip_addresses = ForemanNetbox::Api.client.ipam.ip_addresses.filter(params)
             rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
               ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
               context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/update.rb

@@ -22,9 +22,7 @@ module ForemanNetbox
 
             return unless new_params
 
-            if netbox_interface.mac_address != new_params[:mac_address]
-              netbox_interface.mac_address = new_params[:mac_address]
-            end
+            netbox_interface.mac_address = new_params[:mac_address] if netbox_interface.mac_address != new_params[:mac_address]
             assign_tags_to(netbox_interface)
 
             netbox_interface.save

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_site/create.rb

@@ -13,7 +13,7 @@ module ForemanNetbox
           end
 
           def call
-            context.site = ForemanNetbox::API.client::DCIM::Site.new(params).save
+            context.site = ForemanNetbox::Api.client::DCIM::Site.new(params).save
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_device/sync_site/find.rb

@@ -8,7 +8,7 @@ module ForemanNetbox
           include ::Interactor
 
           def call
-            context.site = ForemanNetbox::API.client.dcim.sites.find_by(params)
+            context.site = ForemanNetbox::Api.client.dcim.sites.find_by(params)
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_tags/create.rb

@@ -15,7 +15,7 @@ module ForemanNetbox
         def new_tags
           SyncTags::Organizer::DEFAULT_TAGS
             .reject { |params| existing_slugs.include?(params[:slug]) }
-            .map { |params| ForemanNetbox::API.client::Extras::Tag.new(params).save }
+            .map { |params| ForemanNetbox::Api.client::Extras::Tag.new(params).save }
         rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
           ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
           context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_tags/find.rb

@@ -8,7 +8,7 @@ module ForemanNetbox
 
         def call
           context.tags = slugs.map do |slug|
-            ForemanNetbox::API.client.extras.tags.find_by(slug: slug)
+            ForemanNetbox::Api.client.extras.tags.find_by(slug: slug)
           end.compact
         rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
           ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")

data/app/interactors/foreman_netbox/sync_host/sync_tenant/create.rb

@@ -12,7 +12,7 @@ module ForemanNetbox
         end
 
         def call
-          context.tenant = ForemanNetbox::API.client::Tenancy::Tenant.new(params).save
+          context.tenant = ForemanNetbox::Api.client::Tenancy::Tenant.new(params).save
         rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
           ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
           context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_tenant/find.rb

@@ -7,7 +7,7 @@ module ForemanNetbox
         include ::Interactor
 
         def call
-          context.tenant = ForemanNetbox::API.client.tenancy.tenants.find_by(params)
+          context.tenant = ForemanNetbox::Api.client.tenancy.tenants.find_by(params)
         rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
           ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
           context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/create.rb

@@ -12,7 +12,7 @@ module ForemanNetbox
         end
 
         def call
-          context.virtual_machine = ForemanNetbox::API.client::Virtualization::VirtualMachine.new(params).save
+          context.virtual_machine = ForemanNetbox::Api.client::Virtualization::VirtualMachine.new(params).save
         rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
           ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
           context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/find.rb

@@ -19,12 +19,12 @@ module ForemanNetbox
         delegate :mac, to: :host
 
         def find_by_mac
-          ForemanNetbox::API.client.virtualization.virtual_machines.filter(mac_address: mac).first if mac
+          ForemanNetbox::Api.client.virtualization.virtual_machines.filter(mac_address: mac).first if mac
         end
 
         def find_by_name
           params = netbox_params.fetch(:virtual_machine).slice(:name)
-          ForemanNetbox::API.client.virtualization.virtual_machines.find_by(params)
+          ForemanNetbox::Api.client.virtualization.virtual_machines.find_by(params)
         end
       end
     end

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/organizer.rb

@@ -22,7 +22,7 @@ module ForemanNetbox
           SyncVirtualMachine::Create,
           SyncVirtualMachine::SyncInterfaces::Organizer,
           SyncVirtualMachine::Update,
-          SyncVirtualMachine::SaveNetboxUrl
+          SyncVirtualMachine::SaveNetboxURL
       end
     end
   end

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/save_netbox_url.rb

@@ -3,7 +3,7 @@
 module ForemanNetbox
   module SyncHost
     module SyncVirtualMachine
-      class SaveNetboxUrl
+      class SaveNetboxURL
         include ::Interactor
 
         around do |interactor|

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/create.rb

@@ -13,7 +13,7 @@ module ForemanNetbox
           end
 
           def call
-            context.cluster = ForemanNetbox::API.client::Virtualization::Cluster.new(params).save
+            context.cluster = ForemanNetbox::Api.client::Virtualization::Cluster.new(params).save
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/find.rb

@@ -8,7 +8,7 @@ module ForemanNetbox
           include ::Interactor
 
           def call
-            context.cluster = ForemanNetbox::API.client.virtualization.clusters.find_by(params)
+            context.cluster = ForemanNetbox::Api.client.virtualization.clusters.find_by(params)
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/sync_cluster_type/create.rb

@@ -13,7 +13,7 @@ module ForemanNetbox
             end
 
             def call
-              context.cluster_type = ForemanNetbox::API.client::Virtualization::ClusterType.new(params).save
+              context.cluster_type = ForemanNetbox::Api.client::Virtualization::ClusterType.new(params).save
             rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
               ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
               context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/sync_cluster_type/find.rb

@@ -11,7 +11,7 @@ module ForemanNetbox
             def call
               return unless params
 
-              context.cluster_type = ForemanNetbox::API.client.virtualization.cluster_types.find_by(params)
+              context.cluster_type = ForemanNetbox::Api.client.virtualization.cluster_types.find_by(params)
             rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
               ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
               context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/create.rb

@@ -17,14 +17,14 @@ module ForemanNetbox
                          .select { |i| i[:name] }
                          .reject { |i| interfaces.map(&:name).include?(i[:name]) }
                          .map do |new_interface|
-                           ForemanNetbox::API.client::Virtualization::Interface.new(
-                             new_interface.except(:type)
-                                          .merge(
-                                            virtual_machine: virtual_machine.id,
-                                            tags: default_tag_ids
-                                          )
-                           ).save
-                         end
+              ForemanNetbox::Api.client::Virtualization::Interface.new(
+                new_interface.except(:type)
+                .merge(
+                  virtual_machine: virtual_machine.id,
+                  tags: default_tag_ids
+                )
+              ).save
+            end
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/find.rb

@@ -8,7 +8,7 @@ module ForemanNetbox
           include ::Interactor
 
           def call
-            context.interfaces = ForemanNetbox::API.client.virtualization.interfaces.filter(params)
+            context.interfaces = ForemanNetbox::Api.client.virtualization.interfaces.filter(params)
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
             ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
             context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/create.rb

@@ -14,14 +14,14 @@ module ForemanNetbox
                 interface_id = interfaces_map.fetch(ip_address.dig(:interface, :name), nil)
 
                 next unless interface_id
-                next unless ForemanNetbox::API.client
+                next unless ForemanNetbox::Api.client
                                               .ipam
                                               .ip_addresses
                                               .filter(vminterface_id: interface_id, address: ip_address[:address])
                                               .total
                                               .zero?
 
-                ForemanNetbox::API.client::IPAM::IpAddress.new(
+                ForemanNetbox::Api.client::IPAM::IpAddress.new(
                   ip_address.slice(:address)
                             .merge(
                               assigned_object_type: 'virtualization.vminterface', assigned_object_id: interface_id,

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/delete.rb

@@ -22,9 +22,8 @@ module ForemanNetbox
 
               context.interfaces.each do |netbox_interface|
                 host_interface_ips = ip_addresses_netbox_params.select do |ip|
-                                       ip.dig(:interface, :name) == netbox_interface.name
-                                     end
-                                                               .map { |ip| ip.fetch(:address) }
+                  ip.dig(:interface, :name) == netbox_interface.name
+                end.map { |ip| ip.fetch(:address) }
 
                 context.ip_addresses
                        .select { |ip| ip['assigned_object_type'] == 'virtualization.vminterface' && ip['assigned_object_id'] == netbox_interface.id }
@@ -32,7 +31,6 @@ module ForemanNetbox
                        .each(&:delete)
               end
             end
-
             delegate :netbox_params, to: :context
           end
         end

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/find.rb

@@ -9,7 +9,7 @@ module ForemanNetbox
             include ::Interactor
 
             def call
-              context.ip_addresses = ForemanNetbox::API.client.ipam.ip_addresses.filter(params)
+              context.ip_addresses = ForemanNetbox::Api.client.ipam.ip_addresses.filter(params)
             rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
               ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
               context.fail!(error: "#{self.class}: #{e}")

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/update.rb

@@ -22,9 +22,7 @@ module ForemanNetbox
 
             return unless new_params
 
-            if netbox_interface.mac_address != new_params[:mac_address]
-              netbox_interface.mac_address = new_params[:mac_address]
-            end
+            netbox_interface.mac_address = new_params[:mac_address] if netbox_interface.mac_address != new_params[:mac_address]
             assign_tags_to(netbox_interface)
 
             netbox_interface.save

data/app/lib/foreman_netbox/api.rb

@@ -1,12 +1,21 @@
 # frozen_string_literal: true
 
 module ForemanNetbox
-  class API
+  class Api
     def self.client
       NetboxClientRuby.configure do |config|
-        config.netbox.api_base_url = "#{Setting['netbox_url']}/api"
+        config.netbox.api_base_url = netbox_api_url
         config.netbox.auth.token = Setting['netbox_api_token']
       end
     end
+
+    def self.netbox_api_url
+      return Setting['netbox_api_url'] if URI.parse(Setting['netbox_api_url']).is_a?(URI::HTTP)
+
+      api_url = "#{Setting['netbox_url']}/api"
+      return api_url if URI.parse(api_url).is_a?(URI::HTTP)
+
+      raise Foreman::Exception, 'Invalid Netbox API URL, please check the netbox_url and netbox_api_url settings'
+    end
   end
 end

data/app/services/foreman_netbox/netbox_parameters.rb

@@ -123,7 +123,7 @@ module ForemanNetbox
       }
     end
 
-    # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+    # rubocop:disable Metrics/CyclomaticComplexity
     def ip_addresses
       {
         ip_addresses: host.interfaces.map do |interface|
@@ -144,7 +144,7 @@ module ForemanNetbox
         end.flatten,
       }
     end
-    # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+    # rubocop:enable Metrics/CyclomaticComplexity
 
     def virtual_machine
       {

data/app/services/foreman_netbox/netbox_parameters_comparator.rb

@@ -66,7 +66,7 @@ module ForemanNetbox
       end.compact
     end
 
-    # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+    # rubocop:disable Metrics/CyclomaticComplexity
     def diff_new
       new_hash.except(*added_keys).each_with_object({}) do |(key, new_value), memo|
         case new_value
@@ -97,6 +97,6 @@ module ForemanNetbox
         end
       end.compact
     end
-    # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+    # rubocop:enable Metrics/CyclomaticComplexity
   end
 end

data/db/migrate/20230303095650_fix_netbox_settings_category_to_dsl.rb

@@ -2,8 +2,6 @@
 
 class FixNetboxSettingsCategoryToDsl < ActiveRecord::Migration[6.0]
   def up
-    # rubocop:disable Rails/SkipsModelValidations
     Setting.where(category: 'Setting::Netbox').update_all(category: 'Setting') if column_exists?(:settings, :category)
-    # rubocop:enable Rails/SkipsModelValidations
   end
 end