foreman_maintain 1.4.2 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d37937d8bc4cbf619ea0e654e6826ae92a96ecd74f1b260e5b402df7bcbdc68
-  data.tar.gz: a0fcf7a0f6802f7547c26d640650ac29cafa3568f7fdbc648f31d3dbdbcf6a72
+  metadata.gz: 2d9b46e0f2566916075ef7ec1972734f31919fafaa10ce814a2e5006ece9ab62
+  data.tar.gz: 989952ede4062aaba32b380a5226b63e9aaa0c22ffbf34b79bc80a153a0b0920
 SHA512:
-  metadata.gz: 2bab8216e974e96128a5f0fb88a201d1c8dd9da13d71b89efea76337c242f6459285e8af8a8dbcacbaa318f402c1b26cc7056e5e1d976946b8939f13bbaa4fda
-  data.tar.gz: 59772c9b2ec381408458383f4e06bafb8bb3998f5c4cea60be7a2dc2a254803896a05aa2858aad48f34e54185b7db6a455534cafa5f671b6a52a69bbe0b07e74
+  metadata.gz: a9a380eb151bfadbbba33824d438dc69fe47732cf3219af14b8e78ebcb2bb8dd5ba590fc9887d936aa1eb662e644f8e085a39c2023a71e5d3d975075d37a57bb
+  data.tar.gz: 7725d0d13f08191822fbda79b828498d8b064a984ca8d38a841d1e400768ec6c530ea8d99c94ea35f6a62ac547455de32a9d4048d06a3d4a953fd065908385d1

data/definitions/checks/katello_agent.rb

@@ -0,0 +1,41 @@
+require 'yaml'
+
+class Checks::CheckKatelloAgentEnabled < ForemanMaintain::Check
+  metadata do
+    label :check_katello_agent_enabled
+    description 'Check whether the katello-agent feature is enabled before upgrading'
+    tags :pre_upgrade
+
+    confine do
+      !feature(:capsule)
+    end
+  end
+
+  def run
+    instance_name = feature(:instance).downstream ? "Satellite" : "Katello"
+    instance_version = feature(:instance).downstream ? "6.15" : "4.10"
+    installer_command = feature(:instance).downstream ? "satellite-installer" : "foreman-installer"
+    maintain_command = feature(:instance).downstream ? "satellite-maintain" : "foreman-maintain"
+
+    assert(
+      !katello_agent_enabled?,
+      "The katello-agent feature is enabled on this system. As of #{instance_name}"\
+      " #{instance_version}, katello-agent is removed and will no longer function."\
+      " Before proceeding with the upgrade, you should ensure that you have deployed"\
+      " and configured an alternative tool for remote package management and patching"\
+      " for content hosts, such as Remote Execution (REX) with pull-based transport."\
+      " See the Managing Hosts guide in the #{instance_name} documentation for more info."\
+      " Disable katello-agent with the command"\
+      " `#{installer_command} --foreman-proxy-content-enable-katello-agent false`"\
+      " before proceeding with the upgrade. Alternatively, you may skip this check and proceed by"\
+      " running #{maintain_command} again with the `--whitelist` option, which will automatically"\
+      " uninstall katello-agent."
+    )
+  end
+
+  private
+
+  def katello_agent_enabled?
+    feature(:installer).answers['foreman_proxy_content']['enable_katello_agent']
+  end
+end

data/lib/foreman_maintain/concerns/primary_checks.rb

@@ -2,7 +2,8 @@ module ForemanMaintain
   module Concerns
     module PrimaryChecks
       def validate_downstream_packages
-        return unless detector.feature(:installer)&.with_scenarios?
+        return unless detector.feature(:installer)
+
         if (package = package_name) && !package_manager.installed?(package)
           raise ForemanMaintain::Error::Fail,
             "Error: Important rpm package #{package} is not installed!"\

data/lib/foreman_maintain/version.rb

@@ -1,3 +1,3 @@
 module ForemanMaintain
-  VERSION = '1.4.2'.freeze
+  VERSION = '1.4.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_maintain
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.3
 platform: ruby
 authors:
 - Ivan Nečas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-10-26 00:00:00.000000000 Z
+date: 2023-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: clamp
@@ -181,6 +181,7 @@ files:
 - definitions/checks/foreman_tasks/invalid/check_planning_state.rb
 - definitions/checks/foreman_tasks/not_paused.rb
 - definitions/checks/foreman_tasks/not_running.rb
+- definitions/checks/katello_agent.rb
 - definitions/checks/maintenance_mode/check_consistency.rb
 - definitions/checks/non_rh_packages.rb
 - definitions/checks/package_manager/dnf/validate_dnf_config.rb